Re: RFR 8005311: Add Scalable Updatable Variables, DoubleAccumulator, DoubleAdder, LongAccumulator, LongAdder

2013-01-13 Thread Howard Lovatt
If you make a binary tree and sum it, the rounding errors aren't that bad and this algorithm is easy to parallelise. Higham, Nicholas J 1993 the accuracy of floating point summation SIAM Sci Comp 14 (4) 783-799 Also see Wikipedia for a description of Kahan summation and a general discussion o

Re: Request for Review: Java SE 8 Compact Profiles

2013-01-13 Thread David Holmes
Thanks Alan. Updated webrev just for good measure: http://cr.openjdk.java.net/~dholmes/8004265.v3/webrev.jdk/ David On 10/01/2013 1:52 AM, Alan Bateman wrote: On 09/01/2013 03:58, Mandy Chung wrote: : Looks like the jar tool -m option allows an entry with a space "Profile: " (a space followi

Re: Final RFR: 8005232 (JEP-149) Class Instance size reduction

2013-01-13 Thread David Holmes
Thanks everyone, this work has now been committed: author dholmes Sun Jan 13 19:57:06 2013 -0500 (5 minutes ago) changeset 6357 1109bfff4e92 parent 6356 7db04ae3378f 8005232: (JEP-149) Class Instance size reduction Summary: Moved the fields for cached reflection objects into a seper

hg: jdk8/tl/jdk: 8005232: (JEP-149) Class Instance size reduction

2013-01-13 Thread david . holmes
Changeset: 1109bfff4e92 Author:dholmes Date: 2013-01-13 19:57 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1109bfff4e92 8005232: (JEP-149) Class Instance size reduction Summary: Moved the fields for cached reflection objects into a seperate ReflectionData object to reduce

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Lance Andersen - Oracle
On Jan 13, 2013, at 4:25 PM, Ulf Zibis wrote: > > Am 13.01.2013 21:08, schrieb Alan Bateman: >> Assuming CCE is long standing behavior then it would be good to update the >> spec of all the other read* methods too. Alternatively a statement in the >> class description to cover it. Yes that is

Re: RFR (XS): CR 8003985: Support @Contended annotation

2013-01-13 Thread David Holmes
On 14/01/2013 4:30 AM, Vladimir Kozlov wrote: Thank you, Alan I already pushed it into hotspot/jdk: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9d5c43050210 We will promote it as we did before with similar changes together with Hotspot changes. So this seem to be becoming a new proce

hg: jdk8/tl/jdk: 8006153: HTTP protocol handler authenication should use Base64 API

2013-01-13 Thread chris . hegarty
Changeset: 7db04ae3378f Author:chegar Date: 2013-01-13 22:09 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7db04ae3378f 8006153: HTTP protocol handler authenication should use Base64 API Reviewed-by: chegar, alanb Contributed-by: Mark Sheppard ! src/share/classes/sun/net/w

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Ulf Zibis
Am 13.01.2013 21:08, schrieb Alan Bateman: Assuming CCE is long standing behavior then it would be good to update the spec of all the other read* methods too. Alternatively a statement in the class description to cover it. Only using a generified version of readObject(), a CCE would be less su

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Alan Bateman
On 13/01/2013 15:07, Lance Andersen wrote: I will enter a jbs entry on Monday for this Assuming CCE is long standing behavior then it would be good to update the spec of all the other read* methods too. Alternatively a statement in the class description to cover it. One other thing is that t

Re: RFR (XS): CR 8003985: Support @Contended annotation

2013-01-13 Thread Vladimir Kozlov
Thank you, Alan I already pushed it into hotspot/jdk: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9d5c43050210 We will promote it as we did before with similar changes together with Hotspot changes. Thanks, Vladimir On 1/13/13 7:05 AM, Alan Bateman wrote: On 11/01/2013 23:23, Aleks

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Zhong Yu
Why not pass the target class, like private T getNextAttribute(Class clazz) throws SQLException { if (++idx >= attrib.length) { throw new SQLException("SQLInputImpl exception: Invalid read " + "position"); } else {

Re: Review request JDK-8004729: Parameter Reflection API

2013-01-13 Thread Eric McCorkle
On 01/12/13 13:36, Joe Darcy wrote: > Hi Eric, > > On 1/11/2013 9:14 PM, Eric McCorkle wrote: >> I got halfway through implementing a change that would synthesize >> Parameter's for the static links (this for the inner classes), when it >> occurred to me: is there really a case for allowing reflec

RFR: 8005252: pack200 support for MethodParameters

2013-01-13 Thread Kumar Srinivasan
Hi All, Please let me know if you have any comments on this enhancement, which makes pack200 understand and compress class files containing MethodParameters. This also reinstates a test which was disabled when the corresponding javac changes went in earlier. http://cr.openjdk.java.net/~ksrin

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Remi Forax
On 01/13/2013 02:26 PM, Ulf Zibis wrote: Am 13.01.2013 13:33, schrieb Remi Forax: Additionally I'm wondering, whether getNextAttribute() could be generified. Yes it probably could however I do no want to do this as part of this change I disagree, it should not be generified, getNextAttribute(

Re: RFR (XS): CR 8003985: Support @Contended annotation

2013-01-13 Thread Alan Bateman
On 11/01/2013 23:23, Aleksey Shipilev wrote: Hi guys, This is the JDK side of changes for supporting @Contended: http://cr.openjdk.java.net/~shade/8003985/webrev.jdk.02/ Status: - This change is ready to be pushed; due to licensing reasons with jsr166, we can only commit the stub; regular

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Lance Andersen
I will enter a jbs entry on Monday for this Have a good weekend Best Lance -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone On Jan 13, 2013, at 8:37 AM, Alan Bat

Re: RFE - add generic accessors to SQLInput, SQLOutput

2013-01-13 Thread Lance Andersen
I. Will enter a feature request but I do not plan on a change for this release Best Lance -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone On Jan 13, 2013, at 8:2

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Alan Bateman
On 12/01/2013 21:56, Lance Andersen - Oracle wrote: Hi This is a review request for 8006139 which adds missing methods to SQLInput/Output The webrev can be found at http://cr.openjdk.java.net/~lancea/8006139/webrev.00/ Lance - I think this will require a spec clarification so that it's clear

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Ulf Zibis
Am 13.01.2013 13:33, schrieb Remi Forax: Additionally I'm wondering, whether getNextAttribute() could be generified. Yes it probably could however I do no want to do this as part of this change I disagree, it should not be generified, getNextAttribute() should return Object and be casted at c

RFE - add generic accessors to SQLInput, SQLOutput

2013-01-13 Thread Ulf
Hi, because bugparade is not working, I post this here :-( There could be: public T read() throws SQLException; public void write(T obj) throws SQLException; Alternatively, maybe readObject(), writeObject() could be re-engineered with generic API. All other methods then could be deprecated

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Remi Forax
On 01/13/2013 01:24 PM, Lance @ Oracle wrote: On Jan 13, 2013, at 5:56 AM, Ulf Zibis wrote: Am 12.01.2013 22:56, schrieb Lance Andersen - Oracle: Hi This is a review request for 8006139 which adds missing methods to SQLInput/Output The webrev can be found at http://cr.openjdk.java.net/~lanc

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Lance @ Oracle
Yes I just noticed this The code was written before my time I will add them though Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jan 13, 2013, at 7:28 AM, Ulf Zi

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Ulf Zibis
Am 12.01.2013 22:56, schrieb Lance Andersen - Oracle: Hi This is a review request for 8006139 which adds missing methods to SQLInput/Output The webrev can be found at http://cr.openjdk.java.net/~lancea/8006139/webrev.00/ All @since tags are missing in these classes :-( -Ulf

Can't report bug

2013-01-13 Thread Ulf Zibis
Hi, what's about http://bugreport.sun.com/bugreport/ ? I get "Server not available" Is this temporary, or is it disabled because of new infrastructure? Thanks, -Ulf

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Lance @ Oracle
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jan 13, 2013, at 5:56 AM, Ulf Zibis wrote: > Am 12.01.2013 22:56, schrieb Lance Andersen - Oracle: >> Hi >> This i

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Ulf Zibis
Hi again, as you imported java.net.URL, you do not need to outline it in the code any more, e.g. line 769. Am 13.01.2013 12:13, schrieb Ulf Zibis: ... and again more general: xxx private T readNext() throws SQLException { xxx T attrib = (T)getNextAttribute(); xxx lastVa

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Ulf Zibis
Oops, missing spaces by Thunderbird failure, correction: 811 public String readNString() throws SQLException { 812 String attrib = (String)getNextAttribute(); 813 lastValueWasNull = attrib == null; 814 return attrib; 815 } Additionally I'm wondering, whether g

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

2013-01-13 Thread Ulf Zibis
Am 12.01.2013 22:56, schrieb Lance Andersen - Oracle: Hi This is a review request for 8006139 which adds missing methods to SQLInput/Output The webrev can be found at http://cr.openjdk.java.net/~lancea/8006139/webrev.00/ Hi, are you paid by code lines ;-) Additionally you have left out one o