On Mar 19, 2013, at 9:43 PM, Rob Leland wrote:
> Has the optional classes been verified to serialize/deserialize correctly? I
> noticed it tries to use the null object pattern with the use of EMPTY private
> instance. When I have implemented the NULL pattern I have used a private
> subclass
Changeset: 74d7f9bcac93
Author:jjg
Date: 2013-03-19 19:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/74d7f9bcac93
8010317: DocLint incorrectly reports some tags as empty
Reviewed-by: darcy
! src/share/classes/com/sun/tools/doclint/Checker.java
+ test/tools/doclint
On 3/14/2013 10:14 AM, Joe Darcy wrote:
FYI, I've submitted a JEP reviewed by Alan Bateman on "Capturing
support and stability information about JDK classes in source and
class files."
Following up in the same thread, the JEP for this work is now available
for your reading pleasure at:
On 3/19/2013 5:29 PM, Christian Thalinger wrote:
On Mar 19, 2013, at 1:14 PM, Mandy Chung wrote:
I do a partial review in particular to make sure the jdk and hotspot change are
in sync.
javaClasses.hpp - MN_CALLER_SENSITIVE and MN_SEARCH_SUPERCLASSES have the same
value. Should they be di
On Mar 19, 2013, at 5:21 PM, John Rose wrote:
> On Mar 14, 2013, at 8:31 PM, Christian Thalinger
> wrote:
>
>> [This is the HotSpot part of JEP 176]
>>
>> http://cr.openjdk.java.net/~twisti/7198429
>>
>> 7198429: need checked categorization of caller-sensitive methods in the JDK
>> Reviewed
On Mar 19, 2013, at 5:29 PM, Christian Thalinger
wrote:
> Right. I forgot to add that code. Here is an incremental webrev:
>
> http://cr.openjdk.java.net/~twisti/7198429/edit/
>
> And the full thing:
>
> http://cr.openjdk.java.net/~twisti/7198429/
>
> Let me know if that works for you.
Go
On Mar 19, 2013, at 1:14 PM, Mandy Chung wrote:
> javaClasses.hpp - MN_CALLER_SENSITIVE and MN_SEARCH_SUPERCLASSES have the
> same value. Should they be different?
>
> 1057 MN_CALLER_SENSITIVE = 0x0010, // @CallerSensitive annotation
> detected
> 1061 MN_SEARCH_SUPERCLASSES =
On Mar 19, 2013, at 1:14 PM, Mandy Chung wrote:
> I do a partial review in particular to make sure the jdk and hotspot change
> are in sync.
>
> javaClasses.hpp - MN_CALLER_SENSITIVE and MN_SEARCH_SUPERCLASSES have the
> same value. Should they be different?
>
> 1057 MN_CALLER_SENSITIVE
On Mar 14, 2013, at 8:31 PM, Christian Thalinger
wrote:
> [This is the HotSpot part of JEP 176]
>
> http://cr.openjdk.java.net/~twisti/7198429
>
> 7198429: need checked categorization of caller-sensitive methods in the JDK
> Reviewed-by:
Over all, great work on a tricky problem. I'd add a f
Changeset: 9cf17b7a5fe7
Author:jjg
Date: 2013-03-19 17:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9cf17b7a5fe7
8010333: Remove com.sun.tools.javac.Server
Reviewed-by: darcy
- src/share/classes/com/sun/tools/javac/Server.java
Changeset: 8196357e95b5
Author:amurillo
Date: 2013-03-08 08:22 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8196357e95b5
8009688: new hotspot build - hs25-b23
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: 255c0a4cb4eb
Author:sla
Date: 2013-03-05 08:5
Changeset: 2241a2d34085
Author:mduigou
Date: 2013-03-19 16:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2241a2d34085
8001642: Add Optional, OptionalDouble, OptionalInt, OptionalLong
Reviewed-by: mduigou, darcy, alanb, jjb
Contributed-by: Brian Goetz
+ src/share/classes
Changeset: 578eb3dd111d
Author:jjg
Date: 2013-03-19 15:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/578eb3dd111d
8010315: doclint errors in javac public API
Reviewed-by: darcy
! make/build.xml
! src/share/classes/com/sun/source/util/DocTreeScanner.java
! src/share
Simple update of a logging test to include test cases for the
".useParentHandlers" property set in the logging configuration.
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8006104/webrev.00/
Thanks
Mandy
On Mar 12 2013, at 06:51 , Paul Sandoz wrote:
>> - should be replace with {@code}
>>
>
> It is mostly consistent with the rest of the Map documentation. We should do
> a global replace in that case?
We are incrementally updating the source with this change. Nobody is going out
of their way t
I do a partial review in particular to make sure the jdk and hotspot
change are in sync.
javaClasses.hpp - MN_CALLER_SENSITIVE and MN_SEARCH_SUPERCLASSES have
the same value. Should they be different?
1057 MN_CALLER_SENSITIVE = 0x0010, // @CallerSensitive annotation
detected
106
Changeset: a4913ea9bb62
Author:darcy
Date: 2013-03-19 13:10 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a4913ea9bb62
8010179: Remove transitional target values from javac
Reviewed-by: jjg, mcimadamore
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/shar
2013/3/15 17:16 -0400, joe.da...@oracle.com:
> On 03/15/2013 02:12 PM, mark.reinh...@oracle.com wrote:
>> ...
>>
>> What I'm trying to understand is, for a JDK API that's @Supported(true)
>> in one or more releases, what's the recommended protocol for removing
>> it? Perhaps something like this?
Posted: http://openjdk.java.net/jeps/179
- Mark
I couldn't resist fixing the two typos of ArrayIndexOutofBoundsException
-// throws ArrayIndexOutofBoundsException if index out of bounds
+// throws ArrayIndexOutOfBoundsException if index out of bounds
Thanks! Webrev updated.
On Tue, Mar 19, 2013 at 11:58 AM, Xueming Shen wrote:
> **
> On 03/19/2013 11:49 AM, Martin Buchholz wrote:
>
>
> Masayoshi or Xueming, please file a bug for me:
> Title: Improve handling of char sequences containing surrogates
> Desc: Fix and optimize codePointAt, codeP
On 03/19/2013 11:49 AM, Martin Buchholz wrote:
Masayoshi or Xueming, please file a bug for me:
Title: Improve handling of char sequences containing surrogates
Desc: Fix and optimize codePointAt, codePointBefore and similar methods
Eval: A fine idea!
JDK-8010316: Improve handling of char sequenc
Masayoshi or Xueming, please file a bug for me:
Title: Improve handling of char sequences containing surrogates
Desc: Fix and optimize codePointAt, codePointBefore and similar methods
Eval: A fine idea!
On Mon, Mar 18, 2013 at 11:10 PM, Masayoshi Okutsu <
masayoshi.oku...@oracle.com> wrote:
>
> For classes as important as important as StringBuilder, I think we
> should go the extra mile to ensure best performance,
>
>
> That was exactly the reason why I initially took the same approach. So,
> I'
Hi Laurent,
Thanks for the contribution. I agree that the map can be replaced with
a direct mapping from a int value to Level object and avoid the
autoboxing conversion.
I have filed a bug to track this and target this for JDK8:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id= 8010309
On 03/19/2013 05:18 PM, Martin Buchholz wrote:
Sorry, just finished one more (final?) round of exception spec updates,
notably to change "unchecked exception" to "exception", since the code
catches any Throwable.
Thanks Martin, my fault I suggested "unchecked". I also like the
additional clari
Sorry, just finished one more (final?) round of exception spec updates,
notably to change "unchecked exception" to "exception", since the code
catches any Throwable.
On Tue, Mar 19, 2013 at 9:53 AM, Chris Hegarty wrote:
> Updated specdiff and webrev. Unless I hear otherwise, I think the API is
>
Updated specdiff and webrev. Unless I hear otherwise, I think the API is
as good as final.
http://cr.openjdk.java.net/~chegar/8005696/ver.01/specdiff/java/util/concurrent/package-summary.html
http://cr.openjdk.java.net/~chegar/8005696/ver.01/webrev/
-Chris
On 03/18/2013 02:10 PM, Doug Lea w
Dear all,
I run recently netbeans profiler on my swing application (Aspro2:
http://www.jmmc.fr/aspro) under linux x64 platform and figured out a
performance and waste issue related to PlatformLogger.
Actually, the JavaLogger implementation uses a Map
levelObjects to store mapping between Platform
Changeset: e766da5575fa
Author:dholmes
Date: 2013-03-19 06:01 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e766da5575fa
8009426: "profiles" target fails due to nashorn if "images" is not built first
Reviewed-by: alanb
! makefiles/CreateJars.gmk
! makefiles/Profiles.gmk
! m
Brad,
I do not build using the old build anymore. This is clearly a blocker
for your work. If you want to suppress the warnings for
overrides/deprecation, then please push the change ( your patch ). We
can revisit this in the future, when it is necessary.
-Chris.
On 03/19/2013 01:29 AM, Bra
Changeset: a0275a47fa78
Author:sla
Date: 2013-03-19 09:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a0275a47fa78
8006637: Failure to filter out native frame events on Solaris
Summary: Test is confused by other threads calling String.intern(). Add a
thread filter to avoi
Thanks!
On 19 mar 2013, at 08:51, Alan Bateman wrote:
>
> I see Serguei has reviewed this. It looks okay to me too.
>
> -Alan.
>
> On 18/03/2013 14:14, Staffan Larsen wrote:
>> I still need an official Review for this change.
>>
>> Thanks,
>> Staffan
>>
>> On 7 mar 2013, at 09:10, Staffan L
I see Serguei has reviewed this. It looks okay to me too.
-Alan.
On 18/03/2013 14:14, Staffan Larsen wrote:
I still need an official Review for this change.
Thanks,
Staffan
On 7 mar 2013, at 09:10, Staffan Larsen wrote:
Adding core-libs-dev and re-asking for a review.
Thanks,
/Staffan
O
34 matches
Mail list logo
