RE: Review request for 7198429: need checked categorization of caller-sensitive methods in the JDK

John Rose wrote: > Making Runtime and/or Runtime.load* final is an API change, which is > harder to do than an implementation change. I worry about compatibility a lot and my (selfish) reasoning is that it is better for the CCC to break someones code (there has to be someone somewhere that uses

Review request: 8011380: FX dependency on PlatformLogger broken

Peter, Laurent, History and details are described below. Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8011380/webrev.00/ I add back the getLevel(int), setLevel(int) and isLoggable(int) methods but marked deprecated and also revert the static final variables to resolve the regres

hg: jdk8/tl: 8011350: hgforest.sh uses non-POSIX sh features that may fail with some shells

Changeset: 575f2ca947ab Author:mduigou Date: 2013-04-03 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/575f2ca947ab 8011350: hgforest.sh uses non-POSIX sh features that may fail with some shells Reviewed-by: tbell, katleman, dholmes ! common/bin/hgforest.sh

RFR : 8010948 : Add conversion functional interfaces

Hello all; Another set of functional interfaces for review for the soon-to-be-arriving-in-TL-repo lambda libraries. http://cr.openjdk.java.net/~mduigou/JDK-8010948/0/webrev/ These interfaces are Functions between the core primitive types (double, int, long) used by the lambda libraries. Method

Re: RFR JDK-8011200 (was 7143928) : (coll) Optimize for Empty ArrayList and HashMap

A couple small things: HashMap: It might be nice to have a comment or two on the new, dual-purpose of 'threshold': perhaps in the comments for inflateTable(), and/or at the field declaration. ArrayList: Is there an extra set of ()'s around (minCapacity > DEFAULT_CAPACITY) ? Thanks, -Brent O

Re: Review request for 7198429: need checked categorization of caller-sensitive methods in the JDK

On Apr 3, 2013, at 12:52 PM, Jeroen Frijters wrote: > Thanks for this. This is a really great change. > > I reviewed the changes and my only comment is that there is a typo in > java/lang/reflect/Field.java ("scurity"). Thanks! > Somewhat unrelated (but relevant for my implementation of Calle

Re: Review request for 8011393 - javadoc typo in SerialClob.truncate

Hi Mandy, Thank you for the suggestion and the review. I have been making some of those changes as I have been going forward. I agree, that would be better to use {@code} and will look to continue to clean those things up. Would be great if we had an automated tool to help as I am sure ther

RE: Review request for 7198429: need checked categorization of caller-sensitive methods in the JDK

Hi, Thanks for this. This is a really great change. I reviewed the changes and my only comment is that there is a typo in java/lang/reflect/Field.java ("scurity"). Somewhat unrelated (but relevant for my implementation of CallerSensitive), but would it be possible to mark java.lang.Runtime as

hg: jdk8/tl/langtools: 8011052: Add DEFAULT to javax.lang.model.Modifier

Changeset: 0d47e6131490 Author:darcy Date: 2013-04-03 12:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0d47e6131490 8011052: Add DEFAULT to javax.lang.model.Modifier Reviewed-by: abuckley, jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/clas

Re: Review request for 7198429: need checked categorization of caller-sensitive methods in the JDK

This version has corrected to use Class.getMethod to determine if the checkMemberAccess method is overridden in the subclass: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7198429/webrev.02/ thanks Mandy On 4/2/2013 9:25 PM, John Rose wrote: So getDM has a bug and getM is correct wrt inher

Re: Review request for 8011393 - javadoc typo in SerialClob.truncate

Looks fine. You may want to use {@code CLOB} to replace ... Mandy On 4/3/2013 9:15 AM, Lance Andersen - Oracle wrote: Hi all Need a reviewer for the correction of the following typo in SerialClob.java which is bug 8011393 hg diff SerialClob.java diff -r e6c3b8e74e50 src/share/classes/ja

hg: jdk8/tl/jdk: 7091601: Arabic Locale: can not set type of digit in application level

Changeset: 9a6ef3391f32 Author:naoto Date: 2013-04-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a6ef3391f32 7091601: Arabic Locale: can not set type of digit in application level Reviewed-by: okutsu ! src/macosx/native/sun/util/locale/provider/HostLocaleProviderA

Re: Review request for 8011393 - javadoc typo in SerialClob.truncate

Lance, Looks fine; approved. Cheers, -Joe On 04/03/2013 09:15 AM, Lance Andersen - Oracle wrote: Hi all Need a reviewer for the correction of the following typo in SerialClob.java which is bug 8011393 hg diff SerialClob.java diff -r e6c3b8e74e50 src/share/classes/javax/sql/rowset/seria

Re: Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type

Hi Peter, On 04/03/2013 01:26 AM, Peter Levart wrote: Hi Joe, Why not using StringBuilder instead of StringBuffer in Class.toGenericString ? No reason. Thanks for catching this; I'll use StringBuilder in the final push. Thanks, -Joe Regards, Peter On 04/03/2013 09:27 AM, Joe Darcy wr

Review request for 8011393 - javadoc typo in SerialClob.truncate

Hi all Need a reviewer for the correction of the following typo in SerialClob.java which is bug 8011393 hg diff SerialClob.java diff -r e6c3b8e74e50 src/share/classes/javax/sql/rowset/serial/SerialClob.java --- a/src/share/classes/javax/sql/rowset/serial/SerialClob.java Tue Apr 02 10:12:20

Re: RFR: JDK-8011187 : http://cr.openjdk.java.net/~mduigou/JDK-8011187/0/webrev/

Looks fine. -kto On Apr 1, 2013, at 1:19 PM, Mike Duigou wrote: > Hello all; > > Another changeset for review in the series "JDK-8009683 Running regression > tests with make". Many of the targets in jdk/test/Makefile are currently > unused or were never used. These targets will be removed:

Re: Review request for 7198429: need checked categorization of caller-sensitive methods in the JDK

Peter, Thanks. I misread your example and missed the fact that SM2 extends SM1. After seeing John's reply, I reread the example and realized the correctness issue you try to point out. I'll revise it and send out a new webrev. Mandy On 4/3/2013 12:39 AM, Peter Levart wrote: On 04/03/2013

Re: RFR JDK-8011200 (was 7143928) : (coll) Optimize for Empty ArrayList and HashMap

On 02/04/2013 23:50, Mike Duigou wrote: Hello again; I have updated the patch with the received review feedback. The revised webrev is here: http://cr.openjdk.java.net/~mduigou/JDK-8011200/1/webrev/ The important changes in this revision: - The behaviour of the readObject/writeObject seriali

Re: hg: jdk8/tl/jdk: 8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level

On 04/03/2013 04:59 PM, Mandy Chung wrote: On 4/3/2013 7:01 AM, Alan Bateman wrote: On 03/04/2013 14:29, Peter Levart wrote: : The change was designed to be largely source-level compatible, but not binary-level. Is this JavaFX 8? Is it going to be re-compiled with recent JDK8? Is JavaFX 8 su

Re: hg: jdk8/tl/jdk: 8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level

On 4/3/2013 7:01 AM, Alan Bateman wrote: On 03/04/2013 14:29, Peter Levart wrote: : The change was designed to be largely source-level compatible, but not binary-level. Is this JavaFX 8? Is it going to be re-compiled with recent JDK8? Is JavaFX 8 supposed to be compatible with both JDK7 and

Re: [OpenJDK 2D-Dev] Review Request: JDK-8000406 - change files using @GenerateNativeHeader to use @Native

Hi Phil, Thank you for your good comments. Please see my answers below. On 04/02/2013 12:37 PM, Phil Race wrote: The addition of @Native to various lines in SunGraphics2D.java look to have pushed them >80 chars and it looks to me as if previously the author took some care to limit it. Moreover

Re: hg: jdk8/tl/jdk: 8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level

On 03/04/2013 14:29, Peter Levart wrote: : The change was designed to be largely source-level compatible, but not binary-level. Is this JavaFX 8? Is it going to be re-compiled with recent JDK8? Is JavaFX 8 supposed to be compatible with both JDK7 and JDK8 ? If PlatformLogger API is supposed

Re: hg: jdk8/tl/jdk: 8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level

On 04/03/2013 02:41 PM, Alan Bateman wrote: On 28/03/2013 20:16, mandy.ch...@oracle.com wrote: Changeset: e433ed08b733 Author:mchung Date: 2013-03-28 13:14 -0700 URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e433ed08b733 8010309: Improve PlatformLogger.isLoggable performance by direct

hg: jdk8/tl/jdk: 8011373: Property java.runtime.profile should be removed (left-over code)

Changeset: eb8f7bc6f964 Author:alanb Date: 2013-04-03 13:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb8f7bc6f964 8011373: Property java.runtime.profile should be removed (left-over code) Reviewed-by: lancea, dholmes ! src/share/classes/sun/misc/Version.java.template

Re: hg: jdk8/tl/jdk: 8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level

Does JavaFX belong to OpenJDK projects (*openjfx/8) *? How do I build the complete OpenJDK (javafx, java web start ...) ? Laurent 2013/4/3 Alan Bateman > On 28/03/2013 20:16, mandy.ch...@oracle.com wrote: > > Changeset: e433ed08b733 > Author:mchung >

Re: hg: jdk8/tl/jdk: 8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level

On 28/03/2013 20:16, mandy.ch...@oracle.com wrote: Changeset: e433ed08b733 Author:mchung Date: 2013-03-28 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e433ed08b733 8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level Rev

Re: 8011373: Property java.runtime.profile should be removed (left-over code)

Looks good. David On 3/04/2013 9:14 PM, Alan Bateman wrote: I need a reviewer for a trivial change to remove code that sets the property java.runtime.profile during initialization. This is a left-over experimental code from the jdk8/profiles forest that I should have removed before the changes

hg: jdk8/tl/jdk: 8011234: Performance regression with ftp protocol when uploading in image mode

Changeset: c534937f6e94 Author:alanb Date: 2013-04-03 13:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c534937f6e94 8011234: Performance regression with ftp protocol when uploading in image mode Reviewed-by: chegar ! src/share/classes/sun/net/ftp/impl/FtpClient.java

Re: 8011373: Property java.runtime.profile should be removed (left-over code)

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 3, 2013, at 7:14 AM, Alan Bateman wrote: > > I need a reviewer for a trivial change to remove code that set

8011373: Property java.runtime.profile should be removed (left-over code)

I need a reviewer for a trivial change to remove code that sets the property java.runtime.profile during initialization. This is a left-over experimental code from the jdk8/profiles forest that I should have removed before the changes were pushed to the build forest. Thanks, Alan. diff --gi

Re: [concurrency-interest] RFR [8011215] optimization of CopyOnWriteArrayList.addIfAbsent()

A few quick notes while travelling: This was designed to perform best in the case of possibly contended updates when the element is absent, by avoiding retraversal, and thus minimizing lock hold times in the common case. (When not common, it can be guarded by a contains check.) However even in th

Re: [OpenJDK 2D-Dev] sun.java2D.pisces big memory usage (waste ?)

Thanks for your valueable feedback! Here is the current status of my patch alpha version: >> http://jmmc.fr/~bourgesl/share/java2d-pisces/ >> >> There is still a lot to be done: clean-up, stats, pisces class instance >> recycling (renderer, stroker ...) and of course sizing correctly initial >> ar

Re: Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type

Hi Joe, Why not using StringBuilder instead of StringBuffer in Class.toGenericString ? Regards, Peter On 04/03/2013 09:27 AM, Joe Darcy wrote: Hello, This is combined code review request for 629 (reflect) Add toGenericString to java.lang.Class and getTypeName to java.lang.reflect.

Re: RFR [8011215] optimization of CopyOnWriteArrayList.addIfAbsent()

On 03/04/2013 00:28, Ivan Gerasimov wrote: Thank you, Louis. Yes, you're probably right. I might want to get familiar with caliper mentioned earlier, or something else like that. One other tool to also be aware of is the Java Microbenchmark Harness [1]. Aleksey Shipilev recently contributed th

Re: Review request for 7198429: need checked categorization of caller-sensitive methods in the JDK

On 04/03/2013 12:25 AM, Mandy Chung wrote: On 4/2/13 3:00 PM, Peter Levart wrote: Hi Mandy, There could be: public class SM1 extends SecurityManager { @Override public void checkMemberAccess(Class clazz, int which) {... and: public class SM2 extends SM1 { ... // no checkMemberAccess override

Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type

Hello, This is combined code review request for 629 (reflect) Add toGenericString to java.lang.Class and getTypeName to java.lang.reflect.Type 6992705 (reflect) Include modifiers to Class's toGenericString() http://cr.openjdk.java.net/~darcy/629.0/ In brief, a "toGenericSt