Changeset: 7d4e30730f80
Author:valeriep
Date: 2013-04-04 20:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d4e30730f80
7155720: PKCS11 minor issues in native code
Summary: Added OOM handling to address the two issues found by parfait.
Reviewed-by: weijun
! src/solaris/na
On 5/04/2013 11:27 AM, Mani Sarkar wrote:
Hi David,
I'll reply in more detail later but to respond to your comment on:
> I would not add the extra methods around the cdl.await() and
cdl.countDown() as they just obscure things
In general its meant to do the opposite. We come across a lot of cod
Hi David,
I'll reply in more detail later but to respond to your comment on:
> I would not add the extra methods around the cdl.await() and
cdl.countDown() as they just obscure things
In general its meant to do the opposite. We come across a lot of code that
does not express intent, and the purpo
Hi Mani,
Patches came through ok.
I would not add the extra methods around the cdl.await() and
cdl.countDown() as they just obscure things in my opinion. But that
aside the latch is not needed. The fork() method starts a thread and
joins it. So when createNoise() returns we already know for c
Thanks David,
Here are the patches, let me know if they have come in fine:
1) test/java/lang/ref/Basic.**java.patch - changed to not use
Thread.sleep() any more rather use the java.util.concurrent.**CountdownLatch
functionality
Authors: Mani (sadhak...@gmail.com) and Edward Yue Shung Wong (
edwa
Hi Mani,
Attachments get stripped so you will need to inline the patches in your
email to the list.
Thanks,
David
On 5/04/2013 9:07 AM, Mani Sarkar wrote:
Hi all,
I'd like to rectify that I;m a contributor (and not a committer as
mentioned earlier), so I don't have access to the webrev syst
Hi all,
I'd like to rectify that I;m a contributor (and not a committer as
mentioned earlier), so I don't have access to the webrev system but would
love to have these patches hosted on them when a sponsor becomes available.
Cheers,
mani
On Thu, Apr 4, 2013 at 11:57 PM, Mani Sarkar wrote:
> Hi
Hi all,
During #TestFest in London last month we hacked away on jtreg and tests in
the OpenJDK. Myself and another participant managed to change two unit
tests. I haven't looked for a sponsor in the past so I'm fairly new to the
process, hence my email on the list is to request for someone to revi
Changeset: 7b1189bf1d7b
Author:dxu
Date: 2013-04-04 15:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b1189bf1d7b
8000406: change files using @GenerateNativeHeader to use @Native
Summary: Use @Native annotation to mark constants interested by native codes
Reviewed-by: ala
Alan - can you review this change?
I have changed Level.valueOf(int) to return the nearest Level as Peter
suggests using binary search:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8011380/webrev.01/
I want to push the changeset tomorrow since we need this fix before the
TL integration.
On Tue, Apr 2, 2013 at 3:50 PM, Mike Duigou wrote:
>
> - T I will file a spec change request for the addition of ", a power of 2"
> to the @serialData tag for this existing but previously unstated
> requirement.
>
Hi Mike,
I think changing the serialization spec is a mistake. There are a bunch
Well done: binary search to find the closest matching level !
However, I still do not see any concrete use case for custom Levels in such
closed API as PlatformLogger is: KISS, please !
I mean as PlatformLogger is only used (available) to JDK and related
projects, is there any RFE or will to use
This is finally ready for integration. Going once... going twice...
Updated webrev and specdiff:
http://cr.openjdk.java.net/~chegar/8005696/ver.02/
Doug,
I just finalized the jtreg test, and found a small issue. Please find
below a suggested change (included in the webrev), and a small test
Hi Mandy, Laurent,
What do you think of this variation (changed just PlatformLogger, other
files exactly equal to your webrev):
http://dl.dropbox.com/u/101777488/jdk8-tl/PlatformLogger/webrev.enumapi.02/index.html
Moved the nearest >= intValue search to
PlatformLogger.Level.valueOf(int) sinc
I updated both patched pisces code and benchmarks:
http://jmmc.fr/~bourgesl/share/java2d-pisces/
Few results comparing ThreadLocal vs ConcurrentLinkedQueue usage:
OpenJDK 8 PATCH ThreadLocal mode:
Testing file
/home/bourgesl/libs/openjdk/mapbench/test/dc_boulder_2013-13-30-06-13-17.ser
1 threads
Ok, I can provide an updated patch after finding / fixing all usages.
Probably in 1 or 2 days,
Laurent
2013/4/4 Anthony Petrov
> Yes, this makes sense. Do you want to update your fix for 8010297 to
> include these changes as well?
>
> --
> best regards,
> Anthony
>
>
> On 04/04/13 15:47, Laure
Yes, this makes sense. Do you want to update your fix for 8010297 to
include these changes as well?
--
best regards,
Anthony
On 04/04/13 15:47, Laurent Bourgès wrote:
Dear all,
I just realized there is another problem with PlatformLogger log statements:
XBaseWindow:
public boolean grabIn
Dear all,
I just realized there is another problem with PlatformLogger log statements:
XBaseWindow:
public boolean grabInput() {
grabLog.fine("Grab input on {0}", this);
...
}
This calls the PlatformLogger.fine( varargs):
public void fine(String msg, Object... params) {
lo
Mandy, Peter,
here are my comments:
On 04/04/2013 06:52 AM, Mandy Chung wrote:
>
> Peter, Laurent,
>
> History and details are described below.
>
> Webrev at:
> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8011380/webrev.00/
>
> I add back the getLevel(int), setLevel(int) and isLoggable(int) m
HI Mandy,
On 04/04/2013 06:52 AM, Mandy Chung wrote:
Peter, Laurent,
History and details are described below.
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8011380/webrev.00/
I add back the getLevel(int), setLevel(int) and isLoggable(int)
methods but marked deprecated and also r
20 matches
Mail list logo
