system reserved property names

2013-04-17 Thread huizhe wang
System.getProperties [1] returns all of the "current" system properties. Is there a way to get a list of the system reserved properties such as "java.version" and etc.? Would anyone know? [1]http://docs.oracle.com/javase/6/docs/api/java/lang/System.html#getProperties%28%29 Thanks, Joe

hg: jdk8/tl/jdk: 8010096: Initial java.util.Spliterator putback

2013-04-17 Thread mike . duigou
Changeset: 674880648db4 Author:briangoetz Date: 2013-04-16 13:51 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/674880648db4 8010096: Initial java.util.Spliterator putback Reviewed-by: mduigou, alanb, chegar, darcy Contributed-by: Paul Sandoz , Brian Goetz , Doug Lea ! src

Re: RFR: String.join(), StringJoiner additions

2013-04-17 Thread Mike Duigou
If I don't get a chance to revisit the whole UUID optimization patch soon I will see what I can do about breaking it up further and maybe just do the no-copy String constructor by itself. Mike On Apr 17 2013, at 20:29 , Martin Buchholz wrote: > To be concrete, here's a proposed toString method

Re: RFR: String.join(), StringJoiner additions

2013-04-17 Thread Martin Buchholz
To be concrete, here's a proposed toString method : http://cr.openjdk.java.net/~martin/webrevs/openjdk8/toString/ which is pretty good as it stands, but even better once it gets to use the no-copy String constructor.

Re: What is the Build Process for Codes inside jdk/src/macosx/native/jobjc

2013-04-17 Thread David Holmes
On 18/04/2013 10:50 AM, Dan Xu wrote: Hi David, Under src/macosx/native/jobjc folder, it contains not only native *.m source files, but also *.java files. If you check the build results in build/macosx-x86_64-normal-server-release/jdk folder, it contains some build results specific for jobjc, sa

Re: RFR: JDK8011946 - java.util.Currency javadoc has broken link to iso.org

2013-04-17 Thread Mike Duigou
Looks good to me! The table is still accessible from that page it's just no longer part of the page. Mike On Apr 17 2013, at 17:57 , Dan Xu wrote: > Hi All, > > Here is ajava doc fix. I have changed the broken link and pointed it to the > page for standard ISO 4217. Thanks! > > Webrev: http

Re: RFR: String.join(), StringJoiner additions

2013-04-17 Thread Roger Riggs
Hi, Can I suggest that the StringJoiner.toString() method explicitly append the suffix to the existing StringBuilder. 152 return (value != null ? value.toString() + suffix : emptyValue); Currently it will go to the trouble of creating a String from the builder and then transparentl

Re: RFR: String.join(), StringJoiner additions

2013-04-17 Thread Brian Goetz
The motivation was indeed that it would support more efficient Collection.toString. (But, I don't believe anything actually uses that feature right now, other than tests.) Even if *our* implementations were not to use this because we had a better for-experts construction, I still think this i

RFR: JDK8011946 - java.util.Currency javadoc has broken link to iso.org

2013-04-17 Thread Dan Xu
Hi All, Here is ajava doc fix. I have changed the broken link and pointed it to the page for standard ISO 4217. Thanks! Webrev: http://cr.openjdk.java.net/~dxu/8011946/webrev/ Bug: http://bugs.sun.com/view_bug.do?bug_id=8011946 -Dan

Re: What is the Build Process for Codes inside jdk/src/macosx/native/jobjc

2013-04-17 Thread Dan Xu
Hi David, Under src/macosx/native/jobjc folder, it contains not only native *.m source files, but also *.java files. If you check the build results in build/macosx-x86_64-normal-server-release/jdk folder, it contains some build results specific for jobjc, say gensrc_jobjc/, gensrc_headers_job

Re: Use of super in type parameters

2013-04-17 Thread Martin Buchholz
Thanks, all, for the history lesson.

Re: What is the Build Process for Codes inside jdk/src/macosx/native/jobjc

2013-04-17 Thread David Holmes
Hi Dan, I don't quite understand the question but all native code building is handled via jdk/makefiles/CompileNativeLibraries.gmk which in turn utilizes the set up from /common/makefiles/NativeCompilation.gmk HTH David On 18/04/2013 9:51 AM, Dan Xu wrote: Adding core-libs-dev On 04/17/20

Re: Use of super in type parameters

2013-04-17 Thread Zhong Yu
On Wed, Apr 17, 2013 at 4:53 PM, Martin Buchholz wrote: > With the coming of lambda, it is more likely that people will be creating > APIs with "not quite correct" generic types, as we are doing in I believe that we can tweak generic signatures in APIs without breaking calling codes. No API user

RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

2013-04-17 Thread Mike Duigou
Hello All; Some of you have noticed that the lambda streams libraries patches currently going in to the TL repo make use of special javadoc tags. There are three tags being used: @apiNote : Non-normative notes about the API. Usually used for examples. @implSpec : Describes required behaviour of

Re: What is the Build Process for Codes inside jdk/src/macosx/native/jobjc

2013-04-17 Thread Dan Xu
Adding core-libs-dev On 04/17/2013 04:47 PM, Dan Xu wrote: Hi, As for the sourcecodes for mac platform, it has a special place holding native and java codes for jdk, jdk/src/macosx/native/jobjc. I wonder how those codes are builtand whether its compilation process has any special handling. T

Re: Use of super in type parameters

2013-04-17 Thread Dan Smith
On Apr 15, 2013, at 1:37 PM, Martin Buchholz wrote: > CompletableFuture currently has a method like this: > > public CompletableFuture acceptEither > (CompletableFuture other, > Consumer block) { > return doAcceptEither(other, block, null); > } > > But that sign

RFR: JDK-8012542 (Stream methods on Collection)

2013-04-17 Thread Brian Goetz
Updated spec for Collection.spliterator; default methods for Collection.stream() and parallelStream(). Specialized implementations in subtypes will come in a separate putback. Webrev at: http://cr.openjdk.java.net/~briangoetz/JDK-8012542/webrev/

Re: RFR: String.join(), StringJoiner additions

2013-04-17 Thread Jim Gish
I'm open to this, but am interested in what others have to say, especially as it relates to other lambda features coming in. Bear in mind that this is at least the third major round of reviews for these changes, the first round being a year ago on lambda-dev, when I first submitted them, and t

Re: RFR: String.join(), StringJoiner additions

2013-04-17 Thread Martin Buchholz
I'm still wondering about whether a joiner utility should support a prefix and suffix. The obvious uses for this are collection class toString methods, but we already know that we can and should implement those with a single precise char[] construction, so should not use StringJoiner, or at least

Re: Use of super in type parameters

2013-04-17 Thread Martin Buchholz
With the coming of lambda, it is more likely that people will be creating APIs with "not quite correct" generic types, as we are doing in CompletableFuture. Which is pretty bad for a feature that is designed specifically to provide compile time safety. It would be nice to at least have an acknowl

Re: RFR: String.join(), StringJoiner additions

2013-04-17 Thread Jim Gish
Here's an update: http://cr.openjdk.java.net/~jgish/Bugs-5015163-7172553/ Jim On 04/17/2013 03:15 PM, Mike Duigou wrote: String:: line 1253: This should use {@code } rather than . I think regular spaces are OK as well.   seems inap

Re: Incorrect arguments is passed to sun.misc.Perf#createLong

2013-04-17 Thread Mandy Chung
Hi Yasumasa, Thanks for the patch. I'm going to sponsor your fix for 8011934 and will be pushing it shortly. http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8011934/webrev.00/ Mandy On 4/10/2013 6:59 PM, Yasu wrote: Hi Mandy, On 4:59, Mandy Chung wrote: Hi Yasumasa, I'm adding core-libs

Re: [OpenJDK 2D-Dev] sun.java2D.Pisces renderer Performance and Memory enhancements

2013-04-17 Thread Phil Race
> whereas on Windows / Mac it is client compiler (c1). For Mac we only have a 64 bit VM which SFAIK should be c2 as well, yet in that case native was presumably still faster. So its also a matter of factoring in how good the code is that is generated by the C compiler. -phil. On 4/17/2013 1:26

RE: Code review request for 8012044: Give more information about self-suppression from Throwable.addSuppressed

2013-04-17 Thread Jason Mehrens
Joe, The patch at http://cr.openjdk.java.net/~darcy/8012044.3/ looks good to me. Thanks for working on this. Jason > Date: Wed, 17 Apr 2013 10:32:10 -0700 > From: joe.da...@oracle.com > To: jason_mehr...@hotmail.com > CC: core-libs-dev@openjdk.java.net

Re: [OpenJDK 2D-Dev] sun.java2D.Pisces renderer Performance and Memory enhancements

2013-04-17 Thread Laurent Bourgès
Jim, thanks for having some interest for my efforts ! As I got almost no feedback, I felt quite disappointed and was thinking that improving pisces was not important ... Here are ductus results and comparison (open office format): http://jmmc.fr/~bourgesl/share/java2d-pisces/ductus_det.log http:/

hg: jdk8/tl/jdk: 16 new changesets

2013-04-17 Thread lana . steuck
Changeset: 87c62f03bc07 Author:jgodinez Date: 2013-03-27 12:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/87c62f03bc07 8010005: [parfait] Memory leak in jdk/src/macosx/native/sun/awt/CTextPipe.m Reviewed-by: bae, prr Contributed-by: jia-hong.c...@oracle.com ! src/macosx/

hg: jdk8/tl/jaxws: 2 new changesets

2013-04-17 Thread lana . steuck
Changeset: a5e7c2f093c9 Author:lana Date: 2013-04-16 08:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/a5e7c2f093c9 Merge - src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/DefaultAuthenticator.java - src/share/jaxws_classes/com/sun/tools/internal/xjc/api/i

hg: jdk8/tl/hotspot: 19 new changesets

2013-04-17 Thread lana . steuck
Changeset: e437668ced9d Author:amurillo Date: 2013-04-11 01:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e437668ced9d 8011948: new hotspot build - hs25-b28 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 68fe50d4f1d5 Author:johnc Date: 2013-04-05 10

hg: jdk8/tl/nashorn: 2 new changesets

2013-04-17 Thread lana . steuck
Changeset: 35881a9d0fc2 Author:lana Date: 2013-04-16 08:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/35881a9d0fc2 Merge - test/script/basic/JDK-8017010.js - test/script/basic/JDK-8017010.js.EXPECTED Changeset: 44d8612e29b0 Author:lana Date: 2013-04-17 10:3

hg: jdk8/tl/langtools: 2 new changesets

2013-04-17 Thread lana . steuck
Changeset: 1f19b84efa6d Author:lana Date: 2013-04-16 08:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1f19b84efa6d Merge - src/share/classes/com/sun/tools/javac/util/CloseableURLClassLoader.java - test/tools/javac/diags/examples/SecondaryBoundMustBeMarkerIntf.java

hg: jdk8/tl/jdk: 2 new changesets

2013-04-17 Thread coleen . phillimore
Changeset: 7f9f69729934 Author:coleenp Date: 2013-04-17 12:50 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7f9f69729934 8009531: Crash when redefining class with annotated method Summary: Add code to annotated methods and command line flags to the tests to verify bug above

RFR: JDK-8011917 (java.util.stream.Collectors)

2013-04-17 Thread Brian Goetz
Single new source file at: http://hg.openjdk.java.net/lambda/lambda/jdk/file/76ac19e61df1/src/share/classes/java/util/stream/Collectors.java Doc at: http://cr.openjdk.java.net/~briangoetz/JDK-8008682/api/java/util/stream/Collectors.html for JDK-8011917 (Collectors class in java.util.stream).

Re: RFR: String.join(), StringJoiner additions

2013-04-17 Thread Mike Duigou
String:: line 1253: This should use {@code } rather than . I think regular spaces are OK as well.   seems inappropriate. lines 2425/2467: elements may not be null either. I can tell you (or maybe it's just me) are itching to change : for (CharSequence cs: elements) { 2477 joiner.ad

hg: jdk8/tl/jdk: 8004260: dynamic proxy class should have the same Java language access as the proxy interfaces

2013-04-17 Thread mandy . chung
Changeset: 73e3b474125e Author:mchung Date: 2013-04-17 12:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/73e3b474125e 8004260: dynamic proxy class should have the same Java language access as the proxy interfaces Reviewed-by: alanb, jrose, jdn ! src/share/classes/java/la

hg: jdk8/tl/jdk: 8010953: Add primitive summary statistics utils

2013-04-17 Thread mike . duigou
Changeset: d9f9040554d6 Author:mduigou Date: 2013-04-17 11:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9f9040554d6 8010953: Add primitive summary statistics utils Reviewed-by: mduigou, dholmes, chegar, darcy Contributed-by: Brian Goetz + src/share/classes/java/util/D

Re: [PATCH] Review Request for 8009258: TEST_BUG: java/io/pathNames/GeneralWin32.java fails intermittently

2013-04-17 Thread Dan Xu
On 04/17/2013 02:15 AM, Alan Bateman wrote: On 17/04/2013 07:36, Dan Xu wrote: : In the changes, the usages of NIO classes are not necessary. The test is against java.io packages, and it is better to keep it clean in case it might be used to test old jdk version which does not have NIO. I

Re: Request for review of 8009648 Tests fail in -agentvm -concurrency mode

2013-04-17 Thread Alan Bateman
On 17/04/2013 18:00, roger riggs wrote: As noted in 8009648: Tests fail in -agentvm -concurrency mode there are several tests that fail in agentvm mode, adding the directories with the sensitive tests to othervms.dir speeds up testing and the tests pass. Please review. http://cr.openjdk.java.

Re: Code review request for 8012044: Give more information about self-suppression from Throwable.addSuppressed

2013-04-17 Thread Joe Darcy
On 04/14/2013 07:36 PM, Joe Darcy wrote: On 04/12/2013 07:29 PM, Jason Mehrens wrote: Joe, You'll have guard ise.addSuppressed against null. Looks good otherwise. private static void initCauseNull() { Throwable t1 = new Throwable(); t1.initCause(null); try { t1.initCa

Re: RFR: 8009681: TEST_BUG: MethodExitReturnValuesTest.java fails with when there are unexpected background threads

2013-04-17 Thread serguei.spit...@oracle.com
Hi Mikael, It looks good. Thank you for figuring out how to make it more stable! BTW, the webrev frames mode does not work. Thanks, Serguei On 4/17/13 6:03 AM, Mikael Auno wrote: Hi, I'd like some reviews on http://cr.openjdk.java.net/~nloodin/8009681/webrev.01/ for JDK-8009681 (http://bugs.

Request for review of 8009648 Tests fail in -agentvm -concurrency mode

2013-04-17 Thread roger riggs
As noted in 8009648: Tests fail in -agentvm -concurrency mode there are several tests that fail in agentvm mode, adding the directories with the sensitive tests to othervms.dir speeds up testing and the tests pass. Please review. http://cr.openjdk.java.net/~rriggs/webrev-testconcurrency/

Re: RFR: JDK-8005954: JAXP Plugability Layer should use java.util.ServiceLoader

2013-04-17 Thread Daniel Fuchs
On 4/17/13 6:30 PM, Alan Bateman wrote: On 17/04/2013 16:41, Daniel Fuchs wrote: Hi, These changes correspond to the changes that have been already reviewed under the umbrella name of JDK-7169894 (which was closed & cloned into JDK-8005954 for administrative reasons) - re-based on the latest jd

Re: RFR: JDK-8005954: JAXP Plugability Layer should use java.util.ServiceLoader

2013-04-17 Thread Alan Bateman
On 17/04/2013 16:41, Daniel Fuchs wrote: Hi, These changes correspond to the changes that have been already reviewed under the umbrella name of JDK-7169894 (which was closed & cloned into JDK-8005954 for administrative reasons) - re-based on the latest jdk8-tl forest tip. So this is basically J

RFR: JDK-8005954: JAXP Plugability Layer should use java.util.ServiceLoader

2013-04-17 Thread Daniel Fuchs
Hi, These changes correspond to the changes that have been already reviewed under the umbrella name of JDK-7169894 (which was closed & cloned into JDK-8005954 for administrative reasons) - re-based on the latest jdk8-tl forest tip. So this is basically JDK-7169894, re-based & merged at the tip -

hg: jdk8/tl/jdk: 8012019: (fc) Thread.interrupt triggers hang in FileChannelImpl.pread (win)

2013-04-17 Thread alan . bateman
Changeset: 7ded74ffea36 Author:alanb Date: 2013-04-17 16:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ded74ffea36 8012019: (fc) Thread.interrupt triggers hang in FileChannelImpl.pread (win) Reviewed-by: chegar ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! s

hg: jdk8/tl/jdk: 12 new changesets

2013-04-17 Thread vincent . x . ryan
Changeset: 473ed4b94306 Author:vinnie Date: 2013-04-11 17:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/473ed4b94306 7171982: Cipher getParameters() throws RuntimeException: Cannot find SunJCE provider Reviewed-by: vinnie, wetmore Contributed-by: Tony Scarpino ! src/sh

Re: RFR: String.join(), StringJoiner additions

2013-04-17 Thread Jim Gish
I'm going to rip out the then. It's an unnecessary burden. Thanks Jim On 04/16/2013 06:50 PM, Mike Duigou wrote: On Apr 16 2013, at 08:50 , Alan Bateman wrote: On 16/04/2013 16:13, Jim Gish wrote: On 04/15/2013 02:02 PM, Martin Buchholz wrote: You are fiddling with the javadoc for getCh

Re: Proxy.isProxyClass scalability

2013-04-17 Thread Peter Levart
Hi Mandy, Here's the updated webrev: https://dl.dropboxusercontent.com/u/101777488/jdk8-tl/proxy-wc/webrev.02/index.html This adds TwoLevelWeakCache to the scene with following performance compared to other alternatives: Summary (4 Cores x 2 Threads i7 CPU): Test Threads

RFR: 8009681: TEST_BUG: MethodExitReturnValuesTest.java fails with when there are unexpected background threads

2013-04-17 Thread Mikael Auno
Hi, I'd like some reviews on http://cr.openjdk.java.net/~nloodin/8009681/webrev.01/ for JDK-8009681 (http://bugs.sun.com/view_bug.do?bug_id=8009681). The issue here is that when MethodExitReturnValuesTest hooks into MethodExit events through JDI it uses an exclude list to filter out classes f

hg: jdk8/tl/langtools: 8011181: javac, empty UTF8 entry generated for inner class

2013-04-17 Thread vicente . romero
Changeset: 49d32c84dfea Author:vromero Date: 2013-04-17 11:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/49d32c84dfea 8011181: javac, empty UTF8 entry generated for inner class Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java + test/too

Re: [PATCH] Review Request for 8009258: TEST_BUG: java/io/pathNames/GeneralWin32.java fails intermittently

2013-04-17 Thread Alan Bateman
On 17/04/2013 07:36, Dan Xu wrote: : In the changes, the usages of NIO classes are not necessary. The test is against java.io packages, and it is better to keep it clean in case it might be used to test old jdk version which does not have NIO. I briefly looked at it and I think the usage oka

Re: Fwd: Latency in starting threads on Mac OS X

2013-04-17 Thread Alan Bateman
On 17/04/2013 02:27, David Holmes wrote: : I don't know specifically what may have changed between 7u5 and 7u6 in that regard but I think it would be a hotspot issue more than a libraries issue. I know 7u6 was the first version of JDK to fully support OS X. The Mac support went into 7u4 but O

hg: jdk8/tl: 8011347: JKD-8009824 has broken webrev with some ksh versions

2013-04-17 Thread daniel . fuchs
Changeset: b95c5c8ee60a Author:jgish Date: 2013-04-16 13:25 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b95c5c8ee60a 8011347: JKD-8009824 has broken webrev with some ksh versions Reviewed-by: mduigou ! make/scripts/webrev.ksh