Re: review request: 8011620 adding free form netbeans project for jdbc to jdk/make/netbeans

FWIW, looks ok to me. -Chris. On 04/19/2013 07:11 PM, Lance Andersen - Oracle wrote: still looking for a committer to bless this webrev so I can put it back thank you in advance best Lance On Apr 9, 2013, at 11:58 AM, Lance Andersen - Oracle wrote: Thank you ulf, I made the change in my wo

hg: jdk8/tl/jdk: 8010939: Deadlock in LogManager

Changeset: e8f1dc6d0c0c Author:jgish Date: 2013-04-19 16:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8f1dc6d0c0c 8010939: Deadlock in LogManager Summary: re-order locks to avoid deadlock Reviewed-by: mchung ! src/share/classes/java/util/logging/LogManager.java + test/

Re: RFR: 8001647: In-place methods on Collection/List

On 04/19/2013 05:42 AM, David Holmes wrote: On 19/04/2013 10:14 PM, Paul Sandoz wrote: On Apr 19, 2013, at 1:15 PM, Alan Bateman wrote: On 18/04/2013 19:49, Akhil Arora wrote: Looks like the stars are aligning on getting on this into TL... the refreshed webrev is - http://cr.openjdk.java.n

Re: RFR: 8001647: In-place methods on Collection/List

On 04/19/2013 04:15 AM, Alan Bateman wrote: On 18/04/2013 19:49, Akhil Arora wrote: Looks like the stars are aligning on getting on this into TL... the refreshed webrev is - http://cr.openjdk.java.net/~akhil/8001647.8/webrev/ A minor comment on Collection.removeIf is "that satisifies the give

Re: RFR: 8001647: In-place methods on Collection/List

On 04/18/2013 12:36 PM, Mike Duigou wrote: Hi Akhil; List.sort:: - @since tag is in a strange location. - The (optional) on IAE is in a strange position and not linked like the others. fixed both AbstractList:: - Should we consider adding overrides for default methods here even if our im

Re: RFR: 8001647: In-place methods on Collection/List

Updated with feedback so far - http://cr.openjdk.java.net/~akhil/8001647.9/webrev/ On 04/18/2013 11:49 AM, Akhil Arora wrote: Looks like the stars are aligning on getting on this into TL... the refreshed webrev is - http://cr.openjdk.java.net/~akhil/8001647.8/webrev/ Please review Thanks On

RFR: 8005051: optimized defaults for Iterator.forEachRemaining

Please review the addition of optimized defaults for Iterator's forEachRemaining to ArrayList, LinkedList, Vector and CopyOnWriteArrayList. The unit test has a performance comparison test (disabled by default) that measures the difference between this method and hasNext()/next(). Significant im

Re: RFR: 8010939 Deadlock in LogManager

Hi Mandy, I've incorporated your changes, run JPRT, and posted an updated webrev: http://cr.openjdk.java.net/~jgish/Bug8010939-LogManager-Deadlock.1/ Thanks, Jim On 04/12/2013 06:51 PM, Mandy Chung wrote: Hi Jim, T

hg: jdk8/tl/jdk: 8008670: Initial java.util.stream putback -- internal API classes

Changeset: 6139f8fb0137 Author:mduigou Date: 2013-04-16 22:50 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6139f8fb0137 8008670: Initial java.util.stream putback -- internal API classes Reviewed-by: mduigou, dholmes Contributed-by: Brian Goetz , Doug Lea , Paul Sandoz +

hg: jdk8/tl/langtools: 8012661: remove langtools Makefile-classic

Changeset: d59730bd3162 Author:jjg Date: 2013-04-19 11:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d59730bd3162 8012661: remove langtools Makefile-classic Reviewed-by: erikj, tbell - make/Makefile-classic

Re: review request: 8011620 adding free form netbeans project for jdbc to jdk/make/netbeans

still looking for a committer to bless this webrev so I can put it back thank you in advance best Lance On Apr 9, 2013, at 11:58 AM, Lance Andersen - Oracle wrote: > Thank you ulf, I made the change in my workspace so that it will be > accommodated as part of the putback > > Best > Lance > O

hg: jdk8/tl/jaxp: 8010495: Update JAXP NetBeans project - add support for generating javadoc

Changeset: 1c2079d11a79 Author:dfuchs Date: 2013-04-19 17:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1c2079d11a79 8010495: Update JAXP NetBeans project - add support for generating javadoc Summary: Make it possible to use NetBeans to edit the jaxp sources and to gene

Re: RFR: String.join(), StringJoiner additions

Martin, I've updated the toString() method as you suggested. http://cr.openjdk.java.net/~jgish/Bugs-5015163-7172553/ Thanks, Jim On 04/18/2013 05:02 PM, Martin Buchholz wrote: On Thu, Apr 18, 2013 at 10:34 AM, Jim Gish

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 414384c3b3eb Author:yhuang Date: 2013-04-16 22:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/414384c3b3eb 8011977: ISO 4217 Amendment Number 155 Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! test/java/util/Currency/tablea1.txt Cha

Re: [OpenJDK 2D-Dev] sun.java2D.Pisces renderer Performance and Memory enhancements

On Tue, Apr 9, 2013 at 3:02 PM, Laurent Bourgès wrote: > Dear Java2D members, > > Could someone review the following webrev concerning Java2D Pisces to > enhance its performance and reduce its memory footprint (RendererContext > stored in thread local or concurrent queue): > http://jmmc.fr/~bourge

Re: [OpenJDK 2D-Dev] sun.java2D.Pisces renderer Performance and Memory enhancements

> > Also, this is with the Java version, right? > > Yes, my patch is pure java given as webrev: > http://jmmc.fr/~bourgesl/share/java2d-pisces/webrev-1/ > > We got a decent 2x speedup in FX by porting the version of Open Pisces that > you started with to C code (all except on Linux w

Re: RFR : 8010953: Add primitive summary statistics utils

On Mon, Apr 15, 2013 at 7:30 PM, Mike Duigou wrote: > Another integration review in the JSR-335 libraries series. These three > classes provide a utility for conveniently finding count, sum, min, max > and average of ints, longs or doubles. They can be used with existing code > but will most lik

review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

Hi, We have been asked by a few JDBC driver vendors to allow a JDBC driver to be notified when/if it was deregistered via DriverManager.deregisterDriver if desired. The webrev can be found at http://cr.openjdk.java.net/~lancea/8010416/webrev.01 Best Lance Lance Andersen| Principal Memb

Re: RFR: String.join(), StringJoiner additions

Sorry I am not receiving emails from core-lib-dev earlier. What I did was to remove things we considered not absolutely required, which left us only a StringJoiner class and two String.join methods. StringJoiner was intended to be used with Stream as a collector, thus prefix, and suffix is desi

Re: RFR: String.join(), StringJoiner additions

Hi Henry, Can you please comment on the simplifications you did ? Thanks, Jim On 04/18/2013 07:38 PM, Ulf Zibis wrote: Am 18.04.2013 19:37, schrieb Jim Gish: On 04/18/2013 08:49 AM, Ulf Zibis wrote: Hi, I'm wondering, that StringJoiner has some logic for pre/suffix, but nothing to loo

RFR(XS) : JDK-8008687 - MethodHandle code: allow static and invokespecial calls to interface methods

I would like to request for a review of code changes made to support lambda related modifications to allow static and invokespecial calls to interface methods per spec version 0.6.2 (http://cr.openjdk.java.net/~dlsmith/jsr335-0.6.2.html). These changes support an upcoming change that compiles l

Re: Proxy.isProxyClass scalability

Hi Mandy, I just noticed the following (have been thinking of it already, but then forgot) in original code: /* 512 * Note that we need not worry about reaping the cache for 513 * entries with cleared weak references because if a proxy class 514 * has

Re: Proxy.isProxyClass scalability

On 04/19/2013 04:36 PM, Peter Levart wrote: http://dl.dropboxusercontent.com/u/101777488/jdk8-tl/proxy-wc-wi/webrev.01/index.html Hi Mandy, I changed the copyright header of WeakCache to GPLv2 with ClassPath exception and corrected a minor formatting inconsistency: http://dl.dropboxuse

Re: RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

On Apr 19 2013, at 08:15 , Alan Bateman wrote: > On 19/04/2013 16:13, Mike Duigou wrote: >> : >> Not as currently used, no. The @implSpec is being used to describe required >> behaviour of the implementation, usually defaults. ie. Conforming defaults >> implementations must throw ISE (or UOE, e

Re: RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

On 19/04/2013 16:13, Mike Duigou wrote: : Not as currently used, no. The @implSpec is being used to describe required behaviour of the implementation, usually defaults. ie. Conforming defaults implementations must throw ISE (or UOE, etc.). Sorry, I meant @implNote where it may not always be de

Re: RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

On Apr 19 2013, at 03:40 , Alan Bateman wrote: > On 18/04/2013 16:12, Mike Duigou wrote: >> : >> >>> @implSpec is very welcome, more reasons now with the addition of default >>> methods. >>> >>> Clearly distinguishing normative from non-normative text is also been a >>> long standing problem

Re: RFR: 8001647: In-place methods on Collection/List

On Apr 19, 2013, at 2:42 PM, David Holmes wrote: > On 19/04/2013 10:14 PM, Paul Sandoz wrote: >> >> On Apr 19, 2013, at 1:15 PM, Alan Bateman wrote: >> >>> On 18/04/2013 19:49, Akhil Arora wrote: Looks like the stars are aligning on getting on this into TL... the refreshed webrev is

hg: jdk8/tl/jaxp: 8005954: JAXP Plugability Layer should use java.util.ServiceLoader

Changeset: fad6560cb32a Author:dfuchs Date: 2013-04-17 15:23 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/fad6560cb32a 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP

Re: Proxy.isProxyClass scalability

Hi Mandy, On 04/19/2013 07:33 AM, Mandy Chung wrote: https://dl.dropboxusercontent.com/u/101777488/jdk8-tl/proxy-wc/webrev.02/index.html What about package-private in java.lang.reflect? It makes Proxy itself much easier to read. When we decide which way to go, I can remove the interface and

Re: RFR: 8001647: In-place methods on Collection/List

On Apr 19, 2013, at 2:29 PM, David Holmes wrote: > Hi Akhil, > > This is only a partial review so far. > > I have some issues with the ConcurrentModificationException strategy. > > Taking ArrayList, the basic idea is that you want to detect > modifications that are concurrent with iteration

Re: RFR: 8001647: In-place methods on Collection/List

On 19/04/2013 10:14 PM, Paul Sandoz wrote: On Apr 19, 2013, at 1:15 PM, Alan Bateman wrote: On 18/04/2013 19:49, Akhil Arora wrote: Looks like the stars are aligning on getting on this into TL... the refreshed webrev is - http://cr.openjdk.java.net/~akhil/8001647.8/webrev/ A minor comment

Re: RFR: 8001647: In-place methods on Collection/List

On 19/04/2013 13:14, Paul Sandoz wrote: : The function value could structurally modify the Vector instance. Ah yes, got it - thanks. For removeIf then I assume it isn't required in the pass over the removeSet. -Alan.

Re: RFR: 8001647: In-place methods on Collection/List

Hi Akhil, This is only a partial review so far. I have some issues with the ConcurrentModificationException strategy. Taking ArrayList, the basic idea is that you want to detect modifications that are concurrent with iteration - so the mutators up the modCount and the iterator functions check

Re: RFR: 8001647: In-place methods on Collection/List

On Apr 19, 2013, at 1:15 PM, Alan Bateman wrote: > On 18/04/2013 19:49, Akhil Arora wrote: >> Looks like the stars are aligning on getting on this into TL... the >> refreshed webrev is - >> >> http://cr.openjdk.java.net/~akhil/8001647.8/webrev/ >> > A minor comment on Collection.removeIf is "t

Re: RFR: 8001647: In-place methods on Collection/List

On 18/04/2013 19:49, Akhil Arora wrote: Looks like the stars are aligning on getting on this into TL... the refreshed webrev is - http://cr.openjdk.java.net/~akhil/8001647.8/webrev/ A minor comment on Collection.removeIf is "that satisifies the given predicate" might be better than "which matc

Re: RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

On 18/04/2013 16:12, Mike Duigou wrote: : @implSpec is very welcome, more reasons now with the addition of default methods. Clearly distinguishing normative from non-normative text is also been a long standing problem so having a tag to identify the non-normative text is very useful. I had t

Re: RFR 8012681: Commit for JDK-8012656 breaks tl build Was: can't build current jdk8/tl tip

Fix pushed, thanks for the reviews. Peter, I missed your patch. My fix should probably have been attributed to you, sorry! cheers /Joel On 04/19/2013 10:49 AM, Joel Borggrén-Franck wrote: Hi On 04/19/2013 09:30 AM, Alan Bateman wrote:> On 19/04/2013 08:08, Peter Levart wrote: >> Hi, >> >

hg: jdk8/tl/langtools: 8012681: Commit for JDK-8012656 breaks tl build

Changeset: a3655c24e232 Author:jfranck Date: 2013-04-19 11:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a3655c24e232 8012681: Commit for JDK-8012656 breaks tl build Reviewed-by: vromero, chegar, alanb ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java

hg: jdk8/tl/jdk: 8010505: HTTP DIGEST implementation incorrectly quotes header values, fails auth

Changeset: 90b03f9a2e77 Author:jzavgren Date: 2013-04-17 11:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90b03f9a2e77 8010505: HTTP DIGEST implementation incorrectly quotes header values, fails auth Summary: The extraneous quotes were removed. Reviewed-by: chegar ! src/

Re: RFR 8012681: Commit for JDK-8012656 breaks tl build Was: can't build current jdk8/tl tip

On 19/04/2013 09:49, Joel Borggrén-Franck wrote: See inline patch to fix this. Since TL isn't building I think we can review this on core-libs-dev although technically a compiler issue. With this fix langtools builds and all langtools tests passes. Looks fine, this is what Peter Levart sugge

Re: RFR JDK-8011426: java.util collection Spliterator implementations

On Apr 19, 2013, at 6:52 AM, Mike Duigou wrote: > I reversed this change : > > -final Collection c; > - > +final Collection c; > > > in Collections.UnmodifiableCollection instead opting or casts in the forEach > and spliterator Methods. > OK, i prefer the former but i ain't gonna a

Re: RFR 8012681: Commit for JDK-8012656 breaks tl build Was: can't build current jdk8/tl tip

Looks good to me Joel, -Chris. On 19/04/2013 09:49, Joel Borggrén-Franck wrote: Hi On 04/19/2013 09:30 AM, Alan Bateman wrote:> On 19/04/2013 08:08, Peter Levart wrote: >> Hi, >> >> I get the following compile-time error: >> >> /home/peter/work/hg/jdk8-tl/langtools/src/share/classes/com/s

RFR 8012681: Commit for JDK-8012656 breaks tl build Was: can't build current jdk8/tl tip

Hi On 04/19/2013 09:30 AM, Alan Bateman wrote:> On 19/04/2013 08:08, Peter Levart wrote: >> Hi, >> >> I get the following compile-time error: >> >> /home/peter/work/hg/jdk8-tl/langtools/src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java:264: >> error: illegal start of expression >>

hg: jdk8/tl/jdk: 8009636: JARSigner including TimeStamp PolicyID (TSAPolicyID) as defined in RFC3161

Changeset: 778b16225d85 Author:weijun Date: 2013-04-19 15:41 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/778b16225d85 8009636: JARSigner including TimeStamp PolicyID (TSAPolicyID) as defined in RFC3161 Reviewed-by: mullan ! src/share/classes/com/sun/jarsigner/ContentSign

Re: can't build current jdk8/tl tip

On 19/04/2013 08:08, Peter Levart wrote: Hi, I get the following compile-time error: /home/peter/work/hg/jdk8-tl/langtools/src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java:264: error: illegal start of expression if (qualifiedName == null) } I'm seeing the same thing, looks li

can't build current jdk8/tl tip

Hi, I get the following compile-time error: /home/peter/work/hg/jdk8-tl/langtools/src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java:264: error: illegal start of expression if (qualifiedName == null) } ^ ...isn't this '}' supposed to be '{' ?