Re: RFR: [corba] 4504275, 8011986 - two issues with generated code

2013-04-28 Thread Lance Andersen - Oracle
This is good to go. Also reviewed by Russ Gold from the Corba team Best Lance On Apr 12, 2013, at 6:48 AM, Dmeetry Degrave wrote: > > Hi all, > > I'm looking for a review for two ancient issues in idlj. > > First is an issue with uncompilable java code generated for unions with > boolean dis

Re: Review Request: BigInteger patch for efficient multiplication and division (#4837946)

2013-04-28 Thread Tim Buktu
Hi Brian, thanks for the update. > This patch differs from the code in https://github.com/tbuktu/bigint.git. > Notably I observed that Schonhage-Strassen multiplication and Barrett > division are not present. Is this intentional and if so why would that be? > Are the implementations of these ad

hg: jdk8/tl: 8011152: Precision problems on sflt builds

2013-04-28 Thread david . holmes
Changeset: 10775618db00 Author:aharlap Date: 2013-04-26 15:54 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/10775618db00 8011152: Precision problems on sflt builds Summary: Need to add global flag to the linker Reviewed-by: tbell, dholmes ! common/makefiles/NativeCompilation.gm

Re: 8013413: javadoc warnings

2013-04-28 Thread Chris Hegarty
On 28 Apr 2013, at 12:20, Lance Andersen wrote: > Looks fine +1 best to quash these whenever they're noticed. -Chris. > > -- > > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > lance.ander...@oracle.

Re: 8013413: javadoc warnings

2013-04-28 Thread Lance Andersen
Looks fine -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone On Apr 28, 2013, at 7:09 AM, Alan Bateman wrote: > > I need a reviewer to fix two trivial javadoc wa

8013413: javadoc warnings

2013-04-28 Thread Alan Bateman
I need a reviewer to fix two trivial javadoc warnings that sneaked in recently. -Alan. diff --git a/src/share/classes/java/nio/file/attribute/FileTime.java b/src/share/classes/java/nio/file/attribute/FileTime.java --- a/src/share/classes/java/nio/file/attribute/FileTime.java +++ b/src/share