On Apr 27, 2013, at 5:01 PM, Alan Bateman wrote:
> On 27/04/2013 00:08, Henry Jen wrote:
>> Hi,
>>
>> Please review webrev at
>>
>> http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/webrev
>>
>> The API doc in specdiff format is at
>>
>> http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/sp
Looks fine to me too.
-Chris.
On 27/04/2013 02:05, Mandy Chung wrote:
Looks good to me.
Mandy
On Apr 26, 2013, at 5:12 PM, Mike Duigou wrote:
Hello all;
A very small change to review.
http://cr.openjdk.java.net/~mduigou/JDK-7178639/0/webrev/
The change removes some erroneous documentati
On Apr 27, 2013, at 10:15 AM, Alan Bateman wrote:
> On 26/04/2013 22:59, Henry Jen wrote:
>> Hi,
>>
>> Please review webrev at
>>
>> http://cr.openjdk.java.net/~henryjen/ccc/8003258.1/webrev/
>>
>> It adds a method to BufferedReader.
>>
>> public Stream lines() {}
>>
>> A class java.io.Unc
On 29/04/2013 09:53, Paul Sandoz wrote:
Yes, since a stream of increasing int values, corresponding to indexes of set
bits, is created (the current index of a set bit is used to obtain the index of
the next set bit) i.e. it is doing:
for (int i = bs.nextSetBit(0); i>= 0; i = bs.nextSetBit(
On 04/27/2013 11:37 AM, Alan Bateman wrote:
> On 27/04/2013 00:13, Mandy Chung wrote:
>> Peter,
>>
>> I have pushed the changeset:
>>
>> Changeset: 5e7ae178b24d
>> Author:plevart
>> Date: 2013-04-26 16:09 -0700
>> URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e7ae178b24d
>>
>> Mandy
> Th
Changeset: 138f767b8eff
Author:dholmes
Date: 2013-04-29 07:40 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/138f767b8eff
8010280: jvm.cfg needs updating for non-server builds
Summary: Generate jvm.cfg based on chosen VMs for non-"standard" builds and
remove legacy entries f
Hi,
Please review:
http://cr.openjdk.java.net/~psandoz/lambda/jdk-8012646/webrev/
The stream-based test currently resides in the lambda repo and will flow into
tl with other stream-based tests:
http://hg.openjdk.java.net/lambda/lambda/jdk/file/d5456784b348/test-ng/tests/org/openjdk/tests/
Changeset: 8f0a461776a9
Author:dmeetry
Date: 2013-04-29 16:44 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/8f0a461776a9
4504275: CORBA boolean type unions do not generate compilable code from idlj
Summary: JLS doesn't allow boolean type in switch statement, hence substitu
Changeset: 846aaf02e516
Author:dmeetry
Date: 2013-04-29 16:51 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/846aaf02e516
8011986: [corba] idlj generates read/write union helper methods that throw
wrong exception in some cases
Reviewed-by: lancea
! src/share/classes/com/s
Alan,
The XPathException class doesn't have any fields only methods (it had a
'cause' method, but it was deleted in suggested fix). And, as I can see,
there is no need to control what information is saved or to append
additional information to the serialization stream.
So, I think the readObje
On 29/04/2013 14:45, Aleksej Efimov wrote:
Alan,
The XPathException class doesn't have any fields only methods (it had
a 'cause' method, but it was deleted in suggested fix). And, as I can
see, there is no need to control what information is saved or to
append additional information to the ser
Hi Martin,
Thanks for the comment, I looked at this when I first saw a similar
comment in the code, and didn't change it because the charCount() is a
small operation. The code is just,
> codePoint >= MIN_SUPPLEMENTARY_CODE_POINT ? 2 : 1;
Another reason I didn't change it is to avoid repeated cod
On 04/26/2013 06:21 AM, Alan Bateman wrote:
> On 25/04/2013 21:25, Henry Jen wrote:
>> Hi,
>>
>> Please review two default methods add to CharSequence returns IntStream
>> of char value or code point value.
>>
>> http://cr.openjdk.java.net/~henryjen/tl/8012665.0/webrev/
>>
>> The synchronization te
Hi Daniel,
Thanks for the detailed explanation! The fix looks good.
Sorry for the delay.
Regards,
Joe
On 4/15/2013 7:09 AM, Daniel Fuchs wrote:
Hi,
This a fix for:
JDK-8008738 - Issue in
com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK
tests to fail intermittently.
Changeset: 9d324d667bb3
Author:jzavgren
Date: 2013-04-29 08:17 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d324d667bb3
8012108: Memory leak in jdk/src/windows/native/java/net/NetworkInterface_winXP.c
Summary: Modified code to fix this leak and then proactively fixed impro
Hi Tim,
On Apr 28, 2013, at 4:31 PM, Tim Buktu wrote:
> thanks for the update.
You're welcome.
>> This patch differs from the code inhttps://github.com/tbuktu/bigint.git.
>> Notably I observed that Schonhage-Strassen multiplication and Barrett
>> division are not present. Is this intentional
On 04/27/2013 08:01 AM, Alan Bateman wrote:
> On 27/04/2013 00:08, Henry Jen wrote:
>> Hi,
>>
>> Please review webrev at
>>
>> http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/webrev
>>
>> The API doc in specdiff format is at
>>
>> http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/specdiff
>>
>>
Sure, micro-optimization doesn't necessarily buy much, and might be useless
with a sufficiently smart JIT and micro-benchmarking is known to be
difficult and surprising. Nevertheless, we who have been writing
performance-critical code in core libraries have developed a style that
hotspot is known
Note also that I'm making vaguely related changes to CharSequence and
Buffer implementations.
No reason not to at least get this code feature-complete now and optimize
later.
Hi,
The regex named capturing group support was added into jdk7 [1].
Matcher.group(gname) is the only direct access method we added back then
to access the matched result. The proposed change here is to add a pair of
accessing/convenient method Matcher.start/end(gname) to access the start/end
off
Hi,
Please review this fix which will enable profiles and embedded distros to
eliminate the unpack200 binaries saving space, all this does is switch
to the java implementation if the native one cannot be found.
http://cr.openjdk.java.net/~ksrini/8009389/webrev.0/
Thanks
Kumar
The restyling changes obfustucated things a bit but I didn't see anything of
concern in casual review.
I had hoped to see the updated SmallSet that didn't try to implement Iterator
directly.
It looks the SmallSet needs more discussion.. barring that anyone else
have any other
concerns with
Hi,
please find below an updated webrev incorporating the feedback from
webrev.01 (thanks for the replies)
http://cr.openjdk.java.net/~msheppar/8007799/webrev.02/
regards
Mark
On Apr 29, 2013, at 3:05 PM, Kumar Srinivasan
wrote:
> Please review this fix which will enable profiles and embedded distros to
> eliminate the unpack200 binaries saving space, all this does is switch
> to the java implementation if the native one cannot be found.
>
> http://cr.openjdk.java.ne
Looks fine.
-Sherman
On 04/29/2013 04:04 PM, Mark Sheppard wrote:
Hi,
please find below an updated webrev incorporating the feedback from
webrev.01 (thanks for the replies)
http://cr.openjdk.java.net/~msheppar/8007799/webrev.02/
regards
Mark
On Apr 29, 2013, at 11:00 AM, Brian Burkhalter wrote:
> How much additional code is there for these two algorithms?
To answer my own question, there are apparently about 1,000 more lines.
> Unless it is some daunting amount, then if you think that the code is of
> sufficient quality, my opinion
As always for changes to files maintained in jsr166 CVS, we'd like changes
to flow through jsr166 CVS into openjdk proper.
In this case, there are some issues with missing exception specs in
implementing classes. I'll come up with a diff.
Martin
On Fri, Apr 26, 2013 at 5:12 PM, Mike Duigou wr
OK, I will wait on that and hopefully Chris can pick it up on the next jsr166
sync.
Mike
On Apr 29 2013, at 16:43 , Martin Buchholz wrote:
> As always for changes to files maintained in jsr166 CVS, we'd like changes to
> flow through jsr166 CVS into openjdk proper.
>
> In this case, there are
Below is my proposed alternative fix, that also adds some missing @throws,
reuses some existing wording, and makes small improvements to existing
@throws specs (maintaining these specs is very tedious...)
Index: src/main/java/util/Deque.java
===
Looks reasonable to me. Could BlockingDeque::push() just use {@inheritDoc} for
main body doc?
Mike
On Apr 29 2013, at 18:05 , Martin Buchholz wrote:
> Below is my proposed alternative fix, that also adds some missing @throws,
> reuses some existing wording, and makes small improvements to exi
On Mon, Apr 29, 2013 at 6:14 PM, Mike Duigou wrote:
> Looks reasonable to me. Could BlockingDeque::push() just use {@inheritDoc}
> for main body doc?
>
>
Perhaps. But as I wrote many years ago in the same source file,
/*
* We have "diamond" multiple interface inheritance here, and that
Hello all;
This is a non-integration code review. I am picking this patch up after
ignoring it for most of the last year. I've recently expanded the regression
tests to, I believe, handle almost all of the new code paths added by this
patch.
http://cr.openjdk.java.net/~mduigou/JDK-7129185/0/we
Hello All;
This is a review for three changes to the J2SE Netbeans project. If necessary I
can break this up into three separate patches but I would rather not if
possible.
http://cr.openjdk.java.net/~mduigou/JDK-8011814/0/webrev/
8011814: Add testng.jar to Netbeans projects test compile cla
Hello all;
This change originated as part of JDK-8006627 (which was also previously split
into JDK-8007398 as well). It adds an internal mechanism for performance
sensitive usages to create a string from a provided character array without
copying that array. This saves both in the allocation (a
test/sun/reflect/CallerSensitive/MethodFinder.java is a useful utility
class that jdeps or other tool can take advantage of. This fix moves
MethodFinder.java to com.sun.tools.classfile and generalize it to find
field, method, and interface method references.
Webrev at:
http://cr.openjdk.jav
Changeset: 7857129859bd
Author:briangoetz
Date: 2013-04-20 18:53 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7857129859bd
8012650: Arrays streams methods
8011918: java.util.stream.Streams
Reviewed-by: alanb, mduigou, darcy, henryjen
Contributed-by: brian.go...@oracle.com,
Hi,
Adapt feedback from the first round, updated webrev and specdiff can be
found at:
http://cr.openjdk.java.net/~henryjen/ccc/8012645.1/webrev
http://cr.openjdk.java.net/~henryjen/ccc/8012645.1/specdiff
Summary of change,
1. Javadoc change for ZipFile::stream
2. A inner class implements Enumera
Sorry this slipped through the cracks.
Looks good to me. (Don't know if you already pushed it :) )
David
On 25/04/2013 5:16 PM, Joe Darcy wrote:
Hello,
Responding to David's comment and some comments from Alan off-list, here
is a variant which doesn't use suppressed exceptions in initCause, b
Looks good. As a very small clarification, I might throw in a comma after
"created".
On Mon, Apr 29, 2013 at 9:30 PM, Mike Duigou wrote:
> Hello all;
>
> This change originated as part of JDK-8006627 (which was also previously
> split into JDK-8007398 as well). It adds an internal mechanism fo
39 matches
Mail list logo
