On 05/29/2013 01:20 PM, Aleksey Shipilev wrote:
In general, I think you
>*DO* want the subclass fields to be potentially in the same location as
>the superclass padding fields.
>A >: B
>A layout:
>B layout:
>
>which is not asking too much of a jit.
>I believe it
On May 31, 2013, at 1:56 AM, Mike Duigou wrote:
> Hello all;
>
> A very small review for a change which was fixed in the lambda repo
> (JDK-8012691) but escaped into TL:
>
> http://cr.openjdk.java.net/~mduigou/JDK-8015686/0/webrev/
>
+1 (while lacking reviewer mojo)
Paul.
Changeset: b47044426bcd
Author:psandoz
Date: 2013-05-31 09:58 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b47044426bcd
8014732: Minor spec issue: java.util.Spliterator.getExactSizeIfKnown
Summary: A minor documentation issue (not a spec issue).
Reviewed-by: chegar, dl
! s
On 31/05/2013 5:50 PM, Paul Sandoz wrote:
On May 31, 2013, at 1:56 AM, Mike Duigou wrote:
Hello all;
A very small review for a change which was fixed in the lambda repo
(JDK-8012691) but escaped into TL:
http://cr.openjdk.java.net/~mduigou/JDK-8015686/0/webrev/
+1 (while lacking reviewe
On 05/30/2013 06:30 PM, huizhe wang wrote:
On 5/30/2013 9:22 AM, Chris Hegarty wrote:
Looks fine to me Daniel,
I see you have three copies of Objects.java, is it possible to put it
in a common place accessible to all? Or maybe this causes other issues.
JAXP consists of multiple components. T
Changeset: dcf42861b5b1
Author:chegar
Date: 2013-05-31 09:30 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dcf42861b5b1
7107883: getNetworkPrefixLength() does not return correct prefix length
Reviewed-by: alanb, michaelm
! src/solaris/native/java/net/NetworkInterface.c
! te
Changeset: 9f11c7676cd5
Author:vromero
Date: 2013-05-31 10:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f11c7676cd5
7179353: try-with-resources fails to compile with generic exception parameters
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/com
Hi,
Please review a fix to the key/value/entry spliterators of HashMap/WeakHashMap
when mixed traversal is performed:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8013649/webrev/
A call to forEachRemaning does not correctly check and set the state to
detect/signal all elements have been traver
On 05/30/13 14:18, Mike Duigou wrote:
- I don't see the advantage to exposing the ConcurrentHashMap.KeySetView type
particularly for newKeySet(). Why not return Set? The additional methods
don't seem to offer much that's desirable for the newKeySet() case.
Since we don't have a ConcurrentSet in
Hi,
Please review this JavaDoc fix to j.u.StringJoiner to update and move the
examples to an api note.
--
This has already been fixed in the lambda repo:
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/3a44a6038054
Paul.
# HG changeset patch
# User psandoz
# Date 1369996938 -7200
# Node ID
On 31/05/2013 11:49, Paul Sandoz wrote:
Hi,
Please review this JavaDoc fix to j.u.StringJoiner to update and move the
examples to an api note.
--
This looks okay to me.
The only thing is that removing @author can sometimes to a contentious
topic. Given that StringJoiner has been significant
Changeset: 243cd682c47b
Author:alanb
Date: 2013-05-31 12:17 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/243cd682c47b
8014854: (bf) CharBuffer.chars too slow with default implementation
Reviewed-by: erikj, briangoetz, henryjen, psandoz, mduigou
! makefiles/CompileJavaClass
On May 31, 2013, at 1:14 PM, Alan Bateman wrote:
> On 31/05/2013 11:49, Paul Sandoz wrote:
>> Hi,
>>
>> Please review this JavaDoc fix to j.u.StringJoiner to update and move the
>> examples to an api note.
>>
>> --
> This looks okay to me.
>
Thanks.
> The only thing is that removing @auth
On 31/05/2013 09:15, David Holmes wrote:
On 31/05/2013 5:50 PM, Paul Sandoz wrote:
On May 31, 2013, at 1:56 AM, Mike Duigou wrote:
Hello all;
A very small review for a change which was fixed in the lambda repo
(JDK-8012691) but escaped into TL:
http://cr.openjdk.java.net/~mduigou/JDK-801
On 30/05/2013 17:52, huizhe wang wrote:
Hi Daniel,
This looks good. Thanks again for the extra effort to keep JDK7 updated.
-Joe
This looks okay to me too.
BTW: One suggestios for these backports that require small adjustments
to what is in jdk8, is to include jdk7u-dev on the review request
On 31/05/2013 12:26, Paul Sandoz wrote:
:
My understanding is the @author tag is no longer something we should be using
for new JDK code (and to be egalitarian about it perhaps we should strip out
@author tags from all the code!)
I vaguely remember there was discussion on this topic a few year
Obviously, we can't throw the ISE - it's not described in docs for
readObject() method.
Exceptions suggested by Jason have the following descriptions:
InvalidClassException: Something is wrong with a class used by
serialization.
StreamCorruptedException: Control information in the stream
Joe,
I'll move the tests to jdk/test/javax/xml/jaxp/XPath/ 8009579 in next
version of webrev for JDK8. For JDK7 the tests will be in the same
folder after Daniel's change.
Correct, I'm using the backport ID only for review in this alias, for
commits and test header will use the main bug ID. Tha
On 31/05/2013 03:17, David Chase wrote:
Not sure where this stands, given that Vladimir K has a grand plan to turn the
assembly language into an intrinsic (this is not how I would normally approach
it) but there is another webrev with the unnecessary import removed:
http://cr.openjdk.java.net/
On 29/05/2013 21:47, Brent Christian wrote:
Updated webrev is here:
http://cr.openjdk.java.net/~bchristi/8005698/webrev.03/
It contains the following changes from Mike's review:
* HashMap.comparableClassFor(): corrected reference to TreeBin docs
* fixed @run tag in InPlaceOpsCollisions.java
*
On 31/05/2013 14:39, Aleksej Efimov wrote:
Obviously, we can't throw the ISE - it's not described in docs for
readObject() method.
Exceptions suggested by Jason have the following descriptions:
InvalidClassException: Something is wrong with a class used by
serialization.
StreamCorrupted
On 2013-05-31, at 9:52 AM, Alan Bateman wrote:
> On 31/05/2013 03:17, David Chase wrote:
>> Not sure where this stands, given that Vladimir K has a grand plan to turn
>> the assembly language into an intrinsic (this is not how I would normally
>> approach it) but there is another webrev with t
Thanks Mike!
The updated webrev is here:
http://cr.openjdk.java.net/~shade/8014966/webrev.04/
I think the changes we are doing now are converging. I would like to
hear formal OKs from Martin B, Mike D, David H, so we can proceed with
pushing this. Last-minute grammar corrections welcome!
-Alek
The source changes look fine to me Paul.
-Chris.
On 05/31/2013 11:29 AM, Paul Sandoz wrote:
Hi,
Please review a fix to the key/value/entry spliterators of HashMap/WeakHashMap
when mixed traversal is performed:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8013649/webrev/
A call to forEachRe
Hi Peter,
On 05/31/2013 11:33 AM, Peter Levart wrote:
> Implementation issues aside, the name of the tag specified in the
> @Contended annotation could be evaluated in the context of the fully
> qualified class name in which the annotation is used. For example:
I thought about implying the full
Hi, Alan.
That's what I remember too. There were just too many objections to completely
removing all @author tags.
iris
-Original Message-
From: Alan Bateman
Sent: Friday, May 31, 2013 5:57 AM
To: Paul Sandoz
Cc: core-libs-dev@openjdk.java.net Libs
Subject: Re: RFR 8014383: StringJoin
On 5/31/13 7:42 AM, David Chase wrote:
On 2013-05-31, at 9:52 AM, Alan Bateman wrote:
On 31/05/2013 03:17, David Chase wrote:
Not sure where this stands, given that Vladimir K has a grand plan to turn the
assembly language into an intrinsic (this is not how I would normally approach
it) bu
On 05/29/2013 04:54 AM, Alan Bateman wrote:
On 28/05/2013 19:39, Dan Xu wrote:
Hi All,
When File.createTempFile() is called with some special parameters, it
runs into infiniteloop and hangs. It is because it does not always
mean a file exists when the method, createFileExclusively(), returns
On 5/31/13 7:10 AM, Alan Bateman wrote:
>
I've read through the latest webrev, overall very good work.
I had to read splitTreeBin a few times to convince myself as to how the
keys re-hash. I wonder if would be helpful to beef up the comment on
this method.
I think that's a good idea:
--- 342,
On 2013-05-31, at 1:43 PM, Vladimir Kozlov wrote:
> On 5/31/13 7:42 AM, David Chase wrote:
>>
>> The current plumbing for the XX option does affect code flow in the compiled
>> C; that was pretty much the entire point of it. Vladimir has a plan, I
>> think his attitude is that if convert thi
Changeset: f522bbdf2859
Author:dxu
Date: 2013-05-31 13:34 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f522bbdf2859
8015628: Test Failure in closed/java/io/pathNames/GeneralSolaris.java
Reviewed-by: alanb
! test/java/io/pathNames/General.java
! test/java/io/pathNames/Gener
Changeset: 11cdcf87ad5d
Author:jzavgren
Date: 2013-05-31 15:23 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11cdcf87ad5d
8008972: Memory leak: Java_java_net_TwoStacksPlainDatagramSocketImpl_receive0
[parfait]
Summary: Modified the code so that "jumbo frames" are truncated
Changeset: fc0b3e86fdcf
Author:mduigou
Date: 2013-05-31 11:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc0b3e86fdcf
8015686: {Int|Long}SummaryStatistics toString() throws
IllegalFormatConversionException
Reviewed-by: dholmes, alanb, psandoz
! src/share/classes/java/ut
33 matches
Mail list logo
