On 06/27/2013 08:37 AM, Peter Levart wrote:
Hi,
This version seems correct. Maybe just replace double volatile read at
length re-check with a single one:
private static BigInteger getRadixConversionCache(int radix, int
exponent) {
BigInteger[] cacheLine = powerCache[radix]; //
Hi Chris,
Thanks for the information! I'll give it a try.
On 6/26/2013 6:18 AM, Chris Hegarty wrote:
The streams package recently added tests for exercising
package-private implementation.
Top level dir contain the TEST.properties to add to the bootclasspath:
Do you mean TEST.properties ne
Hi,
There are some isEmpty() check added into get/remove methods since
8011200 to return directly if HashMap is empty. However isEmpty is a
non-final public method which can be overridden by subclass. If the
subclass defines isEmpty differently from HashMap, it would cause
problem while getti
Hi,
Expanding on the idea of building single growing linked list of values
and treating the array just as index for quick access which can be
re-created at any time without synchronization or volatile publication,
here's the attempt:
private static class Node {
final BigInteger
Changeset: a47e28759666
Author:vromero
Date: 2013-06-27 09:51 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a47e28759666
7066788: javah again accepts -old option (ineffectively) which was removed in
1.5.
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javah/JavahT
Changeset: c30beaf3c42a
Author:jlaskey
Date: 2013-06-21 14:34 -0300
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c30beaf3c42a
8010732: BigDecimal, BigInteger and Long handling in nashorn
Reviewed-by: sundar
Contributed-by: james.las...@oracle.com
+ test/script/basic/JDK-8010
Changeset: 8e3d391c88c6
Author:vromero
Date: 2013-06-27 09:54 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8e3d391c88c6
8017609: javac, ClassFile.read(Path) should be ClassFile.read(Path,
Attribute.Factory)
Reviewed-by: jjg
! src/share/classes/com/sun/tools/classfil
Changeset: dcc6a52bf363
Author:erikj
Date: 2013-06-27 10:35 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dcc6a52bf363
8014513: Sjavac doesn't detect 32-bit jvm properly
Reviewed-by: jjg
! src/share/classes/com/sun/tools/sjavac/CompileJavaPackages.java
On 27/06/2013 07:13, Alan Bateman wrote:
On 27/06/2013 05:37, Brad Wetmore wrote:
Brent/Alan/Mike,
Hashing.java was removed from the JDK workspace, but was not removed
from the old java/java/FILES_java.gmk. Things that still depend on the
old build (JCE/deploy) are currently broken.
http://cr.
Sorry for high frequency of messages.
This one is even better. powerCacheIndex need not be holding Nodes, but
BigIntegers instead. So no indirection on fast-path:
private static class Node {
final BigInteger value;
Node next;
Node(BigInteger value) { this.value = v
Hi,
Please review a fix for a regression with using Stream.substream for an ORDERED
but not SUBSIZED spliterator that does not split.
This is based off:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8012987-slice/webrev/
which is blocked waiting for the Comparator API webrev to go into tl, whic
Changeset: 370e7beff8a0
Author:wetmore
Date: 2013-06-27 10:19 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/370e7beff8a0
8019227: JDK-8010325 broke the old build
Reviewed-by: alanb, chegar
! make/java/java/FILES_java.gmk
Changeset: 4e69a7dfbeac
Author:chegar
Date:
Dear members,
I have a problem within an external library using one JVM Shutdown hook to
perform resource cleanup (socket, lock file deletion ...) that seems buggy
in java web start environment: sometimes the JVM reports an
IllegalStateException happenning during that shutdown hook.
This library
On 27/06/2013 08:50, huizhe wang wrote:
Hi Chris,
Thanks for the information! I'll give it a try.
On 6/26/2013 6:18 AM, Chris Hegarty wrote:
The streams package recently added tests for exercising
package-private implementation.
Top level dir contain the TEST.properties to add to the bootclas
On 06/27/2013 10:37 AM, Peter Levart wrote:
> Hi,
>
> This version seems correct. Maybe just replace double volatile read at
> length re-check with a single one:
>
>
> private static BigInteger getRadixConversionCache(int radix, int
> exponent) {
> BigInteger[] cacheLine = powerCache
Changeset: d137ce373c4c
Author:vromero
Date: 2013-06-27 16:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d137ce373c4c
7008643: inlined finally clauses confuse debuggers
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/jvm/Gen.java
+ test/tools/javac/T700864
Changeset: e42c27026290
Author:vromero
Date: 2013-06-27 16:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e42c27026290
8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes )
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/comp/Attr.java
Hi,
This webrev contains updates of java.util.concurrent collections from 166:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8011427-concur-splits/webrev/
More specifically:
- spliterator implementations (which are tested by the existing spltierator
tests).
- various doc updates.
- and other
I forgot to mention this patch is based off the comparator's patch which is
required by updates to ConcurrentSkipListMap.java.
Paul.
On Jun 27, 2013, at 5:33 PM, Paul Sandoz wrote:
> Hi,
>
> This webrev contains updates of java.util.concurrent collections from 166:
>
> http://cr.openjdk.jav
Changeset: 26437287529d
Author:janvalenta
Date: 2013-06-27 17:47 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/26437287529d
8015720: since tag isn't copied while generating JavaFX documentation
Reviewed-by: jjg
!
src/share/classes/com/sun/tools/doclets/internal/toolk
Thanks Chris for the instructions!
Joe
On 6/27/2013 3:34 AM, Chris Hegarty wrote:
On 27/06/2013 08:50, huizhe wang wrote:
Hi Chris,
Thanks for the information! I'll give it a try.
On 6/26/2013 6:18 AM, Chris Hegarty wrote:
The streams package recently added tests for exercising
package-priv
Hi all,
Here's a simple webrev to add exception chaining (constructor overloads with
the 'cause' parameter) to some internal exception types used in RMI.
We've been getting some test failures that go through this area and I suspect
that this code is discarding some diagnostic information.
h
Looks fine Stuart; cheers,
-Joe
On 06/27/2013 09:21 AM, Stuart Marks wrote:
Hi all,
Here's a simple webrev to add exception chaining (constructor
overloads with the 'cause' parameter) to some internal exception types
used in RMI.
We've been getting some test failures that go through this a
If this is to be undone after the correct zip fix, why not add the
@ignore for now ?
and enable this when 8015666 is fixed correctly.
Kumar
This is fine to be a workaround for the test case for now. It probably
will need to be
undo-ed after the propose change for #8015666 get integrated.
htt
Hi all,
Need a reviewer for 8017471 which addresses the JDBC doclint errors
The webrev can be found at http://cr.openjdk.java.net/~lancea/8017471/webrev.00/
please note that for the WebRowset changes, you will need to use the udiff vs
the sdiff formant as webrev generates errors due to the numb
Hi Sherman,
I started looking at this, my initial comment, the Unpacker.unpack
does not close its output and we allow multiple pack files to be
concatenated,
I am assuming out.finish() will allow further jar files to be appended ?
or would this cause a problem ?
Kumar
Hi,
The zip time rel
Yes, I think that this is the correct approach.
-- Jon
On 06/27/2013 09:43 AM, Kumar Srinivasan wrote:
If this is to be undone after the correct zip fix, why not add the
@ignore for now ?
and enable this when 8015666 is fixed correctly.
Kumar
This is fine to be a workaround for the test cas
On 06/27/2013 10:04 AM, Kumar Srinivasan wrote:
Hi Sherman,
I started looking at this, my initial comment, the Unpacker.unpack
does not close its output and we allow multiple pack files to be concatenated,
I am assuming out.finish() will allow further jar files to be appended ?
or would this c
Hi Lance,
I looked through the patch and it looks fine; thanks,
-Joe
On 06/27/2013 09:56 AM, Lance Andersen wrote:
Hi all,
Need a reviewer for 8017471 which addresses the JDBC doclint errors
The webrev can be found at http://cr.openjdk.java.net/~lancea/8017471/webrev.00/
please note that fo
+1
On Jun 27, 2013, at 1:59 PM, Joe Darcy wrote:
> Hello,
>
> Please review the patch below which resolves doclint warnings in
> java.util.prefs.
>
> Thanks,
>
> -Joe
>
> diff -r 4e69a7dfbeac
> src/share/classes/java/util/prefs/AbstractPreferences.java
> --- a/src/share/classes/java/util/pr
Changeset: 1c31082f0a51
Author:darcy
Date: 2013-06-27 11:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c31082f0a51
8019304: Fix doclint issues in java.util.prefs
Reviewed-by: lancea
! src/share/classes/java/util/prefs/AbstractPreferences.java
! src/share/classes/java/ut
Hello,
Please review the patch below which resolves doclint warnings in
java.util.prefs.
Thanks,
-Joe
diff -r 4e69a7dfbeac
src/share/classes/java/util/prefs/AbstractPreferences.java
--- a/src/share/classes/java/util/prefs/AbstractPreferences.java Thu
Jun 27 10:21:22 2013 +0100
+++ b/src/s
On 27/06/2013 18:59, Joe Darcy wrote:
Hello,
Please review the patch below which resolves doclint warnings in
java.util.prefs.
Thanks,
-Joe
This looks okay to me although you might want to put in a blank line
before the @param list so that is consistent with the other prefs classes.
-Alan
Accidentally dropped core-libs-dev from the reply.
On 06/27/13 13:31, Eric McCorkle wrote:
> I could easily replace the patch I have now with one that just marks the
> test @ignore and commit it. Do we want to go ahead and approve that?
>
> On 06/27/13 13:12, Jonathan Gibbons wrote:
>> Yes, I th
On Jun 26, 2013, at 10:55 PM, David DeHaven wrote:
>>> Specifically, I was referred to how C handles "%0.4f\n".
>
> No width, decimal truncated (rounded? floored? I forgot which it is) to four
> digits.
>
> -DrD-
>
>>> printf("%0.4f\n", 56789.456789F);
> ...
>>> 56789.4570
>> ^ ^ ^ ^ ^ ^ ^
On Jun 27, 2013, at 4:18 AM, Aleksey Shipilev wrote:
> On 06/27/2013 10:37 AM, Peter Levart wrote:
>> Hi,
>>
>> This version seems correct. Maybe just replace double volatile read at
>> length re-check with a single one:
>>
>>private static BigInteger getRadixConversionCache(int radix, int
>
Changeset: 065f8cb7bd89
Author:darcy
Date: 2013-06-27 11:46 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/065f8cb7bd89
8019308: Add descriptions of Java SE 7 and 8 language changes to SourceVersion
Reviewed-by: jjg
! src/share/classes/javax/lang/model/SourceVersion.ja
Hello,
Please review the patch below which resolves doclint warnings in
java.util.logging.
Thanks,
-Joe
diff -r 1c31082f0a51 src/share/classes/java/util/logging/Handler.java
--- a/src/share/classes/java/util/logging/Handler.javaThu Jun 27
11:06:46 2013 -0700
+++ b/src/share/classes/java
Changeset: b9ba04dc210f
Author:lancea
Date: 2013-06-27 15:07 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b9ba04dc210f
8017471: Fix JDBC -Xdoclint public errors
Reviewed-by: darcy
! src/share/classes/java/sql/Blob.java
! src/share/classes/java/sql/CallableStatement.java
!
The old build has not produced usable bits for several months, it may
not have been failing but if you look closely (or run the tests) then
you'll see that there are several things missing. On build-dev then
you'll probably have seen a mail or two from me where I was trying to
encourage the buil
+1
On Jun 27, 2013, at 2:58 PM, Joe Darcy wrote:
> Hello,
>
> Please review the patch below which resolves doclint warnings in
> java.util.logging.
>
> Thanks,
>
> -Joe
>
> diff -r 1c31082f0a51 src/share/classes/java/util/logging/Handler.java
> --- a/src/share/classes/java/util/logging/Handle
Changeset: b8f16cb2d95b
Author:darcy
Date: 2013-06-27 12:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b8f16cb2d95b
8019315: Fix doclint issues in java.util.logging
Reviewed-by: lancea
! src/share/classes/java/util/logging/Handler.java
! src/share/classes/java/util/loggi
Changeset: 97e798c06804
Author:ksrini
Date: 2013-06-27 12:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97e798c06804
7080001: Need to bump version numbers in build.properties for 8
Reviewed-by: jjg
! make/build.properties
Hello,
Please review the next patch in a series of patches to resolve doclint
warnings in the JDK; this time in javax.script.
Thanks,
-Joe
diff -r b8f16cb2d95b src/share/classes/javax/script/Invocable.java
--- a/src/share/classes/javax/script/Invocable.javaThu Jun 27
12:24:26 2013 -0700
looks fine joe
On Jun 27, 2013, at 3:47 PM, Joe Darcy wrote:
> Hello,
>
> Please review the next patch in a series of patches to resolve doclint
> warnings in the JDK; this time in javax.script.
>
> Thanks,
>
> -Joe
>
> diff -r b8f16cb2d95b src/share/classes/javax/script/Invocable.java
> ---
Changeset: 6729f7ef94cd
Author:smarks
Date: 2013-06-27 13:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6729f7ef94cd
8019224: add exception chaining to RMI CGIHandler
Reviewed-by: darcy
! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java
On 06/27/2013 08:49 PM, joe.da...@oracle.com wrote:
Changeset: 065f8cb7bd89
Author:darcy
Date: 2013-06-27 11:46 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/065f8cb7bd89
8019308: Add descriptions of Java SE 7 and 8 language changes to SourceVersion
Reviewed-by: jjg
Changeset: 1099fe14fb65
Author:darcy
Date: 2013-06-27 14:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1099fe14fb65
8019320: Fix doclint issues in javax.script
Reviewed-by: lancea
! src/share/classes/javax/script/Invocable.java
! src/share/classes/javax/script/ScriptCont
On 06/27/2013 10:02 AM, Shi Jun Zhang wrote:
Hi,
There are some isEmpty() check added into get/remove methods since
8011200 to return directly if HashMap is empty. However isEmpty is a
non-final public method which can be overridden by subclass. If the
subclass defines isEmpty differently fro
Ok. I will put it through shortly.
On 06/27/13 14:18, Jonathan Gibbons wrote:
> Yes,
>
> Per the latest conventions, the line should be of the form
>
> @ignore BUGID: synopsis
>
> where BUGID is the number for a currently open issue that justifies this
> test being ignored.
>
> -- Jon
>
> O
Changeset: e34e3ddb3cd8
Author:naoto
Date: 2013-06-27 14:40 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e34e3ddb3cd8
6609431: (rb) ResourceBundle.getString() returns incorrect value
Reviewed-by: okutsu, sherman
! src/share/classes/java/util/Properties.java
+ test/java/uti
Changeset: 5c548a8542b8
Author:emc
Date: 2013-06-27 17:45 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5c548a8542b8
8013357: javac accepts erroneous binary comparison operations
Summary: javac does not report type errors on illegal Object == primitive
comparisons
Rev
Hi John,
Please review the changes for
8019357: Fix doclint warnings in java.lang.invoke
http://cr.openjdk.java.net/~darcy/8019357.0/
Thanks,
-Joe
On Jun 27, 2013, at 6:43 PM, Joe Darcy wrote:
> Hi John,
>
> Please review the changes for
>
>8019357: Fix doclint warnings in java.lang.invoke
>http://cr.openjdk.java.net/~darcy/8019357.0/
>
I read it and it is good. Thanks for doing this. — John
Changeset: 29136bc5
Author:darcy
Date: 2013-06-27 19:02 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/29136bc5
8019357: Fix doclint warnings in java.lang.invoke
Reviewed-by: jrose
! src/share/classes/java/lang/invoke/LambdaConversionException.java
! src/share/classe
Changeset: 60d1994f63f7
Author:xuelei
Date: 2013-06-27 19:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60d1994f63f7
8019359: To comment why not use no_renegotiation to reject client initiated
renegotiation
Reviewed-by: wetmore
! src/share/classes/sun/security/ssl/Serve
56 matches
Mail list logo
