Re: RFR: 8019381: HashMap.isEmpty is non-final, potential issues for get/remove

2013-07-02 Thread Shi Jun Zhang
On 7/1/2013 11:49 PM, Chris Hegarty wrote: On 1 Jul 2013, at 17:22, Remi Forax wrote: On 07/01/2013 09:43 AM, Shi Jun Zhang wrote: On 6/29/2013 12:05 AM, Shi Jun Zhang wrote: On 6/28/2013 9:02 PM, Alan Bateman wrote: On 27/06/2013 22:13, Remi Forax wrote: On 06/27/2013 10:02 AM, Shi Jun Zh

Re: RFC 6910473: BigInteger negative bit length, value range, and future prospects

2013-07-02 Thread Joseph Darcy
Hello, A quick note on this issue, before the recent work to use better algorithms for BigInteger arithmetic operation, working with huge numbers was impractical and thus BigInteger.bitLength misbehavior was mostly an academic concern. With the better algorithms, exposure to these large value

Re: Code update for 8014319: Faster division of large integers

2013-07-02 Thread Brian Burkhalter
Hi Tim, On Jul 2, 2013, at 3:31 PM, Tim Buktu wrote: >> That would be helpful if you don't mind. Note that this changeset >> modifying BigInteger >> >> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8cf01de8fa8 >> >> was just applied today. > The latest files for phase 3 are up at > > https://gis

hg: jdk8/tl/jdk: 8007035: deprecate public void SecurityManager.checkMemberAccess(Class clazz, int which)

2013-07-02 Thread mandy . chung
Changeset: cf7202b32a34 Author:mchung Date: 2013-07-02 15:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf7202b32a34 8007035: deprecate public void SecurityManager.checkMemberAccess(Class clazz, int which) Reviewed-by: jrose, alanb, dfuchs ! src/share/classes/java/lang/

Re: Code update for 8014319: Faster division of large integers

2013-07-02 Thread Tim Buktu
Hi Brian, > > That would be helpful if you don't mind. Note that this changeset > modifying BigInteger > > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8cf01de8fa8 > > was just applied today. The latest files for phase 3 are up at https://gist.github.com/tbuktu/1576025/raw/f93093a412eac86d8d81e03b

hg: jdk8/tl/langtools: 6326693: variable x might already have been assigned, when assignment is in catch block

2013-07-02 Thread vicente . romero
Changeset: 3b4f92a3797f Author:vromero Date: 2013-07-02 22:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b4f92a3797f 6326693: variable x might already have been assigned, when assignment is in catch block Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools

Re: RFR: 8015666: test/tools/pack200/TimeStamp.java failing

2013-07-02 Thread Xueming Shen
On 06/28/2013 07:47 AM, Kumar Srinivasan wrote: Some nits while reading the changes: 1. ZipEntry.java a. typo: + * Sets the laste access time of the entry. b. extra space +case EXTID_ZIP64 : 2. ZipOutputStream.java I think it would be nice to have the flags 0x1, 0x2

hg: jdk8/tl/jdk: 7184195: java.util.logging.Logger.getGlobal().info() doesn't log without configuration

2013-07-02 Thread daniel . fuchs
Changeset: 70bff2d12af0 Author:dfuchs Date: 2013-07-02 19:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70bff2d12af0 7184195: java.util.logging.Logger.getGlobal().info() doesn't log without configuration Summary: Due to subtle synchronization issues between LogManager &

hg: jdk8/tl/langtools: 8019460: tests in changeset do not have @bug tag

2013-07-02 Thread kumar . x . srinivasan
Changeset: 565341d436e2 Author:ksrini Date: 2013-07-01 16:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/565341d436e2 8019460: tests in changeset do not have @bug tag Reviewed-by: darcy ! test/tools/javac/warnings/AuxiliaryClass/ClassUsingAnotherAuxiliary.java ! tes

Re: Java 8 RFR: 6178739 - Formatter - Zero padding flag with zero width

2013-07-02 Thread Brian Burkhalter
On Jul 1, 2013, at 5:37 PM, Joe Darcy wrote: > While matching the C behavior is generally desirable, if no one has requested > that in the many years Formatter has been in the platform, I think it is > reasonable to change the specification to require a positive argument in this > case. All r

Re: Request for Review: 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion

2013-07-02 Thread Alan Bateman
On 23/12/2012 01:19, Rob McKenna wrote: Hi Martin, thanks a lot for this. I've renamed LINKFLAG to the more appropriate (and common) ARCHFLAG. It seems to pop up all around our source but if build-dev know of a better (or canonical) way of doing it I'll take it! The BUILD_JEXEC differences d

hg: jdk8/tl/nashorn: 12 new changesets

2013-07-02 Thread sundararajan . athijegannathan
Changeset: 218c2833c344 Author:sundar Date: 2013-06-28 19:36 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/218c2833c344 8019365: Error stack format Reviewed-by: hannesw ! src/jdk/nashorn/api/scripting/NashornException.java ! src/jdk/nashorn/internal/objects/NativeError.

hg: jdk8/tl/jdk: 8017463: [TEST_BUG] 2 tests from tools/pack200/ remain about 1 GB of data in work directory after execution

2013-07-02 Thread kumar . x . srinivasan
Changeset: b1fffbbdf58c Author:ksrini Date: 2013-07-02 05:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1fffbbdf58c 8017463: [TEST_BUG] 2 tests from tools/pack200/ remain about 1 GB of data in work directory after execution Reviewed-by: mchung ! test/tools/pack200/Attr

hg: jdk8/tl/jdk: 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger

2013-07-02 Thread daniel . fuchs
Changeset: 020f023f87d1 Author:dfuchs Date: 2013-07-02 11:30 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/020f023f87d1 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger Summary: This patch makes sure that LoggerContext instances crea

Re: RFR: 8019500: Exclude MemoryTest.java and MemoryTestAllGC.sh to enable integration

2013-07-02 Thread Erik Helin
On 2013-07-02, Alan Bateman wrote: > On 01/07/2013 16:32, Erik Helin wrote: > >Hi all, > > > >this change excludes the following two MemoryMXBean tests: > >- java/lang/management/MemoryMXBean/MemoryTestAllGC.sh > >- java/lang/management/MemoryMXBean/MemoryTest.java > > > >This is needed since a cha

hg: jdk8/tl/langtools: 8019397: javap does not show SourceDebugExtension properly

2013-07-02 Thread vicente . romero
Changeset: 27a2e8c78bd0 Author:vromero Date: 2013-07-02 10:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/27a2e8c78bd0 8019397: javap does not show SourceDebugExtension properly Reviewed-by: jjg Contributed-by: dmytro_she...@hotmail.com ! src/share/classes/com/sun/t

Re: RFR: 8019500: Exclude MemoryTest.java and MemoryTestAllGC.sh to enable integration

2013-07-02 Thread Alan Bateman
On 01/07/2013 16:32, Erik Helin wrote: Hi all, this change excludes the following two MemoryMXBean tests: - java/lang/management/MemoryMXBean/MemoryTestAllGC.sh - java/lang/management/MemoryMXBean/MemoryTest.java This is needed since a change in hotspot added a new memory pool for metaspace:

Re: RFR: 8016341 java/lang/ref/OOMEInReferenceHandler.java failing intermittently

2013-07-02 Thread Peter Levart
Hi David, Looking at original code once again, I think this was actually a bug. The WeakReference instance constructed in (old) line 82, can be GCed right away, since nobody is using the local variable after assignment. I f WeakReference is GCed it can not be enqueued. The promotion of local