hg: jdk8/tl/jdk: 8021121: ISO 4217 Amendment Number 156

2013-08-14 Thread yong . huang
Changeset: 2f6523abab08 Author:yhuang Date: 2013-08-14 22:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2f6523abab08 8021121: ISO 4217 Amendment Number 156 Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! src/share/classes/sun/util/resources/lv/

hg: jdk8/tl/jdk: 8023075: JDK-5049299 has broken old make in jdk8

2013-08-14 Thread bradford . wetmore
Changeset: f8af3499c1fb Author:wetmore Date: 2013-08-14 19:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8af3499c1fb 8023075: JDK-5049299 has broken old make in jdk8 Reviewed-by: katleman ! make/java/java/Makefile

hg: jdk8/tl/langtools: 8016921: Change the profiles table on overview-summary.html page to a list

2013-08-14 Thread bhavesh . x . patel
Changeset: 3d4f0fa2ad05 Author:bpatel Date: 2013-08-14 21:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d4f0fa2ad05 8016921: Change the profiles table on overview-summary.html page to a list Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/

hg: jdk8/tl/langtools: 6840442: JavaCompiler.getTask() has incomplete specification for IllegalArgumentException

2013-08-14 Thread kumar . x . srinivasan
Changeset: fac0d1bb87f2 Author:ksrini Date: 2013-08-14 18:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fac0d1bb87f2 6840442: JavaCompiler.getTask() has incomplete specification for IllegalArgumentException Reviewed-by: jjg ! src/share/classes/javax/tools/JavaComp

hg: jdk8/tl/langtools: 8017191: Javadoc is confused by @link to imported classes outside of the set of generated packages

2013-08-14 Thread jonathan . gibbons
Changeset: 14faef2b51eb Author:jjg Date: 2013-08-14 16:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/14faef2b51eb 8017191: Javadoc is confused by @link to imported classes outside of the set of generated packages Reviewed-by: bpatel ! src/share/classes/com/sun/too

Re: RFR ConcurrentHashMap typo

2013-08-14 Thread Mike Duigou
Looks correct. mike On Aug 14 2013, at 15:08 , Chris Hegarty wrote: > Typo that crept in during a refactoring. > > http://cs.oswego.edu/pipermail/concurrency-interest/2013-August/011695.html > > This change is already in the jsr166 CVS. > > diff --git a/src/share/classes/java/util/concurrent/

Re: RFR FJ parallelism zero

2013-08-14 Thread Mike Duigou
Looks fine. Mike On Aug 14 2013, at 14:59 , Chris Hegarty wrote: > Source changes that follow Doug's mail on lambda-libs-spec-observers > > http://mail.openjdk.java.net/pipermail/lambda-libs-spec-observers/2013-August/002361.html > > These changes are already in the jsr166 CVS, and there is a

RFR ConcurrentHashMap typo

2013-08-14 Thread Chris Hegarty
Typo that crept in during a refactoring. http://cs.oswego.edu/pipermail/concurrency-interest/2013-August/011695.html This change is already in the jsr166 CVS. diff --git a/src/share/classes/java/util/concurrent/ConcurrentHashMap.java b/src/share/classes/java/util/concurrent/ConcurrentHashMap.

RFR FJ parallelism zero

2013-08-14 Thread Chris Hegarty
Source changes that follow Doug's mail on lambda-libs-spec-observers http://mail.openjdk.java.net/pipermail/lambda-libs-spec-observers/2013-August/002361.html These changes are already in the jsr166 CVS, and there is a test in OpenJDK that verifies the change. diff --git a/src/share/classes/j

Re: RFR: JDK-7154662: {CRC32, Adler32}.update(byte[] b, int off, int len): undocumented ArrayIndexOutOfBoundsException

2013-08-14 Thread Xueming Shen
Thanks Chris! "the" removed. I would assume the jck team probably will add a unit test for it. They filed the bug originally. -Sherman On 08/14/2013 02:33 PM, Chris Hegarty wrote: > * @throws ArrayIndexOutOfBoundsException > * if the {@code off} is negative, or the {@code len} is >

Re: 8022921: Remove experimental Profile attribute

2013-08-14 Thread Chris Hegarty
The code changes look ok to me. -Chris. On 14/08/2013 13:30, Alan Bateman wrote: As part of the Compact Profiles [1] solution we updated the JAR File specification to define a new attribute named "Profile" to allow both main application and library JAR files specify the minimum subset Profile

Re: RFR: JDK-7154662: {CRC32, Adler32}.update(byte[] b, int off, int len): undocumented ArrayIndexOutOfBoundsException

2013-08-14 Thread Chris Hegarty
> * @throws ArrayIndexOutOfBoundsException > * if the {@code off} is negative, or the {@code len} is > * negative, or the {@code off+len} is greater than the > * length of the array {@code b} I agree that specifying this in CRC32 and Adler32 is the right thing to do.

Re: RFR: JDK-7154662: {CRC32, Adler32}.update(byte[] b, int off, int len): undocumented ArrayIndexOutOfBoundsException

2013-08-14 Thread Alan Bateman
On 14/08/2013 20:10, Xueming Shen wrote: Hi, Please help review the change to document the AIOBE exception for CRC32/Adler32.update() methods (may need a followup CCC). This has been the behavior probably from day one, but the exception is just not explicitly listed. Ideally it probably should b

Re: 8022921: Remove experimental Profile attribute

2013-08-14 Thread Mandy Chung
On 8/14/2013 5:30 AM, Alan Bateman wrote: As part of the Compact Profiles [1] solution we updated the JAR File specification to define a new attribute named "Profile" to allow both main application and library JAR files specify the minimum subset Profile of Java SE that the code in the JAR fi

hg: jdk8/tl/jdk: 8022109: Evaluate adding incrementExact, decrementExact, negateExact to java.lang.Math

2013-08-14 Thread mike . duigou
Changeset: 17dfbb3f60d3 Author:bpb Date: 2013-08-12 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17dfbb3f60d3 8022109: Evaluate adding incrementExact, decrementExact, negateExact to java.lang.Math Summary: Add the methods for parameter types int and long. Reviewed-by

Re: RFR: JDK-4858457 -- File.getCanonicalPath() throws IOException when invoked with "nul" (win)

2013-08-14 Thread Dan Xu
Hi Alan, Thanks for pointing out. I have updated my fix in the new webrev, http://cr.openjdk.java.net/~dxu/4858457/webrev.01/. Please take a look! -Dan On 08/14/2013 08:22 AM, Alan Bateman wrote: On 08/08/2013 21:44, Dan Xu wrote: Hi All, Windows platforms have reserved a few names for dev

Please review Meiji era tidyup

2013-08-14 Thread roger riggs
The issue 8019185: Inconsistency between JapaneseEra start dates and java.util.JapaneseImperialDate Observes a minor discrepancy between the java.util.Calendar Japanese implementation and the java.time JapaneseEra. This fix aligns the start dates of the Meiji Era to avoid the inconsistency. ht

RFR: JDK-7154662: {CRC32, Adler32}.update(byte[] b, int off, int len): undocumented ArrayIndexOutOfBoundsException

2013-08-14 Thread Xueming Shen
Hi, Please help review the change to document the AIOBE exception for CRC32/Adler32.update() methods (may need a followup CCC). This has been the behavior probably from day one, but the exception is just not explicitly listed. Ideally it probably should be in Checksum.update(), but that probably

hg: jdk8/tl/jdk: 8022990: Fix dep_ann lint warnings in swing code

2013-08-14 Thread joe . darcy
Changeset: 444a7edcf367 Author:darcy Date: 2013-08-14 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/444a7edcf367 8022990: Fix dep_ann lint warnings in swing code Reviewed-by: alexsch ! src/share/classes/com/sun/java/swing/Painter.java ! src/share/classes/com/sun/java/

Re: RFR: JDK-8022178: System.console() throws IOE on some Windows

2013-08-14 Thread Dan Xu
Looks good to me. -Dan On 08/14/2013 11:35 AM, Alan Bateman wrote: On 14/08/2013 19:35, Xueming Shen wrote: Hi, Please help review the trivial change for 8022178. http://cr.openjdk.java.net/~sherman/console/webrev System.console() is not specified to throw an IOE. It is supposed to return a

hg: jdk8/tl/jdk: 8022178: System.console() throws IOE on some Windows

2013-08-14 Thread xueming . shen
Changeset: c138d1b608e0 Author:sherman Date: 2013-08-14 11:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c138d1b608e0 8022178: System.console() throws IOE on some Windows Summary: to remove the IOE throwing code Reviewed-by: alanb ! src/windows/native/java/io/Console_md.

Re: RFR: JDK-8022178: System.console() throws IOE on some Windows

2013-08-14 Thread Alan Bateman
On 14/08/2013 19:35, Xueming Shen wrote: Hi, Please help review the trivial change for 8022178. http://cr.openjdk.java.net/~sherman/console/webrev System.console() is not specified to throw an IOE. It is supposed to return a null silently if there is no system console or anything goes wrong to

RFR: JDK-8022178: System.console() throws IOE on some Windows

2013-08-14 Thread Xueming Shen
Hi, Please help review the trivial change for 8022178. http://cr.openjdk.java.net/~sherman/console/webrev System.console() is not specified to throw an IOE. It is supposed to return a null silently if there is no system console or anything goes wrong to get one. The Windows implementation obvio

Re: Classes on the stack trace (was: getElementClass/StackTraceElement, was: @CallerSensitive public API, was: sun.reflect.Reflection.getCallerClass)

2013-08-14 Thread Christian Thalinger
On Jul 30, 2013, at 4:11 PM, Nick Williams wrote: > Quick question for those of you that know anything about @CallerSensitive... > > After looking at the code and experimenting some, I've discovered that > getCallerClass() doesn't actually keep going until it finds the first method > without

Re: [Fwd: Missing merge for 8014890: Reference queues may return more entries than expected]

2013-08-14 Thread Mandy Chung
Thomas, I haven't got to your mail as Alan suspects. I'm happy that you confirmed this is no longer an issue. Mandy On 8/14/2013 2:56 AM, Thomas Schatzl wrote: Hi, On Wed, 2013-08-14 at 10:43 +0100, Alan Bateman wrote: Mandy is just back from vacation and might not have got to your mail y

hg: jdk8/tl/jdk: 8022547: [verifier] move DefaultMethodRegressionTests.java to jdk

2013-08-14 Thread kumar . x . srinivasan
Changeset: bc3cafb17c09 Author:ksrini Date: 2013-08-14 08:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc3cafb17c09 8022547: [verifier] move DefaultMethodRegressionTests.java to jdk Reviewed-by: acorn + test/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java +

Re: RFR: JDK-4858457 -- File.getCanonicalPath() throws IOException when invoked with "nul" (win)

2013-08-14 Thread Alan Bateman
On 08/08/2013 21:44, Dan Xu wrote: Hi All, Windows platforms have reserved a few names for device usages, and "nul" is one of them. And Windows API, such as _wfullpath() and GetFullPathNameW, returns its full path with the prefix "\\.\", which represents win32 device namespaces. For example

hg: jdk8/tl/jdk: 2 new changesets

2013-08-14 Thread coleen . phillimore
Changeset: cb74d71fd02f Author:hseigel Date: 2013-08-13 10:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb74d71fd02f 8022259: MakeClasslist is buggy and its README is out of date. Summary: Fixed bug in FOR loop and updated comments and README Reviewed-by: dholmes, alanb

hg: jdk8/tl/langtools: 8007517: DefaultMethodRegressionTests.java fail in TL

2013-08-14 Thread kumar . x . srinivasan
Changeset: 3ab468194f11 Author:ksrini Date: 2013-08-14 07:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ab468194f11 8007517: DefaultMethodRegressionTests.java fail in TL Reviewed-by: jjg, vromero - test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMet

Re: Possible HashMap update

2013-08-14 Thread Remi Forax
On 08/14/2013 01:16 PM, Doug Lea wrote: On 08/13/13 16:56, Remi Forax wrote: And that the iterators on entrySet, keySet and values doesn't have their method forEachRemaining overriden (unlike java.util.ArrayList). Are you saying that all iterators should define forEachRemaining? Seems exces

Re: RFR 8022898 java/util/Spliterator/SpliteratorCollisions.java fails in HashableIntSpliteratorWithNull data provider

2013-08-14 Thread Roger RIggs
I fixed a jtreg bug a while back when I had a problem with exceptions in dataProviders. I don't know if it has propagated into the latest promotion. Roger changeset: 37:ec890bad20b5 user:jjg date:Tue Jul 09 13:16:13 2013 +0100 description: 7900130: Test summary does not show

Re: Possible HashMap update

2013-08-14 Thread Alan Bateman
On 14/08/2013 12:02, Doug Lea wrote: : Aside: What's up with doclint complaining about no comments on package declarations? Who puts doc comments on package declarations? [javac] /home/dl/concurrent/src/main/java/util/HashMap.java:26: warning: no comment [javac] package java.util; I

8022921: Remove experimental Profile attribute

2013-08-14 Thread Alan Bateman
As part of the Compact Profiles [1] solution we updated the JAR File specification to define a new attribute named "Profile" to allow both main application and library JAR files specify the minimum subset Profile of Java SE that the code in the JAR file requires. The Profile attribute has be

Re: Possible HashMap update

2013-08-14 Thread Doug Lea
On 08/13/13 16:56, Remi Forax wrote: And that the iterators on entrySet, keySet and values doesn't have their method forEachRemaining overriden (unlike java.util.ArrayList). Are you saying that all iterators should define forEachRemaining? Seems excessive. All iterators for ArrayList, HashMa

Re: Possible HashMap update

2013-08-14 Thread Doug Lea
On 08/13/13 17:18, Joe Darcy wrote: While I haven't touched it lately (I've been distracted with a lot of other things), last I left it, it seemed integratable. I haven't seen any list traffic that seems applicable, except for Remi's, that I ought to reply to... Have you seen the patch from Da

Re: Possible HashMap update

2013-08-14 Thread Paul Sandoz
On Aug 14, 2013, at 12:18 PM, Alan Bateman wrote: > On 13/08/2013 22:18, Joe Darcy wrote: >> >> Have you seen the patch from Dan Smith which would revolve all the javac >> lint warnings in HashMap? >> >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-August/019618.html > My preferen

Re: RFR 8022898 java/util/Spliterator/SpliteratorCollisions.java fails in HashableIntSpliteratorWithNull data provider

2013-08-14 Thread Alan Bateman
On 13/08/2013 14:46, Paul Sandoz wrote: Hi, This patch fixes a bug in the data provider of the SpliteratorCollisions.java test, which was attempting to add an element to an unmodifable map. Interestingly although this caused the data provider to barf, and therefore tests using such a provider

Re: Possible HashMap update

2013-08-14 Thread Alan Bateman
On 13/08/2013 22:18, Joe Darcy wrote: Have you seen the patch from Dan Smith which would revolve all the javac lint warnings in HashMap? http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-August/019618.html My preference would be to get Doug's update in as soon as we can, mostly bec

hg: jdk8/tl/langtools: 8013394: compile of iterator use fails with error \"defined in an inaccessible class or interface\"

2013-08-14 Thread vicente . romero
Changeset: 0ad781399706 Author:vromero Date: 2013-08-14 10:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0ad781399706 8013394: compile of iterator use fails with error \"defined in an inaccessible class or interface\" Reviewed-by: mcimadamore ! src/share/classes/c

Re: [Fwd: Missing merge for 8014890: Reference queues may return more entries than expected]

2013-08-14 Thread Thomas Schatzl
Hi, On Wed, 2013-08-14 at 10:43 +0100, Alan Bateman wrote: > Mandy is just back from vacation and might not have got to your mail > yet. However it's not clear to me that there is an actual problem as it > looks like you've just ended up with two heads, maybe a hg fetch when > you had changes w

Re: [Fwd: Missing merge for 8014890: Reference queues may return more entries than expected]

2013-08-14 Thread Alan Bateman
Mandy is just back from vacation and might not have got to your mail yet. However it's not clear to me that there is an actual problem as it looks like you've just ended up with two heads, maybe a hg fetch when you had changes where you forgot to merge? As I understand, the hg server is setup

[Fwd: Missing merge for 8014890: Reference queues may return more entries than expected]

2013-08-14 Thread Thomas Schatzl
Hi all, could somebody take care of the missing merge for the fix below? Thanks, Thomas Forwarded Message > From: Thomas Schatzl > To: mandy.ch...@oracle.com > Subject: Missing merge for 8014890: Reference queues may return more > entries than expected > Date: Wed, 07 Aug 20