Changeset: be2d25a277a7
Author:henryjen
Date: 2013-08-21 20:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be2d25a277a7
8023528: Rename Comparator combinators to disambiguate overloading methods
Reviewed-by: mduigou, smarks
! src/share/classes/java/util/Comparator.java
!
Is it reasonable to make specification clearer ?
Either to return JLS 1 specification:
<<<
The result is rounded to an integer by adding , taking the floor of the
result, and casting the result to type long.
>>>
or to replace "rounding up" with "rounding to positive infinity":
<<<
Returns the clos
Hello all;
Fairly frequently it is reported that various Collection/Map implementations of
hashCode() fail when the instance directly or indirectly contains itself. For a
variety of reasons, mostly performance and resource related, most
implementations choose not to support calculation of hash
Nice.
I think deleting code should be like hazard pay, double the normal hourly wage,
but deleting Makefile lines should be triple wage. :) Looks great to me. Not
that I use this makefile much anymore.
-kto
On Aug 27, 2013, at 4:17 PM, Mike Duigou wrote:
> Hello all;
>
> I have updated the
Hi,
When GeneralSolaris testcase follows symbolic link to pick up an
existing file or directory for testing, it will fail the assertion in
check()method because the file path canonicalization process will result
in the real path not a path containing symbolic link. I enforce this
test not to
Hello all;
I have updated the changeset for this issue based upon feedback from the
earlier version. As a result of intervening work this version contains even
more cleanup.
http://cr.openjdk.java.net/~mduigou/JDK-8015068/1/webrev/
Since the last revision:
- One open issue remains--handling o
On 08/27/2013 03:07 PM, Martin Buchholz wrote:
It does seem vaguely reasonable to support any extra data.
Don't you want to also handle arbitrary byte arrays, if e.g. one the 16-bit
size fields overflows the extra data?
It looks to me like getExtraLen could return a negative number.
probably
Hello all;
Here's an updated version of the patch which incorporates feedback and improves
the tests (the reason for delay):
http://cr.openjdk.java.net/~mduigou/JDK-8021591/1/webrev/
The substance of the patch is largely to add missing checks that the collection
provided to removeAll()/retainA
Looks good.
Random::
- Seems fine.
ThreadLocalRandom::
- I don't understand the point of having a writeObject() if the readResolve()
ignores the result. My expectation for a serialized TLR might be that upon
de-serialization the seeding state is restored. If that isn't provided, why
offer a
On 08/27/2013 03:51 PM, Martin Buchholz wrote:
On Tue, Aug 27, 2013 at 3:00 AM, Paul Sandoz wrote:
[...]
Note that j.u. classes are quite inconsistent in this respect to using
diamonds and @Overrides. My preference is to do a sweeping change to all
such code.
For jsr166, we continue to mai
Hi,
Please help review the change for #8023713
http://cr.openjdk.java.net/~sherman/8023713/webrev
The root cause is that the newly introduced ZOS.writeExtra() (for
#8015666) fails to handle "irregular" extra data field. The zip spec
requires the the extra data stars with 4 bytes of "tag + size"
On 08/27/2013 12:00 PM, Paul Sandoz wrote:
On Aug 26, 2013, at 11:13 PM, Remi Forax wrote:
On 08/26/2013 10:10 PM, Paul Sandoz wrote:
On Aug 25, 2013, at 8:04 PM, Remi Forax wrote:
On 08/21/2013 02:25 PM, Paul Sandoz wrote:
Hi,
Here are Doug's Linked/HashMap changes, discussed in a previ
Changeset: 3f6777cbfe69
Author:sherman
Date: 2013-08-27 12:54 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f6777cbfe69
8023647: "abc1c".matches("(\\w)+1\\1")) returns false
Summary: to correct the wrong GroupCurly group index backoff code
Reviewed-by: alanb
! src/share/cl
Changeset: 662a5188bded
Author:darcy
Date: 2013-08-27 11:58 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/662a5188bded
8023826: Typo in warning about obsolete source / target values
Reviewed-by: jjg, wmdietl
! src/share/classes/com/sun/tools/javac/main/JavaCompiler.ja
Changeset: ade440668f94
Author:henryjen
Date: 2013-08-26 22:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ade440668f94
8023275: Wrapping collections should override default methods
Reviewed-by: mduigou, psandoz
! src/share/classes/java/util/Collections.java
+ test/java/u
Updated:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8023155-Random-TLR-SR-sync/webrev/
- we reverted the addition of the new next* methods on Random. The stream-based
methods remain unchanged. Decided to be extra conservative, since there may be
sub-classes that define such methods (not unusu
Changeset: 51151b440e95
Author:darcy
Date: 2013-08-27 11:46 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51151b440e95
8023827: Fix doclint issues in javax.net.ssl
Reviewed-by: wetmore, xuelei
! src/share/classes/javax/net/ssl/SNIHostName.java
! src/share/classes/javax/net/
Changeset: 7fb27bc201cc
Author:bpatel
Date: 2013-08-27 11:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7fb27bc201cc
7052170: javadoc -charset option generates wrong meta tag
Reviewed-by: jjg
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.j
Changeset: 6a1bfcde4d4d
Author:mullan
Date: 2013-08-27 12:04 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a1bfcde4d4d
8019830: Add com.sun.media.sound to the list of restricted package
Reviewed-by: vinnie
! src/share/lib/security/java.security-linux
! src/share/lib/securi
Changeset: 134283a88499
Author:mullan
Date: 2013-08-27 10:46 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/134283a88499
8023769: JDK-8016850 broke the old build
Summary: remove files that were moved/removed from
com/sun/security/auth/FILES_java.gmk
Reviewed-by: chegar, xuel
Changeset: badc919cd621
Author:lagergren
Date: 2013-08-23 14:16 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/badc919cd621
8023550: -d option was broken for any dir but '.'. Fixed Java warnings.
Reviewed-by: jlaskey, sundar
!
buildtools/nasgen/src/jdk/nashorn/internal/
On 08/27/2013 12:12 AM, Alan Bateman wrote:
On 27/08/2013 01:18, Dan Xu wrote:
Hi All,
MaxPathLength.javais a troublesome testcase, and fails intermittently
in the nightly test. And it also runs for a long time, especially on
Windows platforms. Inorder to improve the test stability, I remove
On 08/27/2013 03:00 AM, Masayoshi Okutsu wrote:
> /etc/sysconfig/clock used to be supported, but it was removed in JDK 7.
> The problem is discussed in bug #6456628.
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6456628
Thanks for that link. I did not know that this support was present i
Hi Joel and others,
Here's a 3rd revision of this proposed patch:
http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationData/webrev.03/
I used LinkedHashMap for annotations in this one. It means that now even
.getAnnotations() are reported in "declaration order": 1st inherited
(includes overr
I vote for pedantry, though not necessarily for every NPE.
I've had to port the JDK to a non-standard operating system. The docs are
frequently inadequate to answer detailed coding questions, so I end up reading
code to figure out what is supposed to happen. Even then, we sometimes don't
sort
On Aug 26, 2013, at 11:13 PM, Remi Forax wrote:
> On 08/26/2013 10:10 PM, Paul Sandoz wrote:
>> On Aug 25, 2013, at 8:04 PM, Remi Forax wrote:
>>
>>> On 08/21/2013 02:25 PM, Paul Sandoz wrote:
Hi,
Here are Doug's Linked/HashMap changes, discussed in a previous thread, as
Changeset: ca53110f1c74
Author:weijun
Date: 2013-08-27 17:50 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca53110f1c74
8015669: KerberosPrincipal::equals should ignore name-type
Reviewed-by: mullan
! src/share/classes/javax/security/auth/kerberos/KerberosPrincipal.java
+ t
On Aug 27, 2013, at 8:54 AM, Peter Levart wrote:
> Hi,
>
> The system property name "java.util.secureRandomSeed" suggests that it is not
> for SplittableRandom only. Now that ThreadLocalRandom is algorithmically
> aligned with SplittableRandom, should initial seed for TLR instances also use
On 27/08/2013 01:18, Dan Xu wrote:
Hi All,
MaxPathLength.javais a troublesome testcase, and fails intermittently
in the nightly test. And it also runs for a long time, especially on
Windows platforms. Inorder to improve the test stability, I remove its
unnecessary test iterations, and use NIO
On 26/08/2013 21:54, Xueming Shen wrote:
Hi,
Please help review the proposed change for 8023647:
http://cr.openjdk.java.net/~sherman/8023647/webrev
It appears group index updating in situation of GroupCurly backing off
is incorrect from day one (the bug is reproducible back to jdk5). The
curre
Hi Omair,
/etc/sysconfig/clock used to be supported, but it was removed in JDK 7.
The problem is discussed in bug #6456628.
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6456628
Have you tested your fix on all Red Hat-like distros, including some
older releases, with all the time zone I
31 matches
Mail list logo
