hg: jdk8/tl/jdk: 8020687: Deflater.setLevel does not work as expected

Changeset: efa09bf27d39 Author:sherman Date: 2013-09-15 13:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/efa09bf27d39 8020687: Deflater.setLevel does not work as expected Summary: to clarify the api to match the existing implementation behavior Reviewed-by: alanb ! src/s

Re: RFR: 8920687: Deflater.setLevel does not work as expected

Updated accordingly. http://cr.openjdk.java.net/~sherman/8020687/webrev/ Thanks! -Sherman On 9/15/13 12:45 PM, Alan Bateman wrote: On 15/09/2013 19:30, Xueming Shen wrote: Thanks Alan. I dropped the "current" in setLevel. Yes, I would like to be explicit about the deflate invocation here, as

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

On 15/09/2013 12:06, Ivan Gerasimov wrote: : I decided to check whether this test really detects the failure, and run JPRT job with the new test but no fix included. Unfortunately, the new test *does not* fail with unmodified jdk. The same thing happens when the test is run with jtreg locally.

Re: RFR: 8920687: Deflater.setLevel does not work as expected

On 15/09/2013 19:30, Xueming Shen wrote: Thanks Alan. I dropped the "current" in setLevel. Yes, I would like to be explicit about the deflate invocation here, as the implementation clearly just calls the deflate() blindly with the old level/strategy after the level/strategy changed, regardless

Re: review request 7097386: Correct error in Predicate javadoc example

I added a webrev http://cr.openjdk.java.net/~lancea/7097386/webrev.00/ as it might be a bit easier for this review. Best lance On Sep 13, 2013, at 4:40 PM, Lance Andersen - Oracle wrote: > Hi Everyone, > > Looking for a reviewer for this trivial fix to correct the sample example in > the Predi

Re: RFR: 8920687: Deflater.setLevel does not work as expected

Thanks Alan. I dropped the "current" in setLevel. Yes, I would like to be explicit about the deflate invocation here, as the implementation clearly just calls the deflate() blindly with the old level/strategy after the level/strategy changed, regardless whether there is really anything in the bu

hg: jdk8/tl/jdk: 7186311: (props) "Unicode" is misspelled as "Uniocde" in JavaDoc and error message

Changeset: b9d59414de23 Author:sherman Date: 2013-09-15 11:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b9d59414de23 7186311: (props) "Unicode" is misspelled as "Uniocde" in JavaDoc and error message Summary: to correct the typo Reviewed-by: alanb, chegar ! make/tools/

RFR 8024253: ThreadLocal random can use SecureRandom for the initial seed

Hi, http://cr.openjdk.java.net/~psandoz/tl/JDK-8024253-tlr-seed/webrev/ Now that the hash seed functionality, which utilized ThreadLocalRandom, has been removed from Hashtable and WeakHashMap we can update TLR to use the same seed initialization functionality as SplittableRandom, which includes

RFR 8024341: j.u.regex.Pattern.splitAsStream() doesn't correspond to split() method if using an example from the spec

Hi, http://cr.openjdk.java.net/~psandoz/tl/JDK-8024341-pattern-splitAsStream/webrev/ This fixes an issue with Pattern.splitAsStream reporting empty trailing elements and aligns with the functionality of Pattern.split(CharSequence input). The matching iterator passed to the stream was updated to

RFR 8024408: Specifications for Collection/List/Set/SortedSet.spliterator() need to document if all the (subclass) instances are required to return SIZED spliterators

Hi, http://cr.openjdk.java.net/~psandoz/tl/JDK-8024408-split-col-size/webrev/ It is necessary to relax the constraints when SIZED should be reported for a Spliterator of a Collection or Set. The spliterator of a Collection/Set can report SIZED, or CONCURRENT, or neither (and never both). The l

RFR 8024405: Spliterators.spliterator should support CONCURRENT characteristic

Hi, http://cr.openjdk.java.net/~psandoz/tl/JDK-8024405-spliterators-size-concurrent/webrev/ This fixes an oversight in creating spliterators from the iterator of a collection or directly from an iterator (+ primitive variants). If CONCURRENT is supplied as a characteristic then the returned spl

Re: RFR JDK-8011940 : java.lang.Class.getAnnotations() always enters synchronized method

Hi, I rebased the changes and added @bug tag to test. Here's new webrev: http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationData/webrev.04/ Joel, I believe you've got the "R" mojo now... Regards, Peter On 09/09/2013 06:57 PM, Peter Levart wrote: Hi Joel, Thanks for reviewing. On 09/09

hg: jdk8/tl/jdk: 8024837: Rename java/util/concurrent/ConcurrentHashMap/toArray.java to ToArray.java

Changeset: 5025ed287a4a Author:psandoz Date: 2013-09-15 16:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5025ed287a4a 8024837: Rename java/util/concurrent/ConcurrentHashMap/toArray.java to ToArray.java Reviewed-by: alanb ! test/java/util/concurrent/ConcurrentHashMap/ToA

Re: RFR 8010293 Re: Potential issue with CHM.toArray

On Sep 10, 2013, at 4:34 PM, Alan Bateman wrote: > On 09/09/2013 14:35, Paul Sandoz wrote: >> On Sep 6, 2013, at 4:56 PM, Alan Bateman wrote: >> >>> : >>> The comments are very educational as the resizing is difficult to >>> completely grok without going through examples on a whiteboard. Anyw

hg: jdk8/tl/jdk: 8010293: java/util/concurrent/ConcurrentHashMap/toArray.java fails intermittently

Changeset: ff6c76f7733e Author:psandoz Date: 2013-09-02 11:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff6c76f7733e 8010293: java/util/concurrent/ConcurrentHashMap/toArray.java fails intermittently Reviewed-by: forax, chegar, alanb Contributed-by: Doug Lea , Peter Leva

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

On 15.09.2013 11:15, Alan Bateman wrote: On 14/09/2013 19:58, Ivan Gerasimov wrote: : Yes, done. Would you please review the updated webrev? http://cr.openjdk.java.net/~igerasim/8023130/2/webrev/ Thanks for the update, I think it's l

Re: static vs. default interface methods and inheritance VM/javac issues

On 13/09/2013 10:37, Peter Levart wrote: Karen, I filed a bug, but don't have the bug ID yet. Will let you know when I get it. I found it, and moved it into the JDK project as: 8024836: static vs. default interface methods and inheritance - VM crash -Alan.

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

On 14/09/2013 19:58, Ivan Gerasimov wrote: : Yes, done. Would you please review the updated webrev? http://cr.openjdk.java.net/~igerasim/8023130/2/webrev/ Thanks for the update, I think it's looks okay now. It is of course disappointi