Remi,
Thanks for the review and comments, you have some good points.
I am thinking perhaps the dumper class could be used somewhere else given a
different path, which is why the directory is used as key to get an instance
and injected from caller. As you observed, it's not necessary. But the
i
Chris Thalinger suggested removing the new booleans from the changed
"getDirectMethod" call sites and instead put the intended usage into the method
names, e.g., "getDirectMethodNoSecurityManager". The result is more clearly
correct and maintainable.
Here is the respin:
http://cr.openjdk.jav
On 01/10/2013 12:46, Brian Burkhalter wrote:
:
I updated the webrev
http://cr.openjdk.java.net/~bpb/8010371/
with changes in the test of the return value of getaddrinfo for Unix Inet 4 and
6 and Windows Inet 6. The usual testing is in progress.
Brian
This looks better, although I think I wou
Changeset: 3fca37c636be
Author:xuelei
Date: 2013-10-01 20:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fca37c636be
8025123: SNI support in Kerberos cipher suites
Reviewed-by: weijun, xuelei
Contributed-by: Artem Smotrakov
! src/share/classes/sun/security/ssl/ClientHan
Changeset: 187a759c08ba
Author:alanb
Date: 2013-10-02 04:21 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/rev/187a759c08ba
8006843: org.w3c.dom.events.UIEvent.getView is specified to return type that is
not in the Java SE specification
Reviewed-by: mduigou, tbell
! common/makefile
Sounds good. Thanks for the clarification.
Gili
On 01/10/2013 9:25 PM, Dmitry Nadezhin wrote:
I see that I misused the word "to clamp" in this discussion.
I guess that addition with "clumping" means:
return x + y < MIN_VALUE ? MIN_VALUE : x + y > MAX_VALUE ? MAX_VALUE : x +
y;
The patch a
Changeset: d90928a89af5
Author:drchase
Date: 2013-09-27 13:32 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d90928a89af5
8022701: Accessibility checking: InvocationTargetException is thrown instead of
IllegalAccessError
Summary: Inserted code to convert specific exceptions,
I see that I misused the word "to clamp" in this discussion.
I guess that addition with "clumping" means:
return x + y < MIN_VALUE ? MIN_VALUE : x + y > MAX_VALUE ? MAX_VALUE : x +
y;
The patch actually throws ArithmeticException on overflow:
if (x + y < MIN_VALUE || x + y > MAX_VALUE) throw new A
(Cross-post.)
From: John Rose
Subject: RFR (S) 8025112: JSR 292 spec updates for security manager and caller
sensitivity
Date: October 1, 2013 3:15:24 PM PDT
To: Da Vinci Machine Project
Cc: "hotspot-compiler-...@openjdk.java.net compiler"
This change updates the javadoc to reflect previous
(Cross-posting RFR.)
From: John Rose
Subject: RFR (M) 8024438: JSR 292 API specification maintenance for JDK 8
Date: October 1, 2013 3:19:30 PM PDT
To: Da Vinci Machine Project
Cc: "hotspot-compiler-...@openjdk.java.net compiler"
http://cr.openjdk.java.net/~jrose/8024438/webrev.00
These are
On 10/02/2013 01:04 AM, Henry Jen wrote:
Hi,
Please review the updated webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/3/webrev/
This update addressed comments from Mandy with following,
- call doPrivileged with specific file permission, "<>", "write".
- Use nio package to write dea
Hi,
Please review the updated webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/3/webrev/
This update addressed comments from Mandy with following,
- call doPrivileged with specific file permission, "<>", "write".
- Use nio package to write deal with FS, also create directory hierarchy
Changeset: 84e7f6685319
Author:ksrini
Date: 2013-10-01 15:40 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84e7f6685319
8025342: NLS: unsupported translation format in jar/pack/DriverResource.java
Reviewed-by: naoto, mfang
! src/share/classes/com/sun/java/util/jar/pack/Driv
Changeset: 5a7bd9825c01
Author:vlivanov
Date: 2013-09-23 19:51 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5a7bd9825c01
8001107: @Stable annotation for constant folding of lazily evaluated variables
Reviewed-by: twisti, kvn, rbackman
Contributed-by: john.r.r...@oracle.com,
Changeset: de1c5dbe6c28
Author:emc
Date: 2013-10-01 17:41 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/de1c5dbe6c28
8021339: Compile-time error during casting array to intersection
Summary: Add ability to have arrays in intersection types.
Reviewed-by: jjg, vromero
!
Changeset: bf1118ab775b
Author:emc
Date: 2013-10-01 17:35 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf1118ab775b
8021398: j.l.r.Parameter.getAnnotatedType().getType() for not annotated use of
type returns null
Summary: Fixed issue with type annotation reflection framewo
Changeset: 1ed675532589
Author:vlivanov
Date: 2013-09-18 20:12 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ed675532589
8024616: JSR292: lazily initialize core NamedFunctions used for bootstrapping
Reviewed-by: jrose
! src/share/classes/java/lang/invoke/DirectMethodHandle
I am already running pre-commit tests, but I have another upcoming
reflection API patch, and I could do this as part of that one.
On 10/01/13 15:36, Paul Sandoz wrote:
> Hi Eric,
>
> If it is not too late you could also change other references to "new
> TypeAnnotation[0]" in the same source file
On 10/01/13 02:41, Joe Darcy wrote:
(Suggested changes have been applied)
>
> I think the test is acceptable as-is, but an RFE could be filed for some
> refactoring (having each bad class be represented as a diff from a base
> byte[], avoiding sending the bytes through the file system).
>
Bett
On Oct 1, 2013, at 1:25 PM, Michael McMahon wrote:
>> The approach I initially was going to take was to retry once after a short
>> wait and then fail with the proposed exception if the retry failed.
>
> I'm not sure about the short wait. I know the submitter claims that it worked
> after 50ms
On 01/10/13 19:59, Brian Burkhalter wrote:
On Oct 1, 2013, at 11:50 AM, Alan Bateman wrote:
On 01/10/2013 11:31, Brian Burkhalter wrote:
Hello net-dev members,
Please review this proposed fix at your convenience.
Summary
When looking up a host and an EAGAIN error is encountered, throw an ins
Alan,
getaddrinfo is actually a shell around couple of different calls, so
for getaddrinfo EAGAIN usually means that it can't rich nameserver, not
the interrupted syscall.
EAI_SYSTEM means that one of underlaying calls (e.g. gethostbyname)
returns an error.
Under Windows, getaddrinfo never retu
Looks good to me!
Mike
On Oct 1 2013, at 12:30 , Paul Sandoz wrote:
> Hi,
>
> Please review the following patch that checks size limits for the sorted
> operation and fails quickly rather than failing with an obscure ISE or an
> OOME later on:
>
>
> http://cr.openjdk.java.net/~psandoz/tl/J
Hi Kumar,
Looks good. Thanks for addressing translatability conformance of this file.
thanks,
-michael
On 13年10月01日 11:46 上午, Kumar Srinivasan wrote:
Hi Naoto, Michael,
Please review the webrev below. Apparently using variables to hold
the common
message strings between pack200(1) and unpa
Hi Kumar,
Just a cosmetic comment. Looks like the description columns at line
103 (and before) and line 104 (and after) do not align to each other.
yes indeed, I will fix that.
Thanks Naoto!
Kumar
Otherwise it looks good to me.
Naoto
On 10/1/13 11:46 AM, Kumar Srinivasan wrote:
Hi
On Oct 1, 2013, at 11:59 AM, Brian Burkhalter wrote:
> It seems a bit unclear to me and to depend on which system one is on. There
> is also the possibility apparently of it returning EAI_AGAIN. It might be
> best to test both the return value and if that is EAI_SYSTEM to test errno.
I updated
I prefer throwing exceptions on unusual conditions (e.g. overflow)
and letting the user clamp the value if they so wish. Clamping will lead
to unexpected behavior once values fall outside this range. Yes, it will
be documented, but I daresay most applications won't ever check for it
and p
Hi Eric,
If it is not too late you could also change other references to "new
TypeAnnotation[0]" in the same source file.
78 TypeAnnotation[] typeAnnotations = l.toArray(new
TypeAnnotation[0]);
79 return AnnotatedTypeFactory.buildAnnotatedType(type,
80
Hi,
Please review the following patch that checks size limits for the sorted
operation and fails quickly rather than failing with an obscure ISE or an OOME
later on:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8025535-sorted-unsafe-type-cast/webrev/
Tests have been added that assert for both
Hi Kumar,
Just a cosmetic comment. Looks like the description columns at line 103
(and before) and line 104 (and after) do not align to each other.
Otherwise it looks good to me.
Naoto
On 10/1/13 11:46 AM, Kumar Srinivasan wrote:
Hi Naoto, Michael,
Please review the webrev below. Apparent
On Oct 1, 2013, at 11:50 AM, Alan Bateman wrote:
> On 01/10/2013 11:31, Brian Burkhalter wrote:
>> Hello net-dev members,
>>
>> Please review this proposed fix at your convenience.
>>
>> Summary
>> When looking up a host and an EAGAIN error is encountered, throw an instance
>> of the new HostL
Thanks all, committing after successful tests.
On 10/01/13 14:33, Joe Darcy wrote:
> Looks fine; cheers,
>
> -Joe
>
> On 10/1/2013 11:18 AM, Eric McCorkle wrote:
>> I forgot to hg add the test. I've addressed your and others' comments,
>> and refreshed the webrev. Please review.
>>
>> On 10/01
Ping, needs a Reviewer.
http://cr.openjdk.java.net/~rriggs/webrev-serial-refactor-8024896/
Updated the webrev with the renamed test classes to distinguish them
from the
non-serialization tests in a different package.
Thanks, Roger
On 9/23/2013 11:04 AM, Stephen Colebourne wrote:
The chang
Hi Stephen,
The proposed approach makes sense to me, shall I take the patch as is or
wait to integrate until for the mentioned update of effective chrono?
Thanks, Roger
On 9/22/2013 10:27 AM, Stephen Colebourne wrote:
The patch only changes the text of one of the two appendValueReduced
methods
On 01/10/2013 11:31, Brian Burkhalter wrote:
Hello net-dev members,
Please review this proposed fix at your convenience.
Summary
When looking up a host and an EAGAIN error is encountered, throw an instance of
the new HostLookupException subclass of UnknownHostException.
Issue
https://bugs.ope
Looks good.
cheers
/Joel
On Oct 1, 2013, at 8:18 PM, Eric McCorkle wrote:
> I forgot to hg add the test. I've addressed your and others' comments,
> and refreshed the webrev. Please review.
>
> On 10/01/13 04:06, Joel Borggren-Franck wrote:
>> Hi Eric,
>>
>> Thanks for fixing this.
>>
>> O
Hi Naoto, Michael,
Please review the webrev below. Apparently using variables to hold the
common
message strings between pack200(1) and unpack200(1) utilities don't bode
well,
with the new globalization tools. Thus the request is to remove these common
variable and inline these in the messag
Looks fine; cheers,
-Joe
On 10/1/2013 11:18 AM, Eric McCorkle wrote:
I forgot to hg add the test. I've addressed your and others' comments,
and refreshed the webrev. Please review.
On 10/01/13 04:06, Joel Borggren-Franck wrote:
Hi Eric,
Thanks for fixing this.
On 2013-10-01, Eric McCorkle
Hello net-dev members,
Please review this proposed fix at your convenience.
Summary
When looking up a host and an EAGAIN error is encountered, throw an instance of
the new HostLookupException subclass of UnknownHostException.
Issue
https://bugs.openjdk.java.net/browse/JDK-8010371
Webrev
http:/
Please review these changes from the Threeten project for integration
into jdk-tl.
http://cr.openjdk.java.net/~rriggs/webrev-period-until-8023762-807-834-835/
8023762: Add ChronoPeriod interface and bind period to Chronology
Summary: Make Period ISO-only, adding a Chronology-specific period con
Dear BigInteger experts,
Do you have comments to my previous message ?
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-September/021264.html
On Sat, Sep 21, 2013 at 8:13 AM, Dmitry Nadezhin
wrote:
> It is important that BigInteger objects be full-fledged instances on which
> all method
I forgot to hg add the test. I've addressed your and others' comments,
and refreshed the webrev. Please review.
On 10/01/13 04:06, Joel Borggren-Franck wrote:
> Hi Eric,
>
> Thanks for fixing this.
>
> On 2013-10-01, Eric McCorkle wrote:
>> Hello, please review this simple patch which fixes a
Changeset: c32ab940a183
Author:mduigou
Date: 2013-10-01 10:37 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c32ab940a183
8025686: Update jdk repo netbeans projects to support NetBeans 7.4 for Java 8
support
Reviewed-by: lancea, chegar
! make/netbeans/common/java-data-nativ
Changeset: 8cfb2bddd95e
Author:mduigou
Date: 2013-09-30 15:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8cfb2bddd95e
7057785: Add note about optional support of recursive methods for
self-referential Collection/Map
Reviewed-by: scolebourne, darcy, mduigou
Contributed-by
2013/10/1 2:12 -0700, cow...@bbs.darktech.org:
> Two questions:
>
> 1. "restore the totally unsupported getCallerClass": Does that mean
> it'll become supported again?
No. It never was supported. Use at your own risk.
> 2. "submit a JEP with a proposal to add a standard API": Will this p
On 01/10/2013 9:40 AM, Alan Bateman wrote:
On 01/10/2013 01:50, Jörn Huxhorn wrote:
…just saying…
We know. It seems unlikely that there will be agreement on a standard
API or that there is time for a new API to bake. So the safest thing
might be just restore the totally unsupported getCallerCl
On 10/1/2013 4:18 AM, Paul Sandoz wrote:
On Sep 20, 2013, at 5:30 PM, Martin Buchholz wrote:
Looks good.
Random nitpicks:
I prefer the old variable name DOUBLE_UNIT to DOUBLE_ULP; else you are
inventing a slightly different meaning for ULP.
I think using hex floating point literals is prefer
Changeset: 2016a6b9e1f3
Author:hannesw
Date: 2013-09-27 16:59 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2016a6b9e1f3
8025515: Performance issues with Source.getLine()
Reviewed-by: sundar, lagergren
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nash
Changeset: bf52ea6bd9eb
Author:aefimov
Date: 2013-10-01 17:15 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf52ea6bd9eb
8024707: TransformerException : item() return null with node list of length != 1
Reviewed-by: joehw, lancea
+ test/javax/xml/jaxp/parsers/8024707/TestFun
Changeset: 84a2b2ee6fc6
Author:aefimov
Date: 2013-10-01 17:14 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/84a2b2ee6fc6
8024707: TransformerException : item() return null with node list of length != 1
Reviewed-by: joehw, lancea
! src/com/sun/org/apache/xml/internal/dtm/re
Hi,
This patch marks certain stream tests as serialization hostile. Such tests will
ignored by by lambda serialization testing framework:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8025567-test-serialization-hostile/webrev/
Paul.
On 01/10/2013 01:50, Jörn Huxhorn wrote:
…just saying…
We know. It seems unlikely that there will be agreement on a standard
API or that there is time for a new API to bake. So the safest thing
might be just restore the totally unsupported getCallerClass and submit
a JEP with a proposal to add
Changeset: 1a3e8347f3dd
Author:kizune
Date: 2013-10-01 17:03 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1a3e8347f3dd
7118749: NPE in CreateSymbols caused by bad diagnostic
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java
Looks ok to me as well
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Oct 1, 2013, at 5:32 AM, Chris Hegarty wrote:
> The changes look ok to me Mike. Thanks,
>
>
No problem, I just moved it:
http://cr.openjdk.java.net/~mkos/8025054/webrev-jdk.01/
Let me know if I can do anything else to speed up pushing the changeset.
Thanks
Miran
On 10/1/13 11:41 AM, Seán Coffey wrote:
On 01/10/2013 10:29, Chris Hegarty wrote:
On 10/01/2013 10:09 AM, Seán Coffey w
On Sep 20, 2013, at 5:30 PM, Martin Buchholz wrote:
> Looks good.
>
> Random nitpicks:
>
> I prefer the old variable name DOUBLE_UNIT to DOUBLE_ULP; else you are
> inventing a slightly different meaning for ULP.
>
> I think using hex floating point literals is preferred:
>
> -private stati
Changeset: f8b3ab514564
Author:psandoz
Date: 2013-10-01 12:19 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8b3ab514564
8024408: Specifications for Collection/List/Set/SortedSet.spliterator() need to
document if all the (subclass) instances are required to return SIZED
sp
Hi Sean,
yes, all the changes are going throuhg a review on our side before they
are pushed into upstream projects.
When we integrated in the past into jdk, reviewers were Sean Mullan,
Sami Koivu, Alan Bateman and Alexander Fomin. Could anybody from them
look into it? If you had any hint who
On 01/10/2013 10:29, Chris Hegarty wrote:
On 10/01/2013 10:09 AM, Seán Coffey wrote:
Miran,
I'm assuming that all these changes were reviewed when integrated to the
upstream JAX-WS project. I confirm that my changes from 8016271 are
present and look fine. I'm not an OpenJDK reviewer though so
The changes look ok to me Mike. Thanks,
-Chris,
On 09/30/2013 09:48 PM, Mike Duigou wrote:
Hello all;
When JDK-8006709 (http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/cff8d7768d72) was pushed
it changed the default source level for the jdk project NetBeans projects to 1.8. This
was a reasonabl
On 10/01/2013 10:09 AM, Seán Coffey wrote:
Miran,
I'm assuming that all these changes were reviewed when integrated to the
upstream JAX-WS project. I confirm that my changes from 8016271 are
present and look fine. I'm not an OpenJDK reviewer though so you'll need
someone else as reviewer.
From
Miran,
I'm assuming that all these changes were reviewed when integrated to the
upstream JAX-WS project. I confirm that my changes from 8016271 are
present and look fine. I'm not an OpenJDK reviewer though so you'll need
someone else as reviewer.
regards,
Sean.
On 26/09/2013 17:14, Miroslav
…just saying…
On Sep 30, 2013, at 3:39 PM, Mike Duigou wrote:
After posting the webrev I decided that an update to the regression test was going to be necessary.
Here's the updated webrev including additional unit tests. Unfortunately I had to cut-and-paste
some "library" code for exception checking. The
On Oct 1, 2013, at 9:12 AM, Eric McCorkle wrote:
> Hello, please review this simple patch which fixes a problem in the type
> annotations handling API. This manifests as a problem with both
> j.l.r.Parameter.getAnnotatedType().getType() as well as
> j.l.r.Executable.getAnnotatedParameterTypes()
On Oct 1, 2013, at 12:39 AM, Mike Duigou wrote:
> After posting the webrev I decided that an update to the regression test was
> going to be necessary. Here's the updated webrev including additional unit
> tests. Unfortunately I had to cut-and-paste some "library" code for exception
> checking.
The source changes look ok to me.
I presume a test is not needed as this is already covered by JCK?
-Chris.
On 10/01/2013 08:12 AM, Eric McCorkle wrote:
Hello, please review this simple patch which fixes a problem in the type
annotations handling API. This manifests as a problem with both
j.l
Hi Eric,
Thanks for fixing this.
On 2013-10-01, Eric McCorkle wrote:
> Hello, please review this simple patch which fixes a problem in the type
> annotations handling API. This manifests as a problem with both
> j.l.r.Parameter.getAnnotatedType().getType() as well as
> j.l.r.Executable.getAnnota
Hello, please review this simple patch which fixes a problem in the type
annotations handling API. This manifests as a problem with both
j.l.r.Parameter.getAnnotatedType().getType() as well as
j.l.r.Executable.getAnnotatedParameterTypes().getType().
The webrev is here:
http://cr.openjdk.java.net/
69 matches
Mail list logo
