hg: jdk8/tl/langtools: 8026758: Inefficient code in LambdaToMethod

2013-10-21 Thread kumar . x . srinivasan
Changeset: 87c950ea88be Author:ksrini Date: 2013-10-21 20:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/87c950ea88be 8026758: Inefficient code in LambdaToMethod Reviewed-by: jjg, jlahoda, rfield ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java

hg: jdk8/tl/jdk: 3 new changesets

2013-10-21 Thread jason . uh
Changeset: 975e3a89814e Author:darcy Date: 2013-10-21 13:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/975e3a89814e 8024603: Turn on javac lint checking for auxiliaryclass, empty, and try in jdk build Reviewed-by: erikj, ihse, chegar ! makefiles/Setup.gmk Changeset: f4

hg: jdk8/tl/jdk: 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV

2013-10-21 Thread coleen . phillimore
Changeset: f581b72e3715 Author:sla Date: 2013-10-21 23:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f581b72e3715 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV Summary: Redefined class in stack trace may not be found by method_idnum so handle nu

hg: jdk8/tl/langtools: 8026855: AnnoConstruct.getAnnotationsByType includes inherited indirectly present annotations even when containee type is not inheritable

2013-10-21 Thread joel . franck
Changeset: ac839d6f4953 Author:jfranck Date: 2013-10-22 03:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ac839d6f4953 8026855: AnnoConstruct.getAnnotationsByType includes inherited indirectly present annotations even when containee type is not inheritable Summary:

RFR: 8026427: deprecate obsolete APIs from java.rmi

2013-10-21 Thread Stuart Marks
Hi all, Please review this small spec change to deprecate some obsolete RMI APIs, along with a bit of associated cleanup. There are no functional changes in this changeset. Bug: https://bugs.openjdk.java.net/browse/JDK-8026427 Webrev: http://cr.openjdk.java.net/~smarks/reviews/80264

Re: RFR 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking

2013-10-21 Thread Xueming Shen
On 10/21/13 3:25 PM, Mike Duigou wrote: On Oct 19 2013, at 19:04 , Kumar Srinivasan wrote: Hi Martin, I'm not convinced this feature pulls its weight. I'd like to see more motivation/documentation for this change. It seems like this just adds a post-processing phase which packs and unpacks

hg: jdk8/tl/jdk: 8008386: (cs) Unmappable leading should be decoded to replacement.

2013-10-21 Thread xueming . shen
Changeset: 3b00bf85a6f5 Author:sherman Date: 2013-10-21 18:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b00bf85a6f5 8008386: (cs) Unmappable leading should be decoded to replacement. Summary: updated the unmappable/malformed detecting handling for db charsets Reviewed-b

Re: RFC 6910473: BigInteger negative bit length, value range, and future prospects

2013-10-21 Thread Dmitry Nadezhin
The updated patch is here: http://cr.openjdk.java.net/~bpb/6910473/webrev.4/ It contains 4 new small tests - one for each bug: 6910473 BitLengthOverflow.java 8021203 DoubleValueOverflow.java 8021204 StringConstructorOverflow.java 8022780 DivisionOverflow.java Each test catches possible OutOfMemo

Re: 8021257: com.sun.corba.se.** should be on restricted package list

2013-10-21 Thread Stuart Marks
Looks fine, except one tiny issue. In javax/rmi/CORBA/Stub.java, createDelegate() returns Object, and in the static initializer it's cast to Object before being assigned to Object stubDelegateInstance. It's sort-of in parallel with the other cases that cast it to some other type, but a cast to

RFR: 8023862: deprecate HTTP proxying from RMI

2013-10-21 Thread Stuart Marks
Hi all, Please review the following spec change (deprecation) and change of a property default value. Briefly, RMI has some machinery that will attempt to tunnel RMI requests through HTTP under certain circumstances. This is a maintenance burden and also causes customer confusion. The change

hg: jdk8/tl/langtools: 8026984: Clarity intended use of jdk.Exported

2013-10-21 Thread joe . darcy
Changeset: b82982ac3ca2 Author:darcy Date: 2013-10-21 15:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b82982ac3ca2 8026984: Clarity intended use of jdk.Exported Reviewed-by: psandoz, mr, alanb ! src/share/classes/jdk/Exported.java

Re: RFR 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking

2013-10-21 Thread Mike Duigou
On Oct 19 2013, at 19:04 , Kumar Srinivasan wrote: > Hi Martin, > >> I'm not convinced this feature pulls its weight. >> I'd like to see more motivation/documentation for this change. >> It seems like this just adds a post-processing phase which packs and >> unpacks the jar file (why?) > Pack2

Re: JDK 8 RFR for JDK-8022658: Revisit FunctionalInterface on some core libs types

2013-10-21 Thread Remi Forax
On 10/21/2013 08:16 PM, Joe Darcy wrote: Hello, Earlier in JDK 8, various core library classes were annotated with the @FunctionalInterface annotation (JDK-8005623 Retrofit FunctionalInterface annotations to core platform interfaces). As experience has been gained with the feature, the time h

hg: jdk8/tl/jdk: 8020037: String.toLowerCase incorrectly increases length, if string contains \u0130 char

2013-10-21 Thread yuka . kamiya
Changeset: e8683d5b2b0a Author:peytoia Date: 2013-10-22 06:13 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8683d5b2b0a 8020037: String.toLowerCase incorrectly increases length, if string contains \u0130 char Reviewed-by: naoto ! src/share/classes/java/lang/ConditionalSpe

8026863: regression in anonymous Logger.setParent method

2013-10-21 Thread Daniel Fuchs
Hi, Please find below a fix for 8026863: regression in anonymous Logger.setParent method This is a regression I introduced in JDK 8 with one of my recent logging fixes: 8023168: Cleanup LogManager class initialization and LogManager/LoggerContext relationship The issue is that

Re: RFR 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking

2013-10-21 Thread Kumar Srinivasan
Alex, The @test should be just TestNormal not TestNormal.java if you need an alternate/small jar you can use one in $JDK/lib/ ex: jconsole.jar or dt.jar Kumar On 10/21/2013 7:41 AM, Alexander Zuev wrote: Alan, thanks for a review, see my comments inline. On 10/20/13 23:15, Alan Bateman

hg: jdk8/tl/jdk: 8022658: Revisit FunctionalInterface on some core libs types

2013-10-21 Thread joe . darcy
Changeset: c1700125d041 Author:darcy Date: 2013-10-21 12:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1700125d041 8022658: Revisit FunctionalInterface on some core libs types Reviewed-by: briangoetz, mduigou, mr ! src/share/classes/java/io/Closeable.java ! src/share/cl

Re: JDK 8 RFR for JDK-8022658: Revisit FunctionalInterface on some core libs types

2013-10-21 Thread mark . reinhold
2013/10/21 4:53 -0700, joe.da...@oracle.com: > I was on the fence for Iterable too. Other opinions? When in doubt, leave it out. Omitting this annotation won't prevent people from using lambda expressions to implement the Iterable interface, and we can always add it back later as experience warra

Re: JDK 8 RFR for JDK-8022658: Revisit FunctionalInterface on some core libs types

2013-10-21 Thread Mike Duigou
I am fine with all of these removals including Iterable. In some future world where Iterable can extend Supplier> then it can be revisited. Mike On Oct 21 2013, at 11:16 , Joe Darcy wrote: > Hello, > > Earlier in JDK 8, various core library classes were annotated with the > @FunctionalInter

hg: jdk8/tl/jdk: 8026842: Remove Time-Zone IDs HST/EST/MST

2013-10-21 Thread xueming . shen
Changeset: f0c18a5e3ae5 Author:sherman Date: 2013-10-21 11:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0c18a5e3ae5 8026842: Remove Time-Zone IDs HST/EST/MST Summary: removed these ids from ZoneId's zid list, supported via short_ids list Reviewed-by: okutsu ! make/tool

Re: JDK 8 RFR for JDK-8022658: Revisit FunctionalInterface on some core libs types

2013-10-21 Thread Joe Darcy
I was on the fence for Iterable too. Other opinions? Thanks, -Joe On 10/21/2013 11:47 AM, Brian Goetz wrote: Of these, the only one I might question is Iterable. While it is commonly used as a mixin like Closeable or Flushable, unlike the others, Iterables also make sense to stand on their o

Re: JDK 8 RFR for JDK-8022658: Revisit FunctionalInterface on some core libs types

2013-10-21 Thread Brian Goetz
Of these, the only one I might question is Iterable. While it is commonly used as a mixin like Closeable or Flushable, unlike the others, Iterables also make sense to stand on their own, and there are some libraries that truck entirely in Iterable to perform stream-like behavior (being the lea

JDK 8 RFR for JDK-8022658: Revisit FunctionalInterface on some core libs types

2013-10-21 Thread Joe Darcy
Hello, Earlier in JDK 8, various core library classes were annotated with the @FunctionalInterface annotation (JDK-8005623 Retrofit FunctionalInterface annotations to core platform interfaces). As experience has been gained with the feature, the time has come to revisit some of those annotati

Re: JDK 8 code review request for JDK-8025913 - Rename jdk.Supported to jdk.Exported

2013-10-21 Thread Joe Darcy
On 10/17/2013 10:45 PM, Joe Darcy wrote: Hello, Following up on the earlier feedback, please review the patch below with proposed clarifications to jdk.Exported. Thanks, -Joe Responding to Paul's comment on the earlier version, I've reordered and slightly amended the text as shown in the

Re: RFR: 8025909: Lambda Library Spec Updates

2013-10-21 Thread Paul Sandoz
Hi Henry, Collector: Typo in multiple places: that accumulate elements -> that accumulates elements Otherwise looks good. Paul. On Oct 16, 2013, at 12:34 AM, Henry Jen wrote: > Hi, > > Please kindly review the latest update on lambda library spec, and a few > minor code clean up. > > We

Re: RFR: 8020037: String.toLowerCase incorrectly increases length, if string contains \u0130 char

2013-10-21 Thread Naoto Sato
Looks good to me. Naoto On 10/21/13 2:29 AM, Yuka Kamiya wrote: Hi, This is a backout of wrong fix added in jdk 7. https://bugs.openjdk.java.net/browse/JDK-8020037 http://cr.openjdk.java.net/~peytoia/8020037/webrev.00/ Thanks, -- Yuka

hg: jdk8/tl/langtools: 8026956: test tools/javac/lambda/TargetType58.java is failing after a libs change

2013-10-21 Thread vicente . romero
Changeset: 9f876bd43f55 Author:vromero Date: 2013-10-21 15:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f876bd43f55 8026956: test tools/javac/lambda/TargetType58.java is failing after a libs change Reviewed-by: jfranck ! test/tools/javac/lambda/TargetType58.java

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread Volker Simonis
Hi Neil, Steve, is there an easy way to detect and specify a correct setting for $(BOOT_RTJAR) if we are using an IBM J9 as bootstrap jdk in the new build system? With OpenJDK/Oracle based boot jdks $(BOOT_RTJAR) is simply set to "$BOOT_JDK/jre/lib/rt.jar" but this doesn't work with IBM J9 because

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread Volker Simonis
Hi Erik, with the small changes proposed in "8026964: Building with an IBM J9 boot jdk requires special settings for BOOT_RTJAR" https://bugs.openjdk.java.net/browse/JDK-8026964 I could finally successfully build with J9 as bootstrap jdk. I saw that you already submitted this change so I'm prob

Re: RFR 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking

2013-10-21 Thread Alexander Zuev
Alan, thanks for a review, see my comments inline. On 10/20/13 23:15, Alan Bateman wrote: On 19/10/2013 16:14, Kumar Srinivasan wrote: Hi Alex, This looks good. Hi Sherman, Alan, Could one of you review this, please The "-n" options seems okay but I wonder if there has any thought given

Re: 8021257: com.sun.corba.se.** should be on restricted package list

2013-10-21 Thread Mark Sheppard
Hi Alan, Chris, yes, very happy to see the CORBA layers below the pure omg CORBA API packages being restricted. The reflection changes in the API layer look good, also. regards Mark On 21/10/2013 13:45, Chris Hegarty wrote: Very nice Alan. I have reviewed all the changes, and am happy to

Re: 8021257: com.sun.corba.se.** should be on restricted package list

2013-10-21 Thread Seán Coffey
Looks good to me too Alan. Thanks for taking care of this. After studying the class delegation code, it's now making sense to me why the initial package restriction failed. regards, Sean. On 21/10/13 13:45, Chris Hegarty wrote: Very nice Alan. I have reviewed all the changes, and am happy to

Re: RFR: 8004912: Repeating annotations - getAnnotationsByType is not working as expected

2013-10-21 Thread Andreas Lundblad
Hi, New revision up for review: http://aoeu.se/webrevs/8019420-and-8004912/webrev.01 The following has been addressed since webrev.00: - Order of directly / indirectly present annotations now respects the order of the keys in the given map of annotations. - A new test has been added to test t

Re: 8021257: com.sun.corba.se.** should be on restricted package list

2013-10-21 Thread Chris Hegarty
Very nice Alan. I have reviewed all the changes, and am happy to be listed as reviewer for both changesets, though Mark or Sean should also probably take a look at the corba changes. -Chris. On 21/10/2013 12:14, Alan Bateman wrote: Back in June, Sean Coffey had an attempt to add com.sun.co

hg: jdk8/tl/jdk: 7140929: NotSerializableNotifTest.java fails intermittently

2013-10-21 Thread jaroslav . bachorik
Changeset: 698baf22e081 Author:jbachorik Date: 2013-10-21 13:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/698baf22e081 7140929: NotSerializableNotifTest.java fails intermittently Reviewed-by: sjiang, alanb ! test/javax/management/remote/mandatory/notif/NotSerializableNo

8021257: com.sun.corba.se.** should be on restricted package list

2013-10-21 Thread Alan Bateman
Back in June, Sean Coffey had an attempt to add com.sun.corba.se.impl.** to the restricted package list. Problems arose and the change had to be backed out ([1] [2]]). Mark Sheppard and I have been looking at this one again and we would like to make a second attempt at this. The proposed pat

Re: RFR: 8009411 : getMethods should not inherit static methods from interfaces

2013-10-21 Thread Joel Borggrén-Franck
Hi All, http://cr.openjdk.java.net/~jfranck/8009411/webrev.03/ New webrev including the test originally contributed by Peter (I noticed the commit doesn't include Peter in contributed by, I have fixed that in my local copy). Static methods on implemented interfaces are now ignored in the searc

hg: jdk8/tl/jdk: 8024613: javax/management/remote/mandatory/connection/RMIConnector_NPETest.java failing intermittently

2013-10-21 Thread jaroslav . bachorik
Changeset: d8694ad1ed2d Author:jbachorik Date: 2013-10-21 10:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8694ad1ed2d 8024613: javax/management/remote/mandatory/connection/RMIConnector_NPETest.java failing intermittently Summary: RMID needs a varying amount of time to

hg: jdk8/tl/nashorn: 8026871: NASHORN TEST: Enable possibility to test Nashorn use of JavaFX canvas.

2013-10-21 Thread konstantin . shefov
Changeset: f22742d5daa3 Author:kshefov Date: 2013-10-21 13:31 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f22742d5daa3 8026871: NASHORN TEST: Enable possibility to test Nashorn use of JavaFX canvas. Reviewed-by: jlaskey, sundar ! make/build.xml ! make/project.properti

Re: JDK 8 RFC 4891331: BigInteger a.multiply(a) should use squaring code

2013-10-21 Thread Aleksey Shipilev
I'm with Joe on this. I think we should keep all cases from regressing. Having that, the patch is not really acceptable if it is degrading the mag.length < 8 cases. -Aleksey. On 10/18/2013 03:52 AM, Brian Burkhalter wrote: > Hi Joe, > > Will do. > > Thanks, > > Brian > > On Oct 17, 2013, at 4

hg: jdk8/tl/jdk: 8026499: Root Logger level can be reset unexpectedly

2013-10-21 Thread daniel . fuchs
Changeset: c81125493ca6 Author:dfuchs Date: 2013-10-21 12:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c81125493ca6 8026499: Root Logger level can be reset unexpectedly Summary: This fix prevents the logger's level to be re-initialized if it has already been initialized

RFR: 8020037: String.toLowerCase incorrectly increases length, if string contains \u0130 char

2013-10-21 Thread Yuka Kamiya
Hi, This is a backout of wrong fix added in jdk 7. https://bugs.openjdk.java.net/browse/JDK-8020037 http://cr.openjdk.java.net/~peytoia/8020037/webrev.00/ Thanks, -- Yuka

DecimalFormat regression bug in Java 8?

2013-10-21 Thread Lennart Börjeson
I've found what I believe is a DecimalFormat regression bug in Java 8, i.e. Java 8 seems to format some numbers differently than previous releases do. I've tried submitting a proper bug report using the form at bugreport.sun.com, but it just throws back a "submission error" at me, so I resort to

hg: jdk8/tl/jdk: 8016344: (props) Properties.storeToXML behaviour has changed from JDK 6 to 7

2013-10-21 Thread daniel . fuchs
Changeset: 567d47fd3fe2 Author:dfuchs Date: 2013-10-21 11:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/567d47fd3fe2 8016344: (props) Properties.storeToXML behaviour has changed from JDK 6 to 7 Summary: When storing Properties to XML only locally defined properties must b

hg: jdk8/tl/jdk: 7197919: java/lang/management/ThreadMXBean/ThreadBlockedCount.java has concurency issues

2013-10-21 Thread jaroslav . bachorik
Changeset: 30c46debdf0f Author:jbachorik Date: 2013-10-21 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30c46debdf0f 7197919: java/lang/management/ThreadMXBean/ThreadBlockedCount.java has concurency issues Reviewed-by: sla, mchung ! test/java/lang/management/ThreadMX

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread Volker Simonis
On Mon, Oct 21, 2013 at 9:02 AM, David Holmes wrote: > On 19/10/2013 1:15 AM, Volker Simonis wrote: >> >> Hi Erik, >> >> I had to fix another issue in the JAXWS build >> (https://bugs.openjdk.java.net/browse/JDK-8026874) but with that I've >> finally managed to get to the Corba build with a J9 boo

Re: Question about FileSystemProvider API in JDK7

2013-10-21 Thread Alan Bateman
On 21/10/2013 06:30, Pisarev, Vitaliy wrote: Hello, I was directed to this list by Brian Goetz, I am a new member and I am not yet acquainted with how things go in these mailing lists. I am an SW Engineer and I am looking for some insight about the new FileSystemProvider API. I posted a questi

hg: jdk8/tl/nashorn: 2 new changesets

2013-10-21 Thread sundararajan . athijegannathan
Changeset: d8aa87d292eb Author:hannesw Date: 2013-10-18 22:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d8aa87d292eb 8026858: Array length does not handle defined properties correctly Reviewed-by: jlaskey ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nasho

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread David Holmes
On 19/10/2013 1:50 AM, Erik Joelsson wrote: Hello Volker, Building without a -bootclasspath results in the following warning which is likely why it was added in the first place: warning: [options] bootstrap class path not set in conjunction with -source 1.7 Note that we are using the bootstrap

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread David Holmes
On 19/10/2013 1:15 AM, Volker Simonis wrote: Hi Erik, I had to fix another issue in the JAXWS build (https://bugs.openjdk.java.net/browse/JDK-8026874) but with that I've finally managed to get to the Corba build with a J9 bootstrap JDK. With the following small change in BuildCorba.gmk: -