Hi All, http://cr.openjdk.java.net/~jfranck/8009411/webrev.03/
New webrev including the test originally contributed by Peter (I noticed the commit doesn't include Peter in contributed by, I have fixed that in my local copy). Static methods on implemented interfaces are now ignored in the search for methods in getMethod() , and are filtered out from getMethods() calls. Tests run: jdk_lang (including the updated testing with this commit) jdk_beans1, jdk_beans2, jdk_beans3 please review cheers /Joel On 26 sep 2013, at 22:53, Joel Borggrén-Franck <joel.fra...@oracle.com> wrote: > Hi again, > > New webrev with more tests contributed by Amy Lu. > > http://cr.openjdk.java.net/~jfranck/8009411/webrev.02/ > > No change to non-test code since webrev.01 > > cheers > /Joel > > On 2013-09-12, Joel Borggrén-Franck wrote: >> Hi again, >> >> New webrev: http://cr.openjdk.java.net/~jfranck/8009411/webrev.01/ >> >> Thanks to Remi and Peter for the quick feedback, I've updated the code >> to use for-each as well as fixing getMethod(...). >> >> Andreas Lundblad also added ~100 testcases for getMethod(), both >> positive and negative. >> >> Please review >> >> cheers >> /Joel >> >> On 2013-09-09, Joel Borggrén-Franck wrote: >>> Hi >>> >>> Pleaser review fix for 8009411 : getMethods should not inherit static >>> methods from interfaces >>> >>> The issue is that since we added static methods to interfaces those have >>> erroneously been reflected in getMethods of implementing classes. This fix >>> filters out static interface methods from superinterfaces when adding >>> methods. I have also added a note to the javadoc for both getMembers and >>> getDeclaredMembers pointing this out (though it is implied from JLS). >>> Webrev is based on the clarification to getMethods and friends out for >>> review on this list. >>> >>> Webrev: http://cr.openjdk.java.net/~jfranck/8009411/webrev.00/ >>> Bug is here: http://bugs.sun.com/view_bug.do?bug_id=8009411 >>> >>> For oracle reviewers, ccc is approved. >>> >>> cheers >>> /Joel
