On 11/05/2013 11:11 AM, Joel Borggrén-Franck wrote:
On 5 nov 2013, at 10:51, Peter Levart wrote:
On 11/05/2013 10:33 AM, Joel Borggrén-Franck wrote:
I would also restructure the Method/Constructor accessor logic differently. The
check for ReflectUtil.isVMAnonymousClass() can be performed jus
Hi Alan,
On 06/11/13 09:05, Alan Bateman wrote:
On 05/11/2013 21:37, Rob McKenna wrote:
Apologies, I forgot to mention the dependency on:
8008118: (process) Possible null pointer dereference in
jdk/src/solaris/native/java/lang/UNIXProcess_md.c
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/011
Changeset: 75c8cde12ab6
Author:jlahoda
Date: 2013-11-06 17:48 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/75c8cde12ab6
8027281: Incorrect invokespecial generated for JCK lang
EXPR/expr636/expr63602m* tests
Summary: When invoking interface default method via a superc
Hi David,
The only difference in 5049299 is the change in the default property
value in Solaris. Apologies for not making that clear.
-Rob
On 06/11/13 01:09, David Holmes wrote:
Hi Rob,
How different is this to the JDK 8 version?
Thanks,
David
On 6/11/2013 7:24 AM, Rob McKenna wrote:
On 06/11/2013 13:30, Rob McKenna wrote:
Yes, absolutely. I'm looking for approval for the code in principle.
Particularly the change in the default property value on Solaris since
thats the only change. Once approved I will of course seek approval
for integration.
I think the proposal is reas
On 06/11/2013 03:51, Mike Duigou wrote:
I have updated the webrev to backout the changes to how JT_HOME is set. This
will be addressed in the next set of changes (8020779
https://bugs.openjdk.java.net/browse/JDK-8020779 and 8009683
https://bugs.openjdk.java.net/browse/JDK-8009683) which will
Thank you for the review!
On Nov 6 2013, at 09:11 , Alan Bateman wrote:
> On 06/11/2013 03:51, Mike Duigou wrote:
>> I have updated the webrev to backout the changes to how JT_HOME is set. This
>> will be addressed in the next set of changes (8020779
>> https://bugs.openjdk.java.net/browse/JDK
Looks fine.
thanks!
-Sherman
On 11/05/2013 03:21 PM, Aleksej Efimov wrote:
Sherman,
Thank you for a quick review. I totally agree with you on all items.
Actually, I missed fact that the transitions are sorted. And yes - the change
can be done on line #431.
The new tested fix can be found here
Changeset: 9c30cbc316e9
Author:mduigou
Date: 2013-11-05 19:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c30cbc316e9
8021309: replace test/Makefile jdk_* targets with jtreg groups
8015068: Use jtreg -exclude for handling problemList.txt exclusions
Reviewed-by: jjg, smark
On 05/11/2013 21:37, Rob McKenna wrote:
Apologies, I forgot to mention the dependency on:
8008118: (process) Possible null pointer dereference in
jdk/src/solaris/native/java/lang/UNIXProcess_md.c
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/0111bab8dc35
-Rob
To keep the changes the same f
Hi,
The latest spec and implementation of java.util.Base64.getXXXEncoder()
is to add appropriate padding character(s) at the end of the output
encoded data stream, to follow the note explicitly specified in the
RFC
Implementations MUST include appropriate pad characters at the end
of encod
On 11/06/2013 11:37 AM, Remi Forax wrote:
On 11/05/2013 11:11 AM, Joel Borggrén-Franck wrote:
On 5 nov 2013, at 10:51, Peter Levart wrote:
On 11/05/2013 10:33 AM, Joel Borggrén-Franck wrote:
I would also restructure the Method/Constructor accessor logic
differently. The check for ReflectUti
Hi,
We have a fix for JDK-8027848 and it was approved in parallel thread.
With '-XX:-UseMathExactIntrinsics' tests run flag and applied fix for
JDK-8027848 all tests from the following test sets are passing:
test/sun/util/calendar test/java/util/Calendar
test/sun/util/resources/TimeZone test/s
Sherman, thank you for reviewing it!
-Aleksej
On 11/06/2013 09:18 PM, Xueming Shen wrote:
Looks fine.
thanks!
-Sherman
On 11/05/2013 03:21 PM, Aleksej Efimov wrote:
Sherman,
Thank you for a quick review. I totally agree with you on all items.
Actually, I missed fact that the transitions are
On 11/05/2013 10:10 AM, Brian Goetz wrote:
Ineexof(char) sounds like as fast and simpler?
Well, indexOf(char) or lastIndexOf(char) searches for a single char. We
can do better searching backwards for two chars at the same time.
If the "name" of VM-anonymous class is always ending with patte
Hello all;
With JDK-8015068 only very recently pushed it's time for the next set of jtreg
test/Makfile changes. These changes improve the configure script detection of
jtreg and improve the handling of the specification variables in the jdk and
langtools test/Makefiles. This changeset is also t
Changeset: 6ea1f9d8ec78
Author:dxu
Date: 2013-11-06 13:25 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ea1f9d8ec78
8025698: (fs) Typo in exception thrown by encode() in UnixPath.java
Reviewed-by: dxu, mduigou, henryjen, weijun
Contributed-by: ajuc...@gmail.com
! src/solar
Changeset: 81cbdd5876e8
Author:ksrini
Date: 2013-11-06 11:22 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81cbdd5876e8
8027227: [asm] generate CONSTANT_InterfaceMethodref for invoke{special/static)
of non-abstract methods on ifaces
Reviewed-by: ksrini, lagergren
Contribute
On Nov 6, 2013, at 11:30 AM, Peter Levart wrote:
> Well, indexOf(char) or lastIndexOf(char) searches for a single char. We can
> do better searching backwards for two chars at the same time.
>
> If the "name" of VM-anonymous class is always ending with pattern: "slash
> followed by some decima
Hi all,
Please review the following spec changes to java.lang.String.
In several places the specs mention returning "new" strings. This is
overspecified; it's sufficient to return "a" string that satisfies the required
properties. In some cases the current implementation doesn't create a new s
John,
Just curious here - the String.indexOf(String) will have to fetch the arg
string from memory somewhere (how are constant pool entries handled by the
way? Is their address patched in or is it a lookup into the
StringTable?). If it's not in cache, that could be tens if not hundreds
of cycles
On 6/11/2013 10:00 PM, Rob McKenna wrote:
Hi David,
The only difference in 5049299 is the change in the default property
value in Solaris. Apologies for not making that clear.
Given this was primarily aimed at Solaris in the first place it seems
strange to me to not make the change on Solaris
Hi Stuart,
On 7/11/2013 11:31 AM, Stuart Marks wrote:
Hi all,
Please review the following spec changes to java.lang.String.
In several places the specs mention returning "new" strings. This is
overspecified; it's sufficient to return "a" string that satisfies the
required properties. In some c
Hi Everyone,
I am working on https://bugs.openjdk.java.net/browse/JDK-8019502. The
problem is, some java.util test does use ${TESTVMOPTS} to launch java
program in script. Then it may lose VM setting from high level.
The fix will refer to https://bugs.openjdk.java.net/browse/JDK-8003890
fini
On 11/6/13 10:45 AM, Amy Lu wrote:
On 11/5/13 7:09 PM, Amy Lu wrote:
On 11/5/13 6:01 PM, Alan Bateman wrote:
On 05/11/2013 09:26, Amy Lu wrote:
:
Please review ProblemList.txt changes:
https://dl.dropboxusercontent.com/u/5812451/yl153753/8027822/webrev/index.html
This looks okay to me alth
On Nov 6, 2013, at 5:32 PM, Boris Davidovich wrote:
> Am I missing something?
>
The intrinsic would be looking at a constant string. — John
26 matches
Mail list logo
