Thank you for the review! On Nov 6 2013, at 09:11 , Alan Bateman <alan.bate...@oracle.com> wrote:
> On 06/11/2013 03:51, Mike Duigou wrote: >> I have updated the webrev to backout the changes to how JT_HOME is set. This >> will be addressed in the next set of changes (8020779 >> https://bugs.openjdk.java.net/browse/JDK-8020779 and 8009683 >> https://bugs.openjdk.java.net/browse/JDK-8009683) which will revisit how >> JT_HOME is set and how the jtreg executable is found. >> >> http://cr.openjdk.java.net/~mduigou/JDK-8015068/4/webrev/ >> >> Mike >> > I've skimmed over the lastest webrev and it looks very good (and great to see > the use of groups and the removal of the exclude list cruft). > > On the excluded=CODETOOLS-7900176 output then maybe this should be left out > for now as the Makefile will need to be updated if/when there is a way to get > the count of the number of tests excluded. I will remove "excluded" entirely for now then. Mike > -Alan.