Deadlock between FileHandler and ConsoleHandler when using customized formatter

Hi, We get a deadlock between java.util.logging.FileHandler and java.util.logging.ConsoleHandler when we are using a customized formatter in these handlers. Here is the simple test case. http://cr.openjdk.java.net/~zhangshj/deadlockInHandlers/deadlockInHandlers.zip Run "java -Djava.util.lo

hg: jdk8/tl/jdk: 8021418: Intermittent: SSLSocketSSLEngineTemplate.java test fails with timeout

Changeset: 5ac7cd164300 Author:juh Date: 2013-11-27 15:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ac7cd164300 8021418: Intermittent: SSLSocketSSLEngineTemplate.java test fails with timeout Reviewed-by: xuelei, wetmore Contributed-by: rajan.hal...@oracle.com ! test/su

Re: 8029281: Synchronization issues in Logger and LogManager

Hi Daniel, I have started looking at the LogManager change first, and here's the 1st race I found... The new method LoggerWeakRef.dispose() can be called from 3 places: - LoggerContext.addLocalLogger - LoggerContext.findLogger - LogManager.drainLoggerRefQueueBounded which is called from publ

Re: JDK 8 RFR 4891331: BigInteger a.multiply(a) should use squaring code

Hi Brian, Looks good; approved to go back. Thanks, -Joe On 11/27/2013 11:39 AM, Brian Burkhalter wrote: Continuing from the end of this thread http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-October/022399.html ... Issue: https://bugs.openjdk.java.net/browse/JDK-4891331

JDK 8 RFR 4891331: BigInteger a.multiply(a) should use squaring code

Continuing from the end of this thread http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-October/022399.html ... Issue: https://bugs.openjdk.java.net/browse/JDK-4891331 Webrev: http://cr.openjdk.java.net/~bpb/4891331/webrev.2 After running more micro-benchmark performan

8029281: Synchronization issues in Logger and LogManager

Hi, Please find below a webrev for: 8029281: Synchronization issues in Logger and LogManager

hg: jdk8/tl/jdk: 8028771: regression test java/util/Locale/LocaleProviders.sh failed

Changeset: 2370d285d08b Author:naoto Date: 2013-11-27 10:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2370d285d08b 8028771: regression test java/util/Locale/LocaleProviders.sh failed Reviewed-by: alanb ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

On 11/27/2013 2:03 AM, Alan Bateman wrote: On 26/11/2013 22:13, huizhe wang wrote: Ah, I missed that. I took it for granted that since ServiceLoader.load(service) uses TCCL, load(service, null) would use TCCL. I've updated the webrev now: http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/802

Re: Review Request for 8029216: (jdeps) Provide a specific option to report JDK internal APIs

On 11/27/2013 7:52 AM, Dalibor Topic wrote: On 11/27/13 1:04 PM, Alan Bateman wrote: On 26/11/2013 23:59, Mandy Chung wrote: This is a simple patch that adds a new jdeps -jdkinternals option to make it easier for developers to find dependencies on the JDK internal APIs: http://cr.openjdk.java

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

On 11/27/2013 02:40 PM, David Chase wrote: On 2013-11-27, at 6:53 AM, Peter Levart wrote: Ah, I have misunderstood the back-porting issue. It was not about not having new class but about which existing class to use as a host that might not exist in older version of platform... Sorry for nois

Re: Review Request for 8029216: (jdeps) Provide a specific option to report JDK internal APIs

On 11/27/13 1:04 PM, Alan Bateman wrote: > On 26/11/2013 23:59, Mandy Chung wrote: >> This is a simple patch that adds a new jdeps -jdkinternals option to make it >> easier for developers to find dependencies on the JDK internal APIs: >> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8029216/webr

Re: Poor Javadoc of Map default methods [Re: RFR: 8029055: Map.merge must refuse null values]

On 26 November 2013 17:35, Martin Buchholz wrote: > I haven't looked in depth, but I agree with Stephen's analysis. This API > and its javadoc needs work. > E.g. It's not clear that the purpose of Map.compute is to *update* the > mapping for key in the map. I actually felt that the names of all

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

On 2013-11-27, at 6:53 AM, Peter Levart wrote: > Ah, I have misunderstood the back-porting issue. It was not about not having > new class but about which existing class to use as a host that might not > exist in older version of platform... > > Sorry for noise. Noise is okay. This fix was a

Re: Request to review JDK-8028094

Hi Martin, I have incorporated your contribution into following webrev. Please review the changes. http://cr.openjdk.java.net/~bvaidya/8/8028094/webrev.01/ I have tested it on a linux machine, and the test is passing. The sleep processes are killed when the pkill command exists on the mach

Re: Review Request for 8029216: (jdeps) Provide a specific option to report JDK internal APIs

On 26/11/2013 23:59, Mandy Chung wrote: This is a simple patch that adds a new jdeps -jdkinternals option to make it easier for developers to find dependencies on the JDK internal APIs: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8029216/webrev.00/ This looks good (and I can't think of a be

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

On 11/27/2013 11:03 AM, David Holmes wrote: Hi Peter, On 27/11/2013 7:20 PM, Peter Levart wrote: On 11/27/2013 08:40 AM, David Holmes wrote: On 27/11/2013 2:16 AM, David Chase wrote: On 2013-11-26, at 8:12 AM, David Chase wrote: On 2013-11-26, at 7:32 AM, David Holmes wrote: On 26/11/2013

Re: RFR 8029164: Race condition in CompletableFuture.thenCompose with asynchronous task

Looks good to me Paul. -Chris. On 27/11/13 11:02, Paul Sandoz wrote: Hi, https://bugs.openjdk.java.net/browse/JDK-8029164 http://cr.openjdk.java.net/~psandoz/tl/JDK-8029164-thenCompose-async/webrev/ This fixes an issue with CompletableFuture.thenCompose. If the composing future is already c

RFR 8029164: Race condition in CompletableFuture.thenCompose with asynchronous task

Hi, https://bugs.openjdk.java.net/browse/JDK-8029164 http://cr.openjdk.java.net/~psandoz/tl/JDK-8029164-thenCompose-async/webrev/ This fixes an issue with CompletableFuture.thenCompose. If the composing future is already completed before the call to thenCompose (or completes during some part

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

Hi Peter, On 27/11/2013 7:20 PM, Peter Levart wrote: On 11/27/2013 08:40 AM, David Holmes wrote: On 27/11/2013 2:16 AM, David Chase wrote: On 2013-11-26, at 8:12 AM, David Chase wrote: On 2013-11-26, at 7:32 AM, David Holmes wrote: On 26/11/2013 10:16 PM, David Chase wrote: On 2013-11-26,

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

On 26/11/2013 22:13, huizhe wang wrote: Ah, I missed that. I took it for granted that since ServiceLoader.load(service) uses TCCL, load(service, null) would use TCCL. I've updated the webrev now: http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/8028822/webrev/ It looks good now but I'm still

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

On 11/27/2013 08:40 AM, David Holmes wrote: On 27/11/2013 2:16 AM, David Chase wrote: On 2013-11-26, at 8:12 AM, David Chase wrote: On 2013-11-26, at 7:32 AM, David Holmes wrote: On 26/11/2013 10:16 PM, David Chase wrote: On 2013-11-26, at 7:12 AM, David Holmes wrote: On 26/11/2013 9

Re: Proposed fix for JDK-8028804 (Deflater.deflateBytes() may produce corrupted output on Deflater level/strategy change)

> > > My personal view is that we should link to libz where possible (already > so on Mac, but not the default on Linux or Solaris). Clearly we still have > to allow for platforms where it doesn't exist (Windows only I think) and in > that case we should periodically update it (as we did in both