hg: jdk8/tl/corba: 2 new changesets

Changeset: 5029f982dfae Author:cl Date: 2013-11-28 08:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5029f982dfae Added tag jdk8-b118 for changeset d6820a414f18 ! .hgtags Changeset: 379fc7609beb Author:lana Date: 2013-12-03 10:46 -0800 URL: http://hg.ope

hg: jdk8/tl: 2 new changesets

Changeset: 06d512d44c31 Author:cl Date: 2013-11-28 08:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/06d512d44c31 Added tag jdk8-b118 for changeset 0a6db1aac998 ! .hgtags Changeset: 9e90215673be Author:lana Date: 2013-12-03 10:46 -0800 URL: http://hg.openjdk.j

hg: jdk8/tl/langtools: 3 new changesets

Changeset: 1f6ffcd56363 Author:cl Date: 2013-11-28 08:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1f6ffcd56363 Added tag jdk8-b118 for changeset 4fd6a7ff8c06 ! .hgtags Changeset: 43a80d75d06e Author:lana Date: 2013-12-03 10:47 -0800 URL: http://hg

Initial with JDK-7168267

Hi Stuart I am working on https://bugs.openjdk.java.net/browse/JDK-7168267. This bug is asking performance improvement for RMI test. Because this would involve different RMI tests. I'd like to use this cr as an umbrella bug, create sub-cr for different test. Then I can make progress on sub-cr.

hg: jdk8/tl/jdk: 8028816: Add value-type notice to Optional* classes

Changeset: 2aae624bb833 Author:briangoetz Date: 2013-12-03 21:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2aae624bb833 8028816: Add value-type notice to Optional* classes Reviewed-by: mduigou, smarks Contributed-by: bitterf...@gmail.com + src/share/classes/java/lang/do

JDK 8 RFR for JDK-8023471, , Add compatibility note to AnnotatedElement

Hello, Please review the patch below to address JDK-8023471 Add compatibility note to AnnotatedElement Thanks, -Joe diff -r cd4aabc40f72 src/share/classes/java/lang/reflect/AnnotatedElement.java --- a/src/share/classes/java/lang/reflect/AnnotatedElement.java Tue Dec 03 11:52:18 2013 -08

Re: RFR: 8028816: Add value-type notice to Optional* classes

On Dec 3 2013, at 18:06 , Stuart Marks wrote: > Overall looks fine. > > If you're listing yourself as the reviewer, jcheck will object if you're also > the changeset author. Instead of listing Brian Goetz in Contributed-by, make > him the changeset author instead. Using MQ, do "hg qref -u bri

hg: jdk8/tl/jdk: 8029489: StringJoiner spec for setEmptyValue() and length() is malformatted

Changeset: c6b6b515cf4f Author:smarks Date: 2013-12-03 18:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6b6b515cf4f 8029489: StringJoiner spec for setEmptyValue() and length() is malformatted Reviewed-by: darcy, lancea, mduigou ! src/share/classes/java/util/StringJoiner

Re: RFR: 8028816: Add value-type notice to Optional* classes

Overall looks fine. If you're listing yourself as the reviewer, jcheck will object if you're also the changeset author. Instead of listing Brian Goetz in Contributed-by, make him the changeset author instead. Using MQ, do "hg qref -u briangoetz". The gist of the paragraph being added to each

hg: jdk8/tl/jdk: 8028397: Undo the lenient MIME BASE64 decoder support change (JDK-8025003) and remove methods de/encode(buf, buf)

Changeset: 301d76b8cb55 Author:sherman Date: 2013-12-03 17:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/301d76b8cb55 8028397: Undo the lenient MIME BASE64 decoder support change (JDK-8025003) and remove methods de/encode(buf, buf) Summary: updated the spec and implement

Re: RFR: 8029489: StringJoiner spec for setEmptyValue() and length() is malformatted

Hi Stuart, Looks good; thanks, -Joe On 12/3/2013 5:40 PM, Stuart Marks wrote: Hi all, Please review the following small javadoc change. The StringJoiner doc for a couple methods uses "i.e." in the first sentence, which screws up the javadoc logic that pulls the first sentence into the Metho

Re: RFR: 8029489: StringJoiner spec for setEmptyValue() and length() is malformatted

Looks fine. On Dec 3 2013, at 17:40 , Stuart Marks wrote: > Hi all, > > Please review the following small javadoc change. The StringJoiner doc for a > couple methods uses "i.e." in the first sentence, which screws up the javadoc > logic that pulls the first sentence into the Method Summary. T

Re: RFR: 8029489: StringJoiner spec for setEmptyValue() and length() is malformatted

looks OK On Dec 3, 2013, at 8:40 PM, Stuart Marks wrote: > Hi all, > > Please review the following small javadoc change. The StringJoiner doc for a > couple methods uses "i.e." in the first sentence, which screws up the javadoc > logic that pulls the first sentence into the Method Summary. This

RFR: 8029489: StringJoiner spec for setEmptyValue() and length() is malformatted

Hi all, Please review the following small javadoc change. The StringJoiner doc for a couple methods uses "i.e." in the first sentence, which screws up the javadoc logic that pulls the first sentence into the Method Summary. This is an editorial change to fix this up; there is no actual specifi

Re: JDK 8 RFR 8029501: BigInteger division algorithm selection heuristic is incorrect

Looks good Brian; thanks, -Joe On 12/3/2013 5:33 PM, Brian Burkhalter wrote: Hello, Issue: https://bugs.openjdk.java.net/browse/JDK-8029501 Webrev: http://cr.openjdk.java.net/~bpb/8029501/webrev/ This patch would change the division algorithm selection heuristic as previously described in [

JDK 8 RFR 8029501: BigInteger division algorithm selection heuristic is incorrect

Hello, Issue: https://bugs.openjdk.java.net/browse/JDK-8029501 Webrev: http://cr.openjdk.java.net/~bpb/8029501/webrev/ This patch would change the division algorithm selection heuristic as previously described in [1]. Many subsequent performance benchmark runs have determined that the threshol

hg: jdk8/tl/jdk: 2 new changesets

Changeset: d922c8aba2f8 Author:valeriep Date: 2013-12-03 17:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d922c8aba2f8 8029158: sun/security/pkcs11/Signature/TestDSAKeyLength.java does not compile (or run) Summary: Add the missing library path and skip testing against NS

hg: jdk8/tl/jdk: 8029281: Synchronization issues in Logger and LogManager

Changeset: 9f624e115c6b Author:dfuchs Date: 2013-12-04 01:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f624e115c6b 8029281: Synchronization issues in Logger and LogManager Summary: Fixes several race conditions in logging which have been at the root cause of intermitte

hg: jdk8/tl/jdk: 8028351: JWS doesn't get authenticated when using kerberos auth proxy

Changeset: e1bc55ddf1ad Author:weijun Date: 2013-12-04 09:14 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e1bc55ddf1ad 8028351: JWS doesn't get authenticated when using kerberos auth proxy Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule

hg: jdk8/tl/jdk: 8028757: CharSequence.subSequence improperly requires a "new" CharSequence be returned

Changeset: accd6ffd4b3f Author:smarks Date: 2013-12-03 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/accd6ffd4b3f 8028757: CharSequence.subSequence improperly requires a "new" CharSequence be returned Reviewed-by: alanb, darcy, mduigou ! src/share/classes/java/lang/C

Re: Theoretical data race on java.util.logging.Handler.sealed

On 12/3/2013 1:44 AM, Peter Levart wrote: On 12/03/2013 09:51 AM, Peter Levart wrote: Hi, While browsing the code of java.util.logging.Handler, I noticed a theoretical possibility that a security check in a j.u.l.StreamHandler be circumvented using a data race. There is a plain boolean ins

hg: jdk8/tl/jdk: 7190106: java/rmi/reliability/benchmark fails intermittently because of use of fixed port

Changeset: df819e356901 Author:tyan Date: 2013-12-03 14:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df819e356901 7190106: java/rmi/reliability/benchmark fails intermittently because of use of fixed port Reviewed-by: smarks, mduigou ! test/ProblemList.txt ! test/java/r

Re: RFR: 8029055: Map.merge must refuse null values

On Nov 26 2013, at 05:35 , Stephen Colebourne wrote: > See the new thread for the general Javadoc issues. I'll focus on null here. > > Given a map {"Key" -> null} I find the notion that putIfAbsent() or > computeIfAbsent() ignore the existing mapping just plain wrong. While > I can rationalise

RFR: 8028816: Add value-type notice to Optional* classes

Hello all; There's been a discussion on the lambda spec experts list (http://mail.openjdk.java.net/pipermail/lambda-spec-experts/) about adding a notice to the Optional classes about implications of their likely future as values. This discussion recently completed so now there's a doc patch to

hg: jdk8/tl/langtools: 8025416: doclet not substituting {@docRoot} in some cases

Changeset: 4cb9de4dd420 Author:bpatel Date: 2013-12-03 14:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4cb9de4dd420 8025416: doclet not substituting {@docRoot} in some cases Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.j

hg: jdk8/tl/jdk: 8028019: AWT Doclint warning/error cleanup

Changeset: 3e95aadb479f Author:rriggs Date: 2013-12-03 16:20 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e95aadb479f 8028019: AWT Doclint warning/error cleanup Summary: Fix numerious javadoc and html errors and warnings Reviewed-by: yan ! src/share/classes/java/applet/Ap

RFR: JDK-8029117: (reflect) clarify javadoc for getMethod(...) and getMethods()

Hi Please review this javadoc fix for Class.getMethod(name, params) and Class.getMethods() when called on an interface. This fix aligns the javadoc with the long standing implementation to not return any implicitly declared object methods when calling getMethod(s) on an interface. Bug: https:

Re: 8029281: Synchronization issues in Logger and LogManager

On 12/3/2013 10:57 AM, Daniel Fuchs wrote: Hi Mandy, I have updated the webrev taking your comments into account. Looks much cleaner. Thanks for the update. Nit LogManager.java L1050: formatting - one extra space. No need to

hg: jdk8/tl/jdk: 8022181: Tune algorithm crossover thresholds in BigInteger

Changeset: c138b0d33980 Author:bpb Date: 2013-12-03 12:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c138b0d33980 8022181: Tune algorithm crossover thresholds in BigInteger Summary: Change multiplication, squaring, division, and base conversion thresholds to values which

Re: RFR: MethodHandles.Lookup. Wrong access verification

Thanks. I would like to add the test[1] prior to fixing it. JDK 7 shows the same behavior. As i am not an author of any openjdk-project but i signed the OCA some time ago i would love to find and sponsor for this[1]. — Sebastian Am 03.12.2013 01:08, schrieb John Rose: > I appreciate the report

Re: RFR: 8028757: CharSequence.subSequence improperly requires a "new" CharSequence be returned

On 03/12/2013 18:15, Stuart Marks wrote: Hi all, Please review this small change to the subSequence() method specs of CharSequence and String. Essentially this removes the requirement of returning a "new" character sequence at each call. This brings the spec in line with String's implementati

hg: jdk8/tl/jdk: 8029475: Fix more doclint issues in javax.security

Changeset: cd4aabc40f72 Author:darcy Date: 2013-12-03 11:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd4aabc40f72 8029475: Fix more doclint issues in javax.security Reviewed-by: juh ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/CipherSpi

Re: RFR: 8029434: Spliterator of Stream returned by BufferedReader.lines() should have NONNULL characteristic

Go ahead with pushing 8029483 as no approval is required for doc only change. Mike On Dec 3 2013, at 11:49 , Henry Jen wrote: > I have separated the fix into two part, > > 8029434: Spliterator of Stream returned by BufferedReader.lines() should have > NONNULL characteristic > > 8029483: Buff

Re: RFR: 8029434: Spliterator of Stream returned by BufferedReader.lines() should have NONNULL characteristic

I have separated the fix into two part, 8029434: Spliterator of Stream returned by BufferedReader.lines() should have NONNULL characteristic 8029483: BufferedReader.lines() javadoc typo should be fixed So that we can at least fix the javadoc by jdk8 release if not the characteristic. Cheer

hg: jdk8/tl/jdk: 8029483: BufferedReader.lines() javadoc typo should be fixed

Changeset: 1061f4d085b5 Author:henryjen Date: 2013-12-03 11:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1061f4d085b5 8029483: BufferedReader.lines() javadoc typo should be fixed Reviewed-by: mduigou ! src/share/classes/java/io/BufferedReader.java

Re: RFR: 8028757: CharSequence.subSequence improperly requires a "new" CharSequence be returned

The changes look OK. The needs of mutable CharSequences to isolate the subsequence changes seems adequately handled in the mutable classes. Mike On Dec 3 2013, at 10:15 , Stuart Marks wrote: > Hi all, > > Please review this small change to the subSequence() method specs of > CharSequence an

Re: 8029281: Synchronization issues in Logger and LogManager

Hi Mandy, I have updated the webrev taking your comments into account. Changes are small and outlined below: On 12/3/13 1:49 AM, Mandy Chung wrote: On 11/29/2013 3:41 AM, Daniel Fuchs wrote: Hi, Here is a new revision that inclu

Re: 8029281: Synchronization issues in Logger and LogManager

On 12/3/13 8:36 AM, Peter Levart wrote: Hi Daniel, 1st sorry for the delay. I promised looking at the patch, but was then distracted by other things. I think that synchronization in LogManager is correct now. The fact that Mandy thinks so is also reassuring. Yes - that's usually a good sign :-

RFR: 8029434: Spliterator of Stream returned by BufferedReader.lines() should have NONNULL characteristic

Hi, Please review a small fix that add missing NONNULL characteristic and cleanup in javadoc. Thanks Anthony Vanelverdinghe for reporting of this bug. http://cr.openjdk.java.net/~henryjen/tl/8029434/0/webrev/ Cheers, Henry

hg: jdk8/tl/langtools: 8029179: javac produces a compile error for valid boolean expressions

Changeset: fb8c59cf26c8 Author:vromero Date: 2013-12-03 18:13 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fb8c59cf26c8 8029179: javac produces a compile error for valid boolean expressions Reviewed-by: jjg, jlahoda ! src/share/classes/com/sun/tools/javac/parser/Java

RFR: 8028757: CharSequence.subSequence improperly requires a "new" CharSequence be returned

Hi all, Please review this small change to the subSequence() method specs of CharSequence and String. Essentially this removes the requirement of returning a "new" character sequence at each call. This brings the spec in line with String's implementation, which will return 'this' in appropriat

hg: jdk8/tl/jdk: 8029478: Fix more doclint issues in javax.script

Changeset: 1c3d58caa7da Author:darcy Date: 2013-12-03 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c3d58caa7da 8029478: Fix more doclint issues in javax.script Reviewed-by: chegar, mduigou ! src/share/classes/javax/script/ScriptEngineFactory.java

hg: jdk8/tl/langtools: 8028699: Compiler crash during speculative attribution of annotated type

Changeset: a746587a1ff1 Author:jlahoda Date: 2013-12-03 18:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a746587a1ff1 8028699: Compiler crash during speculative attribution of annotated type Summary: Moving the checkForDeclarationAnnotations check into Attr.TypeAnn

Re: JDK 8 RFR of javax.script doclint fixes

Hi, Not specific to your change, but the previous sentences end in ";" in some cases and ":" in others. I thing ":" colon is more natural. Roger On 12/3/2013 12:55 PM, roger riggs wrote: Hi Joe, looks fine, Not a reviewer, Roger On 12/3/2013 12:49 PM, Joe Darcy wrote: Hello, Please revi

Re: JDK 8 RFR of javax.script doclint fixes

Looks fine to me Joe. -Chris. On 3 Dec 2013, at 17:49, Joe Darcy wrote: > Hello, > > Please review the patch before which addresses a handful of doclint issues in > javax.script. > > Thanks, > > -Joe > > diff -r c11553506228 src/share/classes/javax/script/ScriptEngineFactory.java > --- a/sr

Re: JDK 8 RFR of javax.script doclint fixes

Hi Joe, looks fine, Not a reviewer, Roger On 12/3/2013 12:49 PM, Joe Darcy wrote: Hello, Please review the patch before which addresses a handful of doclint issues in javax.script. Thanks, -Joe diff -r c11553506228 src/share/classes/javax/script/ScriptEngineFactory.java --- a/src/share/

Re: JDK 8 RFR of javax.script doclint fixes

Approved. On Dec 3 2013, at 09:49 , Joe Darcy wrote: > Hello, > > Please review the patch before which addresses a handful of doclint issues in > javax.script. > > Thanks, > > -Joe > > diff -r c11553506228 src/share/classes/javax/script/ScriptEngineFactory.java > --- a/src/share/classes/jav

JDK 8 RFR of javax.script doclint fixes

Hello, Please review the patch before which addresses a handful of doclint issues in javax.script. Thanks, -Joe diff -r c11553506228 src/share/classes/javax/script/ScriptEngineFactory.java --- a/src/share/classes/javax/script/ScriptEngineFactory.javaTue Dec 03 08:53:23 2013 +0100 +++ b/

hg: jdk8/tl/jdk: 8029127: Redirected POST request throws IllegalStateException on HttpURLConnection.getInputStream

Changeset: e01c6e0bf8ae Author:michaelm Date: 2013-12-03 17:29 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e01c6e0bf8ae 8029127: Redirected POST request throws IllegalStateException on HttpURLConnection.getInputStream Reviewed-by: alanb, chegar ! src/share/classes/sun/ne

Re: RFR [6968459] JNDI timeout fails before timeout is reached

On 12/03/2013 03:35 PM, Ivan Gerasimov wrote: Hi Peter! Thank you for your review! You are right, the patch changed the behavior of the code. I've reverted back all the unnecessary changes. This should minimize the risk. I've also made another correction: After decrementing the remaining ti

Re: RFR [6968459] JNDI timeout fails before timeout is reached

Hello Ivan, Thanks for the updated patch. I would like to see a testcase along with this fix, since it is modifying a critical component of the LDAP client code. An LDAP server may not even be required in order to exercise the timeouts. Thanks. On 3 Dec 2013, at 14:35, Ivan Gerasimov wrote:

Re: RFR [6968459] JNDI timeout fails before timeout is reached

Hi Peter! Thank you for your review! You are right, the patch changed the behavior of the code. I've reverted back all the unnecessary changes. This should minimize the risk. I've also made another correction: After decrementing the remaining timeOut, the startTime should be set to currTime.

Re: Review Request for 8029216: (jdeps) Provide a specific option to report JDK internal APIs

On 02/12/2013 21:49, Mandy Chung wrote: On 11/27/13 4:04 AM, Alan Bateman wrote: On 26/11/2013 23:59, Mandy Chung wrote: This is a simple patch that adds a new jdeps -jdkinternals option to make it easier for developers to find dependencies on the JDK internal APIs: http://cr.openjdk.java.net

Re: RFR [6968459] JNDI timeout fails before timeout is reached

On 11/29/2013 09:06 PM, Ivan Gerasimov wrote: Thank you Alan for the reply! On 29.11.2013 21:03, Alan Bateman wrote: On 19/11/2013 17:58, Ivan Gerasimov wrote: Hello all! Would you please help review a fix for the bug? https://bugs.openjdk.java.net/browse/JDK-6968459 It was reported that cre

Re: Theoretical data race on java.util.logging.Handler.sealed

On 12/03/2013 09:51 AM, Peter Levart wrote: Hi, While browsing the code of java.util.logging.Handler, I noticed a theoretical possibility that a security check in a j.u.l.StreamHandler be circumvented using a data race. There is a plain boolean instance field 'sealed' in j.u.l.Handler that

Theoretical data race on java.util.logging.Handler.sealed

Hi, While browsing the code of java.util.logging.Handler, I noticed a theoretical possibility that a security check in a j.u.l.StreamHandler be circumvented using a data race. There is a plain boolean instance field 'sealed' in j.u.l.Handler that is pre-initialized to 'true' in field initial