Hi,
could you please review the following changes for the ppc-aix-port
stage/stage-9 repositories (the changes are planned for integration into
ppc-aix-port/stage-9 and subsequent backporting to ppc-aix-port/stage):
http://cr.openjdk.java.net/~simonis/webrevs/8031581/
I've build and smoke
On 14/01/2014 08:40, Volker Simonis wrote:
Hi,
could you please review the following changes for the ppc-aix-port
stage/stage-9 repositories (the changes are planned for integration
into ppc-aix-port/stage-9 and subsequent backporting to
ppc-aix-port/stage):
I'd like to review this but I
On 14/01/2014 01:11, Joe Darcy wrote:
:
A few comments on the changes. In java/security/cert/* the tests were
intentionally creating a corrupted set to make sure it was rejected
properly.
See JDK-8005937 [1] for a previous attempt to remove the the -source 1.4
from these tests.
-Alan
Hi Alan,
On Tue, Jan 14, 2014 at 10:19 AM, Alan Bateman alan.bate...@oracle.comwrote:
On 14/01/2014 08:40, Volker Simonis wrote:
Hi,
could you please review the following changes for the ppc-aix-port
stage/stage-9 repositories (the changes are planned for integration into
On 1/14/14 2:11 AM, Joe Darcy wrote:
Hello,
Per the policy set forth in
JEP 182: Policy for Retiring javac -source and -target Options
http://openjdk.java.net/jeps/182
in JDK 9, javac will only recognize javac source and target value of
6/1.6 and higher. Therefore, uses of earlier
Since Martin has removed completely the '@compile -source 1.5 XXX’ lines from
the 166 CVS, you can amend your patch to do the same, or we can file a separate
bug to bring in these change. Whatever suits you, just let me know.
-Chris.
On 14 Jan 2014, at 02:30, Martin Buchholz
Just a note on this part (I havent looked at the code):
On AIX, the constants used for the polling events (i.e. POLLIN, POLLOUT, ...)
are defined to different values than on other operating systems. The problem is
however, that these constants are hardcoded as public final static members of
Okay. But I think we all agree we should at least bring this test back
for further tacking.
http://cr.openjdk.java.net/~tyan/JDK-7027502/webrev.06/
Thank you.
Tristan
On 01/14/2014 10:39 AM, David Holmes wrote:
On 13/01/2014 4:21 PM, Tristan Yan wrote:
Hi All
I add more trace output to
Hi Tristan,
See below for a patch.
The location of the code seems a little out of place with the other code. I
would have expected a structure such as:
stream/parallel/*.java
where the source code is in the default no-package.
I am not yet convinced of the value of the RandomPrimeNumber
On 14/01/2014 12:40, Tristan Yan wrote:
Okay. But I think we all agree we should at least bring this test back
for further tacking.
http://cr.openjdk.java.net/~tyan/JDK-7027502/webrev.06/
This make sense so I think this should be pushed. If JDK-7027502 is used
for this then the synopsis
A recent change, JDK-8029007 introduced JNU_ThrowOutOfMemoryError into
MessageUtils. The Windows x86 build subsequently fails as follows:
Warning (shows the root cause):
c:/jprt/T/P1/113753.chhegar/s/jdk/src/share/native/sun/misc/MessageUtils.c(58)
: warning C4013: 'JNU_ThrowOutOfMemoryError'
Thank you Alan. I have changed this bug's synopsis.
Is it okay you could push this?
Tristan
On 01/14/2014 09:48 PM, Alan Bateman wrote:
On 14/01/2014 12:40, Tristan Yan wrote:
Okay. But I think we all agree we should at least bring this test
back for further tacking.
On 14/01/2014 13:56, Chris Hegarty wrote:
A recent change, JDK-8029007 introduced JNU_ThrowOutOfMemoryError into
MessageUtils. The Windows x86 build subsequently fails as follows:
Warning (shows the root cause):
c:/jprt/T/P1/113753.chhegar/s/jdk/src/share/native/sun/misc/MessageUtils.c(58)
:
On 14 Jan 2014, at 14:03, Alan Bateman alan.bate...@oracle.com wrote:
On 14/01/2014 13:56, Chris Hegarty wrote:
A recent change, JDK-8029007 introduced JNU_ThrowOutOfMemoryError into
MessageUtils. The Windows x86 build subsequently fails as follows:
Warning (shows the root cause):
On Tue, Jan 14, 2014 at 12:29 PM, David Holmes david.hol...@oracle.comwrote:
Just a note on this part (I havent looked at the code):
On AIX, the constants used for the polling events (i.e. POLLIN, POLLOUT,
...) are defined to different values than on other operating systems. The
problem is
Hi Chris,
Sorry that I did not check my previous change carefully on Windows.
Thanks for fixing the issue. The change looks good to me.
-Dan
On 01/14/2014 06:06 AM, Chris Hegarty wrote:
On 14 Jan 2014, at 14:03, Alan Bateman alan.bate...@oracle.com wrote:
On 14/01/2014 13:56, Chris
Hi David,
The CHECK_RETURN macros have existed in java.net for some time and
I have not seen any empty statement warnings.
The CHECK_EXCEPTION macros are new and does not have any uses yet.
I don't plan to do any wholesale modification of current sources.
The macros always produce a valid
Hi Chris,
I think it is easier to use the exact version of the change in the 166
CVS. I've reverted the java/util/concurrent parts of my patch so a
separate bug can be used for the next sync with 166.
Thanks,
-Joe
On 01/14/2014 03:27 AM, Chris Hegarty wrote:
Since Martin has removed
On 14 Jan 2014, at 16:45, Joe Darcy joe.da...@oracle.com wrote:
Hi Chris,
I think it is easier to use the exact version of the change in the 166 CVS.
I've reverted the java/util/concurrent parts of my patch so a separate bug
can be used for the next sync with 166.
No problem. I’ll file a
Hi,
could you please review the following change:
http://cr.openjdk.java.net/~simonis/webrevs/8028537/
which, together with the changes from 8031581: PPC64: Addons and fixes for
AIX to pass the jdk regression tests and 8031134 : PPC64: implement
printing on AIX enables our our port to pass all
On 1/14/2014 2:13 AM, Alan Bateman wrote:
This looks good to me, I assume JDK-6434149 can finally be closed too.
Thanks for the review. Yes JDK-6434149 will be closed.
Mandy
The docs changes look good to me.
Mike
On Jan 13 2014, at 05:39 , Paul Sandoz paul.san...@oracle.com wrote:
On Jan 10, 2014, at 3:01 PM, Alan Bateman alan.bate...@oracle.com wrote:
The implementation changes look good. I agree that the javadoc needs
changing as it's otherwise misleading as
Please review my fix for
JDK-8029646: [pack200] should support the new zip64 format.
The fix can be found at
http://cr.openjdk.java.net/~kizune/8029646/webrev.00/
Bug description is: https://bugs.openjdk.java.net/browse/JDK-8029646
/Alex
Good catch on the CallStaticVoidMethod, fixed these as well, here is the
updated webrev:
http://cr.openjdk.java.net/~ksrini/8031494/webrev.2/
delta webrev to the last:
http://cr.openjdk.java.net/~ksrini/8031494/webrev.2/webrev.delta/index.html
Thanks
Kumar
On 1/13/2014 6:35 PM, Kumar
Hi,
Need a reviewer for this simple change to remove an entry for a test that does
not exist from TEST.groups:
hg diff
diff -r 6744e0c2459f test/TEST.groups
--- a/test/TEST.groups Tue Jan 14 10:08:24 2014 -0800
+++ b/test/TEST.groups Tue Jan 14 13:35:22 2014 -0500
@@ -379,7 +379,6 @@
On 1/14/2014 10:17 AM, Kumar Srinivasan wrote:
Good catch on the CallStaticVoidMethod, fixed these as well, here is the
updated webrev:
http://cr.openjdk.java.net/~ksrini/8031494/webrev.2/
delta webrev to the last:
http://cr.openjdk.java.net/~ksrini/8031494/webrev.2/webrev.delta/index.html
On 14/01/2014 16:57, Volker Simonis wrote:
:
test/com/sun/nio/sctp/SctpChannel/Util.java
test/com/sun/nio/sctp/SctpMultiChannel/Util.java
test/com/sun/nio/sctp/SctpServerChannel/Util.java
- On AIX, we currently haven't implemented SCTP but we nevertheless
compile the shared SCTP
Thumbs up.
Mandy
On 1/14/2014 10:39 AM, Lance Andersen wrote:
Hi,
Need a reviewer for this simple change to remove an entry for a test that does
not exist from TEST.groups:
hg diff
diff -r 6744e0c2459f test/TEST.groups
--- a/test/TEST.groups Tue Jan 14 10:08:24 2014 -0800
+++
Changeset: ff1478785e43
Author:katleman
Date: 2014-01-03 11:54 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/ff1478785e43
Added tag jdk8-b122 for changeset 347009c58816
! .hgtags
Changeset: c330fa67c4da
Author:katleman
Date: 2014-01-10 08:31 -0800
URL:
Changeset: 98a5caae1990
Author:chegar
Date: 2013-11-03 07:32 +
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/98a5caae1990
Merge
Changeset: 880514b576d5
Author:msheppar
Date: 2013-11-12 17:56 +
URL:
Changeset: 7ccce1a6fa4d
Author:coleenp
Date: 2013-09-05 10:29 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7ccce1a6fa4d
8021266: Better life cycle for objects
Summary: Improve life cycle for objects
Reviewed-by: art, hseigel
Contributed-by: gerard.ziem...@oracle.com
!
Changeset: 51bbdd517b93
Author:joehw
Date: 2013-08-26 21:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/51bbdd517b93
8022935: Enhance Apache resolver classes
Reviewed-by: alanb, mchung, skoivu
! src/com/sun/org/apache/xml/internal/resolver/CatalogManager.java
!
Changeset: b0c2840e2513
Author:mkos
Date: 2013-11-22 21:11 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b0c2840e2513
8010935: Better XML handling
8027378: Two closed/javax/xml/8005432 fails with jdk7u51b04
8028382: Two javax/xml/8005433 tests still fail after the fix
Please see the updated webrev http://cr.openjdk.java.net/~bpb/8030814/webrev.3/.
Hopefully my verbose description of the very clever overflow test is accurate
and understandable. Also, I cleaned up the JTREG test a bit and added some
tests based on the boundary values which split the range of
Changeset: b9fdc55a6e28
Author:chegar
Date: 2013-11-03 07:33 +
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b9fdc55a6e28
Merge
Changeset: c1049f63d4f5
Author:kizune
Date: 2013-12-03 14:13 +0400
URL:
Changeset: 53dd31d3c5d7
Author:chegar
Date: 2013-11-03 07:33 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/53dd31d3c5d7
Merge
Changeset: aaea3a69fa6c
Author:kizune
Date: 2013-12-03 14:13 +0400
URL:
Hi Alex,
zip.cpp: (nit) I would keep the hex values to be in upper case just like
the others for
consistency, not a big deal.
typo: + // Zip64 END sugnature
PackTestZip64.java: shouldn't we test a jar with 64K+ entries ?
Kumar
On 1/14/2014 10:04 AM,
Hi Brian,
Lots good other than a few quibbles:
We usually use
/*
*
*/
for long multi-line comments rather than
//
//
//
In the test update, we don't usually include mention of the bug id other
than the @bug line.
Thanks,
-Joe
On 1/14/2014 11:56 AM, Brian
On 15/01/2014 12:10 AM, Volker Simonis wrote:
On Tue, Jan 14, 2014 at 12:29 PM, David Holmes david.hol...@oracle.com
mailto:david.hol...@oracle.com wrote:
Just a note on this part (I havent looked at the code):
On AIX, the constants used for the polling events (i.e. POLLIN,
39 matches
Mail list logo
