On 3/7/14 1:24 PM, Mark Sheppard wrote:
Hi,
Please oblige and review the changes
http://cr.openjdk.java.net/~msheppar/8036603/webrev/
Better to rename the variable to "stringClass" or something more
explicit. Also you can get rid of line 65-66 to simply use "stringClass".
I think the c
On 07/03/2014 21:24, Mark Sheppard wrote:
Hi,
Please oblige and review the changes
http://cr.openjdk.java.net/~msheppar/8036603/webrev/
which address the issues raised in
https://bugs.openjdk.java.net/browse/JDK-8036603
summary
JNU_ClassString extracted as parameter to GetMethodID and NewOb
Hi,
Please oblige and review the changes
http://cr.openjdk.java.net/~msheppar/8036603/webrev/
which address the issues raised in
https://bugs.openjdk.java.net/browse/JDK-8036603
summary
JNU_ClassString extracted as parameter to GetMethodID and NewObject calls
and NUL_CHECKed
regards
Mark
On Mar 3, 2014, at 4:14 PM, Brian Burkhalter wrote:
PING-INg-Ing-ing!
> This review request concerns this issue and proposed patch:
>
> issue https://bugs.openjdk.java.net/browse/JDK-6375303
> patch http://cr.openjdk.java.net/~bpb/6375303/webrev.00/
On Mar 4, 2014, at 9:21 AM, Mike Duigou wrote
Hi,
Lambda is deceptively lightweight. It seems like a straightforward
operation but
the real implementation is more costly than one might expect.
There are other cases where the implementation doesn't match the
appearance,
for example, who pays any attention to the fact that String in switch
On 3/7/14 7:03 AM, Sergey Bylokhov wrote:
Is this absolutely necessary? Does it mean that Get**Actions are
deprecated now?
The question should be whether this dependency is absolutely necessary
and it's not. Get**Action classes are simple convenient classes that
you could either use lambda
Thumbs up.
Mandy
On 3/7/14 11:46 AM, Brian Burkhalter wrote:
On Mar 7, 2014, at 10:52 AM, Brian Burkhalter wrote:
Patch: http://cr.openjdk.java.net/~bpb/8036848/
I updated this patch to change some ugly albeit legal syntax.
Old:http://cr.openjdk.java.net/~bpb/8036848/webrev.00/
On Mar 7, 2014, at 10:52 AM, Brian Burkhalter wrote:
> Patch:http://cr.openjdk.java.net/~bpb/8036848/
I updated this patch to change some ugly albeit legal syntax.
Old:http://cr.openjdk.java.net/~bpb/8036848/webrev.00/
New:http://cr.openjdk.java.net/~bpb/8036848/webrev.01
Hello all,
This should be an easy one but then again I've been gravely in error about that
before …
Issue: https://bugs.openjdk.java.net/browse/JDK-8036848
Patch: http://cr.openjdk.java.net/~bpb/8036848/
Deprecated method:
http://download.java.net/jdk8/docs/api/java/lang/String.html#get
Hi Rob and everybody else on this list,
just as a broad link (I don't want to offend anybody, just create some
awareness :)
We have a new platform called 'AIX' in the OpenJDK. For the matter of JTreg
test it behaves mostly like every other Unix platform. I would really
appreciate it very much if
The changes look ok to me Mark.
-Chris.
On 7 Mar 2014, at 13:11, Mark Sheppard wrote:
> Subject should read
>
> RFR: JDK-8036609
>
> apologies for the typo.
>
> regards
> Mark
>
> On 07/03/2014 13:05, Mark Sheppard wrote:
>> Hi
>> Please oblige and review the following changes
>> http://c
Hi,
there is a bulk update of JAX-B/WS from upstream projects -
webrev: http://cr.openjdk.java.net/~mkos/8036030/jaxws.00/
more details in issue desc: https://bugs.openjdk.java.net/browse/JDK-8036030
Thanks
Miran
On 07/03/2014 15:34, Sergey Bylokhov wrote:
Hi, Alan.
Why we cannot move these classes to java.security.* package instead?
There's nothing to stop adding APIs in java.* but would need to
consideration as to whether they hold their weight. It would be
interesting to have some data on how many li
Hi, Alan.
Why we cannot move these classes to java.security.* package instead?
On 3/7/14 6:36 PM, Alan Bateman wrote:
On 07/03/2014 13:14, Florian Weimer wrote:
I think we had sun.security.action.GetPropertyAction for exactly this
purpose. Consequently, the proposed change actually *increase
On 3/7/14 3:31 PM, Alan Bateman wrote:
On 06/03/2014 21:10, Mandy Chung wrote:
Webrev:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8035808/webrev.00/
This patch converts the use of sun.security.action.GetPropertyAction
tolambda
(PrivilegedAction) () -> System.getProperty(key)
Simi
On 07/03/2014 13:14, Florian Weimer wrote:
I think we had sun.security.action.GetPropertyAction for exactly this
purpose. Consequently, the proposed change actually *increases* class
size:
-rw-rw-r--. 1 fweimer fweimer 6056 Mar 7 14:00
./build-orig/linux-x86_64-normal-server-release/jdk/c
On 03/07/2014 12:31 PM, Alan Bateman wrote:
This looks good to me as it reduces the number of inner classes,
I think we had sun.security.action.GetPropertyAction for exactly this
purpose. Consequently, the proposed change actually *increases* class size:
-rw-rw-r--. 1 fweimer fweimer 6056
Subject should read
RFR: JDK-8036609
apologies for the typo.
regards
Mark
On 07/03/2014 13:05, Mark Sheppard wrote:
Hi
Please oblige and review the following changes
http://cr.openjdk.java.net/~msheppar/8036609/webrev/
for the issues raised in
https://bugs.openjdk.java.net/browse/JDK-8036
Hi
Please oblige and review the following changes
http://cr.openjdk.java.net/~msheppar/8036609/webrev/
for the issues raised in
https://bugs.openjdk.java.net/browse/JDK-8036609
summary:
changes adds a couple of ExceptionChecks and a jboolean cast for CloseHandle
regards
Mark
On 07/03/2014 11:39, Peter Levart wrote:
Maybe, if PrivilegedAction interface could be retrofitted as follows:
public interface PrivilegedExceptionAction {
T run() throws Exception;
}
public interface PrivilegedAction extends
PrivilegedExceptionAction {
@Override
On 03/07/2014 12:31 PM, Alan Bateman wrote:
On 06/03/2014 21:10, Mandy Chung wrote:
Webrev:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8035808/webrev.00/
This patch converts the use of sun.security.action.GetPropertyAction
tolambda
(PrivilegedAction) () -> System.getProperty(key)
On 06/03/2014 21:10, Mandy Chung wrote:
Webrev:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8035808/webrev.00/
This patch converts the use of sun.security.action.GetPropertyAction
tolambda
(PrivilegedAction) () -> System.getProperty(key)
Similarly for GetIntegerAction and GetLongAc
This looks good to me Mandy. Reviewed.
-Chris.
On 6 Mar 2014, at 21:10, Mandy Chung wrote:
> Webrev:
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8035808/webrev.00/
>
> This patch converts the use of sun.security.action.GetPropertyAction tolambda
> (PrivilegedAction) () -> System.g
23 matches
Mail list logo
