On 3/7/14 1:24 PM, Mark Sheppard wrote:
Hi, Please oblige and review the changes http://cr.openjdk.java.net/~msheppar/8036603/webrev/
Better to rename the variable to "stringClass" or something more explicit. Also you can get rid of line 65-66 to simply use "stringClass".
I think the caller doesn't check for null that is not an issue since java.lang.String always exists. Another option is to throw InternalError.
Mandy