Re: A hole in the serialization spec

2014-04-16 Thread Chris Hegarty
On 17/02/14 15:50, David M. Lloyd wrote: ... Honestly I'm coming to the conclusion that the spec should just be updated to match the existing behavior. At least this way, it is possible to establish and explain exactly what is happening and why, and what the effect is on the wire protocol, and

RFR JDK-8038178: Fix corrupt license header

2014-04-16 Thread Pavel Rappo
Hi everyone, could you please review my change for JDK-8038178? P.S. Some may find this a little bit amusing. Thanks -Pavel diff --git a/src/share/classes/sun/misc/InnocuousThread.java b/src/share/classes/sun/misc/InnocuousThread.java --- a/src/share/classes/sun/misc/InnocuousThread.java +++ b/

Re: RFR JDK-8038178: Fix corrupt license header

2014-04-16 Thread Chris Hegarty
This looks good to me Pavel. Thanks for fixing it. -Chris. P.S. it gave me a little chuckle ;-) On 16/04/14 12:28, Pavel Rappo wrote: Hi everyone, could you please review my change for JDK-8038178? P.S. Some may find this a little bit amusing. Thanks -Pavel diff --git a/src/share/classes/su

Re: RFR JDK-8038178: Fix corrupt license header

2014-04-16 Thread David Holmes
On 16/04/2014 9:28 PM, Pavel Rappo wrote: Hi everyone, could you please review my change for JDK-8038178? Looks okay to me. P.S. Some may find this a little bit amusing. Indeed :) I'm guessing original code was private static final Unsafe U; then a rename occurred s/U/UNSAFE/ :) David

Re: RFR JDK-8038178: Fix corrupt license header

2014-04-16 Thread Aleksey Shipilev
On 04/16/2014 03:36 PM, David Holmes wrote: > On 16/04/2014 9:28 PM, Pavel Rappo wrote: >> P.S. Some may find this a little bit amusing. > > Indeed :) I'm guessing original code was > > private static final Unsafe U; Awww... Another thing to be cautious about when using Unsafe. -Aleksey.

Re: ProcessReaper: single thread reaper

2014-04-16 Thread roger riggs
Hi, Another approach was suggested by a member of the Solaris team. If you open /proc/pid O_RDONLY for any process you wish to monitor and use poll(2), you can wait for a hangup event which indicates that the process has exited. You can then reap that process's status w/ waitpid. You'll also w

Re: 8020860: cluster Hashtable/Vector field updates for better transactional memory behaviour

2014-04-16 Thread Martin Desruisseaux
Hello all Le 15/04/14 18:14, Mike Duigou a écrit : > I have updated the webrev with what I hope is the final form: > > http://cr.openjdk.java.net/~mduigou/JDK-8020860/1/webrev/ The first changes in the javadoc contains "{@code #keys keys}" and "{@code #elements elements}". I presume that you mean

Thread hangs reading from process output streams, even though process has terminated. (possible JDK bug?)

2014-04-16 Thread Bruno Medeiros
I have some code where I start an external process (ProcessBuilder.start() ,etc.) and then I spawn two worker threads to read the stdout and stderr of the external process. I directly read the streams provided by process.getInputStream() and process.getErrorStream() , I'm not wrapping them with my

RE: RFR JDK-8038178: Fix corrupt license header

2014-04-16 Thread Iris Clark
Hi, Pavel. Oops. Looks good to me. iris -Original Message- From: Pavel Rappo Sent: Wednesday, April 16, 2014 4:29 AM To: core-libs-dev Subject: RFR JDK-8038178: Fix corrupt license header Hi everyone, could you please review my change for JDK-8038178? P.S. Some may find this a little

Re: 8020860: cluster Hashtable/Vector field updates for better transactional memory behaviour

2014-04-16 Thread Mike Duigou
Yes. This has been corrected. Mike On Apr 16 2014, at 08:19 , Martin Desruisseaux wrote: > Hello all > > Le 15/04/14 18:14, Mike Duigou a écrit : >> I have updated the webrev with what I hope is the final form: >> >> http://cr.openjdk.java.net/~mduigou/JDK-8020860/1/webrev/ > > The first ch

RFR 8040760: Addition of new java.sql tests

2014-04-16 Thread Lance Andersen
Hi, Looking for a reviewer for some new java.sql tests. The webrev can be found at http://cr.openjdk.java.net/~lancea/8040760/webrev.00/ Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander

Re: ProcessReaper: single thread reaper

2014-04-16 Thread David M. Lloyd
On 04/16/2014 02:15 PM, Martin Buchholz wrote: On Mon, Apr 14, 2014 at 1:57 PM, Peter Levart mailto:peter.lev...@gmail.com>> wrote: There's already such a race in current implementation of Process.terminate(). It admittedly only concerns a small window between process exiting and th

Re: A hole in the serialization spec

2014-04-16 Thread David M. Lloyd
On 04/16/2014 02:34 AM, Chris Hegarty wrote: On 17/02/14 15:50, David M. Lloyd wrote: ... Honestly I'm coming to the conclusion that the spec should just be updated to match the existing behavior. At least this way, it is possible to establish and explain exactly what is happening and why, an

JDK 9 RFR of 8027595: Enable BigInteger overflow tests in JTREG

2014-04-16 Thread Brian Burkhalter
Hello, Following up on http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-January/024171.html. Issue: https://bugs.openjdk.java.net/browse/JDK-8027595#comment-13486513 Patch: http://cr.openjdk.java.net/~bpb/8027595/webrev.00/ The tests modified as shown pass JPRT. The StringConstructor