Re: RFR: 8043129: JAF initialisation in SAAJ clashing with the one in javax.mail

2014-05-20 Thread Miroslav Kos
Hi Chris, thanks for pointing - I forgot to add copyright. Will fix. Regarding jar attachment - this is a slightly modified version of test as received from customer. If there is any mechanism allowing to use maven artifact (I am not aware of it) with jprt, it would be definitelly better solut

RFR(S): 8043520: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

2014-05-20 Thread Yekaterina Kantserova
Staffan, Alan, could you please review the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8043520 Webrev: http://cr.openjdk.java.net/~ykantser/8043520/webrev.00/ I've missed somehow several tests in http://cr.openjdk.java.net/~ykantser/8034960/webrev.01/ which existed in http://

Re: RFR(S): 8043520: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

2014-05-20 Thread Staffan Larsen
test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.java “Dummy” is being built twice. Otherwise good! /Staffan On 20 maj 2014, at 14:24, Yekaterina Kantserova wrote: > Staffan, Alan, > > could you please review the following fix. > > Bug: https://bugs.openjdk.java.net/bro

Re: RFR: 8043129: JAF initialisation in SAAJ clashing with the one in javax.mail

2014-05-20 Thread Chris Hegarty
On 05/20/2014 11:07 AM, Miroslav Kos wrote: Hi Chris, thanks for pointing - I forgot to add copyright. Will fix. Thanks. Regarding jar attachment - this is a slightly modified version of test as received from customer. If there is any mechanism allowing to use maven artifact (I am not aware o

Re: RFR(S): 8043520: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

2014-05-20 Thread Yekaterina Kantserova
Thanks Staffan! New webrev can be found here: http://cr.openjdk.java.net/~ykantser/8043520/webrev.01/ // Katja On 05/20/2014 03:07 PM, Staffan Larsen wrote: test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.java “Dummy” is being built twice. Otherwise good! /Staffan

Re: RFR(S): 8043520: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

2014-05-20 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 20 maj 2014, at 15:48, Yekaterina Kantserova wrote: > Thanks Staffan! > > New webrev can be found here: > http://cr.openjdk.java.net/~ykantser/8043520/webrev.01/ > > // Katja > > > > On 05/20/2014 03:07 PM, Staffan Larsen wrote: >> test/sun/management/jmxr

Re: RFR: JDK-8042369 Remove duplicated java.time classes in build.tools.tzdb

2014-05-20 Thread roger riggs
Hi Sherman, Even though it has well defined content, checking in the tar.gz seems not quite right. Can the tests reconstruct the tar file from the contents or directly use the IANA data on demand from the IANA site? From a maintenance point of view, functions added to the JDK should be well u