Re: Replace concat String to append in StringBuilder parameters

2014-08-26 Thread Wang Weijun
I found an error: diff --git a/src/jdk.dev/share/classes/com/sun/tools/hat/internal/util/Misc.java b/src/jdk.dev/share/classes/com/sun/tools/hat/internal/util/Misc.java --- a/src/jdk.dev/share/classes/com/sun/tools/hat/internal/util/Misc.java +++ b/src/jdk.dev/share/classes/com/sun/tools/hat/int

Re: Replace concat String to append in StringBuilder parameters

2014-08-26 Thread Wang Weijun
Webrev updated again, this time include more changes. http://cr.openjdk.java.net/~weijun/8055723/client/webrev.02/ http://cr.openjdk.java.net/~weijun/8055723/core/webrev.02/ The change to a demo file is removed because that file itself is already removed. *Otávio*: I believe Andrej's follow

Review request: 8055856: checkdeps build target doesn't work for cross-compilation builds

2014-08-26 Thread Mandy Chung
JDK-8055856: checkdeps build target doesn't work for cross-compilation builds JDK-8056113: [build] tools.jar missing modules.xml Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055856/ This patch fixes a few things about modules.xml 1. jdeps is invoked at build time to verify the

Re: RFR: 8055949: ByteArrayOutputStream capacity should be maximal array size permitted by VM

2014-08-26 Thread Martin Buchholz
I'll submit soonish. @summary second line indented. I added some gratuitous assertions to the test: // check data integrity while we're here byte[] bytes = baos.toByteArray(); if (bytes.length != n) throw new AssertionError("wro

RFR 8037819: Xerces Update: jaxp/validation/XMLSchemaFactory

2014-08-26 Thread huizhe wang
Hi, Please review update to XMLSchemaFactory along with changes to relevant classes. All new tests passed, as well as existing jaxp tests and JPRT. Note that this updates XMLSchemaFactory, related classes such as XMLShemaValidator are only updated to the related revisions. Full update of XML

Re: Exposing LZ77 sliding window size in the java.util.zip.[Inflator|Defaltor] API

2014-08-26 Thread Xueming Shen
Hi Mark, It sounds like a reasonable requirement. I have filed the rfe at https://bugs.openjdk.java.net/browse/JDK-8056093. Let's consider to add a pair of constructors in In/Deflator in jdk9. -Sherman On 08/26/2014 01:45 AM, Mark Thomas wrote: Hi, I'm currently working on the implementatio

Re: Replace concat String to append in StringBuilder parameters

2014-08-26 Thread Wang Weijun
I see no problem from the core part of the webrev. However, I am not sure how you find all the occurrences of "+" in StringBuilder, but I just run the following command in jdk/src find . -type f -name *.java -print | xargs grep -n StringBuilder | perl -ne 'print if /new StringBuilder\([^\)]*\

Process API Updates (JEP 102)

2014-08-26 Thread Ron Pressler
I might be a little late to this party, but recently I've had a (rather frustrating) need for the ability to execve a process rather than fork-exec it. I understand that the ability to exec (replace the current process's image) is also available on Windows. This operation (on ProcessBuilder?), whic

Re: Replace concat String to append in StringBuilder parameters

2014-08-26 Thread Andrej Golovnin
Hi all, src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java: 269 .append(LINE_SEP + "g:" + LINE_SEP) should be changed to: 269 .append(LINE_SEP).append( "g:").append(LINE_SEP) src/java.base/share/classes/sun/security/x509/PolicyInformation.java:

Re: Exposing LZ77 sliding window size in the java.util.zip.[Inflator|Defaltor] API

2014-08-26 Thread Stanimir Simeonoff
Hi, If there would be any changes to Deflater/Inflater I'd strongly suggest enabling them to operate with direct buffers. Working with byte[] forces a copy in the native code which is suboptimal. Probably there should be a concern on memLevel for Deflate as well, iirc it uses the 8 by default (ma

Re: Replace concat String to append in StringBuilder parameters

2014-08-26 Thread Xuelei Fan
Pavel, thanks for the checking and confirm. Look back to the benchmark code: private StringBuilder createBuilder(String... values) { StringBuilder text = new StringBuilder(); text.append(values[0]).append(values[1]) .append(values[2]).append(values[3]) .append(values[4]).append(va

Exposing LZ77 sliding window size in the java.util.zip.[Inflator|Defaltor] API

2014-08-26 Thread Mark Thomas
Hi, I'm currently working on the implementation of the WebSocket permessage-deflate extension for Apache Tomcat. I am using the JRE provided classes java.util.zip.[Inflator|Defaltor] to do the compression and decompression. I have a working implementation but there is one feature I can't implemen

Re: Replace concat String to append in StringBuilder parameters

2014-08-26 Thread Pavel Rappo
It's exactly the way it's been working since 1.6 I believe. public class Optimization { public String concat(String... strings) { return "#: " + strings[0] + strings[2] + strings[3] + "..."; } } public class Optimization { public Optimization(); Code: 0: aload_0

Re: RFR: 8055949: ByteArrayOutputStream capacity should be maximal array size permitted by VM

2014-08-26 Thread Alan Bateman
On 25/08/2014 21:45, Martin Buchholz wrote: : jtreg tests are run by default with -ignore:quiet and there is precedent for other tests with such @ignore statements, and I actually used jtreg -ignore:run to really test this. What I would really like someday is to be able to run expensive test