Re: Review request: 8055856: checkdeps build target doesn't work for cross-compilation builds

Hello Mandy, That certainly looks better. A couple of more thoughts, and sorry for not pointing this out earlier, but the new structure is still new to me too. * The rmic targets also generate classes, so for modules.xml to be correct, I suspect you need to depend on that too. Simply add "rmi

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

The patches I mentioned would disable security manager or grant specific permissions needed to run those code, so that no test needs to be excluded from a target (whether with or without security manager). Thanks, Joe On 8/27/2014 8:42 PM, Frank Yuan wrote: Hi Joe The test Tristan mentioned

Re: RFR: 8049343: (tz) Support tzdata2014f

src/java.base/share/classes/sun/util/resources/TimeZoneNames.java: 239 String SLST[] = new String[] {"Greenwich Mean Time", "GMT", 240 "Sierra Leone Summer Time", "SLST", 241 "Sierra Leone Time", "SLT"}; 251

RE: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

Hi Joe The test Tristan mentioned that is unable to run with security manager is http://sqe-hgi.us.oracle.com/hg/index.cgi/testbase/javase/functional/9/xml/file/3f7ae9b99933/src/JAXP/unittests/unit-test/bug6513892 , it is used to test xslt redirect extension. When it runs with security manag

Re: Replace concat String to append in StringBuilder parameters

On 28.08.2014 3:15, Wang Weijun wrote: OK, I'll remember that. Thanks. So you will include the StringBuilder changes into your fix? No. I reimplemented MimeEntry.toProperty() with StringJoiner: http://hg.openjdk.java.net/jdk9/dev/jdk/diff/8be081fb8db1/src/java.base/share/classes/sun/net/ww

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

On 8/27/2014 4:03 PM, Tristan Yan wrote: Hi Joe and others I updated the tests with putting them in jaxp repo. I also run these tests with security manager and they all passed http://cr.openjdk.java.net/~tyan/JDK-8051540/webrev01/

Re: Replace concat String to append in StringBuilder parameters

OK, I'll remember that. So you will include the StringBuilder changes into your fix? --Max On Aug 28, 2014, at 2:10, Ivan Gerasimov wrote: > Hi Max! > >> The core part is updated again at >> >> http://cr.openjdk.java.net/~weijun/8055723/core/webrev.03/ > > Can you please revert changes to

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

Hi Joe and others I updated the tests with putting them in jaxp repo. I also run these tests with security manager and they all passed http://cr.openjdk.java.net/~tyan/JDK-8051540/webrev01/ Also I’d like to propose our way for handling ja

Re: Impact of code difference in Collection#contains() worth improving?

On Aug 27, 2014, at 6:48 AM, Fabian Lange wrote: > Hi all, > I have been involved recently in some theoretical or nonsensical > discussions about microbenchmarking, jit compiling assemblies and so fort. > One example was LinkedList vs ArrayList. > > What I noticed is that those two have a differ

Re: Replace concat String to append in StringBuilder parameters

Hi Max! The core part is updated again at http://cr.openjdk.java.net/~weijun/8055723/core/webrev.03/ Can you please revert changes to src/java.base/share/classes/sun/net/www/MimeEntry.java, as they're conflicting with the fix for JDK-8054714? Apologizing for adding you more work. Sinc

Re: [8u-dev] RFR: 8036981: JAXB not preserving formatting for xsd:any Mixed content

Thank you Lance! -Aleksej On 27.08.2014 19:56, Lance Andersen wrote: I will review it by the end of the week On Aug 27, 2014, at 9:45 AM, Aleksej Efimov > wrote: Hi, I'm adding a core-libs-dev mail list - I might be lucky to find a JDK8 reviewer for my fix

Re: Impact of code difference in Collection#contains() worth improving?

Hi Fabian; The correct mailing list for this discussion would be core-libs-dev@openjdk.java.net The difference between these two implementations is probably of not much consequence though it seems that one or the other could be promoted to AbstractList. This implementation would be marginally

Re: Review request: 8055856: checkdeps build target doesn't work for cross-compilation builds

Erik, Magnus, This is much easier than I have thought. I really like this new build. I have separated out Gendata-jdk.dev.gmk and removed the modules-xml target completely. Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055856/webrev.01/ Mandy

Re: [8u-dev] RFR: 8036981: JAXB not preserving formatting for xsd:any Mixed content

I will review it by the end of the week On Aug 27, 2014, at 9:45 AM, Aleksej Efimov wrote: > Hi, > I'm adding a core-libs-dev mail list - I might be lucky to find a JDK8 > reviewer for my fix there. > > Thank you, > Aleksej > > On 08/26/2014 06:12 PM, Aleksej Efimov wrote: >> Hi Dalibor, >>

Re: Impact of code difference in Collection#contains() worth improving?

The ArrayList version saves one byte of bytecode, and is therefore very slightly better. We should bless that version and use it consistently. javap -c -private java.util.ArrayList | grep -A10 'boolean.*contains' public boolean contains(java.lang.Object); Code: 0: aload_0 1:

Re: Review request: 8055856: checkdeps build target doesn't work for cross-compilation builds

On 2014-08-27 16:39, Mandy Chung wrote: On 8/27/2014 3:19 AM, Magnus Ihse Bursie wrote: On 2014-08-27 10:26, Erik Joelsson wrote: Hello Mandy, Looking at this, I just realized that $(JDK_OUTPUTDIR)/modules/jdk.dev/com/sun/tools/jdeps/resources/jdeps-modules.xml is a generated resource for

Re: Impact of code difference in Collection#contains() worth improving?

As far as I know, hotspot jit will favor cmov only when the branch appears to be unpredictable (or conversely, not strongly predictable); otherwise, jmp is used. To get feedback on predictability, the code needs to run in the interpreter, which you've not done by using -Xcomp. Generally, if you'r

Re: Review request: 8055856: checkdeps build target doesn't work for cross-compilation builds

On 8/27/2014 3:19 AM, Magnus Ihse Bursie wrote: On 2014-08-27 10:26, Erik Joelsson wrote: Hello Mandy, Looking at this, I just realized that $(JDK_OUTPUTDIR)/modules/jdk.dev/com/sun/tools/jdeps/resources/jdeps-modules.xml is a generated resource for a module and that you correctly added it

Re: Impact of code difference in Collection#contains() worth improving?

Hi Vitaly, The code comes from a single invocation of a contains(1) on an empty list. I forced -Xcomp to get a compilation result. But as stated in the initial mail, this was just curiosity. If the >=0 and !=-1 checks are 100% equal in performance and optimization, then it does not matter. If one o

Re: Impact of code difference in Collection#contains() worth improving?

There's no clear winner between cmov and jmp in the general case. When you looked at the generated assembly, what code did you run to warm it up? Were most instances found in the list or not or some mix? Using 0 as a test does have benefits in some places (e.g. when flags register can be used from

Re: Replace concat String to append in StringBuilder parameters

On Aug 27, 2014, at 10:07, Wang Weijun wrote: > Webrev updated again, this time include more changes. > > http://cr.openjdk.java.net/~weijun/8055723/client/webrev.02/ > http://cr.openjdk.java.net/~weijun/8055723/core/webrev.02/ The core part is updated again at http://cr.openjdk.java.net/

Impact of code difference in Collection#contains() worth improving?

Hi all, I have been involved recently in some theoretical or nonsensical discussions about microbenchmarking, jit compiling assemblies and so fort. One example was LinkedList vs ArrayList. What I noticed is that those two have a different implementation for contains(): ArrayList: public bool

Re: RFR: 8049343: (tz) Support tzdata2014f

Masayoshi, Thank you for a detailed review - I tried to address all your comments. Please, see the updated review: http://cr.openjdk.java.net/~aefimov/8049343/9/webrev.03 About the workarounds - I will start discussion with Sherman when the tzdata2014f (and I suppose the 2014g - it will be avai

Re: [8u-dev] RFR: 8036981: JAXB not preserving formatting for xsd:any Mixed content

Hi, I'm adding a core-libs-dev mail list - I might be lucky to find a JDK8 reviewer for my fix there. Thank you, Aleksej On 08/26/2014 06:12 PM, Aleksej Efimov wrote: Hi Dalibor, It's a partial backport (logged with a different bugID) of JDK9 fix, I got an approval from Miran (Thank you Mir

Re: RFR: [8054714] Use StringJoiner where it makes the code cleaner

On Aug 9, 2014, at 8:32 AM, Ivan Gerasimov wrote: > Yes, this will surely work faster. I've incorporated your suggestion: > http://cr.openjdk.java.net/~igerasim/8054714/1/webrev/ > Looks ok. V. minor point, rogue space: sun/net/www/protocol/http/HttpURLConnection.java2014-08-09 10:34:

Re: Replace concat String to append in StringBuilder parameters

Could you please explain what you mean by "javac optimization fails" here? -Pavel On 27 Aug 2014, at 10:41, Ulf Zibis wrote: > 4.) Now we see, that javac optimization fails again if StringBuilder, > concatenation, toString(), append(String), append(Collection) etc. and > StringJoiner use is m

Re: RFR: 8055949: ByteArrayOutputStream capacity should be maximal array size permitted by VM

Am 25.08.2014 um 19:37 schrieb Martin Buchholz: https://bugs.openjdk.java.net/browse/JDK-8055949 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/ByteArrayOutputStream-MAX_ARRAY_SIZE/ The 2x capacity gap was noticed by real users! Hi Martin, the MAX_ARRAY_SIZE code now is copied to many pl

Re: Review request: 8055856: checkdeps build target doesn't work for cross-compilation builds

On 2014-08-27 10:26, Erik Joelsson wrote: Hello Mandy, Looking at this, I just realized that $(JDK_OUTPUTDIR)/modules/jdk.dev/com/sun/tools/jdeps/resources/jdeps-modules.xml is a generated resource for a module and that you correctly added it to the gendata target. Then to make it fit with th

Re: The future of Serialization

On Aug 9, 2014, at 7:20 PM, Brian Goetz wrote: >> I've noticed there's not much interest in improving Serialization on >> these lists. This makes me wonder if java Serialization has lost >> relevance in recent years with the rise of protocol buffers apache >> thrift and other means of data tran

Re: Replace concat String to append in StringBuilder parameters

Hi all, a critical question! 1.) Why we have String concatenation in Java? ... I would answer: for _readability_ purpose. 2.) In the early javac times, we were asked to refactor to StringBuffer for performance critical code. 3.) Since 1.6 ? javac is capable to replace multiple concatenation

Re: RFR: 8049343: (tz) Support tzdata2014f

Here are additional comments. src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java: I'm concerned about the workarounds. It's not new in this update, but this problem would make tzupdater data void until the workaround is added to the next update release. Could you please work with

Re: Review request: 8055856: checkdeps build target doesn't work for cross-compilation builds

Hello Mandy, Looking at this, I just realized that $(JDK_OUTPUTDIR)/modules/jdk.dev/com/sun/tools/jdeps/resources/jdeps-modules.xml is a generated resource for a module and that you correctly added it to the gendata target. Then to make it fit with the new makefile model, the running of TOOL_