http://cr.openjdk.java.net/~vlivanov/8057654/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8057654
The idea is to separate construction logic and different checks
performed before/during method handle construction.
For example: move checks from MHs.foldArguments into
On Sep 4, 2014, at 9:55 PM, John Rose john.r.r...@oracle.com wrote:
David Chase and I just noticed files like this in the JDK:
http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/test/java/util/stream/test/org/openjdk/tests/java/util/stream/
The package for the test code is
http://cr.openjdk.java.net/~vlivanov/8057657/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8057657
Add ability to annotate LambdaForm parameters with their types.
Type info could be useful during LambdaForm compilation to produce
better bytecode.
Testing: jdk/java/lang/invoke,
Hi Peter,
I fixed it and created new webrev.
http://cr.openjdk.java.net/~ysuenaga/JDK-8057556/webrev.1/
Could you review it again?
Thanks,
Yasumasa
(2014/09/05 17:20), Peter Allwin wrote:
Looks like only the first Interface will be considered if no srcAddress is
provided (succeeded will
On Sep 5, 2014, at 10:09 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
http://cr.openjdk.java.net/~vlivanov/8057654/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8057654
+1
Paul.
On 09/05/2014 12:09 PM, Vladimir Ivanov wrote:
http://cr.openjdk.java.net/~vlivanov/8057654/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8057654
Random style rant of the week, not particularly about this concrete
patch. Can we please try to systematically use more
readable/robust/secure
On Sep 5, 2014, at 10:23 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
http://cr.openjdk.java.net/~vlivanov/8057656/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8057656
854 if (!canConvert(returnType(), newType.returnType()))
855 return false;
856
Paul, thanks for review.
Generally looks good (re: Peter's observation of continue/break).
- LambdaFormEditor
61 private static final class Transform {
62 final long packedBytes;
63 final byte[] fullBytes;
64 final LambdaForm result; // result of
+1
On 05 Sep 2014, at 12:46, Aleksey Shipilev aleksey.shipi...@oracle.com wrote:
On 09/05/2014 12:09 PM, Vladimir Ivanov wrote:
http://cr.openjdk.java.net/~vlivanov/8057654/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8057654
Random style rant of the week, not particularly about
To the style rant, I mean.
On 05 Sep 2014, at 13:40, Marcus Lagergren marcus.lagerg...@oracle.com wrote:
+1
On 05 Sep 2014, at 12:46, Aleksey Shipilev aleksey.shipi...@oracle.com
wrote:
On 09/05/2014 12:09 PM, Vladimir Ivanov wrote:
On Sep 5, 2014, at 1:25 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Paul, thanks for review.
Generally looks good (re: Peter's observation of continue/break).
- LambdaFormEditor
61 private static final class Transform {
62 final long packedBytes;
63
On 09/05/2014 12:31 PM, Paul Sandoz wrote:
On Sep 5, 2014, at 10:09 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
http://cr.openjdk.java.net/~vlivanov/8057654/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8057654
+1
Paul.
Paul, Peter, Morris, thanks for review.
Best regards,
Vladimir Ivanov
On 9/5/14, 3:51 PM, Paul Sandoz wrote:
On Sep 5, 2014, at 1:25 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Paul, thanks for review.
Generally looks good (re: Peter's observation of continue/break).
-
Hi,
I'm requesting reviews and a sponsor for these changes to the recently
added parse methods (8041972), suggested during discussions on net-dev:
bug: https://bugs.openjdk.java.net/browse/JDK-8055251
webrev: http://cr.openjdk.java.net/~redestad/8055251/webrev.1/
On Sep 5, 2014, at 2:30 PM, Remi Forax fo...@univ-mlv.fr wrote:
On 09/05/2014 12:31 PM, Paul Sandoz wrote:
On Sep 5, 2014, at 10:09 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
http://cr.openjdk.java.net/~vlivanov/8057654/webrev.00/
http://cr.openjdk.java.net/~vlivanov/8050173/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8050173
Added j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) and provided
implementation for all subclasses.
Also, some cleanups:
* rewrote MH.viewAsType on top of MH.copyWith;
* extended
Paul, Remi, thanks for review.
Renamed type - mtype removed @SuppressWarnings.
Updated webrev in place.
Best regards,
Vladimir Ivanov
On 9/5/14, 5:13 PM, Paul Sandoz wrote:
On Sep 5, 2014, at 2:30 PM, Remi Forax fo...@univ-mlv.fr wrote:
On 09/05/2014 12:31 PM, Paul Sandoz wrote:
On Sep
On Sep 5, 2014, at 3:15 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Looks good, just one comment.
MethodHandles.restrictReceiver
This method has:
1578 private MethodHandle restrictReceiver(MemberName method,
MethodHandle mh, Class? caller) throws
On 05/09/2014 14:03, Claes Redestad wrote:
Hi,
I'm requesting reviews and a sponsor for these changes to the recently
added parse methods (8041972), suggested during discussions on net-dev:
bug: https://bugs.openjdk.java.net/browse/JDK-8055251
webrev:
http://cr.openjdk.java.net/~vlivanov/8057656/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8057656
854 if (!canConvert(returnType(), newType.returnType()))
855 return false;
856 Class?[] srcTypes = newType.ptypes;
857 Class?[] dstTypes =
On Jul 16, 2014, at 1:50 AM, Paul Sandoz paul.san...@oracle.com wrote:
Why not make the second parameter be DirectMethodHandle mh ?
Good suggestion; thanks. Makes the restrictReceiver logic less magic. — John
Hello,
Please review the new tests for the feature Lambda Form Reduction and
Caching https://bugs.openjdk.java.net/browse/JDK-8046703
JBS task: https://bugs.openjdk.java.net/browse/JDK-8057719
Webrev: http://cr.openjdk.java.net/~kshefov/8057719/webrev.00/
These tests also depend on
Hello,
Please review the change in testlibrary
https://bugs.openjdk.java.net/browse/JDK-8057707
This change is needed for new tests for the feature Lambda Form
Reduction and Caching https://bugs.openjdk.java.net/browse/JDK-8046703
Webrev of the testlibrary change:
On Fri, Aug 29, 2014 at 7:53 PM, Guy Steele guy.ste...@oracle.com wrote:
But I cannot resist recalling that one of the earliest pieces of software
in the implementation of EMACS (back when the implementation language was
TECO, a text-editing language) was a routine that, when it loaded TECO
Summary: Add classLoader to java/lang/Class instance for fast access
This is a backport request for 8u40. This change has been in the jdk9
code for 3 months without any problems.
The JDK changes hg imported cleanly. The Hotspot change needed a hand
merge for create_mirror call in
On 05/09/2014 18:57, Konstantin Shefov wrote:
Hello,
Please review the change in testlibrary
https://bugs.openjdk.java.net/browse/JDK-8057707
This change is needed for new tests for the feature Lambda Form
Reduction and Caching https://bugs.openjdk.java.net/browse/JDK-8046703
Webrev of the
Hi Joe,
This seems OK
Best,
Lance
On Aug 28, 2014, at 10:46 PM, huizhe wang huizhe.w...@oracle.com wrote:
Hi,
This is an update to Xerces' Catalog Resolver implementation. The changes
were mostly performance related, for example the changes to the normalizeURI
method in Catalog.java to
Thanks Lance!
Joe
On 9/5/2014 1:44 PM, Lance Andersen wrote:
Hi Joe,
This seems OK
Best,
Lance
On Aug 28, 2014, at 10:46 PM, huizhe wang huizhe.w...@oracle.com
mailto:huizhe.w...@oracle.com wrote:
Hi,
This is an update to Xerces' Catalog Resolver implementation. The
changes were mostly
These test are for core-libs feature, but we want to test that unused lambda
forms are garbage collected using WhiteBox.fullGC() method. There are three
tests that use one common class, only one of them uses whitebox api. So it is
hard to move one of tests to hotspot repo.
- Konstantin
On Aug 30, 2014, at 7:17 AM, Ulf Zibis ulf.zi...@cosoco.de wrote:
Am 30.08.2014 um 01:33 schrieb John Rose:
On Aug 29, 2014, at 1:05 PM, Ulf Zibis ulf.zi...@cosoco.de
mailto:ulf.zi...@cosoco.de wrote:
Thanks for explaining this, but a very little nit: the immediate (I.e. -1)
uses
On Aug 30, 2014, at 10:58 AM, Doug Lea d...@cs.oswego.edu wrote:
In the present case, I'm with Martin about short-circuiting
this with a simple approximate answer: Rather than flip a coin
choosing between solutions A and B, pick the one with smaller bytecode.
This has a decent enough
31 matches
Mail list logo
