Konstantin,
+private TestMethods(String name, int maxArity) {
+this.name = name;
+this.maxArity = maxArity;
+}
+
private TestMethods(String name) {
this.name = name;
+this.maxArity = Helper.MAX_ARITY;
}
please call TestMethods(String, int) fro
Hi all,
Looking for a reviewer for the unit tests being added for RowSetFactory and
RowSetProvider.
The webrev can be found at
http://cr.openjdk.java.net/~lancea/8059570/webrev.00/
Best,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 N
Hi everyone.
Is there any reason to not implement the JSR that already exist and that
was born?
https://jcp.org/en/jsr/detail?id=367
https://jcp.org/en/jsr/detail?id=353
Which especific cases what the OpenJDK need and this JSR don't care?
Why just work together with these JSRs and each one has yo
Thanks for reviewing
http://cr.openjdk.java.net/~kshefov/8058695/webrev.02
-Konstantin
On 01.10.2014 17:30, Igor Ignatyev wrote:
Hi Konstantin,
0. could you please introduce a ctor which sets the default value for
'maxArity' and use it instead of explicitly passed 'Helper.MAX_ARITY'?
1. ther
Hi Konstantin,
0. could you please introduce a ctor which sets the default value for
'maxArity' and use it instead of explicitly passed 'Helper.MAX_ARITY'?
1. there is a existing solution for your case w/ access to an private field of
an outer class:
> int desiredArity = Helper.RNG.nextInt(super
Good.
Best regards,
Vladimir Ivanov
On 10/1/14, 4:20 PM, Konstantin Shefov wrote:
Hi,
I have updated the webrev:
http://cr.openjdk.java.net/~kshefov/8058695/webrev.01
Also I will move fix to JDK-8058733 to other request.
-Konstantin
On 24.09.2014 19:54, Konstantin Shefov wrote:
Hello,
Ple
Hi,
I have updated the webrev:
http://cr.openjdk.java.net/~kshefov/8058695/webrev.01
Also I will move fix to JDK-8058733 to other request.
-Konstantin
On 24.09.2014 19:54, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058695
Webr
Hi Daniel,
The revised changes look fine.
Best,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
> On Oct 1, 2014, at 6:00 AM, Daniel Fuchs wrote:
>
> Hi Lance
Hi Lance,
On 30/09/14 23:55, Lance Andersen wrote:
On Sep 30, 2014, at 5:20 PM, Daniel Fuchs mailto:daniel.fu...@oracle.com>> wrote:
On 9/30/14 9:09 PM, Lance Andersen wrote:
Shouldn't the other constructors indicate that an NPE will occur
similar to the default constructor if the pattern is n
