Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Vitaly Davidovich
Yes sorry, I meant jitter got so much worse. TieredCompilation could be a source -- I'd try turning it off to see what C2 peak is. I'm guessing your machine is otherwise quiet when you're running these benchmarks. On Thu, Oct 2, 2014 at 4:47 PM, Peter Levart wrote: > > On 10/02/2014 09:28 PM,

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Peter Levart
On 10/02/2014 09:28 PM, Vitaly Davidovich wrote: Yes, this is the version I wanted to see (i.e. where the only diff is varargs, and not any anything else like array iteration, etc). Why did fillCopyLoop() get some much worse than in your prior email though? 82050640.406 (+-4055652.247) vs. 8

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Vitaly Davidovich
Yes, this is the version I wanted to see (i.e. where the only diff is varargs, and not any anything else like array iteration, etc). Why did fillCopyLoop() get some much worse than in your prior email though? On Thu, Oct 2, 2014 at 3:12 PM, Peter Levart wrote: > Well, if I add the following

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Peter Levart
Well, if I add the following variant to the mix: private static void fillWith8Arguments(Object[] a, int pos, Object... args) { a[pos] = args[0]; a[pos + 1] = args[1]; a[pos + 2] = args[2]; a[pos + 3] = args[3]; a[pos + 4] = args[4]; a[pos + 5]

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Peter Levart
On 10/02/2014 08:42 PM, Vitaly Davidovich wrote: AFIK, varargs (up to something like 64 args) should be eliminated by EA. Peter, can you add another jmh test that uses varargs but doesn't call into System.arraycopy but uses the hand rolled version like your at method? I'm wondering if that

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Vitaly Davidovich
AFIK, varargs (up to something like 64 args) should be eliminated by EA. Peter, can you add another jmh test that uses varargs but doesn't call into System.arraycopy but uses the hand rolled version like your at method? I'm wondering if that makes EA not kick in. Sent from my phone On Oct 2, 2014

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Peter Levart
On 10/02/2014 06:55 PM, Vladimir Ivanov wrote: Small update: http://cr.openjdk.java.net/~vlivanov/8058892/webrev.01/ Need to reorder initialization sequence in MHI.Lazy. Initialized FILL_ARRAYS and ARRAYS are required for later MH lookups. Additional testing: * jck (api/java_lang/invoke)

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Aleksey Shipilev
On 10/02/2014 09:26 PM, Vladimir Ivanov wrote: > Aleksey, > > Thanks for the review. > Updated version: > http://cr.openjdk.java.net/~vlivanov/8058892/webrev.02/ Looks good. >> * Since initialization order is important, why don't put the >> initialization in the existing static initializer? This

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Vladimir Ivanov
Aleksey, Thanks for the review. Updated version: http://cr.openjdk.java.net/~vlivanov/8058892/webrev.02/ * Since initialization order is important, why don't put the initialization in the existing static initializer? This will secure for inadvertent field reordering in future. Good idea. Fixed

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Remi Forax
On 10/02/2014 07:00 PM, Aleksey Shipilev wrote: I have three comments: * Since initialization order is important, why don't put the initialization in the existing static initializer? This will secure for inadvertent field reordering in future. good idea. * Any reason two new fields are "pr

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Aleksey Shipilev
I have three comments: * Since initialization order is important, why don't put the initialization in the existing static initializer? This will secure for inadvertent field reordering in future. * Any reason two new fields are "private"? All other seem package-private. * Any performance problem

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Vladimir Ivanov
Small update: http://cr.openjdk.java.net/~vlivanov/8058892/webrev.01/ Need to reorder initialization sequence in MHI.Lazy. Initialized FILL_ARRAYS and ARRAYS are required for later MH lookups. Additional testing: * jck (api/java_lang/invoke) * jdk/java/lang/invoke, jdk/java/util/streams w/

Re: Urgent [9], 2nd round, RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

2014-10-02 Thread olivier.lagn...@oracle.com
Oops, please forget this one that is missing text of what is done in this webrev. wrong gui manipulation ... Sorry for this, Olivier. On 02/10/2014 18:08, olivier.lagn...@oracle.com wrote: Please review this 2nd version of the fix taking into account your feedback. Bug : https://bugs.open

Urgent [9], 2nd round, RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

2014-10-02 Thread olivier.lagn...@oracle.com
Please review this 2nd version of the fix taking into account your feedback. Bug : https://bugs.openjdk.java.net/browse/JDK-8039915 webrev : http://cr.openjdk.java.net/~olagneau/8039915/webrev.01 I have changed the code following your r

Urgent [9], 2nd round, RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

2014-10-02 Thread olivier.lagn...@oracle.com
Please review this 2nd version of the fix taking into account your feedback. Bug : https://bugs.openjdk.java.net/browse/JDK-8039915 webrev : http://cr.openjdk.java.net/~olagneau/8039915/webrev.00

[9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-02 Thread Vladimir Ivanov
http://cr.openjdk.java.net/~vlivanov/8058892/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8058892 Core j.l.i classes are preloaded during VM startup in order to avoid possible deadlock when accessing JSR292-related functionality from multiple threads. After LF sharing-related changes, FI

Re: RFR: 8059570, Addition of tests for RowSetFactory and RowSetProvider

2014-10-02 Thread Lance Andersen
Hi Daniel, Thank you for you review. On Oct 2, 2014, at 6:39 AM, Daniel Fuchs wrote: > Hi Lance, > > I probably don't know enough about rowset to qualify as reviewer > for this change, but I had a look at the tests - and I believe > they look good. Thank you. > I wonder whether there should

Re: RFR: 8059570, Addition of tests for RowSetFactory and RowSetProvider

2014-10-02 Thread Daniel Fuchs
Hi Lance, I probably don't know enough about rowset to qualify as reviewer for this change, but I had a look at the tests - and I believe they look good. I wonder whether there should be some additional tests that would run with a security manager on? The only thing unusual I noticed is that the

Re: [9] Review request : JDK-8058695: [TESTBUG] Reinvokers with arity >253 can't be cached

2014-10-02 Thread Konstantin Shefov
Hi, I have updated the webrev http://cr.openjdk.java.net/~kshefov/8058695/webrev.03/ -Konstantin On 02.10.2014 5:10, Igor Ignatyev wrote: Konstantin, +private TestMethods(String name, int maxArity) { +this.name = name; +this.maxArity = maxArity; +} + private Te