Looks good to me. I don't mind if you fix javadoc in the same change.
It's such a small issue I rather not go through the hassle of creating a
bug and a new review.
Thanks!
/Erik
On 2014-12-12 19:25, Mandy Chung wrote:
Webrev:
On 15/12/14 05:21, Nathan Clement wrote:
Hi,
What's the process for finalizing a decision and getting this bug fixed?
Apologies if I'm violating a social norm by asking this - I'm new to
this process and I'm not sure exactly how decisions are made.
You are not violating anything, and it is
Hello everyone!
In certain situations the preferred way of sorting strings is a
combination of char-comparing sorting with numeric sorting, where
applicable.
List of strings sorted this way often look more natural to the human eyes:
{ alpha,
java1,
java2,
java10,
zero }
Here's
Gently reminder. Please review.
-Konstantin
On 11.12.2014 14:09, Konstantin Shefov wrote:
CC'ed core-libs-dev@openjdk.java.net
On 10.12.2014 18:21, Konstantin Shefov wrote:
Hello,
Please, review the bug fix:
https://bugs.openjdk.java.net/browse/JDK-6933879
Webrev:
Konstantin,
I did reply to this RFR [1], with a question, that is still unanswered.
-Chris.
[1] http://mail.openjdk.java.net/pipermail/net-dev/2014-December/008782.html
On 15/12/14 11:15, Konstantin Shefov wrote:
Gently reminder. Please review.
-Konstantin
On 11.12.2014 14:09, Konstantin
Chris, thank you. I see your answer now.
I will try to reproduce NetworkInterface.getName() returning interface
name with the chars in question.
As far as I understood the bug, customers needed URI with scope id
containing . symbol, and now they use URL class instead of URI for that.
On 15/12/2014 11:25, Chris Hegarty wrote:
Konstantin,
I did reply to this RFR [1], with a question, that is still unanswered.
-Chris.
[1]
http://mail.openjdk.java.net/pipermail/net-dev/2014-December/008782.html
I can think of configurations where the scenario could arise. It make me
Hello Sherman, Masayoshi and other experts,
Can I ask for a JDK9 review for the
sun/util/calendar/zi/TestZoneInfo310.java test failure [1] that was
caused by incorrect handling of last rules for Africa/Casablanca time
zone. This timzone has two last rules and three instant rules in a range
Sherman, thank you for looking into this problem and helping solve it. I
will change the formatting before the push.
-Aleksej
On 12/15/2014 07:17 PM, Xueming Shen wrote:
On 12/15/14 8:06 AM, Aleksej Efimov wrote:
Hello Sherman, Masayoshi and other experts,
Can I ask for a JDK9 review for
On 12/14/14 7:43 PM, Wang Weijun wrote:
Several questions:
1. Why cannot I just call os.putNextEntry(ze) or at least os.putNextEntry(new
ZipEntry(ze))? Maybe some fields (say, compressed size) should not be copied
over? If ze2 must be this way, shall I also copy the flag field?
It's the
Hi guys,
Do I have approval to push the latest version of the test for JDK 9:
http://cr.openjdk.java.net/~dfuchs/webrev_8066612/webrev-jdk9.02/
or are there still some objections?
best regards,
-- daniel
On 06/12/14 11:44, Daniel Fuchs wrote:
Hi Peter,
On 12/6/14 11:16 AM, Peter Levart
Thanks for the review. I don't mind filing a bug for javadoc change and
it's easy as it's a separate issue and cleaner to separate them. I'm
happy this saves me the hassle of a separate review, thanks!
Mandy
On 12/15/14 12:56 AM, Erik Joelsson wrote:
Looks good to me. I don't mind if you
On 15/12/2014 17:48, Daniel Fuchs wrote:
Hi guys,
Do I have approval to push the latest version of the test for JDK 9:
http://cr.openjdk.java.net/~dfuchs/webrev_8066612/webrev-jdk9.02/
or are there still some objections?
I'm fine with the test Daniel (as before) - it's a long-life test that
Have there been any further review being done jet?
Good catch, guys!
...the method names are inconsistent (the methods in lower case with
embedded underscores)
Fixed. Updated webrev: http://cr.openjdk.java.net/~prappo/8066867/webrev.01/
-Patrick
Ping...
On 12/12/2014 12:14 PM, roger riggs wrote:
Please review this addition of diagnostic output to an intermittently
failing Runtime.exec test.
The Solaris implementation of ProcessBuilder.start uses posix_spawn
and a trampoline
technique that invokes a small spawnhelper executable which
Hi Roger,
I had looked at it last week and seems fine to help get more info and did not
have another bright solution off the top of my head
Best
Lance
On Dec 15, 2014, at 4:54 PM, roger riggs roger.ri...@oracle.com wrote:
Ping...
On 12/12/2014 12:14 PM, roger riggs wrote:
Please review
Thanks Lance
On 12/15/2014 4:56 PM, Lance Andersen wrote:
Hi Roger,
I had looked at it last week and seems fine to help get more info and
did not have another bright solution off the top of my head
Best
Lance
On Dec 15, 2014, at 4:54 PM, roger riggs roger.ri...@oracle.com
Hello ,
Please review webrev to fix the following minor issues:
1. JDK-8067421: java -help contains information about
-version:,'-jre-restrict-search', '-no-jre-restrict-search', but they
are removed
2. JDK-8067411: tools/launcher/MultipleJRE.sh requires adjustments to
work with module
Hi Ivan,
It does seem like a useful function, though I would have started with
the API,
not the implementation.
Can it apply to CharSequence not only String and maybe skip the
separate char[] version, a char[] array can be wrapped to become a
CharSequence via CharBuffer.
Or a via a new
Hello,
It seems useful to me too, but it should also take digits other than '0'
to '9' into account, for example, １２３４５６７８９０.
Naoto
On 12/15/14, 2:31 PM, roger riggs wrote:
Hi Ivan,
It does seem like a useful function, though I would have started with
the API,
not the implementation.
Can
Hi Ivan, hi Roger,
Roger, the API already exists it's the interface Comparator.
I agree with Roger that a comparator that use a CharSequence is better
that the one that use a char array.
The thing that worry me is the ComparatorCharacter taken as parameter,
it means that
each time the
On 12/12/14 7:54 AM, Chris Hegarty wrote:
On 12/12/14 15:40, Pavel Rappo wrote:
Could you please review my change for JDK-8066642?
http://cr.openjdk.java.net/~prappo/8066642/webrev.00/
The first change, to remove SocketSecurityException seems benign.
SocketSecurityException is a subclass
Looks fine Kumar; thanks,
-Joe
On 12/15/2014 01:56 PM, Kumar Srinivasan wrote:
Hello ,
Please review webrev to fix the following minor issues:
1. JDK-8067421: java -help contains information about
-version:,'-jre-restrict-search', '-no-jre-restrict-search', but
they are removed
2.
On 16/12/2014 3:48 AM, Daniel Fuchs wrote:
Hi guys,
Do I have approval to push the latest version of the test for JDK 9:
http://cr.openjdk.java.net/~dfuchs/webrev_8066612/webrev-jdk9.02/
or are there still some objections?
My objections stand - the classloader aspect of the test is overly
Thanks Roger!
Yes, I agree that a CharSequence variant should be enough.
The function is wrapped into a Comparator, so it can easily be plugged
into an application.
If many people find it useful, I guess it can later be moved from
samples to jdk.
Here's the updated webrev:
25 matches
Mail list logo
