Re: Explicit Serialization API and Security

And that is the point of this discussion, to determine how to do just that. But considering it's such a difficult problem, we haven't figured out how to yet. Peter. - Original message - > > Message: 2 > Date: Wed, 21 Jan 2015 15:43:13 -0600 > From: "David M. Lloyd" > > At some point,

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

> On Jan 22, 2015, at 19:40, Artem Smotrakov wrote: > >> I am not sure if I understand updateJar correctly. It looks like srcJarFile >> is opened multiple times so its entries are duplicated a lot in the >> destination. Or is there a secret break? > There is no any secret, just a bug. It is no

Re: [9] RFR (M): 8063137: Never-taken branches should be pruned when GWT LambdaForms are shared

On Jan 20, 2015, at 11:09 AM, Vladimir Ivanov wrote: > >> What I'm mainly poking at here is that 'isGWT' is not informative about >> the intended use of the flag. > I agree. It was an interim solution. Initially, I planned to introduce > customization and guide the logic based on that property.

Re: [9] RFR (M): 8069591: Customize LambdaForms which are invoked using MH.invoke/invokeExact

On Jan 22, 2015, at 9:56 AM, Vladimir Ivanov wrote: > > Remi, John, thanks for review! > > Updated webrev: > http://cr.openjdk.java.net/~vlivanov/8069591/webrev.01/ > > This time I did additional testing (COMPILE_THRESHOLD > 0) and spotted a > problem with MethodHandle.copyWith(): a MethodHan

Re: RFR (JAXP): 8054196: XPath: support any type

Thanks Lance. On 1/22/2015 9:11 AM, Lance Andersen wrote: Hi Joe, I just looked at the changes below, I looked at the changes below… see minor comments On Jan 22, 2015, at 12:18 AM, huizhe wang > wrote: On 1/21/2015 5:09 PM, Lance Andersen wrote: Hi Joe, I

RE: [PATCH] JDK-8054565: FilterOutputStream.close may throw IOException if called twice and underlying flush or close fails

Hi Chris, We have worked around the problem by using a small jar in our bootstrap classpath (now containing your updated code). From our perspective there's probably no pressing need to have the fix backported. Thanks, Nathan > Subject: Re: [PATCH] JDK-8054565: FilterOutputStream.close may

RFR: JDK-8064736: Part of java.util.jar.JarFile spec looks confusing with references to Zip

Hi Please help review issue: https://bugs.openjdk.java.net/browse/JDK-8064736 webrev: http://cr.openjdk.java.net/~sherman/8064736 The goal is to have the api doc for these two methods to be consistent with the rest of the apis, especially the ISE exception part. Thanks! -Sherman

Re: RFR 8067748: (process) Child is terminated when parent's console is closed [win]

Not really reviewing, but cheerleading - this area is really hard! Historically I tried to avoid touching windows api and avoid changing any aspect of process termination, since whichever way you go, someone will be relying on the historic behavior. On Thu, Jan 22, 2015 at 6:37 AM, Ivan Gerasimov

Re: [9] RFR (M): 8069591: Customize LambdaForms which are invoked using MH.invoke/invokeExact

in Invokers.java, I think that checkCustomized should take an Object and not a MethodHandle exactly like getCallSiteTarget takes an Object and not a CallSite. The use of erased types (any ref => Object) in the MH runtime is an artifact of bootstrapping difficulties, early in the project. I ho

Re: RFR 8067748: (process) Child is terminated when parent's console is closed [win]

On 22/01/2015 14:37, Ivan Gerasimov wrote: : It's hard to create a test, which involves closing the console window and manipulating the detached child application. Would you please help review the fix? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8067748 WEBREV: http://cr.openjdk.java.net

Re: [9] RFR (M): 8069591: Customize LambdaForms which are invoked using MH.invoke/invokeExact

Remi, John, thanks for review! Updated webrev: http://cr.openjdk.java.net/~vlivanov/8069591/webrev.01/ This time I did additional testing (COMPILE_THRESHOLD > 0) and spotted a problem with MethodHandle.copyWith(): a MethodHandle can inherit customized LambdaForm this way. I could have added L

Re: RFR (JAXP): 8054196: XPath: support any type

Hi Joe, I just looked at the changes below, I looked at the changes below… see minor comments On Jan 22, 2015, at 12:18 AM, huizhe wang wrote: > > On 1/21/2015 5:09 PM, Lance Andersen wrote: >> Hi Joe, >> >> I think this is OK (as we discussed offline), one minor comment/suggestion >> below

Re: 8050820: Please add java.util.Optional.stream() to convert Optional to Stream

On 01/22/2015 03:53 PM, Paul Sandoz wrote: [...] Yes, it's very tempting to make the source conform to one's own "cultural of code format" (and it's all to easy to hit the reformat hot key in the IDE) [*]. [...] I think what you have done is acceptable from that viewpoint, since the ch

Re: 8050820: Please add java.util.Optional.stream() to convert Optional to Stream

On Jan 21, 2015, at 7:42 PM, John Rose wrote: > On Jan 21, 2015, at 3:01 AM, Paul Sandoz wrote: >> >> I updated the webrev in place to be more consistent in the use of braces and >> better consistency for the primitive specializations: >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8050

RFR 8067748: (process) Child is terminated when parent's console is closed [win]

Hello! It was reported that the fix for JDK-8023130 ((process) ProcessBuilder#inheritIO does not work on Windows) had caused a regression. It manifests itself in the following situation: 1) A console java application starts a child process. 2) The parent then exits without waiting for the chil

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

Thanks, Max. Please see inline. On 01/21/2015 11:29 AM, Wang Weijun wrote: Thanks for adding so many tests. Some suggestions: - JarUtils.java You can use the new InputStream.transferTo() method. Sure, I didn't know about that, thanks. I am not sure if I understand updateJar correctly. It l

Re: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

Kindly reminder On 21.01.2015 16:06, Konstantin Shefov wrote: Hi, Chris I have done a pre-integration testing for this fix on Linux, Windows, Mac and Solaris x64 and sparc. I have run all regression tests for core libraries, and no new failures appeared. Can I push this change now or should

Re: [8u60] - Request for Approval : RFR 8069302 Deprecate Unsafe monitor methods in JDK 8u release

Paul, Approved for jdk8u-dev. Can you add a subcomponent to the bug, add the 9-na label and add a suitable noreg- label. regards, Sean. On 21/01/2015 19:43, John Rose wrote: +1; do it. On Jan 21, 2015, at 2:35 AM, Paul Sandoz wrote: Hi, The Unsafe monitor methods monitorEnter. monitorEx

Re: [PATCH] JDK-8054565: FilterOutputStream.close may throw IOException if called twice and underlying flush or close fails

On 21 Jan 2015, at 22:37, Nathan Clement wrote: > Hi Chris, > > Thanks for your help on this one! Will this be backported to JDK 8, or is > that not allowed because of the spec change? It is possible that the implementation only, not the spec changes, could be backported to 8u. I currently d