Re: FilePermission Canonical path optimization

2015-02-02 Thread deven you
Hi Sean, The performance degradation was reported by creating an object with always getting its canonical path and there is no degradation heard after we made the lazy load patch for the canonical path. I have asked related people to give me an env to create this problem so that I can take a clo

Re: RFR: JDK-8068033: Fix Java Launcher for splash screen.

2015-02-02 Thread Mandy Chung
Looks fine to me. Mandy On 2/2/2015 4:38 PM, Kumar Srinivasan wrote: Hi, Appreciate a review of this fix for JNI correctness when dealing with Splash Screen on MacOSX. http://cr.openjdk.java.net/~ksrini/8068033/webrev.0/ Sergey, I think you took over from Anthony Petrov for SplashScreen, if

RFR: JDK-8068033: Fix Java Launcher for splash screen.

2015-02-02 Thread Kumar Srinivasan
Hi, Appreciate a review of this fix for JNI correctness when dealing with Splash Screen on MacOSX. http://cr.openjdk.java.net/~ksrini/8068033/webrev.0/ Sergey, I think you took over from Anthony Petrov for SplashScreen, if not please have someone in your team look it over. Thanks Kumar

Re: RFR 9 8055330: (process spec) ProcessBuilder.start and Runtime.exec should throw UnsupportedOperationException ...

2015-02-02 Thread Martin Buchholz
On Mon, Feb 2, 2015 at 12:39 PM, Roger Riggs wrote: > If those platforms change their implementation from not supported ever to > maybe-sometimes > under the right conditions then they would supply an implementation that > reports > failures using IOException. In some cases, policy choices shoul

Re: RFR 8064924: Update java.net.URL to work with modules

2015-02-02 Thread Alan Bateman
On 02/02/2015 11:26, Chris Hegarty wrote: I agree with Alan, addURLStreamHandlerFactory is probably an attractive nuisance. It is not strictly necessary to achieve the goal here; replace the problematic ( with modules ) system property with a service lookup. For now, I'd like to move this iss

Re: RFR 9 8055330: (process spec) ProcessBuilder.start and Runtime.exec should throw UnsupportedOperationException ...

2015-02-02 Thread Roger Riggs
Hi, The original protagonist is on vacation this week so the resolution may be delayed. I picked up what seemed like the relatively simple task of making the change. On 2/2/15 11:50 AM, Martin Buchholz wrote: Hi, Y'all seem determined to continue on this course of UnsupportedOperationExcep

Re: JDK 9 RFR of addition to ProblemList.txt

2015-02-02 Thread Roger Riggs
Hi Joe, Looks fine. Roger On 2/2/15 2:56 PM, joe darcy wrote: Hello, The test javax/xml/ws/8046817/GenerateEnumSchema.java has been failing on windows since some recent changes. Please approve the patch below to put the test on the problem list while a full fix is investigated. Than

JDK 9 RFR of addition to ProblemList.txt

2015-02-02 Thread joe darcy
Hello, The test javax/xml/ws/8046817/GenerateEnumSchema.java has been failing on windows since some recent changes. Please approve the patch below to put the test on the problem list while a full fix is investigated. Thanks, -Joe diff -r 541a8cef4e0d test/ProblemList.txt --- a/test/Pr

Re: RFR 9 8055330: (process spec) ProcessBuilder.start and Runtime.exec should throw UnsupportedOperationException ...

2015-02-02 Thread Martin Buchholz
Hi, Y'all seem determined to continue on this course of UnsupportedOperationException-ization, but to me it seems the wrong direction to take. You are reversing the standard Java dogma of checked vs. unchecked exceptions as explained e.g. at http://www.javapractices.com/topic/TopicAction.do?Id=12

Re: RFR 9 8055330: (process spec) ProcessBuilder.start and Runtime.exec should throw UnsupportedOperationException ...

2015-02-02 Thread Roger Riggs
Hi Martin, The choice of UnsupportedOperationException specifies a complete inability of the runtime to ever launch a Process. IOException on the other hand is appropriate in cases where there are configuration or OS implementation dependencies or transient behavior. Existing applications that

Re: RFR 8064924: Update java.net.URL to work with modules

2015-02-02 Thread Paul Sandoz
On Feb 2, 2015, at 12:34 PM, Chris Hegarty wrote: > On 02/02/15 11:00, Paul Sandoz wrote: >> >> On Jan 30, 2015, at 10:10 PM, Alan Bateman wrote: >> >>> On 30/01/2015 15:35, Chris Hegarty wrote: : Update webrev and spec diffs: http://cr.openjdk.java.net/~chegar/8064924

Re: RFR 8072030 Race condition in ThenComposeExceptionTest.java

2015-02-02 Thread Paul Sandoz
On Feb 2, 2015, at 11:41 AM, Chris Hegarty wrote: > On 02/02/15 09:29, Paul Sandoz wrote: >> Hi, >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8072030-thenComposeException-test-race-condition/webrev/ >> >> I introduced a silly race condition in the test >> ThenComposeExceptionTest.java.

Re: RFR 8064924: Update java.net.URL to work with modules

2015-02-02 Thread Chris Hegarty
On 02/02/15 11:00, Paul Sandoz wrote: On Jan 30, 2015, at 10:10 PM, Alan Bateman wrote: On 30/01/2015 15:35, Chris Hegarty wrote: : Update webrev and spec diffs: http://cr.openjdk.java.net/~chegar/8064924/01/ I think the javadoc looks much better now, thanks. Minor comments in URL:

Re: RFR 8064924: Update java.net.URL to work with modules

2015-02-02 Thread Chris Hegarty
I agree with Alan, addURLStreamHandlerFactory is probably an attractive nuisance. It is not strictly necessary to achieve the goal here; replace the problematic ( with modules ) system property with a service lookup. For now, I'd like to move this issue forward without the additional new publi

Re: Explicit Serialization API and Security

2015-02-02 Thread Peter Firmstone
As mentioned I've been experimenting with an invariant validating ObjectInputStream, that's backward and forward compatible with Java's Object Serialization stream protocol. No changes have been made to ObjectOutputStream. ObjectInputStream has been overridden and reading from the stream has

Re: RFR 8064924: Update java.net.URL to work with modules

2015-02-02 Thread Paul Sandoz
On Jan 30, 2015, at 10:10 PM, Alan Bateman wrote: > On 30/01/2015 15:35, Chris Hegarty wrote: >> : >> >> Update webrev and spec diffs: >>http://cr.openjdk.java.net/~chegar/8064924/01/ >> > I think the javadoc looks much better now, thanks. > Minor comments in URL: Java doc on URL constr

Re: RFR: 8071585: Update JAX-WS RI integration to latest version (2.2.11-b150127.1410)

2015-02-02 Thread Miroslav Kos
On 29/01/15 16:06, Alan Bateman wrote: On 29/01/2015 14:51, Aleksej Efimov wrote: Hi, Can I have a review for a bulk update of JAX-B/WS from upstream projects - webrev: http://cr.openjdk.java.net/~aefimov/8071585/webrev/ more details in JBS: https://bugs.openjdk.java.net/browse/JDK-8071585 Th

Re: RFR 8072030 Race condition in ThenComposeExceptionTest.java

2015-02-02 Thread Chris Hegarty
On 02/02/15 09:29, Paul Sandoz wrote: Hi, http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8072030-thenComposeException-test-race-condition/webrev/ I introduced a silly race condition in the test ThenComposeExceptionTest.java. This manifested itself in hotspot testing where various VM options incr

Re: Time to retire System.runFinalizersOnExit?

2015-02-02 Thread Patrick Reinhart
Am 2.2.2015 um 09:09 schrieb Florian Weimer: On 01/30/2015 06:03 PM, Mandy Chung wrote: I see a few callers in Fedora in test suites, but only hsqldb as an actual user in the installed JAR files. Do you see any issue converting them? I haven't tried. I assume that any changes implemented will

RFR 8072030 Race condition in ThenComposeExceptionTest.java

2015-02-02 Thread Paul Sandoz
Hi, http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8072030-thenComposeException-test-race-condition/webrev/ I introduced a silly race condition in the test ThenComposeExceptionTest.java. This manifested itself in hotspot testing where various VM options increased the probability of failure. Than

Re: RFR 8064924: Update java.net.URL to work with modules

2015-02-02 Thread Chris Hegarty
Just catching up… On 2 Feb 2015, at 08:42, Alan Bateman wrote: > On 01/02/2015 10:45, Peter Levart wrote: >> : >> >> I see. But if URLStreamHandlerFactories are only supposed to be located via >> the system class loader, is that different from what we have now when >> URLStreamHandlers are be

Re: RFR 8064924: Update java.net.URL to work with modules

2015-02-02 Thread Alan Bateman
On 01/02/2015 10:45, Peter Levart wrote: : I see. But if URLStreamHandlerFactories are only supposed to be located via the system class loader, is that different from what we have now when URLStreamHandlers are being located directly via class name construction (prefix + protocol + .Handler)

Re: Time to retire System.runFinalizersOnExit?

2015-02-02 Thread Florian Weimer
On 01/30/2015 06:03 PM, Mandy Chung wrote: >> I see a few callers in Fedora in test suites, but only hsqldb as an >> actual user in the installed JAR files. > > Do you see any issue converting them? I haven't tried. I assume that any changes implemented will actually increase resiliency of the t