I think the fix looks good. I haven't had time to look through the
tests in detail (as there are lots)
Stephen
On 4 March 2015 at 19:48, Xueming Shen wrote:
> Stephen and Roger,
>
> This is the DTF.appendZoneOrOffsetId() issues we discussed last year.
> Somehow the
> ball was dropped somewhere :-
On 3/5/2015 1:16 PM, David Holmes wrote:
On 6/03/2015 4:13 AM, Kumar Srinivasan wrote:
Hello,
Please review the following bug-fix:
http://cr.openjdk.java.net/~ksrini/8074373/webrev.00/
Ugghhh! Can't believe we overlooked that :( Are we sure this is the
last remaining glitch here?
Yes :-[
On 6/03/2015 4:13 AM, Kumar Srinivasan wrote:
Hello,
Please review the following bug-fix:
http://cr.openjdk.java.net/~ksrini/8074373/webrev.00/
Ugghhh! Can't believe we overlooked that :( Are we sure this is the last
remaining glitch here?
Looks good.
Thanks,
David
Addresses:
https://bug
I suggest calling the configuration query "static boolean
byteOrderIsBigEndian()". Then it fits better alongside addressSize().
Now that we're down to picking identifiers we're about done. Here are some
observations on names relative to Unsafe, for those who like watching paint dry
on bikeshe
Hello,
Please review the following bug-fix:
http://cr.openjdk.java.net/~ksrini/8074373/webrev.00/
Addresses:
https://bugs.openjdk.java.net/browse/JDK-8074373
Caused by:
http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/37d1442d53bc
Thanks
Kumar
Looks good to me!
On Thu, Mar 5, 2015 at 7:12 AM, Ivan Gerasimov
wrote:
> Hello!
>
> It was noticed, that the javadoc for CharsetDecoder#replaceWith is missing
> the words about constraints on the length of the new replacement string [1].
>
> Another small glitch is that the common part (of both
On 3/5/15 5:37 AM, Chris Hegarty wrote:
I added TestLibrary.createRegistryOnEphemeralPort(). Eventually other tests
using createRegistryOnUnusedPort can be moved over to
createRegistryOnEphemeralPort, and then createRegistryOnUnusedPort removed. For
now, lets just move PinClientSocketFactory.j
Hello!
It was noticed, that the javadoc for CharsetDecoder#replaceWith is
missing the words about constraints on the length of the new replacement
string [1].
Another small glitch is that the common part (of both encoder and
decoder) of the 'newReplacement' param description is prepended to
Hi,
Peter Levart and I have been working on an API to support setting of final
fields during custom deserialization. Dealing with final fields during
deserialization is a pain point only partially addressed in JSR 133 ( in Java 5
). What we are proposing is a simple API solution to resolve this
On 4 Mar 2015, at 21:02, Stuart Marks wrote:
> On 3/4/15 11:14 AM, Chris Hegarty wrote:
>>
>>> On 4 Mar 2015, at 18:10, Stuart Marks wrote:
>>>
>>> Hi Chris,
>>>
>>> Instead of creating a socket factory for this purpose, this test can use
>>> RMI's test library TestLibrary.createRegistryOnU
On 05/03/2015 00:35, huizhe wang wrote:
:
Fixed both.
The update looks good to me.
-Alan
Looks fine frank
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
> On Mar 5, 2015, at 2:30 AM, Frank Yuan wrote:
>
> Hi All
>
>
>
> Would you like to review the co
Looks ok to me.
Thanks
Miran
On 05/03/15 08:30, Frank Yuan wrote:
Hi All
Would you like to review the code change for bug:
https://bugs.openjdk.java.net/browse/JDK-8061293, this is a Jigsaw
related bug, it's to clean up the reference to "jre" dir.
webrev: http://cr.openjdk.java.net/~fyua
On 05/03/15 01:01, David Holmes wrote:
> I'm only glancing at parts of this ...
>
> On 5/03/2015 6:21 AM, Andrew Haley wrote:
>> John's suggestion works well; the code is smaller and neater.
>>
>> http://cr.openjdk.java.net/~aph/unaligned.jdk.3/
>
> This doesn't make sense to me:
>
> 929 /
14 matches
Mail list logo
