On 6/3/15 9:21 AM, Paul Sandoz wrote:
I had prepared an alternative rendition stashed away just in case this came up
:-)
I still want to retain a punchy short first paragraph. What do you think about
the following?
/**
- * Returns a stream consisting of the longest prefix of element
Am Fri, 5 Jun 2015 22:11:08 +0100
schrieb Jonathan Payne :
> My problem was that finalization was not being run at all with the G1
> collector.
The problem that an object is not detected as unreachable and not
enqueued into the finalizer queue is not only a G1 problem. When an
application has ver
Hi.
I have had an interest in the topic of finalization ever since it caused me to
abandon the G1 collector 3 or 4 years ago.
I’ve recently implemented a fix for my interpretation of the problem, which
might be very different from the discussion currently ongoing in the thread
entitled "JEP 13
Yes, the tests look good to me too :-)
I'd suggest a couple of things:
Bug6794483Test: add 8080908 to the bug tag, and year "2015," to the
header. I added a link to JDK-6794483 from JDK-8080908.
LSSerializerTest: was missing a bug tag. I believe the original test was
for 6439439, so add: @bu
Hi Alexander,
Looks good, thanks for the updates.
Roger
On 6/5/2015 1:33 PM, alexander stepanov wrote:
Hello Lance, Roger,
Thank you for the notes, please see the updated webrev:
http://cr.openjdk.java.net/~avstepan/8081517/webrev.01/index.html
(files changed: FtpURLConnection.java, VmIdenti
Hi Alexander
On Jun 5, 2015, at 1:33 PM, alexander stepanov
wrote:
> Hello Lance, Roger,
>
> Thank you for the notes, please see the updated webrev:
> http://cr.openjdk.java.net/~avstepan/8081517/webrev.01/index.html
> (files changed: FtpURLConnection.java, VmIdentifier.java,
> TraceClassVisit
Hi Sherman,
I have a new webrev which reverts that part,
http://cr.openjdk.java.net/~sfriberg/JDK-8080640/webrev.2/
Summary of changes
Reduce lock region in ZipFile.getInputstream
Add private ZipFile.getBytes that can be used in select places in
the JDK where all bytes will be read
Konstantin,
>> I'd like to get an answer to my previous question:
>> "How reliable the test is if it ignores NoSuchMethodException &
>> VirtualMachineError? Are there other manifestations of the problem?"
>>
>> Most notably, have you seen VM crashes w/ -Xcomp running that test?
> I have seen no c
Hello Lance, Roger,
Thank you for the notes, please see the updated webrev:
http://cr.openjdk.java.net/~avstepan/8081517/webrev.01/index.html
(files changed: FtpURLConnection.java, VmIdentifier.java,
TraceClassVisitor.java, HttpAuthenticator.java, PlatformLogger.java and
JdbcRowSetImpl.java - s
Please approve direct backport.
bug: https://bugs.openjdk.java.net/browse/JDK-8066188
jdk9 change set: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f619341171c0
Thanks,
Maxim
Approved.
-Rob
On 05/06/15 16:50, Maxim Soloviev wrote:
Please approve direct backport.
bug: https://bugs.openjdk.java.net/browse/JDK-8066188
jdk9 change set: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f619341171c0
Thanks,
Maxim
Approved.
-Rob
On 05/06/15 16:45, Maxim Soloviev wrote:
Please approve direct backport.
bug: https://bugs.openjdk.java.net/browse/JDK-8059411
jdk9 change set: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/4110a7627857
Thanks,
Maxim
Approved.
-Rob
On 05/06/15 16:39, Maxim Soloviev wrote:
Please approve direct backport.
bug: https://bugs.openjdk.java.net/browse/JDK-8062198
jdk9 change set: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/4162bcc663dc
Thanks,
Maxim
Please approve direct backport.
bug: https://bugs.openjdk.java.net/browse/JDK-8059411
jdk9 change set: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/4110a7627857
Thanks,
Maxim
Please approve direct backport.
bug: https://bugs.openjdk.java.net/browse/JDK-8062198
jdk9 change set: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/4162bcc663dc
Thanks,
Maxim
ok, as Lance mentioned, that can be deferred.
Roger
On 6/5/2015 10:59 AM, alexander stepanov wrote:
> indentation is in the scope of your cleanup
No, I didn't check the indents, lengths of lines etc. (sorry). The
intention was just to fix some tidy warnings (like empty tags) and
javadoc e
> indentation is in the scope of your cleanup
No, I didn't check the indents, lengths of lines etc. (sorry). The
intention was just to fix some tidy warnings (like empty tags) and
javadoc errors like invalid parameter names, invalid tags etc. Tags
were replaced with {@code} in couple of fil
Added some cleanup code around the BufferedReaders & the leftover test
files:
http://cr.openjdk.java.net/~robm/7130985/webrev.02/
-Rob
On 03/06/15 16:20, Rob McKenna wrote:
Meant to get this sorted a while back.
There was a thread on this last year (
http://mail.openjdk.java.net/pipe
Hi Roger
On Jun 5, 2015, at 10:08 AM, Roger Riggs wrote:
>
> 2)
> If indentation is in the scope of your cleanup…
Agree with you and I did not comment on this as I felt it this should be done
separately as there is a fair amount that can be done in these classes for
clean up.
Best
lance
>
>
Hi Alexander,
On code examples, please use the template:
{@code
}
(not just ... )
See TraceClassVisitor.java: 92+
andFtpURLConnection.java:68
I would use @code instead of @literal in HttpAuthenticator.java:59; it
will make the protocol stand out.
Also in PlatformLogger.java:74+
2)
If
This review request covers the main part of the work for JEP-223, the
new version string format [1]. Basically, we'll call this release Java
"9", instead of Java "1.9.0".
This patch is a folding of all work that has been done so far in the
branch JEP-223-branch in jdk9/sandbox. As you can see,
Hi Alxander
Overall. looks OK. A couple of things I thought could be changed;
In FTPURLConnection, I probably would surround the code in an {@code} tag
In VmIdentifier, I do not see think we still need in the tags
Best
Lance
On Jun 5, 2015, at 8:51 AM, alexander stepanov
wrote:
> Hello,
Vladimir
On 06/05/2015 01:16 PM, Vladimir Ivanov wrote:
Konstantin,
The test has the code cache overflow failure only when run with
"-Xcomp", all other failures has been fixed by
https://bugs.openjdk.java.net/browse/JDK-8058733
So my suggestion is either to exclude this test when run with -Xco
Hello,
Could you please review the fix
http://cr.openjdk.java.net/~avstepan/8081517/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8081517
Just some cleanup for docs.
Thanks,
Alexander
On May 26, 2015, at 11:54 AM, Paul Sandoz wrote:
> Here is an updated webrev:
>
>
> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8080945-nearly-sorted-primitives/webrev/
>
Updated with some contributed JMH benchmarks located in the test area. To be
moved when there is a better location (i
Thanks - this version looks good to me.
/Staffan
> On 5 jun 2015, at 13:00, Dmitry Samersoff wrote:
>
> Staffan,
>
> Thank you for review!
>
> Done. Webrev updated in-place (press shift-reload).
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.14
>
> -Dmitry
>
> On 2015-06-05
Hi Frank,
These seem OK. I am sure Joe will also review when he wakes up in his part of
the world :-)
Best
Lance
On Jun 5, 2015, at 3:45 AM, Frank Yuan wrote:
> Hi Joe and all
>
>
>
> I have been working on the test task of JEP 255 Xerces Updates.
>
>
>
> Here I would invite you to revi
Staffan,
Thank you for review!
Done. Webrev updated in-place (press shift-reload).
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.14
-Dmitry
On 2015-06-05 11:20, Staffan Larsen wrote:
> Dmitry,
>
> I’d like to propose the following change to get prettier output (more in line
> wit
Approved.
Regards,
Sean.
On 05/06/15 11:30, Konstantin Shefov wrote:
Please approve direct backport.
bug: https://bugs.openjdk.java.net/browse/JDK-8068416
jdk9 review thread:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-June/033998.html
jdk8u-dev webrev: http://cr.openjdk.java.n
On Jun 5, 2015, at 12:57 AM, Stefan Zobel wrote:
> With respect to the 'stream test library not closing streams' bug:
>
> would you mind to create a separate bugtracker issue for that, or do you
> think it's too special to carry that weight?
>
Not too special just more more work than necessar
Please approve direct backport.
bug: https://bugs.openjdk.java.net/browse/JDK-8068416
jdk9 review thread:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-June/033998.html
jdk8u-dev webrev: http://cr.openjdk.java.net/~kshefov/8068416/webrev.02
Thanks,
-Konstantin
Konstantin,
The test has the code cache overflow failure only when run with
"-Xcomp", all other failures has been fixed by
https://bugs.openjdk.java.net/browse/JDK-8058733
So my suggestion is either to exclude this test when run with -Xcomp or
(better) to reduce iteration number to 1 when -Xcomp
Good.
Best regards,
Vladimir Ivanov
On 6/5/15 1:05 PM, Konstantin Shefov wrote:
Vladimir
Thanks for reviewing
Here is corrected fix:
http://cr.openjdk.java.net/~kshefov/8068416/webrev.02
-Konstantin
On 06/05/2015 01:00 PM, Vladimir Ivanov wrote:
+ * @ignore until 8078602 is fixed
The stand
Vladimir
Thanks for reviewing
Here is corrected fix:
http://cr.openjdk.java.net/~kshefov/8068416/webrev.02
-Konstantin
On 06/05/2015 01:00 PM, Vladimir Ivanov wrote:
+ * @ignore until 8078602 is fixed
The standard way to exclude a test is to mention bug ID.
Use the following:
@ignore 8078602
+ * @ignore until 8078602 is fixed
The standard way to exclude a test is to mention bug ID.
Use the following:
@ignore 8078602
Otherwise, looks good.
Best regards,
Vladimir Ivanov
On 6/5/15 12:48 PM, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8068416
Webrev is http://cr.openjdk.java.net/~kshefov/8068416/webrev.01/
Test failure is caused by JDK-8078602 [1]. Suggestion is to exclude the
test until [1] is fixed.
[1] https://bugs.openjdk.java.net/browse/JDK
On 06/04/2015 10:34 AM, Paul Sandoz wrote:
On Jun 4, 2015, at 10:09 AM, Remi Forax wrote:
On 06/04/2015 09:37 AM, Paul Sandoz wrote:
On Jun 4, 2015, at 9:04 AM, Remi Forax wrote:
Thinking a little more about dropWhile(),
it can be written using filter() more or less like this:
default Str
Dmitry,
I’d like to propose the following change to get prettier output (more in line
with GC.class_histogram):
diff --git a/src/share/vm/services/diagnosticCommand.cpp
b/src/share/vm/services/diagnosticCommand.cpp
--- a/src/share/vm/services/diagnosticCommand.cpp
+++ b/src/share/vm/services/di
Hi Joe and all
I have been working on the test task of JEP 255 Xerces Updates.
Here I would invite you to review the changes for 2 bugs of this task:
1. JDK-8080906 Develop test for Xerces Update: DOM L3 Serializer
To verify default LSSerializer is Xalan dom 3 serializer
2. J
Hi Srikanth,
I would mention that Object is not annotated in the following statements:
- AnnotatedWildcardType.getAnnotatedUpperBounds(): "Note that if no
upper bound is explicitly declared, the upper bound is Object."
- AnnotatedTypeVariable.getAnnotatedBounds(): "Note that if no bound is
expl
40 matches
Mail list logo
