Re: JDK-8057919 Class.getSimpleName() should work for non-JLS compliant class names

2015-06-16 Thread Vladimir Ivanov
Jochen, Let me elaborate on that topic a bit. There are 5 types of classes mentioned in JVMS: - top-level - nested - inner - local - anonymous Example: class TopLevel { static class Nested {} classInner {} void f() { class Local {} } Object o = new TopLevel() {

Re: Spliterators of iterators

2015-06-16 Thread Paul Sandoz
On Jun 15, 2015, at 7:31 PM, Martin Buchholz wrote: > On Mon, Jun 15, 2015 at 10:16 AM, Paul Sandoz wrote: > On Jun 15, 2015, at 6:34 PM, Martin Buchholz wrote: > > Staring at LinkedTransferQueue.java, I see: > > > > return Spliterators.spliterator > >

Re: RFR 8085978 LinkedTransferQueue.spliterator can report LTQ.Node object, not T

2015-06-16 Thread Paul Sandoz
On Jun 15, 2015, at 6:18 PM, Martin Buchholz wrote: > This is a fine fix for a jdk8 backport. > Thanks, i deliberately kept it simple to make the backport easier. > In pursuit of even more perfection for jdk9, we might do some more fiddling > later. Ok. > It bothers me that not all the t

Re: [9] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option

2015-06-16 Thread Konstantin Shefov
Hello, Please, review the new version of the fix to this issue http://cr.openjdk.java.net/~kshefov/8062904/webrev.02/ Here it is suggested to catch all exceptions caused by VirtualmachineException with "Out of CodeCache" message and stop iterations and consider the test as passed if no other

Re: JDK 9 RFR of JDK-8098582: Remove redundant package.html file in javax.xml.ws/wsaddressing

2015-06-16 Thread Lance Andersen
Hi Joe this is fine. I think you should reach out to Miroslav to make sure this change is pushed to the jaxws repository as well Best Lance On Jun 15, 2015, at 2:01 PM, joe darcy wrote: > Hello, > > Not sure the best place to send this out for review / send it upstream, in > any case, press

Re: JDK-8057919 Class.getSimpleName() should work for non-JLS compliant class names

2015-06-16 Thread Vladimir Ivanov
John, That might be an issue here. Just as (String)null and (String)"" are distinct values in Java, in the class file a CP ref of zero differs from a CP ref to a CONSTANT_Utf8 of the empty string "". But the method Class.isAnonymousClass does not make a distinction between those two cases,

Re: RFR 9: 8086208 : java/lang/ProcessHandle/OnExitTest.java: IllegalThreadStateException: process hasn't exited

2015-06-16 Thread Roger Riggs
Hi Martin, On 6/15/2015 6:19 PM, Martin Buchholz wrote: OK, it wasn't clear to me this code was only running in a forkjoin pool. There are several layers in play. The ProcessHandleImpl.completion() method returns a CF that is completed on the ReaperThread. That CF is unique to the PID. a. Whe

Review Request for 8098850: Remove remaining native2ascii resource files and man pages

2015-06-16 Thread Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8098850/webrev.00/ This patch is to remove the native2ascii remaining file that are missed from the changeset of JDK-8074431. src/jdk.dev/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii_ja.java src/jdk.dev/share/classes/sun/tools/n

Re: Review Request for 8098850: Remove remaining native2ascii resource files and man pages

2015-06-16 Thread Alan Bateman
On 16/06/2015 17:58, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8098850/webrev.00/ This patch is to remove the native2ascii remaining file that are missed from the changeset of JDK-8074431. src/jdk.dev/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii_ja.ja

Re: Review Request for 8098850: Remove remaining native2ascii resource files and man pages

2015-06-16 Thread Chris Hegarty
On 16 Jun 2015, at 18:01, Alan Bateman wrote: > On 16/06/2015 17:58, Mandy Chung wrote: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8098850/webrev.00/ >> >> This patch is to remove the native2ascii remaining file that are missed from >> the changeset of JDK-8074431. >> >> src/jdk.dev/sh

Review Request: 8104574 Update tests to prepare for system class loader not be URLClassLoader

2015-06-16 Thread Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8104574/webrev.00/ Pattern like this should be fixed as a ClassLoader is not necessary a URLClassLoader. ((URLClassLoader) ThreadSafety.class.getClassLoader() We have fixed several tests previously. Two more are identified and fixed in this

Re: JDK-8057919 Class.getSimpleName() should work for non-JLS compliant class names

2015-06-16 Thread joe darcy
FYI, "Nested, Inner, Member, and Top-Level Classes" https://blogs.oracle.com/darcy/entry/nested_inner_member_and_top -Joe On 6/16/2015 1:40 AM, Vladimir Ivanov wrote: Jochen, Let me elaborate on that topic a bit. There are 5 types of classes mentioned in JVMS: - top-level - neste

Re: JDK-8057919 Class.getSimpleName() should work for non-JLS compliant class names

2015-06-16 Thread John Rose
What I'm suggesting is that a BC generator might emit a zero length name for a non-anon class, leading to confusion when C.isAnon is called. – John > On Jun 16, 2015, at 5:09 AM, Vladimir Ivanov > wrote: > > John, > >> >> That might be an issue here. Just as (String)null and (String)"" ar

[verona.stage] RFR 8087203: Add support for PATCH field and remove unused fields of new version string

2015-06-16 Thread Alejandro E Murillo
Please review these changes: Bug: https://bugs.openjdk.java.net/browse/JDK-8087202 Webrev: http://cr.openjdk.java.net/~amurillo/9/8087202 These are intended to: (1) Add support for the patch field of the new version string format (2) Remove unused fields remaining from the old version string

Re: JDK-8057919 Class.getSimpleName() should work for non-JLS compliant class names

2015-06-16 Thread David Holmes
On 17/06/2015 8:39 AM, John Rose wrote: What I'm suggesting is that a BC generator might emit a zero length name for a non-anon class, leading to confusion when C.isAnon is called. Is a zero-length "name" for a non-anonymous class valid? getSimpleName() is specified to return "" for anonymous

Re: RFR 9: 8086208 : java/lang/ProcessHandle/OnExitTest.java: IllegalThreadStateException: process hasn't exited

2015-06-16 Thread David Holmes
On 16/06/2015 7:21 AM, Roger Riggs wrote: Hi Martin, Since the function is called from the FJ pool; what would result from propagating the interrupt? The FJPool reports the interrupted to the task but otherwise just clears it. It does not affect the completion status. Since it is known that the

Re: Spliterators of iterators

2015-06-16 Thread Martin Buchholz
On Tue, Jun 16, 2015 at 1:43 AM, Paul Sandoz wrote: > > It's a subtle area. Certain Spliterator characteristics refer to the > (element) source namely, NONULL, IMMUTABLE and CONCURRENT. > Yes, it's subtle. I went back and studied http://download.java.net/jdk9/docs/api/java/util/Spliterator.ht