Hi Kim,
On 06/09/2015 07:44 AM, Peter Levart wrote:
Hi Kim,
Thanks for taking a look at this code.
On 06/09/2015 04:03 AM, Kim Barrett wrote:
On May 31, 2015, at 3:32 PM, Peter Levart wrote:
So, for the curious, here's the improved prototype:
http://cr.openjdk.java.net/~plevart/misc/
Hello Jan,
Build changes look mostly ok. Some notes:
* "$(CFLAGS_WARNINGS_ARE_ERRORS)", which should not be used anymore.
Warnings are already treated as errors globally.
* There should not be a need to add "-I$(INCLUDEDIR)
-I$(JDK_OUTPUTDIR)/include/$(OPENJDK_TARGET_OS)" to cflags. INCLUDED
Hi Erik,
Thanks for the comments. Yes, I copied an existing file, and -DUSE_MMAP
seems unnecessary. I'll implement your suggestions.
Thanks,
Jan
On 22.6.2015 10:25, Erik Joelsson wrote:
Hello Jan,
Build changes look mostly ok. Some notes:
* "$(CFLAGS_WARNINGS_ARE_ERRORS)", which should
Please review changes to ProcessHandle implementation to uniquely identify
processes based on the start time provided by the OS. It addresses the issue
of PID reuse.
This is the implementation of the ProcessHandle.equals() spec change in
8129344 : (process) ProcessHandle instances should defi
Hi Roger,
It looks ok, just some minor stuff.
So basically it is a necessary but not sufficient condition that two equal
processes have the same pid? If so Perhaps it might be possible to weave that
phrase into the docs? Maybe some wording on getPid is also required?
355 * Returns {@cod
The source changes look good to me Paul. I only skimmed over the test changes,
nothing popping out.
-Chris.
On 19 Jun 2015, at 17:07, Paul Sandoz wrote:
> On Jun 19, 2015, at 2:04 PM, Paul Sandoz wrote:
>> There are two main aspects to the webrev:
>>
>> 1) remove the back propagation logic,
Please review at your convenience.
Issue: https://bugs.openjdk.java.net/browse/JDK-8129499
Patch: http://cr.openjdk.java.net/~bpb/8129499/webrev.00/
Summary: The instance variable ‘rmid’ is never initialized due to some error
which occurs before the statement which would initialize it but it i
Hi Brian,
Looks ok.
Roger
On 6/22/2015 4:08 PM, Brian Burkhalter wrote:
Please review at your convenience.
Issue: https://bugs.openjdk.java.net/browse/JDK-8129499
Patch: http://cr.openjdk.java.net/~bpb/8129499/webrev.00/
Summary: The instance variable ‘rmid’ is never initialized due to so
+1
-Chris
> On 22 Jun 2015, at 21:10, Roger Riggs wrote:
>
> Hi Brian,
>
> Looks ok.
>
> Roger
>
>
>> On 6/22/2015 4:08 PM, Brian Burkhalter wrote:
>> Please review at your convenience.
>>
>> Issue:https://bugs.openjdk.java.net/browse/JDK-8129499
>> Patch:http://cr.openjdk.java.net
Hi,
Issue:
https://bugs.openjdk.java.net/browse/JDK-8124977
Webrev:
http://cr.openjdk.java.net/~kshoop/8124977/
This webrev intends to address interaction between Windows console and java
apps.
Two switches were added that change the behavior of the launcher. The defaults
do not change t
This was on my TODO list back in 2005 or so. I never got around to it, in
part because of my personal and Sun's corporate Unix focus, and because
waiting for Win98 to be de-supported was a great way to procrastinate.
It's good for Microsoft employees (actual Windows users) to work on this -
you h
Please review a minor correction so java_props_md.c will compile with
Visual Studio 2010.
(Declarations are allowed in the middle of blocks only in later versions).
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-props-vs1010-8129535/
Issue:
https://bugs.openjdk.java.net/browse/JDK-8129
On 23/06/2015 04:50, Roger Riggs wrote:
Please review a minor correction so java_props_md.c will compile with
Visual Studio 2010.
(Declarations are allowed in the middle of blocks only in later
versions).
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-props-vs1010-8129535/
Issue:
https:/
13 matches
Mail list logo
