Re: RFR 6415680 handle windows EXCEPTION_IN_PAGE_ERROR just as SIGBUS is handled

On 23/06/2015 23:14, Kirk Shoop (MS OPEN TECH) wrote: Hi, webrev http://cr.openjdk.java.net/~kshoop/6415680/ bug: https://bugs.openjdk.java.net/browse/JDK-6415680 The changes for unix to handle SIGBUS need matching work for Windows EXCEPTION_IN_PAGE_ERROR This change uses handler_for_

RFR 6415680 handle windows EXCEPTION_IN_PAGE_ERROR just as SIGBUS is handled

Hi, webrev http://cr.openjdk.java.net/~kshoop/6415680/ bug: https://bugs.openjdk.java.net/browse/JDK-6415680 The changes for unix to handle SIGBUS need matching work for Windows EXCEPTION_IN_PAGE_ERROR This change uses handler_for_unsafe_access for in-page errors while set_doing_safe_acce

RE: RFR 8124977 cmdline encoding challenges on Windows

> From: Martin Buchholz [mailto:marti...@google.com] > "default unicode charset" is a bizarre concept to me.  Do windows users > really have a "regular" charset and a "unicode" charset?  If they do, we > probably want to keep that concept out of the public non-Windows API somehow.  > Also, the "

RE: RFR 8124977 cmdline encoding challenges on Windows

> -Original Message- > From: Anthony Vanelverdinghe > [mailto:anthony.vanelverdin...@gmail.com] > Sent: Tuesday, June 23, 2015 12:12 PM > > I would like to be able to associate file types with a Java program [1]. > Currently, the Java program doesn't receive the argument (i.e. the path to

Re: RFR 8080640: Reduce copying when reading JAR/ZIP entries

looks good! -Sherman On 06/23/2015 12:47 PM, Staffan Friberg wrote: Hi Sherman, Removed the check, http://cr.openjdk.java.net/~sfriberg/JDK-8080640/webrev.4 Cheers, Staffan On 06/23/2015 11:22 AM, Xueming Shen wrote: Hi Staffan, #527 check is probably unnecessary. The size and csize are 32

Re: RFR 8080640: Reduce copying when reading JAR/ZIP entries

Hi Sherman, Removed the check, http://cr.openjdk.java.net/~sfriberg/JDK-8080640/webrev.4 Cheers, Staffan On 06/23/2015 11:22 AM, Xueming Shen wrote: Hi Staffan, #527 check is probably unnecessary. The size and csize are 32-bit unsigned integer, they should never be < 0. The rest looks good

Re: RFR 8124977 cmdline encoding challenges on Windows

Hi Thanks for taking on these challenges. I would like to be able to associate file types with a Java program [1]. Currently, the Java program doesn't receive the argument (i.e. the path to the file that was double-clicked) correctly if it contains Unicode characters. I assume this would be p

Re: RFR 8080640: Reduce copying when reading JAR/ZIP entries

Hi Staffan, #527 check is probably unnecessary. The size and csize are 32-bit unsigned integer, they should never be < 0. The rest looks good. Thanks, -Sherman On 06/23/2015 10:54 AM, Staffan Friberg wrote: Hi Sherman, Thanks for the review. I removed the unused import and the changes to re

Re: RFR 8080640: Reduce copying when reading JAR/ZIP entries

Hi Sherman, Thanks for the review. I removed the unused import and the changes to reduce the lock region. New webrev, http://cr.openjdk.java.net/~sfriberg/JDK-8080640/webrev.3 Thanks, Staffan On 06/08/2015 02:37 PM, Xueming Shen wrote: Staffan, (1) ByteArrayInputSteram is no longer needed

Re: RFR: 8129572 - Cleanup usage of getResourceAsStream in jaxp

On 23/06/15 16:44, Alan Bateman wrote: On 23/06/2015 15:16, Daniel Fuchs wrote: Hi, Please find below a patch for 8129572 - Cleanup usage of getResourceAsStream in jaxp https://bugs.openjdk.java.net/browse/JDK-8129572 http://cr.openjdk.java.net/~dfuchs/webrev_8129572/webrev.00/ This removes

Re: RFR: 8129572 - Cleanup usage of getResourceAsStream in jaxp

On 23/06/15 17:14, Claes Redestad wrote: "priveleged" typo in: http://cr.openjdk.java.net/~dfuchs/webrev_8129572/webrev.00/jaxp/src/java.xml/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSystemProperty.java.udiff.html The line isn't touched by the patch, but might be a nice driv

Re: RFR: 8129572 - Cleanup usage of getResourceAsStream in jaxp

Hi Daniel, Thanks for the cleanup! The webrev looks good to me too. -Joe On 6/23/2015 8:52 AM, Mandy Chung wrote: On Jun 23, 2015, at 7:16 AM, Daniel Fuchs wrote: Hi, Please find below a patch for 8129572 - Cleanup usage of getResourceAsStream in jaxp https://bugs.openjdk.java.net/browse/

RFR: 8076139: [TEST_BUG] test/javax/xml/ws/8046817/GenerateEnumSchema.java creates files in test.src

Hi, Please, review, comment and approve GenerateEnumSchema.java test bug fix [1]. It solves the following problem: test launches schemagen tool from a 'test.src' folder and in cases when 'test.src' is not writeable failure occurs. The proposed fix [2] solves this issue - it creates a test fol

Re: RFR 9: 8129535: java_props_md.c should compile on VS 2010

Hi Roger, thanks for doing this change! I already had this on my list as well as we at SAP are also still using VS2010 - and probably will use it for quite some time :( The bug was actually a C99 feature which isn't supported by the C-compiler of VS2010 (see http://herbsutter.com/2012/05/03/reade

Re: RFR: 8129572 - Cleanup usage of getResourceAsStream in jaxp

> On Jun 23, 2015, at 7:16 AM, Daniel Fuchs wrote: > > Hi, > > Please find below a patch for > > 8129572 - Cleanup usage of getResourceAsStream in jaxp > https://bugs.openjdk.java.net/browse/JDK-8129572 > > http://cr.openjdk.java.net/~dfuchs/webrev_8129572/webrev.00/ This looks okay to me.

Re: RFR: 8129572 - Cleanup usage of getResourceAsStream in jaxp

On 23/06/2015 15:16, Daniel Fuchs wrote: Hi, Please find below a patch for 8129572 - Cleanup usage of getResourceAsStream in jaxp https://bugs.openjdk.java.net/browse/JDK-8129572 http://cr.openjdk.java.net/~dfuchs/webrev_8129572/webrev.00/ This removes a bunch of unused getResourceAsStream me

RFR: 8129572 - Cleanup usage of getResourceAsStream in jaxp

Hi, Please find below a patch for 8129572 - Cleanup usage of getResourceAsStream in jaxp https://bugs.openjdk.java.net/browse/JDK-8129572 http://cr.openjdk.java.net/~dfuchs/webrev_8129572/webrev.00/ This removes a bunch of unused getResourceAsStream methods and sanitizes the few that remain.

Re: RFR 9: 8129535: java_props_md.c should compile on VS 2010

On 23/06/2015 14:20, Roger Riggs wrote: Hi Alan, Dropping VS2010 should probably a deliberate choice/state, not just an oversight in coding. Its also a style question, if this were shared code I think Solaris also complains about inline declarations; but that too may be due to an older tool

Re: RFR 9: 8129535: java_props_md.c should compile on VS 2010

Hi Alan, Dropping VS2010 should probably a deliberate choice/state, not just an oversight in coding. Its also a style question, if this were shared code I think Solaris also complains about inline declarations; but that too may be due to an older tool chain. Thanks, Roger On 6/23/2015 2:42

Re: [9] Review request: JDK-8129532: LFMultiThreadCachingTest.java failed with ConcurrentModificationException

Looks good. Best regards, Vladimir Ivanov On 6/23/15 1:43 PM, Konstantin Shefov wrote: Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8129532 Webrev is http://cr.openjdk.java.net/~kshefov/8129532/webrev.00/ Thanks -Konstantin

Re: [8u60] RFA 8129120 Terminal operation properties should not be back-propagated to upstream operations

On Jun 23, 2015, at 10:53 AM, Seán Coffey wrote: > Hi Paul, > > Best to get a peer review on this before pushing to jdk8u-dev. > Ok, including core-libs. The JPRT job passed. I additionally ran the 8b JCK tests, which all passed. Paul. > Approved. If you get this into jdk8u-dev before Frid

[9] Review request: JDK-8129532: LFMultiThreadCachingTest.java failed with ConcurrentModificationException

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8129532 Webrev is http://cr.openjdk.java.net/~kshefov/8129532/webrev.00/ Thanks -Konstantin