Re: RFR: 8032446: Support Unicode 7.0.0 in JDK 9

Looks OK to me too. Masayoshi On 7/15/2015 8:16 AM, Naoto Sato wrote: > Looks good to me. > > Naoto > > On 7/13/15 1:20 AM, Yuka Kamiya wrote: >> Hello, >> >> Please review the fix for 8032446 to support Unicode 7 in JDK 9. >> >> https://bugs.openjdk.java.net/browse/JDK-8032446 >> http://cr.openj

Re: [9]RFR 8130394: DatagramChannel tests need to be hardened to ignore stray datagrams

+1, looks fine. On 7/14/15 9:09 PM, Brian Burkhalter wrote: On Jul 10, 2015, at 12:31 AM, FELIX YANG wrote: Hi all, please help to review the change for 8130394. Issue: https://bugs.openjdk.java.net/browse/JDK-8130394 Patch:http://cr.openjdk.java.net/~fyuan/felix/8130394/ The

Re: [9]RFR 8130394: DatagramChannel tests need to be hardened to ignore stray datagrams

On Jul 10, 2015, at 12:31 AM, FELIX YANG wrote: > Hi all, > please help to review the change for 8130394. > > Issue: https://bugs.openjdk.java.net/browse/JDK-8130394 > Patch:http://cr.openjdk.java.net/~fyuan/felix/8130394/ > > The patch updates tests to ignore stray datagrams, or at

Re: RFR: 8032446: Support Unicode 7.0.0 in JDK 9

Looks good to me. Naoto On 7/13/15 1:20 AM, Yuka Kamiya wrote: > Hello, > > Please review the fix for 8032446 to support Unicode 7 in JDK 9. > > https://bugs.openjdk.java.net/browse/JDK-8032446 > http://cr.openjdk.java.net/~peytoia/8032446/webrev.00/ > > - Internal review for both open & close

Re: RFR 9: JDK-8130877 : (process) java/lang/ProcessHandle/TreeTest test3 failure - Destroyed process.isAlive

Hi Roger, Looks fine; thanks, -Joe On 7/13/2015 2:13 PM, Roger Riggs wrote: Please review a testbug to correctly look for destroyed processes. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-isalive-8130877/ Issue: https://bugs.openjdk.java.net/browse/JDK-8130877 Thanks, Roger

Re: RFR 9: JDK-8130877 : (process) java/lang/ProcessHandle/TreeTest test3 failure - Destroyed process.isAlive

Thanks Joe, On 7/14/2015 5:22 PM, Joseph D. Darcy wrote: Hi Roger, Looks fine; thanks, -Joe On 7/13/2015 2:13 PM, Roger Riggs wrote: Please review a testbug to correctly look for destroyed processes. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-isalive-8130877/ Issue: https://bu

Re: RFR 8124977 cmdline encoding challenges on Windows

Hi Kirk, I took another pass over the changes. IMHO, we need to make it easier for people to use this feature, and eliminate these two, atleast externally. "-Dwindows.UnicodeConsole=true", "-Dfile.encoding.unicode=\"UTF-8\"", Can we invent a new command line arg ? we can make it an -X flag, by

Re: [PATCH] javax,script.ScriptEngineFactory Typos

Hi Sidharth, You are totally right, sorry for that. Actually, it seems to be Eclipse Mars bug, since it shows double "}".  I will open a case there. Thanks,Ahmed From: A. Sundararajan To: core-libs-dev@openjdk.java.net; Ahmed Ashour ; "nashorn-...@openjdk.java.net" Sent: Tuesday, July

Re: Fwd: Re: [PATCH] javax,script.ScriptEngineFactory Typos

Hi Ahmed, Did you build the forest with that change or just "found" by code reading? Because {@code requires } to end it. So, those were not 'extra' '}' chars in doc comments. Also, you can check javadoc output is correct. i.e., no extra "}". http://docs.oracle.com/javase/8/docs/api/javax/sc

JDK 9 RFR of JDK-8131140: Mark some tests from WhileOpStatefulTest.java and WhileOpTest.java as serialization hostile

Stream tests WhileOpStatefulTest and WhileOpTest were newly introduced in JDK-8071597, some test cases should be marked as serialization-hostile (such tests will be ignored by lambda serialization testing framework). Please review and sponsor this change: bug: https://bugs.openjdk.java.net/br