RFR for 8068761 : Test java/nio/channels/ServerSocketChannel/AdaptServerSocket.java failed with SocketTimeoutException

2015-07-20 Thread Tristan Yan
Hi Please review small fix for test java/nio/channels/ServerSocketChannel/AdaptServerSocket.java. webrev: http://cr.openjdk.java.net/~tyan/8068761/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8068761

RFR (jaxp) 8131907 : Numerous threads lock during XML processing

2015-07-20 Thread huizhe wang
Please review a change that removes unnecessary class loading. http://cr.openjdk.java.net/~joehw/jdk9/8131907/webrev/ Thanks, Joe

Re: JDK 9 RFR of JDK-8081734 : ConcurrentHashMap/ConcurrentAssociateTest.java, times out 90% of time on sparc with 256 cpu.

2015-07-20 Thread Chris Hegarty
This seems reasonable to me Joe. -Chris. > On 20 Jul 2015, at 22:15, joe darcy wrote: > > Hello, > > Please review a small change to adders > >JDK-8081734 : ConcurrentHashMap/ConcurrentAssociateTest.java, times out > 90% of time on sparc with 256 cpu. >http://cr.openjdk.java.net/~dar

JDK 9 RFR of JDK-8081734 : ConcurrentHashMap/ConcurrentAssociateTest.java, times out 90% of time on sparc with 256 cpu.

2015-07-20 Thread joe darcy
Hello, Please review a small change to adders JDK-8081734 : ConcurrentHashMap/ConcurrentAssociateTest.java, times out 90% of time on sparc with 256 cpu. http://cr.openjdk.java.net/~darcy/8081734.0/ Patch below. Some background, when run on large machines, 256 processors/threads, thi

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-07-20 Thread Xueming Shen
On 07/20/2015 10:22 AM, Kirk Shoop wrote: So when default system locale differs from the active one, we have different behavior on Linux and Windows. The new options allow a windows user to select the same behavior that one would expect on unix. The switches can certainly be removed, if the

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-07-20 Thread Kirk Shoop
Hi, The switches were introduced to prevent compatibility impact for existing usage on Windows. If the impact is acceptable then the next webrev will remove both of them and instead change the default behavior on windows to read the commandline in Unicode and to output UTF-8 to a console that h

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-07-20 Thread Kirk Shoop
Hi, (1) Yes, the changes don't update the underlying console encoding. There is guidance that apps should not change the console encoding as it would affect other commands in the same console. A script must explicitly use chcp to change the codepage. The change has a new option "file.encoding.

Stream.generate

2015-07-20 Thread Remi Forax
Hi all, hi Paul, I've found that the signature of Stream.generate doesn't to use a wildcard hence some program are rejected even if there are valid, by example: public static void main(String[] args) { Supplier supplier = () -> "hello"; Stream s = Stream.generate(supplier); } T

Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

2015-07-20 Thread Roger Riggs
Hi Volker, yes, press ahead. On the _unix topic, I think the most platforms depends on when/how/what you count. I was following the prior pattern that counted OS X as being mostly common with Linux and Oracle Linux as a Redhat derivative. That counts at least as 2 I think. I'd be interested

Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

2015-07-20 Thread Volker Simonis
Hi Roger, thanks for looking at the webrev. Please find my comments inline: On Mon, Jul 20, 2015 at 4:01 PM, Roger Riggs wrote: > Hi Volker, > > yes, generally, the approach is an improvement and provides a clearer > model of os specific variations. > > More comments inline... > > > On 7/17/2015

Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

2015-07-20 Thread Roger Riggs
Hi Volker, yes, generally, the approach is an improvement and provides a clearer model of os specific variations. More comments inline... On 7/17/2015 2:28 PM, Volker Simonis wrote: Hi, I worked on refactoring the native ProcessHandleImpl implementation to enable more code sharing and make it

Re: StackOverflowError on HashMap.hashCode() due to self reference

2015-07-20 Thread Florian Weimer
On 07/17/2015 09:25 PM, Louis Wasserman wrote: > The Javadoc of Map already specifies: > >> > Note: great care must be exercised if mutable objects are used as map > keys. The behavior of a map is not specified if the value of an object is > changed in a manner that affects equals comparisons whil

[9] RFR: 8130006: java/lang/invoke/MethodHandles/CatchExceptionTest Fails

2015-07-20 Thread Konstantin Shefov
Hello, Please review a test bug fix. An exception caused by code cache overflow should be re-thrown before assertion check in the test. Bug: https://bugs.openjdk.java.net/browse/JDK-8130006 Webrev: http://cr.openjdk.java.net/~kshefov/8130006/webrev.00/ -Konstantin