Re: RFR 9: 8133022: Instant.toEpochMilli() silently overflows

Thanks Roger! On 06.08.2015 21:07, Roger Riggs wrote: Hi, Please review the update to include the additional case and fix. http://cr.openjdk.java.net/~rriggs/webrev-overflow-8133022/ In TCKInstant.java, the second testcase could be written as Instant.ofEpochSecond(Long.MIN_VALUE / 10

Re: RFR 9: 8133022: Instant.toEpochMilli() silently overflows

looks good. On 8/6/15 11:07 AM, Roger Riggs wrote: Hi, Please review the update to include the additional case and fix. http://cr.openjdk.java.net/~rriggs/webrev-overflow-8133022/ Thanks, Roger On 8/6/2015 12:37 PM, Roger Riggs wrote: Hi Ivan, I looked at that but didn't find a reproducer

Re: RFR 9: 8133022: Instant.toEpochMilli() silently overflows

Fine by me. Stephen On 6 Aug 2015 19:15, "Chris Hegarty" wrote: > > On 6 Aug 2015, at 19:07, Roger Riggs wrote: > > > Hi, > > > > Please review the update to include the additional case and fix. > > > > http://cr.openjdk.java.net/~rriggs/webrev-overflow-8133022/ > > The updated version looks goo

Re: RFR 9: 8133022: Instant.toEpochMilli() silently overflows

On 6 Aug 2015, at 19:07, Roger Riggs wrote: > Hi, > > Please review the update to include the additional case and fix. > > http://cr.openjdk.java.net/~rriggs/webrev-overflow-8133022/ The updated version looks good Roger. -Chris. > Thanks, Roger > > > On 8/6/2015 12:37 PM, Roger Riggs wrote

Re: RFR 9: 8133022: Instant.toEpochMilli() silently overflows

Hi, Please review the update to include the additional case and fix. http://cr.openjdk.java.net/~rriggs/webrev-overflow-8133022/ Thanks, Roger On 8/6/2015 12:37 PM, Roger Riggs wrote: Hi Ivan, I looked at that but didn't find a reproducer. I'll add that test case and respin. Thanks, Roger

Re: RFR JDK-8022224: Intermittent test failures in sun/nio/cs/FindDecoderBugs.java, ,

On Thu, Aug 6, 2015 at 12:52 AM, Chris Hegarty wrote: > > On 6 Aug 2015, at 00:28, Martin Buchholz wrote: > > > > On Wed, Aug 5, 2015 at 12:29 PM, Chris Hegarty > wrote: > > The change looks ok to me Sherman. > > > > Should the bug synopsis be updated? It looks like a test bug rather than > a p

Re: RFR 9: 8133022: Instant.toEpochMilli() silently overflows

Hi Ivan, I looked at that but didn't find a reproducer. I'll add that test case and respin. Thanks, Roger On 8/6/2015 12:34 PM, Ivan Gerasimov wrote: Hi Roger! There seems to be another numeric overflow possibility a the line# 1235, when 'seconds' is a large negative and 'nanos' is a small

Re: RFR 9: 8133022: Instant.toEpochMilli() silently overflows

Hi Roger! There seems to be another numeric overflow possibility a the line# 1235, when 'seconds' is a large negative and 'nanos' is a small positive. For example, Instant inst = Instant.ofEpochSecond(-9223372036854776L, 1); System.out.println(inst.toEpochMilli());

Re: RFR 9: 8133022: Instant.toEpochMilli() silently overflows

+1 On Aug 6, 2015, at 11:33 AM, Roger Riggs wrote: > Please review a small fix and test for Instant.toEpochMilli > ArithmeticOverflow. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-overflow-8133022/ > > Issue: >https://bugs.openjdk.java.net/browse/JDK-8133022 > > Thanks, Roger

Re: RFR 9: 8133022: Instant.toEpochMilli() silently overflows

Looks fine Roger. -Chris. On 6 Aug 2015, at 16:33, Roger Riggs wrote: > Please review a small fix and test for Instant.toEpochMilli > ArithmeticOverflow. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-overflow-8133022/ > > Issue: >https://bugs.openjdk.java.net/browse/JDK-81330

Re: RFR 9: 8133022: Instant.toEpochMilli() silently overflows

Hi Roger, Not a math expert, but this looks good to me :-) best regards, -- daniel On 06/08/15 17:33, Roger Riggs wrote: Please review a small fix and test for Instant.toEpochMilli ArithmeticOverflow. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-overflow-8133022/ Issue: https:

Re: RFR 9: 8133022: Instant.toEpochMilli() silently overflows

Looks good! Thanks, Volker On Thu, Aug 6, 2015 at 5:33 PM, Roger Riggs wrote: > Please review a small fix and test for Instant.toEpochMilli > ArithmeticOverflow. > > Webrev: >http://cr.openjdk.java.net/~rriggs/webrev-overflow-8133022/ > > Issue: > https://bugs.openjdk.java.net/browse/JDK

Re: RFR [9] 8133115: docs: replace tags (obsolete in html5) for java.util.logging, java.util.prefs, java.util.zip, java.util.jar

Thanks! On 8/6/2015 6:33 PM, Lance Andersen wrote: Looks fine Best Lance On Aug 6, 2015, at 11:08 AM, Alexander Stepanov > wrote: Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133115/webrev.00

RFR 9: 8133022: Instant.toEpochMilli() silently overflows

Please review a small fix and test for Instant.toEpochMilli ArithmeticOverflow. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-overflow-8133022/ Issue: https://bugs.openjdk.java.net/browse/JDK-8133022 Thanks, Roger

Re: RFR [9] 8133115: docs: replace tags (obsolete in html5) for java.util.logging, java.util.prefs, java.util.zip, java.util.jar

Looks fine Best Lance On Aug 6, 2015, at 11:08 AM, Alexander Stepanov wrote: > Hello, > > Could you please review the following fix: > http://cr.openjdk.java.net/~avstepan/8133115/webrev.00 > for > https://bugs.openjdk.java.net/browse/JDK-8133115 > > Just a next portion of "" tags removed. >

RFR(XS): 8133105: Fix getFinalAttributes() on Windows to handle more special cases

Hi, can somebody please review the following small fix contributed by matthias.baes...@sap.com: http://cr.openjdk.java.net/~simonis/webrevs/2015/8133105/ https://bugs.openjdk.java.net/browse/JDK-8133105 Getting file attributes on Windows via GetFileAttributesExW() can fail for some special syste

RFR [9] 8133115: docs: replace tags (obsolete in html5) for java.util.logging, java.util.prefs, java.util.zip, java.util.jar

Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133115/webrev.00 for https://bugs.openjdk.java.net/browse/JDK-8133115 Just a next portion of "" tags removed. specdiffs did not detect any changes for java.util package: http://cr.openjdk.java.net/~avstepan/

Re: [9] RFR: 8060717: [TESTBUG] Improve test coverage of MethodHandles.explicitCastArguments()

Please, look at the modified test http://cr.openjdk.java.net/~kshefov/8060717/webrev.01/ -Konstantin On 08/06/2015 02:06 PM, Konstantin Shefov wrote: Hi Vladimir Thanks for reviewing On 08/06/2015 01:02 PM, Vladimir Ivanov wrote: Konstantin, Overall, looks good. Why do you create a new C

JDK 9 RFR of JDK-8079769: tools/pack200/PackTestZip64.java may timeout at preparing the large test file

Please review the fix for test issue: tools/pack200/PackTestZip64.java may timeout at preparing the large test file This test tries to create a big jar file for testing by adding a large number (Short.MAX_VALUE * 2 + 2) of small files to the golden jar (golden.jar). This prepare work is i/o se

Re: [9] RFR: 8060717: [TESTBUG] Improve test coverage of MethodHandles.explicitCastArguments()

Hi Vladimir Thanks for reviewing On 08/06/2015 01:02 PM, Vladimir Ivanov wrote: Konstantin, Overall, looks good. Why do you create a new ClassLoader here and not simply reference them directly (they are loaded by application class loader)? You a right. Because of class loader hierarchy, all

Re: RFR [9] 8133040: docs: replace tags (obsolete in html5) for java.management

Hello Daniel, Thanks! Regards, Alexander On 8/6/2015 1:14 PM, Daniel Fuchs wrote: Hi Alexander, Cursory inspection of the patch file has not revealed anything wrong. Specdiff looks OK, so that's good for me. best regards, -- daniel On 05/08/15 19:37, Alexander Stepanov wrote: > javax.man

Re: RFR [9] 8133040: docs: replace tags (obsolete in html5) for java.management

Hi Alexander, Cursory inspection of the patch file has not revealed anything wrong. Specdiff looks OK, so that's good for me. best regards, -- daniel On 05/08/15 19:37, Alexander Stepanov wrote: > javax.management - one (expected) change in TabularDataSupport: (full package diff: http://cr.o

Re: RFR [9] 8132468: docs: replace tags (obsolete in html5) for java.io, java.lang, java.math

Thanks! On 8/5/2015 10:46 PM, Stuart Marks wrote: Hi Alexander, The changes to File.java look good. Thanks for doing the specdiffs as well; it's a good way to verify that even with all these markup changes, specdiff didn't detect any changes to java.io.File at all. (I didn't look at other f

Re: [9] RFR: 8060717: [TESTBUG] Improve test coverage of MethodHandles.explicitCastArguments()

Konstantin, Overall, looks good. Why do you create a new ClassLoader here and not simply reference them directly (they are loaded by application class loader)? +public static void testNonBCPRef2Ref() throws Throwable { +String testClassPath = System.getProperty("test.classes",".");

Re: [9] RFR: 8060717: [TESTBUG] Improve test coverage of MethodHandles.explicitCastArguments()

Kindly reminder On 08/03/2015 06:06 PM, Konstantin Shefov wrote: Michael, thanks for reviewing! Vladimir, could you take a look, please? -Konstantin On 08/02/2015 05:31 PM, Michael Haupt wrote: Hi Konstantin, Am 31.07.2015 um 18:37 schrieb Konstantin Shefov mailto:konstantin.she...@oracle.

Re: RFR JDK-8022224: Intermittent test failures in sun/nio/cs/FindDecoderBugs.java, ,

On 6 Aug 2015, at 00:28, Martin Buchholz wrote: > > On Wed, Aug 5, 2015 at 12:29 PM, Chris Hegarty > wrote: > The change looks ok to me Sherman. > > Should the bug synopsis be updated? It looks like a test bug rather than a > product one. > > Why do you say that? The JISAutoDetect charset

Re: RFR [9] 8132468: docs: replace tags (obsolete in html5) for java.io, java.lang, java.math

Hi Alexander, On 8/5/15 2:01 PM, Alexander Stepanov wrote: Hello Stuart, Please see the final version of File.java (please update the page) - just replacing with in the mentioned places: http://cr.openjdk.java.net/~avstepan/8132468/webrev.01/src/java.base/share/classes/java/io/File.java.udif