Re: RFR(m) 2: 8072722: add stream support to Scanner

2015-09-04 Thread Stuart Marks
Hi Tagir, Well spotted! I'll fix this. Thanks, s'marks On 9/3/15 11:57 PM, Tagir F. Valeev wrote: Hello! In tokens() JavaDoc: * {@code * List result = new Scanner("abc,def,,ghi").useDelimiter(","). * .tokens().collect(Collectors.toList()); * } Here the dot is du

Re: RFR 8080486: JNI exception pending in jdk/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c

2015-09-04 Thread Chris Hegarty
The changes look fine to me too. -Chris. On 04/09/15 16:04, Daniel Fuchs wrote: Hi Vyom, I'm not a net/JNI expert but what you are proposing looks good to me too. Ivan has already given his assent. Unless I hear objections - or comments from other reviewers, I will sponsor this change and pus

Re: RFR 8080486: JNI exception pending in jdk/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c

2015-09-04 Thread Alan Bateman
On 04/09/2015 16:04, Daniel Fuchs wrote: Hi Vyom, I'm not a net/JNI expert but what you are proposing looks good to me too. Ivan has already given his assent. Unless I hear objections - or comments from other reviewers, I will sponsor this change and push it for you (I'll wait for Monday). I

Re: RFR 8080486: JNI exception pending in jdk/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c

2015-09-04 Thread Daniel Fuchs
Hi Vyom, I'm not a net/JNI expert but what you are proposing looks good to me too. Ivan has already given his assent. Unless I hear objections - or comments from other reviewers, I will sponsor this change and push it for you (I'll wait for Monday). best regards, -- daniel On 02/09/15 15:55,

Re: RFR(m) 2: 8072722: add stream support to Scanner

2015-09-04 Thread Paul Sandoz
Hi Stuart, This is looking very good. Just some comments on the tricky aspect related to late-binding of the Stream to the scanner state: 2652 * This scanner's state should not be modified during execution of the returned 2653 * stream's pipeline. Subsequent calls to any methods on t