Re: RFR: 8136570: Avoid setting environment variables related to /usr/dt

I don't understand that original assessment. Switching to XAWT had no impact on this code except to make it pointless. i.e it did not prevent its execution. I doubt there is any code left in the JDK that will derive any benefit from it still being there. All CDE/Motif & Xt related code is gone.

Re: RFR(m) 2: 8072722: add stream support to Scanner

On 9/10/15 2:12 PM, Xueming Shen wrote: I think it might be a "nice to have" for a "fail-fast" effort after the the consumer consumed/accepted the result (the second check), but isn't it a bug for the consumer to accept any result if there is CME condition occurred already? I'm not sure

Re: RFR 9: 8133528 : java/lang/ProcessHandle/OnExitTest.java fails intermittently

Looks good to me, Roger. Thanks, Joe On 9/15/2015 3:20 PM, Roger Riggs wrote: Please review this test fix to remove checks for subprocesses not spawned by the test. There are spurious processes (like virus checkers) that show up unexpectedly. webrev:

RFR: 8136583: Core libraries should use blessed modifier order

Hi, Chris and Paul, I'd like you to do a very boring code review. This change is entirely machine generated. (the script is more interesting) http://cr.openjdk.java.net/~martin/webrevs/openjdk9/blessed-modifier-order/blessed-modifier-order.patch https://bugs.openjdk.java.net/browse/JDK-8136583

JDK 9 RFR of JDK-8134795: Port fdlibm pow to Java

Hello, At long last, I've started the port of the C version of FDLIBM (freely distributable math library) from C to Java, beginning with the pow method: JDK-8134795: Port fdlibm pow to Java http://cr.openjdk.java.net/~darcy/8134795.6/ The FDLIBM algorithms provide direct backing to

RFR 9: 8133528 : java/lang/ProcessHandle/OnExitTest.java fails intermittently

Please review this test fix to remove checks for subprocesses not spawned by the test. There are spurious processes (like virus checkers) that show up unexpectedly. webrev: http://cr.openjdk.java.net/~rriggs/webrev-onexittest-8133528/ Issue:

Re: RFR: 8136570: Avoid setting environment variables related to /usr/dt

We would be entirely happy if the environment frobbing code were to be deleted. Should I change my code to do that? On Tue, Sep 15, 2015 at 3:49 PM, Phil Race wrote: > I don't understand that original assessment. > Switching to XAWT had no impact on this code except to

Modifier order for 'default' (was: RFR: 8136583: Core libraries should use blessed modifier order)

Martin, this will be known as the "blame martin" patch, good work. But more seriously a minor thing I noticed in your shell script (as well as the mentioned sources and some coding guidelines), the new interface `default` method modifier is not defined in any of those lists. Not sure if it is

RFR: 8136570: Avoid setting environment variables related to /usr/dt

I reported this bug 12 years ago, but it was closed Will Not Fix, and this year I see java programs crashing because of it! This is a partial fix. https://bugs.openjdk.java.net/browse/JDK-8136570 https://bugs.openjdk.java.net/browse/JDK-4953367

Re: JDK 9 RFR of JDK-8136506: Include sun.arch.data.model as a property that can be queried by jtreg

On 15/09/2015 01:30, Joseph D. Darcy wrote: Hello, Please review the patch below for JDK-8136506: Include sun.arch.data.model as a property that can be queried by jtreg This looks okay, are there are any tests lining up to use this? -Alan

Re: Question about CachedRowSetImpl

Hello, Can you provide a full stacktrace, the copy+paste of the error message, what jdbc driver you use and a code snippet? (I think from the age of the bug it must be even fixed in 1.6 long ago) Gruss Bernd Carolyn Kim schrieb am Mo., 14. Sep. 2015 18:33: > Hi, >

Re: URLClassPath does unnecessary linear search through every jar and jar entry to find resource

Hi Adrian, I looked briefly at your code and claims and have some comments inline... On 09/13/2015 11:08 AM, Adrian wrote: Hi, I posted about this earlier (few weeks ago), and got some responses about concerns which I addressed in my last email, though I didn't hear back about it. My

Re: JDK 9 RFR of JDK-8136506: Include sun.arch.data.model as a property that can be queried by jtreg

On 9/15/2015 2:38 AM, Alan Bateman wrote: On 15/09/2015 01:30, Joseph D. Darcy wrote: Hello, Please review the patch below for JDK-8136506: Include sun.arch.data.model as a property that can be queried by jtreg This looks okay, are there are any tests lining up to use this? In

Re: [9] Review request JDK-8131667: JAX-WS Plugability Layer: using java.util.ServiceLoader

On 27/08/2015 19:26, Miroslav Kos wrote: Hi Alan, I added logging (at least for now) - would it work for you? updated webrev: http://cr.openjdk.java.net/~mkos/8131667/jaxws.02/ If you think the exception shouldn't be ignored I suggest to solve this in separate issue (and maybe revisit all

[9] Review request JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

Hi everybody, I am sending changes for review for JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader JBS: https://bugs.openjdk.java.net/browse/JDK-8131334 webrev: http://cr.openjdk.java.net/~mkos/8131334/jaxws.01/ It's about migrating to standard java.util.ServiceLoader. This