Re: [RFR] (S) 8140189: [TESTBUG] Get rid of "@library /../../test/lib" in jtreg tests

2015-10-27 Thread Chris Plummer
Hello, I've fixed the new jvmci tests. New webrevs found here: http://cr.openjdk.java.net/~cjplummer/8140189/webrev.01/webrev.hotspot http://cr.openjdk.java.net/~cjplummer/8140189/webrev.01/webrev.jdk Only the hotspot/test/compiler/jvmci files have changed since the previous webrev. If you jus

Re: [9] RFR: 8139743 regular JAX-* sync-up from standalone repos

2015-10-27 Thread Lance Andersen
Ok, looks fine now On Oct 27, 2015, at 6:34 AM, Miroslav Kos wrote: > Thanks, good catch - fixed: > http://cr.openjdk.java.net/~mkos/8139743/jaxws.04/index.html > http://cr.openjdk.java.net/~mkos/8139743/specdiff.04/index.html > > Regarding PipeClonerImpl - yes, there is no change - originally

Re: RFR(XXS): 8140514: [TESTBUG] enable sun/security/pkcs11 tests on Linux/ppc64

2015-10-27 Thread Volker Simonis
Resend to core-libs-dev to attract a broader audience :) On Mon, Oct 26, 2015 at 3:32 PM, Volker Simonis wrote: > Hi, > > can somebody please review the following trivial fix to enable the > pkcs11 tests for linux/ppc64: > > http://cr.openjdk.java.net/~simonis/webrevs/2015/8140514/ > https://bugs

Re: RFR: 6823565: Excessive use of HandleList class in de-serialization code causes OutOfMemory

2015-10-27 Thread Claes Redestad
On 2015-10-27 16:41, Chris Hegarty wrote: On 27 Oct 2015, at 13:56, Aleksey Shipilev wrote: On 10/27/2015 04:51 PM, Claes Redestad wrote: On 2015-10-27 14:21, Aleksey Shipilev wrote: On 10/25/2015 04:27 AM, Claes Redestad wrote: when deserializing objects with references to themselves, O

Re: RFR: 6823565: Excessive use of HandleList class in de-serialization code causes OutOfMemory

2015-10-27 Thread Chris Hegarty
On 27 Oct 2015, at 13:56, Aleksey Shipilev wrote: > On 10/27/2015 04:51 PM, Claes Redestad wrote: >> >> >> On 2015-10-27 14:21, Aleksey Shipilev wrote: >>> On 10/25/2015 04:27 AM, Claes Redestad wrote: when deserializing objects with references to themselves, ObjectInputStream pointle

Re: RFR: 8066644: Fix deprecation warnings in jdk.zipfs module

2015-10-27 Thread Claes Redestad
On 2015-10-27 15:09, Claes Redestad wrote: On 2015-10-27 14:40, Aleksey Shipilev wrote: On 10/24/2015 11:54 PM, Claes Redestad wrote: webrev: bug: https://bugs.openjdk.java.net/browse/JDK-8066644 Looks good. Is there really no way to use the new DateTime API, and ditch the multiplication b

RFR: 5108778 Too many instances of java.lang.Boolean created in Java application(core-libs)

2015-10-27 Thread Sebastian Sickelmann
Hello, Actually I am searching through the JBS for low hanging fruits. Right now i am looking through the openjdk-sources and try to evaluate if i can make something about JDK-5108778. Please find my webrevs for the jaxp, jaxws and corba repos at: http://cr.openjdk.java.net/~sebastian/5108778/ja

Re: RFR 9 8140598 : Unused variable stream in freetypeScaler.c fails compilation

2015-10-27 Thread Aleksey Shipilev
On 10/27/2015 05:48 PM, Roger Riggs wrote: > Please review a minor fix to remove an unused variable that can causes a > build warning/failure. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-unused-local-stream-8140598/ I think that one is already fixed: http://hg.openjdk.java.net/jdk9/

Re: RFR 9 8140598 : Unused variable stream in freetypeScaler.c fails compilation (never mind)

2015-10-27 Thread Roger Riggs
It seems to already have been taken care of. Sorry for the noise. http://mail.openjdk.java.net/pipermail/2d-dev/2015-October/005785.html Roger On 10/27/15 7:48 AM, Roger Riggs wrote: Please review a minor fix to remove an unused variable that can causes a build warning/failure. Webrev: htt

RFR 9 8140598 : Unused variable stream in freetypeScaler.c fails compilation

2015-10-27 Thread Roger Riggs
Please review a minor fix to remove an unused variable that can causes a build warning/failure. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-unused-local-stream-8140598/ Thanks, Roger

RFR 9: 8139345: java/lang/ProcessHandle/TreeTest.java test fails...

2015-10-27 Thread Roger Riggs
The ProcessHandle TreeTest continues to fail intermittently. Please review adding additions to diagnose the failure. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-treetest-8139345/ Thanks, Roger

Re: RFR: 8066644: Fix deprecation warnings in jdk.zipfs module

2015-10-27 Thread Claes Redestad
On 2015-10-27 14:40, Aleksey Shipilev wrote: On 10/24/2015 11:54 PM, Claes Redestad wrote: webrev: http://cr.openjdk.java.net/~redestad/8066644/webrev.02 bug: https://bugs.openjdk.java.net/browse/JDK-8066644 Looks good. Is there really no way to use the new DateTime API, and ditch the multip

Re: RFR: 8066644: Fix deprecation warnings in jdk.zipfs module

2015-10-27 Thread Peter Levart
Hi Claes, Nice to see this getting in. Perhaps, as Aleksey notes, the conversion from epoch seconds to millis could be performed with TimeUnit? Regards, Peter Hiall, please review this patch which addresses deprecation warnings in jdk.zipfs module while applying the same code improvements to sim

Re: RFR: 6823565: Excessive use of HandleList class in de-serialization code causes OutOfMemory

2015-10-27 Thread Aleksey Shipilev
On 10/27/2015 04:51 PM, Claes Redestad wrote: > > > On 2015-10-27 14:21, Aleksey Shipilev wrote: >> On 10/25/2015 04:27 AM, Claes Redestad wrote: >>> when deserializing objects with references to themselves, >>> ObjectInputStream pointlessly marks the object as a dependency of >>> itself, which i

Re: RFR: 6823565: Excessive use of HandleList class in de-serialization code causes OutOfMemory

2015-10-27 Thread Claes Redestad
On 2015-10-27 14:21, Aleksey Shipilev wrote: On 10/25/2015 04:27 AM, Claes Redestad wrote: when deserializing objects with references to themselves, ObjectInputStream pointlessly marks the object as a dependency of itself, which increases memory required to deserialize certain memory graphs.

Re: RFR: 8066644: Fix deprecation warnings in jdk.zipfs module

2015-10-27 Thread Aleksey Shipilev
On 10/24/2015 11:54 PM, Claes Redestad wrote: > webrev: http://cr.openjdk.java.net/~redestad/8066644/webrev.02 > bug: https://bugs.openjdk.java.net/browse/JDK-8066644 Looks good. Is there really no way to use the new DateTime API, and ditch the multiplication by 1000L here? 116 return ldt.toEp

Re: RFR: 6823565: Excessive use of HandleList class in de-serialization code causes OutOfMemory

2015-10-27 Thread Aleksey Shipilev
On 10/25/2015 04:27 AM, Claes Redestad wrote: > when deserializing objects with references to themselves, > ObjectInputStream pointlessly marks the object as a dependency of > itself, which increases memory required to deserialize certain memory > graphs. > > bug: https://bugs.openjdk.java.net/bro

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

2015-10-27 Thread David M. Lloyd
FWIW I agree - it's just weird to have the behavior change after the fact like that. On 10/26/2015 11:37 PM, Xueming Shen wrote: Hi Steve, I know I stared to sound like a broken record :-) But I would like to suggest the team one more time to reconsider the current decision of using the "set"

Re: [9] RFR: 8139743 regular JAX-* sync-up from standalone repos

2015-10-27 Thread Miroslav Kos
Thanks, good catch - fixed: http://cr.openjdk.java.net/~mkos/8139743/jaxws.04/index.html http://cr.openjdk.java.net/~mkos/8139743/specdiff.04/index.html Regarding PipeClonerImpl - yes, there is no change - originally there was probably some unintentional change (?) Thanks Miran On 26/10/15

Re: RFR(XS): 8136967: revert all changes applied to obtain information about 8131129

2015-10-27 Thread Sundararajan Athijegannathan
http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-October/036083.html +1 -Sundar