Re: Producing streams in java.time?

2015-12-23 Thread Stephen Colebourne
JSR-310 was developed in parallel with the Stream API. While we briefly considered adding some stream methods, it wasn't obvious what would be of value. A key question is whether the methods are either specific to a narrow use case or more general. Specific methods like months() on Year are very

RFR [9]: 8146086 Publishing two webservices on same port fails with "java.net.BindException: Address already in use"

2015-12-23 Thread Miroslav Kos
Hi everybody, I'd like to ask for review of . This simple patch allows publishing more webeservices on same port. The fix has been submitted by Kubota Yuji, it is already integrated in standalone JAX-WS repo, regression test added. JBS: https://bugs.openjdk.java.net/browse/JDK-8146086 jaxws

Re: RFR:8143413:add toEpochSecond methods for efficient access

2015-12-23 Thread Roger Riggs
+1 Roger On 12/22/2015 9:53 AM, Stephen Colebourne wrote: Fine by me, thanks Stephen On 22 December 2015 at 07:59, nadeesh tv wrote: Hi all, Please see the updated webrev http://cr.openjdk.java.net/~ntv/8143413/webrev.04/ Changes : Included the changes suggested

Re: JDK 9 RFR of 8146041: java.net.URLConnection.guessContentTypeFromStream() does not recognize TIFF streams

2015-12-23 Thread Roger Riggs
Hi Brian, Without any particular domain knowledge, this looks fine. Roger On 12/23/2015 2:54 PM, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8146041 Patch: http://cr.openjdk.java.net/~bpb/8146041/webrev.00/ Summary: Add

Re: RFR: 8145388: URLConnection.guessContentTypeFromStream returns image/jpg for some JPEG images

2015-12-23 Thread Phil Race
Looks OK to me. I don't know why the difference but it goes back to JDK 1.1 -phil. On 12/22/2015 10:48 AM, Ramanand Patil wrote: HI all, Please review this small fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8145388 Bug Description - For some JPEG images the method

Re: JDK 9 RFR of 8146041: java.net.URLConnection.guessContentTypeFromStream() does not recognize TIFF streams

2015-12-23 Thread Brian Burkhalter
Thanks, Roger. It is supposed to detect the first 4 bytes according to this specification: https://en.wikipedia.org/wiki/Tagged_Image_File_Format#Byte_order Brian On Dec 23, 2015, at 12:48 PM, Roger Riggs wrote: > Without any particular domain knowledge, this looks