Hi Daniel,
On 1/13/2016 1:01 AM, Daniel Fuchs wrote:
Hi Joe,
On 1/13/16 2:06 AM, Joseph D. Darcy wrote:
Hi Iris,
Catching up on old reviews, the regular expression for versions is
given as
^[1-9][0-9]*(((\.0)*\.[1-9][0-9]*)*)*$
Is this equivalent to
^[1-9][0-9]*(\.[0-9])*
Ir
Adding core-libs-dev and hotspot-runtime-dev team .
On 1/14/2016 12:24 AM, Martin Buchholz wrote:
You should include core-libs-dev (and perhaps hotspot-runtime-dev) in
this thread. You're changing core library code.
On Wed, Jan 13, 2016 at 2:25 AM, cheleswer sahu
wrote:
Hi,
Please review th
Hi all,
please review the fix for
test/java/net/SocketPermission/SocketPermissionTest.java, which fails
frequently with "java.net.BindException: Address already in use".
Bug: https://bugs.openjdk.java.net/browse/JDK-8065076
Webrev: http://cr.openjdk.java.net/~xiaofeya/8065076/webrev.00
Th
Happen to notice that the indicator that the source was created by a
resolver was not set in StaxEntityResolverWrapper. Also, it's
"IsCreatedByResolver" rather than "hasResolver".
JBS: https://bugs.openjdk.java.net/browse/JDK-8147051
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8147051/webre
Hi, Mandy.
Thanks for looking at this webrev again.
> 273 current = parse(System.getProperty("java.version"));
>
> System.getProperty will do a permission check and it needs to be called
> within a doPrivileged block.
Nice catch! I've added the permission check and the associated
Hi,
Some comment on the regex (and also the JEP):
([1-9][0-9]*(((\.0)*\.[1-9][0-9]*)*)*)(\-([a-zA-Z0-9]+))?((\+)(0|[1-9][0-9]*)?)?(-([\-a-zA-Z0-9\.]+))?
- The outer most quantifier in (((\.0)*\.[1-9][0-9]*)*)* is redundant and a
source of catastrophic backtracking. You only need ((\.0)*\.[1-9][
Hi, Alan.
Thanks for looking at this (hopefully) one last time.
> It can't be java.base (see design principles in JEP 200).
> If it's going into java.base temporarily then the top-level
> modules.xml will need to be updated to export the "jdk" package.
This diff has been applied to modules.xml
Hi,
CCC had some suggestions to improve the code that was previously approved
during review. As a consequence, I had to make significant changes to the API,
and I believe the code need further review. Please review the latest iteration
of the webrev for runtime support of multi-release jar fi
https://bugs.openjdk.java.net/browse/JDK-8147010
-- Kevin
Chris Hegarty wrote:
On 12/01/16 22:44, Kevin Rushforth wrote:
I note that JavaFX optionally uses sun.misc.PerformanceLogger this in
one place (via reflection). We'll need to file a new issue to clean
this up.
Thanks Kevin. Can you
Hi Dmitry,
Approved. Please make sure all the core tests are run using jprt
and integrate this into jdk9/dev, if you can't do so, let me know.
Thanks
Kumar
On 1/13/2016 4:06 AM, Dmitry Cherepanov wrote:
Hi Kumar,
Thanks for the comments.
On 1/12/16 9:21 PM, Kumar Srinivasan wrote:
Hi Dmitr
Hi all,
Can somebody please review and sponsor this fix ?
Thanks,
Yuji
2016-01-05 17:56 GMT+09:00 KUBOTA Yuji :
> Hi Jaroslav and core-libs-dev,
>
> Thank Jaroslav for your kindness!
>
> For core-libs-dev members, links the information about this issue.
>
> * details of problem
> http://mail.o
On 12/01/16 22:44, Kevin Rushforth wrote:
I note that JavaFX optionally uses sun.misc.PerformanceLogger this in
one place (via reflection). We'll need to file a new issue to clean this up.
Thanks Kevin. Can you file the FX bug?
-Chris.
-- Kevin
Mandy Chung wrote:
On Jan 12, 2016, at 10:
Looks OK Joe
Best
Lance
On Jan 13, 2016, at 12:18 AM, huizhe wang wrote:
> Please review a fix to the match method of RewriteSystem and RewriteUri that
> resulted in an extra slash in the URI.
>
> Webrev:
> http://cr.openjdk.java.net/~joehw/jdk9/8146606/webrev/
>
> Issue:
> https://bu
Hi Kumar,
Thanks for the comments.
On 1/12/16 9:21 PM, Kumar Srinivasan wrote:
Hi Dmitry,
src/java.base/windows/native/libjli/java_md.c
1) use NULL
-GetModuleFileName(0, buf, bufsize);
+GetModuleFileName(NULL, buf, bufsize);
OK.
2) extra LF ?
+ * Removes the trailing file name
On 12/01/16 20:49, Aleksey Shipilev wrote:
> Okay, I'll bite:
> http://cr.openjdk.java.net/~shade/scratch/UTF8Scan.java
Great job, Aleksey. Far more thorough than I would have done!
Andrew.
Hi Joe,
On 1/13/16 2:06 AM, Joseph D. Darcy wrote:
Hi Iris,
Catching up on old reviews, the regular expression for versions is given as
^[1-9][0-9]*(((\.0)*\.[1-9][0-9]*)*)*$
Is this equivalent to
^[1-9][0-9]*(\.[0-9])*
Iris's regexp will disallow trailing .0
9.0.1 will match,
16 matches
Mail list logo
