On Mar 4, 2016, at 2:00 PM, Mandy Chung wrote:
>
> Footprint of MemberName as well as GC pressure (as they are kept as weak
> references in VM) are the performance concern that we will have to look at it
> in a future release.
I hope we can increase our investment on MemberName as an all-purpo
New JEP Candidate: http://openjdk.java.net/jeps/285
- Mark
> On Mar 4, 2016, at 10:42 AM, John Rose wrote:
>
> Doing more on the Java side means it will be easier generate strings lazily,
> only if the exception actually prints or presents STEs.
>
> All we need to store eagerly per frame is a MemberName and a BCI.
This is what StackWalker stores in
Can they be method refs, or is this one of those cases where it could
be early boot where none of that stuff works yet?
--
- DML
> On Mar 4, 2016, at 10:19 AM, Roger Riggs wrote:
>
> Hi Daniel,
>
> Good idea.
>
> SimpleConsolerLogger.java:
> Some of the property accesses could use the existing
Doing more on the Java side means it will be easier generate strings lazily,
only if the exception actually prints or presents STEs.
All we need to store eagerly per frame is a MemberName and a BCI.
– John
> On Mar 4, 2016, at 5:28 AM, Aleksey Shipilev
> wrote:
>
>> On 03/02/2016 11:21 PM,
Hi Amy,
Looks good; thanks,
-Joe
On 3/4/2016 6:35 AM, Amy Lu wrote:
java/util/zip/TestLocalTime.java
This test was failing intermittently (reported in JDK-8135108).
JDK-8135108 has been resolved and no open bug (no failure reported)
till now.
This patch is to remove @key intermittent from
Looks fine Amy; thanks,
-Joe
On 3/4/2016 6:50 AM, Amy Lu wrote:
java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java
This test is known to fail intermittently (JDK-8078587). This patch is
to mark the test accordingly with keyword 'intermittent'.
bug: https://bugs.openjdk.
Hi Roger and all,
Thanks your help to share patch and link to here :)
For the assignee, more detailed about the attachments is as below.
http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-February/038593.html
Thanks,
Yuji
2016-03-05 0:56 GMT+09:00 Roger Riggs :
> Hi Yuji,
>
> The patch a
Hi Roger,
Yes that's a good remark:
Applied it to SimpleConsoleLogger.java.
http://cr.openjdk.java.net/~dfuchs/webrev_8150840/webrev.01/
-- daniel
On 04/03/16 17:19, Roger Riggs wrote:
Hi Daniel,
Good idea.
SimpleConsolerLogger.java:
Some of the property accesses could use the existing
> On 4 Mar 2016, at 17:42, Tagir F. Valeev wrote:
>
> Hello!
>
> AIOOBE is possible for ArrayList itself as well. E.g.:
>
>ArrayList test = new ArrayList<>(Arrays.asList(1,2,3,4));
>Spliterator spltr = test.spliterator();
>spltr.tryAdvance(System.out::println);
>test.clear();
>
I thought about that also but it is one of those cases where where it is
'too early' for method refs.
Roger
On 3/4/2016 11:56 AM, David Lloyd wrote:
Can they be method refs, or is this one of those cases where it could
be early boot where none of that stuff works yet?
--
- DML
On Mar 4, 20
Hello!
AIOOBE is possible for ArrayList itself as well. E.g.:
ArrayList test = new ArrayList<>(Arrays.asList(1,2,3,4));
Spliterator spltr = test.spliterator();
spltr.tryAdvance(System.out::println);
test.clear();
test.trimToSize();
spltr.tryAdvance(System.out::println);
R
Hi Daniel,
Good idea.
SimpleConsolerLogger.java:
Some of the property accesses could use the existing property
actions instead of anonymous inner classes.
static Level getDefaultLevel() {
String levelName = AccessController.doPrivileged( new
sun.security.action.GetPropertyAction("jdk.syst
Hi Yuji,
The patch and reproducer have been attached to the issue 8151212[1].
Thanks, Roger
[1] https://bugs.openjdk.java.net/browse/JDK-8151212
On 3/3/2016 9:06 PM, KUBOTA Yuji wrote:
Hi Roger,
Thank you for your help!
My patch and reproducer are as below.
> On 4 Mar 2016, at 15:38, Tagir F. Valeev wrote:
>
> Hello!
>
> Thank you for the review!
>
Thanks.
I just realised there are some subtleties where if the top-level list is
reduced in size the spliterator of a sublist may on traversal throw an
ArrayIndexOutOfBoundsException rather than Co
Yes, there is a mutability test already. We will have to fix the thread
safety problem
(and also the fact HttpHeaders1 was left public by mistake). Probably will
separate the mutable and immutable types completely. Vaibhav, if you'd
like to do it,
you can define a package private implementation
java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java
This test is known to fail intermittently (JDK-8078587). This patch is
to mark the test accordingly with keyword 'intermittent'.
bug: https://bugs.openjdk.java.net/browse/JDK-8151263
webrev: http://cr.openjdk.java.net/~aml
Hello!
Thank you for the review!
Here's updated webrev:
http://cr.openjdk.java.net/~tvaleev/webrev/8148748/r3/
PS> Looks good. I especially like:
PS> 125 addCollection(l.andThen(list -> list.subList(0,
list.size(;
PS> Can you also update SpliteratorTraversingAndSplittingTest?
java/util/zip/TestLocalTime.java
This test was failing intermittently (reported in JDK-8135108).
JDK-8135108 has been resolved and no open bug (no failure reported) till
now.
This patch is to remove @key intermittent from the test and move it back
to tier1.
bug: https://bugs.openjdk.java.n
Hi Vaibhav,
This will not work, as Claes points out. You also might wanna check if there
are tests in place asserting unmodfiablity, if there are none you could add
some. Michael can point you in the right direction.
Follow the trail of HttpHeaders1.makeUnmodifiable(), which is used to
transit
Hi,
even with this code, I think it'd still be possible to do
map().get(name) to get to the underlying, mutable list.
It seems we have to ensure lists mapped in headers are made
unmodifiable, something the method makeUnmodifiable seems to ensure,
albeit in a not very thread-safe manner.
/C
On 03/02/2016 11:21 PM, Aleksey Shipilev wrote:
> On 03/02/2016 10:57 PM, Coleen Phillimore wrote:
>> On 3/2/16 1:58 PM, Aleksey Shipilev wrote:
>>> Is there an underlying reason why we can't return the pre-filled
>>> StackTraceElements[] array from the JVM_GetStackTraceElements to begin
>>> with?
Hi,
Please review :-
Review Link :- http://cr.openjdk.java.net/~ntv/vaibhav/JDK8151182/webrev.00/
Bug ID: https://bugs.openjdk.java.net/browse/JDK-8151182
--
Thank You,
Vaibhav Choudhary
http://blogs.oracle.com/vaibhav
[Resending with a link to the patch]
Hi,
Please find below a patch for:
https://bugs.openjdk.java.net/browse/JDK-8150840
8150840: Add an internal system property to control the default
level of System.Logger when java.logging is not present.
http://cr.openjdk.java.net/~dfuchs/webrev_8
Hi,
Please find below a patch for:
https://bugs.openjdk.java.net/browse/JDK-8150840
8150840: Add an internal system property to control the default
level of System.Logger when java.logging is not present.
This patch also introduces a better separation between the
SimpleConsoleLogger (c
> On 4 Mar 2016, at 10:26, Tagir F. Valeev wrote:
>
> Hello!
>
>>> I'm just worrying a little that my changes might conflict with Ivan
>>> Gerasimov's pending 8079136 issue, so probably it would be better to
>>> wait till it's reviewed and pushed…
>
> Ivan said that 8079136 is stalled for a wh
long DAYS__TO_1970 should be extracted as a private static final constant.
Otherwise looks good.
Stephen
On 3 March 2016 at 18:54, nadeesh tv wrote:
> Hi,
>
> Roger - Thanks for the comments
>
> Made the necessary changes in the spec
>
> Please see the updated webrev
> http://cr.openjdk.jav
In TCKDateTimeFormatterBuilder there is a commented out line in one of
the new tests. Should be removed.
No need for another review for that - happy otherwise.
thanks for the work!
Stephen
On 3 March 2016 at 18:37, nadeesh tv wrote:
> Hi,
>
> Stephen, Roger Thanks for the comments.
>
> Please se
Hello!
>> I'm just worrying a little that my changes might conflict with Ivan
>> Gerasimov's pending 8079136 issue, so probably it would be better to
>> wait till it's reviewed and pushed…
Ivan said that 8079136 is stalled for a while, so I decided to
continue working on 8148748. Here's updated w
29 matches
Mail list logo
