Re: RFR 9: 8085887 : java.time.format.FormatStyle.LONG or FULL causes unchecked exception

2016-03-15 Thread Xueming Shen
looks good. On 3/15/16 12:19 PM, Roger Riggs wrote: Hi Stephen, Updated as recommended. Thanks, Roger On 3/15/2016 2:52 PM, Stephen Colebourne wrote: My only comment is that I would prefer to see "Precision" for the precision constant and "Zone" for the ZONE constant, as they describe t

Re: RFR 9: 8085887 : java.time.format.FormatStyle.LONG or FULL causes unchecked exception

2016-03-15 Thread Roger Riggs
Hi Stephen, Updated as recommended. Thanks, Roger On 3/15/2016 2:52 PM, Stephen Colebourne wrote: My only comment is that I would prefer to see "Precision" for the precision constant and "Zone" for the ZONE constant, as they describe the query better. No need for another webrev. Otherwi

Re: RFR 9: 8085887 : java.time.format.FormatStyle.LONG or FULL causes unchecked exception

2016-03-15 Thread Roger Riggs
Hi Stephen, Updated webrev: http://cr.openjdk.java.net/~rriggs/webrev-format-8085887/ On 3/14/2016 7:45 PM, Stephen Colebourne wrote: Great to see the better error messages. It may be better long term to add toString() to the TemporalQuery implementations (lambdas are convenient but optional

Re: RFR: 8151858: update ASM 5.1 to accept V53.0 classfiles

2016-03-15 Thread forax
After this patch, the version of ASM internally used by OpenJDK will accept V53 class files but not understand module-info.class specific file format, so that version of ASM will be able to read module-info.class, but will see it as a class with a bunch of custom attributes and will not be able t

Re: RFR: 8151858: update ASM 5.1 to accept V53.0 classfiles

2016-03-15 Thread Jonathan Gibbons
Rémi, FYI, the new Module attribute is just one of the reasons to bump the class file version number. See the list here: http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-January/003507.html -- Jon On 03/15/2016 01:41 AM, fo...@univ-mlv.fr wrote: +1 too, Upstream, we will wait to implem

Re: [8u-dev] Request for Approval for Backport: 8151352 (8151574), jdk/test/sample fails with "effective library path is outside the test suite"

2016-03-15 Thread Felix Yang
Hi Sean, thank you for the review. Could you sponsor this change? -Felix On 2016/3/15 16:03, Seán Coffey wrote: Please don't use backport IDs in email communication or approval requests. Use the master bug ID in your changeset commit comment. I've edited the subject line to include master b

Re: RFR 8131913: jdk/internal/jline/console/StripAnsiTest.java can't run in the background

2016-03-15 Thread Roger Riggs
Looks ok. Roger On 3/14/2016 8:32 AM, Jan Lahoda wrote: Hello, Any feedback/comments on this? Thanks, Jan On 1.3.2016 11:54, Jan Lahoda wrote: Hi, I'd like to ask for a review of a patch for JDK-8131913. The fix is to use the "UnsupportedTerminal", which will not try to switch the OS t

Re: toRealPath throws InternalError: Should not get here on Windows (paths with junctions)

2016-03-15 Thread Rory O'Donnell
Hi Dawid, I will update bug. Rgds,Rory On 15/03/2016 12:53, Dawid Weiss wrote: This must be more complicated than I thought because the same code passes with flying colors on another (fairly fresh install) of Windows 10... I don't know what the difference is, to be honest (I have Windows 10 Pr

Re: toRealPath throws InternalError: Should not get here on Windows (paths with junctions)

2016-03-15 Thread Dawid Weiss
This must be more complicated than I thought because the same code passes with flying colors on another (fairly fresh install) of Windows 10... I don't know what the difference is, to be honest (I have Windows 10 Pro N). I'll try to dig deeper, time permitting, but perhaps a comment on the eventual

Re: toRealPath throws InternalError: Should not get here on Windows (paths with junctions)

2016-03-15 Thread Dawid Weiss
I filed an issue (Review ID: JI-9032181). In any case, I checked with Java 7, 8 and the ea: Java(TM) SE Runtime Environment (build 9-ea+109-2016-03-09-181019.javare.4620.nc) The issue only affects Windows 10 (tested on 64-bit only), Windows 7 behaves fine. The following sequence is enough to get

Re: toRealPath throws InternalError: Should not get here on Windows (paths with junctions)

2016-03-15 Thread Rory O'Donnell
Hi Dawid, Can you log a bug and send me the JI, thanks ? If you have more info you can share it would be useful to follow up on the nio-dev mailing list. (http://mail.openjdk.java.net/mailman/listinfo/nio-dev) Rgds,Rory On 15/03/2016 11:28, Alan Bateman wrote: On 15/03/2016 11:19, Dawid Wei

Re: toRealPath throws InternalError: Should not get here on Windows (paths with junctions)

2016-03-15 Thread Alan Bateman
On 15/03/2016 11:19, Dawid Weiss wrote: I couldn't find an appropriate bug in bugzilla, but this fails reliably for me with Java 8 and 9 on Windows 10, 64-bit: mkdir foo mklink /J bar foo cd bar java -cp Test . where Test.java is as simple as: import java.io.*; import java.nio.file.*; public

toRealPath throws InternalError: Should not get here on Windows (paths with junctions)

2016-03-15 Thread Dawid Weiss
I couldn't find an appropriate bug in bugzilla, but this fails reliably for me with Java 8 and 9 on Windows 10, 64-bit: mkdir foo mklink /J bar foo cd bar java -cp Test . where Test.java is as simple as: import java.io.*; import java.nio.file.*; public class Test { public static void main(Str

Re: RFR: 8151858: update ASM 5.1 to accept V53.0 classfiles

2016-03-15 Thread Alan Bateman
On 15/03/2016 08:41, fo...@univ-mlv.fr wrote: +1 too, Upstream, we will wait to implement the module-info file format before bumping the supported major version. Do you need to support module-info file soon ? We going to attempt to bring in the module system in jdk-9+111. The jdk9/dev -> ma

Re: RFR: 8151858: update ASM 5.1 to accept V53.0 classfiles

2016-03-15 Thread forax
+1 too, Upstream, we will wait to implement the module-info file format before bumping the supported major version. Do you need to support module-info file soon ? regards, Rémi - Mail original - > De: "Sundararajan Athijegannathan" > À: "Kumar Srinivasan" , "Remi Forax" > , "Jonathan

Re: [8u-dev] Request for Approval for Backport: 8151352 (8151574), jdk/test/sample fails with "effective library path is outside the test suite"

2016-03-15 Thread Seán Coffey
Please don't use backport IDs in email communication or approval requests. Use the master bug ID in your changeset commit comment. I've edited the subject line to include master bug ID (8151352). Approved. The jtreg upgrade disrupted test results for quite a few teams (again). https://bugs.ope