Re: RFR 8152893 : StackWalker#getCallerClass is not filtering hidden/ reflection frames when walker is configured to show hidden /reflection frames

On 06/03/2016 04:50 PM, Mandy Chung wrote: On Jun 3, 2016, at 1:50 PM, Brent Christian wrote: Updated webrev: http://cr.openjdk.java.net/~bchristi/8152893/webrev.01/ Looks good. Nit: copyright end year missing a trailing “,” Thanks. Fixed prior to pushing. -Brent

Re: RFR 8152893 : StackWalker#getCallerClass is not filtering hidden/ reflection frames when walker is configured to show hidden /reflection frames

> On Jun 3, 2016, at 1:50 PM, Brent Christian > wrote: > > Updated webrev: > http://cr.openjdk.java.net/~bchristi/8152893/webrev.01/ Looks good. Nit: copyright end year missing a trailing “,” Mandy

Re: RFR JDK-8074819: Resolve disabled warnings for libzip

Looks good to me. Naoto On 6/3/16 2:49 PM, Xueming Shen wrote: Hi, Please help review the change for JDK-8074819. issue: https://bugs.openjdk.java.net/browse/JDK-8074819 webrev: http://cr.openjdk.java.net/~sherman/8074819 Thanks, Sherman

RFR JDK-8074819: Resolve disabled warnings for libzip

Hi, Please help review the change for JDK-8074819. issue: https://bugs.openjdk.java.net/browse/JDK-8074819 webrev: http://cr.openjdk.java.net/~sherman/8074819 Thanks, Sherman

Re: handling the deprecations introduced by early access builds 116 and 118 of jdk 9

On 6/1/16 4:15 PM, Richard Hillegas wrote: [deprecation warnings] This was the issue which I faced. The Derby community has spent considerable effort on maintaining a clean build, one which doesn't swamp real error indications in a blizzard of diagnostic noise. At the same time, we are relucta

Re: RFR 8152893 : StackWalker#getCallerClass is not filtering hidden/ reflection frames when walker is configured to show hidden /reflection frames

On 06/02/2016 07:04 PM, Mandy Chung wrote: Nit: on GetCallerClassTest.java: 178 Class c = (Class) walker.getCallerClass(); The cast should not be needed. Any reason there? Uh, the reason there is careless copy/paste... :$ Cast removed. I wonder if you could move the lam

Re: JDK 9 RFR of JDK-8136738: InputStream documentation for IOException in skip() is unclear or incorrect

Perfect! > On 3 Jun 2016, at 20:20, Roger Riggs wrote: > > +1 > > > On 6/3/2016 3:15 PM, Brian Burkhalter wrote: >> So if I make this change to the webrev >> >> --- a/src/java.base/share/classes/java/io/InputStream.java >> +++ b/src/java.base/share/classes/java/io/InputStream.java >> @@ -333,

Re: JDK 9 RFR of JDK-8136738: InputStream documentation for IOException in skip() is unclear or incorrect

+1 On 6/3/2016 3:15 PM, Brian Burkhalter wrote: So if I make this change to the webrev --- a/src/java.base/share/classes/java/io/InputStream.java +++ b/src/java.base/share/classes/java/io/InputStream.java @@ -333,8 +333,7 @@ * * @param n the number of bytes to be skipped.

Re: JDK 9 RFR of JDK-8136738: InputStream documentation for IOException in skip() is unclear or incorrect

So if I make this change to the webrev --- a/src/java.base/share/classes/java/io/InputStream.java +++ b/src/java.base/share/classes/java/io/InputStream.java @@ -333,8 +333,7 @@ * * @param n the number of bytes to be skipped. * @return the actual number of bytes skipped

Re: RFR (JAXP) 8150187: NPE expected if the system identifier is null for CatalogResolver

Thanks Roger, Lance! Joe On 6/3/2016 11:26 AM, Lance Andersen wrote: +1 On Jun 3, 2016, at 1:57 PM, huizhe wang > wrote: Hi, Please review a patch that adds null-check to systemId. JBS: https://bugs.openjdk.java.net/browse/JDK-8150187 webrevs: http://cr.openjd

Re: JDK 9 RFR of JDK-8136738: InputStream documentation for IOException in skip() is unclear or incorrect

> On 3 Jun 2016, at 19:30, Bernd Eckenfels wrote: > > It is unclear to me if this is really forbidden in the interface or in > any implementation. With FileInputStream skip(-5) works. Don't mistake `seek` for `skip`. `skip` can be implemented using `read`, but may be using `seek`. Here's the A

Re: JDK 9 RFR of JDK-8136738: InputStream documentation for IOException in skip() is unclear or incorrect

Hello, I think "seeking negatively" is a bad example for an IO problem. For this reason alone I would remove it. It is unclear to me if this is really forbidden in the interface or in any implementation. With FileInputStream skip(-5) works. (I would expect it to throw IllegalArgumentException or

Re: RFR (JAXP) 8150187: NPE expected if the system identifier is null for CatalogResolver

+1 > On Jun 3, 2016, at 1:57 PM, huizhe wang wrote: > > Hi, > > Please review a patch that adds null-check to systemId. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8150187 > webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8150187/webrev/ > > Thanks, > Joe >

Re: RFR (JAXP) 8150187: NPE expected if the system identifier is null for CatalogResolver

Looks fine. On 6/3/2016 1:57 PM, huizhe wang wrote: Hi, Please review a patch that adds null-check to systemId. JBS: https://bugs.openjdk.java.net/browse/JDK-8150187 webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8150187/webrev/ Thanks, Joe

RFR (JAXP) 8150187: NPE expected if the system identifier is null for CatalogResolver

Hi, Please review a patch that adds null-check to systemId. JBS: https://bugs.openjdk.java.net/browse/JDK-8150187 webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8150187/webrev/ Thanks, Joe

Re: JDK 9 RFR of JDK-8136738: InputStream documentation for IOException in skip() is unclear or incorrect

Hi Pavel, On Jun 3, 2016, at 3:43 AM, Pavel Rappo wrote: > I have a minor question though: > > --- a/src/java.base/share/classes/java/io/InputStream.java > +++ b/src/java.base/share/classes/java/io/InputStream.java > > - * @exception IOException if the stream does not support seek, > -

Re: JDK 9 RFR of JDK-8136738: InputStream documentation for IOException in skip() is unclear or incorrect

+1 On 6/2/2016 5:48 PM, Brian Burkhalter wrote: Please review at your convenience this API doc-only change: Issue: https://bugs.openjdk.java.net/browse/JDK-8136738 Patch: http://cr.openjdk.java.net/~bpb/8136738/webrev.00/ Summary: Try to make the specification of InputStream.skip() slightl

Proposal: java.lang.reflect.Proxy and default methods

Hi, Since Java SE 8 introduced default methods in interfaces there was a question what to do with java.lang.reflect.Proxy API. Nothing was done to the API at that time, so the default behavior is to proxy default methods too. InvocationHandler gets invoked for default methods, but it has not

Re: RFR : 8073611 : javax.script.ScriptEngineFactory: formatting error in javadoc of getParameter

+1 -Sundar On 6/3/2016 5:51 PM, Muneer Kolarkunnu wrote: > > Hi All, > > > > Please review fix for https://bugs.openjdk.java.net/browse/JDK-8073611 > > > > Webrev : http://cr.openjdk.java.net/~sdama/8073611/webrev.00/ > > > > > Probl

RFR : 8073611 : javax.script.ScriptEngineFactory: formatting error in javadoc of getParameter

Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8073611 Webrev : http://cr.openjdk.java.net/~sdama/8073611/webrev.00/ Problem: One extra line break has given in the documentation, so readers will get confused. (Ref: http://docs.oracle.com/javase/8/docs/api/java

Re: JDK 9 RFR of JDK-8136738: InputStream documentation for IOException in skip() is unclear or incorrect

Hi Brian, > On 2 Jun 2016, at 22:48, Brian Burkhalter wrote: > > Please review at your convenience this API doc-only change: > > Issue:https://bugs.openjdk.java.net/browse/JDK-8136738 > Patch:http://cr.openjdk.java.net/~bpb/8136738/webrev.00/ > > Summary: > > Try to make the s

Re: Review request: JDK-8157892: StackFrame::getFileName returns null when a source file exists for native methods

Hi Mandy, On 6/3/16 12:55 AM, Mandy Chung wrote: On Jun 2, 2016, at 3:11 PM, Daniel Fuchs wrote: > > Hi Mandy, > > Looks good to me. Though I wonder whether a better fix would be > to not tweak the bci for native methods in the native call that > sets the value to 0 (I assume this is what happe